1. 13 8月, 2013 1 次提交
  2. 12 8月, 2013 6 次提交
    • P
      Use assert_not rather than refute · e45f176b
      Piotr Sarnacki 提交于
      e45f176b
    • B
      Refactor NestedAttributesWithCallbacksTest for clarity · cc368c3a
      Ben Woosley 提交于
      1) Use `assert` and `refute` where possible.
      2) Separately include the setup, subject, and assertions in each test - don't hide the tested call in an assertion method.
      3) Name things based on their role rather than incidental facts about them - e.g. `@bird[1]` -> `bird_to_destroy`. `bird2_deletion_attributes` -> `destroy_bird_attributes`.
      4) Use more succinct naming where possible - e.g. `birds_with_callback` -> `birds_with_add`, `@pirate_with_two_birds` -> `@pirate`
      cc368c3a
    • B
      Restore the use of `#add_to_target` for nested attribute updates on existing... · d35e900c
      Ben Woosley 提交于
      Restore the use of `#add_to_target` for nested attribute updates on existing records, and don't bother updating the association if the update is going to be rejected anyway.
      
      This requires adding a `skip_callbacks` argument to `#add_to_target`
      so that we don't call the callbacks multiple times in this case,
      which is functionally an application of existing association data,
      rather than an addition of a new record to the association.
      d35e900c
    • D
      Fix interactions between :before_add callbacks and nested attributes assignment · 018697de
      Dr.(USA) Joerg Schray 提交于
      Issue #1: :before_add callback is called when nested attributes assignment assigns to existing record if the association is not yet loaded
      Issue #2: Nested Attributes assignment does not affect the record in the association target when callback triggers loading of the association
      018697de
    • V
      drop extra variable · 4c101ccd
      Vipul A M 提交于
      4c101ccd
    • A
      chmod -x · 2fa83ee1
      Akira Matsuda 提交于
      2fa83ee1
  3. 11 8月, 2013 1 次提交
  4. 10 8月, 2013 1 次提交
  5. 09 8月, 2013 1 次提交
  6. 08 8月, 2013 4 次提交
  7. 07 8月, 2013 2 次提交
    • Y
      skip `test_unicode_column_name` for `MysqlAdapter`. · da49e9a9
      Yves Senn 提交于
      This commit fixes the build but we need to further investigate the root cause,
      to see if it can be fixed.
      
      The test fails under `MysqlAdapter` with:
      
      ```
      ActiveRecord::UnknownAttributeError: unknown attribute: なまえ
      ```
      
      The root cause is that the returned column names from the adapter
      have the wrong encoding:
      
      ```ruby
      columns = Weird.columns_hash.keys
      columns # => ["id", "a$b", "\xE3\x81\xAA\xE3\x81\xBE\xE3\x81\x88", "from"]
      columns.map(&:encoding) # => [#<Encoding:ASCII-8BIT>, #<Encoding:ASCII-8BIT>, #<Encoding:ASCII-8BIT>, #<Encoding:ASCII-8BIT>]
      columns.map {|c| c.dup.force_encoding "utf-8"} # => ["id", "a$b", "なまえ", "from"]
      ```
      
      From what I can tell the MySQL variables are fine:
      
      ```
      ActiveRecord::Base.connection.execute("show variables")
      
      ...
      character_set_client utf8
      character_set_connection utf8
      character_set_database utf8
      character_set_filesystem binary
      character_set_results utf8
      character_set_server utf8
      character_set_system utf8
      character_sets_dir /usr/local/Cellar/mysql/5.5.29/share/mysql/charsets/
      collation_connection utf8_general_ci
      collation_database utf8_unicode_ci
      collation_server utf8_general_ci
      ...
      ```
      da49e9a9
    • Y
      test to express that we can't turn non-array columns to array columns. · 179deea6
      Yves Senn 提交于
      Closes #11062
      179deea6
  8. 06 8月, 2013 9 次提交
  9. 05 8月, 2013 1 次提交
  10. 04 8月, 2013 2 次提交
  11. 03 8月, 2013 2 次提交
  12. 02 8月, 2013 10 次提交