- 18 1月, 2020 3 次提交
-
-
由 eileencodes 提交于
Database configurations are now objects almost everywhere, so we don't need to fake access to a hash with `#default_hash` or it's alias `#[]`. Applications should `configs_for` and pass `env_name` and `spec_name` to get the database config object. If you're looking for the default for the test environment you can pass `configs_for(env_name: "test", spec_name: "primary")`. Change test to developement to get the dev config, etc. `#default_hash` and `#[]` will be removed in 6.2. Co-authored-by: NJohn Crepezzi <john.crepezzi@gmail.com>
-
由 John Hawthorn 提交于
Reduce FILENAME_MAX_SIZE to accomodate large PIDs
-
由 John Hawthorn 提交于
The max size here is designed around Ruby's Dir::Tmpname.create which creates temporary filenames in the format $TIMESTAMP-$PID-$RANDOM I believe the previous value of this field was based on the assumption that PIDs are 1-65535, which isn't necessarily the case on 64 bit Linux systems, which can be up to 2**22. $ uname -a Linux zergling 5.4.11-arch1-1 #1 SMP PREEMPT Sun, 12 Jan 2020 12:15:27 +0000 x86_64 GNU/Linux $ cat /proc/sys/kernel/pid_max 4194304 I've chosen a new value based on what I believe the largest possible tempname is: 255 - "20200117-4194304-#{0x100000000.to_s(36)}.lock".length #=> 226
-
- 17 1月, 2020 4 次提交
-
-
由 Gannon McGibbon 提交于
Mark working_with_javascript_in_rails as WIP
-
由 Gannon McGibbon 提交于
Mark as WIP to indicate it is outdated and currently being worked on.
-
由 Carlos Antonio da Silva 提交于
-
由 Gannon McGibbon 提交于
-
- 16 1月, 2020 7 次提交
-
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
Follow up #36255.
-
由 Ryuta Kamizono 提交于
Follow up #35504. [ci skip]
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
-
由 Eileen M. Uchitelle 提交于
Introduce ActiveSupport Disallowed Deprecations
-
由 Cliff Pruitt 提交于
This allows deprecation messages to be matched by substring, symbol (treated as substring), or regular expression. If a warning is matched, the behaviors configured for disallowed deprecations will be used. The default behavior for disallowed deprecation warnings is `:raise`. Also adds `ActiveSupport::Deprecation.allow` for thread-local, block level ignoring of deprecation warnings which would otherwise be disallowed by ActiveSupport::Deprecation.disallowed_warnings.
-
- 15 1月, 2020 7 次提交
-
-
由 Ryuta Kamizono 提交于
Fix CI failures due to MySQL 8.0.19 no longer output integer display width unless ZEROFILL is also used https://buildkite.com/rails/rails/builds/66475#7a6c54bc-4ed3-4676-b196-4fee031f43bf Fixes #38226.
-
由 Ryuta Kamizono 提交于
Don't encourage using octals for dates and times
-
由 Ian Fleeton 提交于
This could result in confusing errors or inconsistency for 08 and 09
-
由 Richard Schneeman 提交于
fix typos
-
由 Douglas Lara 提交于
-
由 Aaron Patterson 提交于
prevent helper_method from calling to_hash
-
由 Adam Hess 提交于
`helper_method` was taking `**kwargs` on all definitions by default. ruby will assume that this means you want keyword args and call `to_hash` on what you pass if the object responds to `to_hash`. Instead we should only take keyword args if the helper method defined intends to pass keyword args. This also fixes a warning when you pass a hash to your helper method, ``` warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call ``` Also, this would be a good candidate for using `...`, but since `send` requires the method as the first argument, we can't use it here.
-
- 14 1月, 2020 15 次提交
-
-
由 Carlos Antonio da Silva 提交于
-
由 Carlos Antonio da Silva 提交于
[ci skip]
-
由 Ryuta Kamizono 提交于
Remove an empty line from generated migration
-
由 Prem Sichanugrist 提交于
Currently, if you run `rails g migration remove_column_from_models`, there is an empty line before `remove_column` line because we forgot to use `-%>` in the template: $ bin/rails g migration remove_title_from_posts title:string invoke active_record create db/migrate/20200114061235_remove_title_from_posts.rb $ cat db/migrate/20200114061235_remove_title_from_posts.rb class RemoveTitleFromPosts < ActiveRecord::Migration[6.1] def change remove_column :posts, :title, :string end end This commit adds the missing `-` in front of `-%>` to make it removes the empty line.
-
由 John Hawthorn 提交于
Pass Benchmark.ms block through to realtime
-
由 John Hawthorn 提交于
Avoids pushing an extra stack frame.
-
由 John Hawthorn 提交于
Fix CI error with minitest 5.14
-
由 John Hawthorn 提交于
Follow up to 2bf1c17c, which still left this one failure. Minitest 5.14 uses error instead of exception, so exception had been changed to just be the same UnexpectedError instance and losing us the actual error message. This also switches to initializing a new UnexpectedError instance because previously, for reasons I can't quite figure out, reusing the same instance would still give us a DRbConnError.
-
由 Gannon McGibbon 提交于
Add scale support to ActiveRecord::Validations::NumericalityValidator
-
由 Eileen M. Uchitelle 提交于
Fix NoMethodError on ActiveSupport::Cache::RedisCacheStore#clear with…
-
由 Ryuta Kamizono 提交于
Remove Ruby 2.7 warning on arg forwarding
-
由 Kevin Deisz 提交于
Kwargs need to be forwarded for this method_missing to avoid warnings in Ruby 2.7.
-
由 Gannon McGibbon 提交于
-
- 12 1月, 2020 4 次提交
-
-
-
由 Ryuta Kamizono 提交于
https://github.com/seattlerb/minitest/commit/5802aa08280a3609b684e0ebef95dabfbd3ec9ff https://github.com/seattlerb/minitest/pull/809#discussion_r332399750 To support both 5.13.0 and 5.14.0, use `#initialize` instead.
-
-
由 Ryuta Kamizono 提交于
rack 2.1.0 changed expires date format from rfc2822 to httpdate
-