1. 07 8月, 2016 4 次提交
  2. 06 8月, 2016 1 次提交
    • E
      Fix GET JSON integration test request to use method override · af1680f5
      eileencodes 提交于
      When a `GET` request is sent `as: :json` in an integration test the test
      should use Rack's method override to change to a post request so the
      paramters are included in the postdata. Otherwise it will not encode the
      parameters correctly for the integration test.
      
      Because integration test sets up it's own middleware,
      `Rack::MethodOverride` needs to be included in the integration tests as
      well.
      
      `headers ||= {}` was moved so that headers are never nil. They should
      default to a hash.
      
      Fixes #26033
      
      [Eileen M. Uchitelle & Aaron Patterson]
      af1680f5
  3. 27 7月, 2016 2 次提交
  4. 11 7月, 2016 1 次提交
    • K
      Let TestResponse assign a parser. · 333670ce
      Kasper Timm Hansen 提交于
      Previously we'd only assign a response parser when a request came through
      Action Dispatch integration tests. This made calls to `parsed_body` when a TestResponse
      was manually instantiated — though own doing or perhaps from a framework — unintentionally
      blow up because no parser was set at that time.
      
      The response can lookup a parser entirely through its own ivars. Extract request encoder to
      its own file and assume that a viable content type is present at TestResponse instantiation.
      
      Since the default response parser is a no-op, making `parsed_body` equal to `body`, no
      exceptions will be thrown.
      333670ce
  5. 02 7月, 2016 3 次提交
  6. 25 6月, 2016 3 次提交
  7. 27 5月, 2016 1 次提交
  8. 24 4月, 2016 1 次提交
  9. 12 4月, 2016 1 次提交
  10. 08 3月, 2016 1 次提交
  11. 07 3月, 2016 1 次提交
    • Y
      Prevent not-intended loading of `ActionDispatch::IntegrationTest` · 9a642931
      yui-knk 提交于
      After 9d378747 `ActionDispatch::IntegrationTest`
      class is loaded and defined in all Rails environments, not only test but also
      production. This is not-intended loading of a class which is only used in
      test environment.
      To prevent not-intended loading, add `ActiveSupport.run_load_hooks` to
      `ActionDispatch::IntegrationTest` with `action_dispatch_integration_test` name
      and use it in `ActionMailer`.
      9a642931
  12. 03 3月, 2016 1 次提交
  13. 01 3月, 2016 1 次提交
  14. 13 2月, 2016 1 次提交
    • K
      Add fixes accidentally removed. · da1fbb9a
      Kasper Timm Hansen 提交于
      Yesterday, when improving how `parsed_body` extracted a parser I wrote
      77bbf1e9. Then I thought that was too many changes in one commit
      and broke it up locally... or so I thought.
      
      When pushed the extra commits removed the changes! Wups!
      
      In shame, lob those changes together here:
      
        * 3b94c38a which meant to fix the CHANGELOG syntax error.
        * 5007df5e which meant to mention `parsed_body` in the docs.
        * 036a7a03 which meant to memoize the `parsed_body`.
      da1fbb9a
  15. 12 2月, 2016 2 次提交
  16. 11 2月, 2016 1 次提交
    • K
      Add `parsed_body` to spare writing out parsing routines. · eee3534b
      Kasper Timm Hansen 提交于
      When testing:
      
      ```ruby
      post articles_path, params: { article: { title: 'Ahoy!' } }, as: :json
      ```
      
      It's common to want to make assertions on the response body. Perhaps the
      server responded with JSON, so you write `JSON.parse(response.body)`.
      But that gets tedious real quick.
      
      Instead add `parsed_body` which will automatically parse the reponse
      body as what the last request was encoded `as`.
      eee3534b
  17. 03 2月, 2016 1 次提交
  18. 05 1月, 2016 1 次提交
  19. 07 12月, 2015 1 次提交
    • E
      Push `before_sending` to super class · 492b1344
      eileencodes 提交于
      We want to get rid of the `Live::Response` so we are consolidating methods
      from `Live::Response` and `Response` by merging them together.
      
      This adds an `#empty` method to the request so we don't need to
      hard-code the empty array each time we call an empty
      `ActionDispatch::Request`.
      
      The work here is a continuation on combining controller and integration
      test code bases into one.
      492b1344
  20. 28 10月, 2015 1 次提交
  21. 07 10月, 2015 1 次提交
    • J
      Use `Mime[:foo]` instead of `Mime::Type[:FOO]` for back compat · 565094a8
      Jeremy Daer 提交于
      Rails 4.x and earlier didn't support `Mime::Type[:FOO]`, so libraries
      that support multiple Rails versions would've had to feature-detect
      whether to use `Mime::Type[:FOO]` or `Mime::FOO`.
      
      `Mime[:foo]` has been around for ages to look up registered MIME types
      by symbol / extension, though, so libraries and plugins can safely
      switch to that without breaking backward- or forward-compatibility.
      
      Note: `Mime::ALL` isn't a real MIME type and isn't registered for lookup
      by type or extension, so it's not available as `Mime[:all]`. We use it
      internally as a wildcard for `respond_to` negotiation. If you use this
      internal constant, continue to reference it with `Mime::ALL`.
      
      Ref. efc6dd55
      565094a8
  22. 22 9月, 2015 1 次提交
  23. 22 8月, 2015 1 次提交
  24. 08 8月, 2015 1 次提交
    • A
      stop using @_env in the controller instance · 81cfdf24
      Aaron Patterson 提交于
      Actions are processed through `dispatch`, so they should have the
      request set on them before any user land code can be executed.  Lets
      stop setting _env on the controller, and give access to it through the
      `env` method.
      81cfdf24
  25. 07 8月, 2015 1 次提交
  26. 28 7月, 2015 1 次提交
  27. 01 6月, 2015 1 次提交
  28. 30 5月, 2015 1 次提交
  29. 18 5月, 2015 1 次提交
  30. 02 5月, 2015 1 次提交
  31. 18 4月, 2015 1 次提交