- 15 12月, 2015 7 次提交
-
-
由 Rafael Mendonça França 提交于
Update seeds.rb.tt
-
由 Paul Clegg 提交于
Rahm Emanuel doesn't deserve to be in Rails.
-
由 Sean Griffin 提交于
`ActiveRecord::Base#becomes` should copy the errors
-
由 Sean Griffin 提交于
This was changed in 421c81bd, as `exists?` blows up if you are eager loading a polymorphic association, as it'll try to construct a join to that table. The previous change decided to execute a `count` instead, which wouldn't join. Of course, the only time we actually need to perform a join on the eager loaded values (which would perform a left outer join) is if they're being referenced in the where clause. This doesn't affect inner joins.
-
由 Kasper Timm Hansen 提交于
Make Parameters#to_h and #to_unsafe_h return HWIA
-
由 Sean Griffin 提交于
There was a test remaining for PG only that was checking for an exact limit clause
-
由 Vokhmin Alexey V 提交于
-
- 14 12月, 2015 18 次提交
-
-
由 Sean Griffin 提交于
We currently generate an unbounded number of prepared statements when `limit` or `offset` are called with a dynamic argument. This changes `LIMIT` and `OFFSET` to use bind params, eliminating the problem. `Type::Value#hash` needed to be implemented, as it turns out we busted the query cache if the type object used wasn't exactly the same object. This drops support for passing an `Arel::Nodes::SqlLiteral` to `limit`. Doing this relied on AR internals, and was never officially supported usage. Fixes #22250.
-
由 Prem Sichanugrist 提交于
This makes these two methods to be more inline with the previous behavior of Parameters as Parameters used to be inherited from HWIA. Fixes #21391
-
由 Sean Griffin 提交于
Some backends allow `LIMIT 1,2` as a shorthand for `LIMIT 1 OFFSET 2`. Supporting this in Active Record massively complicates using bind parameters for limit and offset, and it's trivially easy to build an invalid SQL query by also calling `offset` on the same `Relation`. This is a niche syntax that is only supported by a few adapters, and can be trivially worked around by calling offset explicitly.
-
由 Sean Griffin 提交于
Add specific bug reporting guidelines to contributing.md [ci skip]
-
由 Sean Griffin 提交于
Add test cases for `#sanitize_sql_array` with named_bind_variables
-
由 eileencodes 提交于
This reverts commit 9712a7a1, reversing changes made to 3e65c3d3. Reverting because this caused test failures and while we have a followup branch there is still one failure that happens randomly and isn't straight forward to fix.
-
由 Santiago Pastorino 提交于
travel back
-
由 Eileen M. Uchitelle 提交于
Controller generators should be creating IntegrationTest stubs instea…
-
由 Kasper Timm Hansen 提交于
-
由 Dharam Gollapudi 提交于
Allows any Rake task to be run through `bin/rails` such as `bin/rails db:migrate`, `bin/rails notes` etc. The Rake tasks are appended to Rails' help output, and blend in as standard commands.
-
由 Kasper Timm Hansen 提交于
Prevent a 500 in the default controller scaffold
-
由 Kasper Timm Hansen 提交于
Update web-console to 3.0.0
-
由 Kasper Timm Hansen 提交于
The API isn't ready yet, which means we haven't documented it. People can't make their own commands, so there's no reason to show it in generated documentation.
-
由 Genadi Samokovarov 提交于
If you update a record with no attributes, you'll hit a 500 from a guard in `assign_attributes` raising: ```ruby ArgumentError: When assigning attributes, you must pass a hash as an argument. app/controllers/users_controller.rb:44:in `block in update' app/controllers/users_controller.rb:43:in `update' test/controllers/users_controller_test.rb:37:in `block in <class:UsersControllerTest>' ``` Not a biggie, but may be quite confusing for the folks new to the framework.
-
由 Arthur Nogueira Neves 提交于
Fix paintIt method in JavaScript guides [ci skip]
-
由 Xavier Noria 提交于
See the rationale in the comment present in this patch.
-
由 Xavier Noria 提交于
Before this commit, the sole presence of the Listen constant enabled the evented file watcher (unless listen resorted to the polling backend). This way, applications may depend on listen for other stuff independently of this feature. Also, allows teams with mixed setups to decide at boot time whether the evented watcher should be enabled for each particular instance.
-
由 Genadi Samokovarov 提交于
Web Console 3.0.0 is compatible with Rails 5, while the 2.x.x releases aren't.
-
- 13 12月, 2015 7 次提交
-
-
由 Kasper Timm Hansen 提交于
Tiny typo in the testing guide; articules should be articles.
-
由 Prathamesh Sonpatki 提交于
- Changed "paintIt" to "@paintIt" so that it can be called in an on click handler. - Closes #22568
-
由 Aaron Patterson 提交于
Use adapter supports_datetime_with_precision
-
由 Fumiaki MATSUSHIMA 提交于
-
由 Abdelkader Boudih 提交于
-
由 eileencodes 提交于
So that it appears correctly in the CHANGELOG on github.
-
由 eileencodes 提交于
In Rails 5.1 `ActionController::TestCase` will be moved out of Rails into it's own gem. Please use `ActionDispatch::IntegrationTest` going foward. Because this will be moved to a gem I used `# :stopdoc:` instead of deleting the documentation. This will remove it from the Rails documentation but still leave the method documented for when we move it to a gem. Guides have been updated to use the routing structure used in Integration and all test examples have been updated to inherit from `ActionDispatch::IntegrationTest` instead of `ActionController::TestCase. Fixes #22496
-
- 12 12月, 2015 6 次提交
-
-
由 Tim 提交于
Add boldface and bullets to make more readable. Make sentences declarative. Remove "you"s.
-
由 Arthur Nogueira Neves 提交于
Show redirect response code in assert_response messages
-
由 Arthur Neves 提交于
This reverts commit c2e70ca9, reversing changes made to b0e5fc27. this broke the build
-
由 Jon Atack 提交于
Follow-up to PR #19977, which helpfully added the redirection path to the error message of assert_response if response is a redirection, but which removed the response code, obscuring the type of redirect. This PR: - brings back the response code in the error message, - updates the tests so the new messages can be tested, - and adds test cases for the change.
-
由 Arthur Nogueira Neves 提交于
Remove unused deprecation notice
-
由 Rafael França 提交于
Use assert over assert_predicate in assert_response
-
- 11 12月, 2015 2 次提交
-
-
由 Rafael França 提交于
fix links to code of conduct [ci skip]
-
由 yuuji.yaginuma 提交于
CoC text has been moved to the Rails website in 90bcb6de
-