- 07 6月, 2014 5 次提交
-
-
由 Sean Griffin 提交于
-
由 Sean Griffin 提交于
As we move towards removing the `klass` method from `column`, the else clause as it stands right now will become the only case.
-
由 Sean Griffin 提交于
-
由 Rafael Mendonça França 提交于
This reverts commit be1db994, reversing changes made to 6680ee94. Reason: This changed a behavior where numeric attributes when receiving blank values didn't change its value.
-
由 Sean Griffin 提交于
-
- 06 6月, 2014 4 次提交
-
-
由 Yves Senn 提交于
Before this patch, using `ActiveRecord::Base.primary_key_prefix_type` with `:table_name_with_underscore` would change the `SchemaMigration` model to have a primary key. This resulted in broken queries for PG because it tried to return the inserted PK (which does not exist). Closes #15051. Closes #15419.
-
由 Yves Senn 提交于
This adds a regression test for #14411, which was fixed by #15503. Closes #14411 Closes #14595
-
由 Yves Senn 提交于
The migration numbers were normalized different ways. This left the task output in an inconsistent state. Closes #15538.
-
由 Sean Griffin 提交于
Whiny nils is no longer a thing, so we no longer need this optimization
-
- 05 6月, 2014 3 次提交
-
-
由 edogawaconan 提交于
BC era year is (astronomical year + 1) and starts from 1 BC.
-
由 Akshay Vishnoi 提交于
-
由 Yves Senn 提交于
Follow up to #15438 and #15502. /cc @sgrif
-
- 04 6月, 2014 7 次提交
-
-
由 Sean Griffin 提交于
For any type that is represented as a string and then type cast, we do not need separate regular expressions for the various types. No function will match this regex. User defined types *should* match this, so that the type object can decide what to do with the value.
-
由 Sean Griffin 提交于
`@raw_attributes` should not contain the type-cast, mutable version of the value.
-
由 Sean Griffin 提交于
-
由 Prathamesh Sonpatki 提交于
-
由 eileencodes 提交于
Reflection has a `belongs_to?` method. Instead of checking for `macro == :belongs_to` throughout the source reuse existing method. I also bumped `foreign_key_present?` method onto on line because the `belongs_to?` makes it shorter than other longer lines in the same class.
-
由 Lauro Caetano 提交于
than existing column. Fixes #15480.
-
由 Sean Griffin 提交于
The contract of `_field_changed?` assumes that the old value is always type cast. That is not the case for the value in `Column#default` as things are today. It appears there are other public methods that assume that `Column#default` is type cast, as well. The reason for this change originally was because the value gets put into `@raw_attributes` in initialize. This reverts to the old behavior on `Column`, and updates `initialize` to make sure that the values are in the right format.
-
- 03 6月, 2014 10 次提交
-
-
由 Yves Senn 提交于
-
由 Sean Griffin 提交于
-
由 Sean Griffin 提交于
-
由 Sean Griffin 提交于
-
由 Yves Senn 提交于
-
由 Sean Griffin 提交于
The types know more about what is going on than the dirty module. Let's ask them!
-
由 Yves Senn 提交于
-
由 eileencodes 提交于
Fix polymorphic to check for `options[:polymorphic]` instead of `options.key? :polymorphic` and then reuse the method `polymorphic?` method instead of constantly checking the same `options[:polymorphic]`.
-
由 Sean Griffin 提交于
This was previously a hook for a special case related to `serialize`, which has since been removed.
-
由 Sean Griffin 提交于
-
- 02 6月, 2014 7 次提交
-
-
由 Yves Senn 提交于
-
由 Yves Senn 提交于
This inlines casting for the most obvious types. The rest will follow eventually. I need to put some tests in place, to make sure that the inlining is not causing regressions. /cc @sgrif
-
由 Sean Griffin 提交于
-
-
The previous tests were passing, because nothing ever looked at the generated XML. What was previously being generated was `<firstname type="NilClass">...`, which is not consistent with all other cases where there is not a known type.
-
由 Sean Griffin 提交于
Nearly completely implemented in terms of custom properties. `_before_type_cast` now stores the raw serialized string consistently, which removes the need to keep track of "state". The following is now consistently true: - `model.serialized == model.reload.serialized` - A model can be dumped and loaded infinitely without changing - A model can be saved and reloaded infinitely without changing
-
由 Sean Griffin 提交于
During `init_with`, the attributes given to the coder will be placed into `@raw_attributes`. As such, we should read from `@raw_attributes` when encoding, rather than `@attributes`, which has been type cast.
-
- 31 5月, 2014 2 次提交
-
-
由 Sean Griffin 提交于
-
由 Sean Griffin 提交于
`@attributes` was actually used for `_before_type_cast` and friends, while `@attributes_cache` is the type cast version (and caching is the wrong word there, but I'm working on removing the conditionals around that). I opted for `@raw_attributes`, because `_before_type_cast` is also semantically misleading. The values in said hash are in the state given by the form builder or database, so raw seemed to be a good word.
-
- 30 5月, 2014 2 次提交
-
-
由 Sean Griffin 提交于
-
由 Yves Senn 提交于
This removes the case statement in `SchemaDumper` and gives every `Type` the possibility to control the SchemaDumper default value output. /cc @sgrif
-