Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
6da00722
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
6da00722
编写于
6月 05, 2014
作者:
A
Akshay Vishnoi
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Remove deprecated method ActiveRecord::Migrator.proper_table_name
上级
92cf1337
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
4 addition
and
54 deletion
+4
-54
activerecord/CHANGELOG.md
activerecord/CHANGELOG.md
+4
-0
activerecord/lib/active_record/migration.rb
activerecord/lib/active_record/migration.rb
+0
-13
activerecord/test/cases/migration_test.rb
activerecord/test/cases/migration_test.rb
+0
-41
未找到文件。
activerecord/CHANGELOG.md
浏览文件 @
6da00722
*
Remove ActiveRecord::Migrator.proper_table_name.
*Akshay Vishnoi*
*
Fix regression on eager loading association based on SQL query rather than
existing column.
...
...
activerecord/lib/active_record/migration.rb
浏览文件 @
6da00722
...
...
@@ -851,19 +851,6 @@ def last_migration #:nodoc:
migrations
(
migrations_paths
).
last
||
NullMigration
.
new
end
def
proper_table_name
(
name
,
options
=
{})
ActiveSupport
::
Deprecation
.
warn
"ActiveRecord::Migrator.proper_table_name is deprecated and will be removed in Rails 4.2. Use the proper_table_name instance method on ActiveRecord::Migration instead"
options
=
{
table_name_prefix:
ActiveRecord
::
Base
.
table_name_prefix
,
table_name_suffix:
ActiveRecord
::
Base
.
table_name_suffix
}.
merge
(
options
)
if
name
.
respond_to?
:table_name
name
.
table_name
else
"
#{
options
[
:table_name_prefix
]
}#{
name
}#{
options
[
:table_name_suffix
]
}
"
end
end
def
migrations_paths
@migrations_paths
||=
[
'db/migrate'
]
# just to not break things if someone uses: migration_path = some_string
...
...
activerecord/test/cases/migration_test.rb
浏览文件 @
6da00722
...
...
@@ -333,47 +333,6 @@ def test_schema_migrations_table_name
Reminder
.
reset_table_name
end
def
test_proper_table_name_on_migrator
reminder_class
=
new_isolated_reminder_class
assert_deprecated
do
assert_equal
"table"
,
ActiveRecord
::
Migrator
.
proper_table_name
(
'table'
)
end
assert_deprecated
do
assert_equal
"table"
,
ActiveRecord
::
Migrator
.
proper_table_name
(
:table
)
end
assert_deprecated
do
assert_equal
"reminders"
,
ActiveRecord
::
Migrator
.
proper_table_name
(
reminder_class
)
end
reminder_class
.
reset_table_name
assert_deprecated
do
assert_equal
reminder_class
.
table_name
,
ActiveRecord
::
Migrator
.
proper_table_name
(
reminder_class
)
end
# Use the model's own prefix/suffix if a model is given
ActiveRecord
::
Base
.
table_name_prefix
=
"ARprefix_"
ActiveRecord
::
Base
.
table_name_suffix
=
"_ARsuffix"
reminder_class
.
table_name_prefix
=
'prefix_'
reminder_class
.
table_name_suffix
=
'_suffix'
reminder_class
.
reset_table_name
assert_deprecated
do
assert_equal
"prefix_reminders_suffix"
,
ActiveRecord
::
Migrator
.
proper_table_name
(
reminder_class
)
end
reminder_class
.
table_name_prefix
=
''
reminder_class
.
table_name_suffix
=
''
reminder_class
.
reset_table_name
# Use AR::Base's prefix/suffix if string or symbol is given
ActiveRecord
::
Base
.
table_name_prefix
=
"prefix_"
ActiveRecord
::
Base
.
table_name_suffix
=
"_suffix"
reminder_class
.
reset_table_name
assert_deprecated
do
assert_equal
"prefix_table_suffix"
,
ActiveRecord
::
Migrator
.
proper_table_name
(
'table'
)
end
assert_deprecated
do
assert_equal
"prefix_table_suffix"
,
ActiveRecord
::
Migrator
.
proper_table_name
(
:table
)
end
end
def
test_proper_table_name_on_migration
reminder_class
=
new_isolated_reminder_class
migration
=
ActiveRecord
::
Migration
.
new
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录