1. 16 7月, 2017 1 次提交
    • Y
      Do not generate unused components contents in `app:update` task · 58036402
      yuuji.yaginuma 提交于
      Currently, `app:update` generates all contents regardless of the
      component using in application.
      
      For example, even if not using Action Cable, `app:update` will generate
      a contents related to Action Cable. This is a little inconvenient.
      This PR checks the existence of the component and does not generate
      unnecessary contents.
      Can not check all options in this way. However, it will be able to
      prevent the generation of unnecessary files.
      58036402
  2. 11 7月, 2017 1 次提交
    • K
      * Don't eagerly require Rails' minitest plugin. · 0d72489b
      Kasper Timm Hansen 提交于
      By making the Rails minitest behave like a standard minitest plugin
      we're much more likely to not break when people use other minitest
      plugins. Like minitest-focus and pride.
      
      To do this, we need to behave like minitest: require files up front
      and then perform the plugin behavior via the at_exit hook.
      This also saves us a fair bit of wrangling with test file loading.
      
      Finally, since the environment and warnings options have to be applied
      as early as possible, and since minitest loads plugins at_exit, they
      have to be moved to the test command.
      
      * Don't expect the root method.
      
      It's likely this worked because we eagerly loaded the Rails minitest plugin
      and that somehow defined a root method on `Rails`.
      
      * Assign a backtrace to failed exceptions.
      
      Otherwise Minitest pukes when attempting to filter the backtrace (which
      Rails' backtrace cleaner then removes).
      
      Means the exception message test has to be revised too.
      
      This is likely caused by the rails minitest plugin now being loaded for
      these tests and assigning a default backtrace cleaner.
      0d72489b
  3. 09 7月, 2017 1 次提交
    • Y
      Load environment file in `dbconsole` command · e12715bf
      yuuji.yaginuma 提交于
      Currently the environment file is not loaded in `dbconsole` command.
      Therefore, for example, if use encrypted secrets values in database.yml,
      `read_encrypted_secrets` will not be true, so the value can not be
      used correctly.
      
      Fixes #29717
      e12715bf
  4. 07 7月, 2017 1 次提交
    • Y
      Add `rails secrets:show` command · af5368ee
      yuuji.yaginuma 提交于
      When secrets confirmed with the `secrets:edit` command, `secrets.yml.enc`
      will change without updating the secrets.
      
      Therefore, even if only want to check secrets, the difference will come
      out. This is a little inconvenient.
      
      In order to solve this problem, added the `secrets:show` command.
      If just want to check secrets, no difference will occur use this command.
      af5368ee
  5. 06 7月, 2017 1 次提交
  6. 03 7月, 2017 1 次提交
  7. 27 6月, 2017 1 次提交
  8. 26 6月, 2017 1 次提交
  9. 18 6月, 2017 1 次提交
  10. 08 5月, 2017 1 次提交
  11. 30 4月, 2017 1 次提交
  12. 27 4月, 2017 1 次提交
  13. 20 4月, 2017 1 次提交
    • J
      Namespace CSS selectors on error pages · df641263
      Jan Krutisch 提交于
      The css selectors on the generated error pages are too broad (for example `text-align: center` on `body` and thus bleed out to the following pages (say, by pressing the back button) when using Turbolinks. This commit namespaces all the selectors.
      df641263
  14. 28 3月, 2017 1 次提交
  15. 26 3月, 2017 2 次提交
  16. 23 3月, 2017 1 次提交
    • C
      Remove -j (--javascript) option from `rails new` · 42198064
      claudiob 提交于
      The "-j" option was added 5 years ago (https://github.com/rails/rails/commit/d9c39c3a)
      when we wanted to support prototype-rails and jquery-rails.
      Prototype is not as popular and jQuery is not a requirement anymore.
      Still the "-j" option can be used to install *any* gem that ends in "-rails".
      
      This "might" open security issues and does not bring great benefits anymore.
      
      If you know which "-rails"-ending gem you want to install, you can manually
      add it to the Gemfile just like any other gem.
      42198064
  17. 22 3月, 2017 1 次提交
  18. 21 3月, 2017 1 次提交
  19. 20 3月, 2017 1 次提交
    • Y
      Add `app:update` task to engines · a42351ac
      yuuji.yaginuma 提交于
      Occasionally we update the file generated by engine.
      Therefore, I think that there is a task for updating as well as
      application in the engine, it is convenient for updating.
      a42351ac
  20. 15 3月, 2017 1 次提交
  21. 14 3月, 2017 1 次提交
  22. 07 3月, 2017 1 次提交
  23. 05 3月, 2017 1 次提交
    • R
      Avoid running system tests by default · 4a77213e
      Robin Dupret 提交于
      These tests may be expansive so let's only allow users to run them
      through `bin/rails test:system` or by passing a path to the `test`
      command.
      
      The same applies for `bin/rake test`.
      
      Refs #28109.
      4a77213e
  24. 03 3月, 2017 1 次提交
  25. 02 3月, 2017 1 次提交
  26. 24 2月, 2017 1 次提交
  27. 22 2月, 2017 1 次提交
  28. 04 2月, 2017 1 次提交
  29. 24 1月, 2017 1 次提交
  30. 18 1月, 2017 1 次提交
  31. 13 1月, 2017 1 次提交
  32. 09 1月, 2017 1 次提交
    • Y
      make all rails commands work in engine · 2a5c116f
      yuuji.yaginuma 提交于
      Currently, all rails commands can be executed in engine,
      but `server`, `console`, `dbconsole` and `runner` do not work.
      
      This make all rails commands work in engine.
      Related to #22588
      2a5c116f
  33. 07 1月, 2017 1 次提交
  34. 04 1月, 2017 6 次提交