1. 16 7月, 2017 2 次提交
    • Y
      Do not generate unused components contents in `app:update` task · 58036402
      yuuji.yaginuma 提交于
      Currently, `app:update` generates all contents regardless of the
      component using in application.
      
      For example, even if not using Action Cable, `app:update` will generate
      a contents related to Action Cable. This is a little inconvenient.
      This PR checks the existence of the component and does not generate
      unnecessary contents.
      Can not check all options in this way. However, it will be able to
      prevent the generation of unnecessary files.
      58036402
    • Y
      Remove blank lines in setup · 02be30ff
      Yoshiyuki Hirano 提交于
      02be30ff
  2. 13 7月, 2017 1 次提交
    • Y
      Allow to edit secrets in mutiple apps at the same time · 1677c64e
      yuuji.yaginuma 提交于
      In encrypted secrets, the tmp file is used as a fixed file
      (`secrets.yml.enc` under the tmp directory).
      And that tmp file will be removed after process.
      
      Therefore, if edit secrets at the same time with multiple applications,
      the tmp file was conflicting.
      
      In order to avoid the above issue, added pid to tmp file.
      1677c64e
  3. 12 7月, 2017 1 次提交
    • L
      Change sqlite3 boolean serialization to use 1 and 0 · 52e050ed
      Lisa Ugray 提交于
      Abstract boolean serialization has been using 't' and 'f', with MySQL
      overriding that to use 1 and 0.
      
      This has the advantage that SQLite natively recognizes 1 and 0 as true
      and false, but does not natively recognize 't' and 'f'.
      
      This change in serialization requires a migration of stored boolean data
      for SQLite databases, so it's implemented behind a configuration flag
      whose default false value is deprecated. The flag itself can be
      deprecated in a future version of Rails.  While loaded models will give
      the correct result for boolean columns without migrating old data,
      where() clauses will interact incorrectly with old data.
      
      While working in this area, also change the abstract adapter to use
      `"TRUE"` and `"FALSE"` as quoted values and `true` and `false` for
      unquoted.  These are supported by PostreSQL, and MySQL remains
      overriden.
      52e050ed
  4. 11 7月, 2017 3 次提交
    • Y
      Fix typo in method name · e01b240e
      yuuji.yaginuma 提交于
      e01b240e
    • L
      Protect from forgery by default · ec4a8369
      Lisa Ugray 提交于
      Rather than protecting from forgery in the generated
      ApplicationController, add it to ActionController::Base by config. This
      configuration defaults to false to support older versions which have
      removed it from their ApplicationController, but is set to true for
      Rails 5.2.
      ec4a8369
    • K
      * Don't eagerly require Rails' minitest plugin. · 0d72489b
      Kasper Timm Hansen 提交于
      By making the Rails minitest behave like a standard minitest plugin
      we're much more likely to not break when people use other minitest
      plugins. Like minitest-focus and pride.
      
      To do this, we need to behave like minitest: require files up front
      and then perform the plugin behavior via the at_exit hook.
      This also saves us a fair bit of wrangling with test file loading.
      
      Finally, since the environment and warnings options have to be applied
      as early as possible, and since minitest loads plugins at_exit, they
      have to be moved to the test command.
      
      * Don't expect the root method.
      
      It's likely this worked because we eagerly loaded the Rails minitest plugin
      and that somehow defined a root method on `Rails`.
      
      * Assign a backtrace to failed exceptions.
      
      Otherwise Minitest pukes when attempting to filter the backtrace (which
      Rails' backtrace cleaner then removes).
      
      Means the exception message test has to be revised too.
      
      This is likely caused by the rails minitest plugin now being loaded for
      these tests and assigning a default backtrace cleaner.
      0d72489b
  5. 09 7月, 2017 2 次提交
  6. 07 7月, 2017 2 次提交
    • Y
      Do not update `secrets.yml.enc` when secretes do not change · 32327eb1
      yuuji.yaginuma 提交于
      Currently, if open a file with `secrets:edit` command, `secrets.yml.enc`
      will be changed even if its contents do not change.
      
      Therefore, even if only want to check secrets, the difference will come
      out. This is a little inconvenient.
      
      As a fix to the above problem, when content does not change,
      `secrets.yml.ecn` is fixed so that it is not changed.
      32327eb1
    • Y
      Add `rails secrets:show` command · af5368ee
      yuuji.yaginuma 提交于
      When secrets confirmed with the `secrets:edit` command, `secrets.yml.enc`
      will change without updating the secrets.
      
      Therefore, even if only want to check secrets, the difference will come
      out. This is a little inconvenient.
      
      In order to solve this problem, added the `secrets:show` command.
      If just want to check secrets, no difference will occur use this command.
      af5368ee
  7. 06 7月, 2017 3 次提交
  8. 05 7月, 2017 1 次提交
    • E
      Fix Parameters configuration integration tests · 458a5502
      Eugene Kenny 提交于
      These tests relied on `ActionController::Parameters` being configured as
      part of the boot process; since that now happens lazily we need to force
      `ActionController::Base` to load so that we can test the behaviour.
      
      The new tests added here ensure that `ActionController::Parameters` can
      be configured from an initializer, which was broken until recently.
      458a5502
  9. 03 7月, 2017 1 次提交
  10. 02 7月, 2017 3 次提交
  11. 01 7月, 2017 3 次提交
  12. 30 6月, 2017 1 次提交
  13. 27 6月, 2017 2 次提交
  14. 26 6月, 2017 1 次提交
  15. 24 6月, 2017 1 次提交
  16. 18 6月, 2017 1 次提交
  17. 17 6月, 2017 1 次提交
  18. 14 6月, 2017 1 次提交
  19. 12 6月, 2017 3 次提交
    • T
      Add note to Railtie docs to use unique filenames · de7bc318
      Tim Vergenz 提交于
      The fact that the names need to be globally unique was not obvious to me, so I
      thought it'd be worth documenting. This not being clear was the cause of both
      ctran/annotate_models#468 and instructure/outrigger#1.
      
      [ci skip]
      de7bc318
    • G
      Drop IRB out of the web-console Gemfile comment · d6581782
      Genadi Samokovarov 提交于
      We don't provide exactly the same experience as IRB does, so let's not
      advertize it like that. We can say that it's an interactive console,
      without further references. I have also followed byebug's comment and
      changed the calling `console` part. Hopefully, this can hint that the
      invocation is not view specific and you can use it like the debugger
      statement.
      
      [ci skip]
      d6581782
    • A
      set message_encryptor default cipher to aes-256-gcm · 7440bf44
      Assain 提交于
      - Introduce a method to select default cipher, and maintain backward compatibility
      7440bf44
  20. 11 6月, 2017 1 次提交
  21. 09 6月, 2017 1 次提交
  22. 06 6月, 2017 1 次提交
  23. 03 6月, 2017 2 次提交
  24. 01 6月, 2017 1 次提交
  25. 30 5月, 2017 1 次提交