- 10 8月, 2016 3 次提交
-
-
由 Andrew White 提交于
In c546a2b0 parameter handling in AC test cases was changed to round tripping through encoders/decoders so that they matched reality and in 0adb8f8f the old methods were removed but the `html_format?` method was overlooked.
-
由 Xavier Noria 提交于
Fix broken alignments caused by auto-correct commit 411ccbda
-
由 Ryuta Kamizono 提交于
Hash syntax auto-correcting breaks alignments. 411ccbda
-
- 09 8月, 2016 6 次提交
-
-
由 Vipul A M 提交于
Document know limitation about using `references` in conjunction with custom select clauses [ci skip]
-
由 Vipul A M 提交于
Document know limitation about using `references` in conjunction with eager loading causing it to ignore custom select clauses. [ci skip] Fixes #24314
-
由 Vipul A M 提交于
Add link to 'Pry' in debugging guide [ci skip]
-
由 Jon Moss 提交于
update list of rescue_responses default [ci skip]
-
由 yuuji.yaginuma 提交于
Follow up to fe859a54
-
由 Xavier Noria 提交于
-
- 08 8月, 2016 20 次提交
-
-
由 Yves Senn 提交于
Use `FETCH FIRST` for Oracle12 and test `ROWNUM <=` for Oracle 11g or older version to test sql limit behavior
-
由 Yasuo Honda 提交于
also test `ROWNUM <=` for Oracle 11g or older version of Oracle and Oracle visitor Oracle 12c database and Arel Oracle12 visitor supports better top N query.
-
由 Xavier Noria 提交于
This code has too much duplication and the rationale for the concatenation may not be obvious to the reader. You define the ones at class-level, explain why does the code concatenates there, and then the convenience ones at instance-level just delegate.
-
由 Yves Senn 提交于
Fix `thread_mattr_accessor` share variable superclass with subclass
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
A few have been left for aesthetic reasons, but have made a pass and removed most of them. Note that if the method `foo` returns an array, `foo << 1` is a regular push, nothing to do with assignments, so no self required.
-
由 Xavier Noria 提交于
Some case expressions remain, need to think about those ones.
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
Inserted spaces in the name of Rails components. Since I was on it, also used PostgreSQL instead of Postgres because albeit Postgres is an accepted alias, PostgreSQL is the official name and the actual name of the adapter. See https://wiki.postgresql.org/wiki/ProjectName with regard to PostgreSQL vs Postgres.
-
由 bogdanvlviv 提交于
-
由 Kasper Timm Hansen 提交于
In some test runs `ActionController::Base.enable_fragment_cache_logging` would be false, based on the test order. Turns out it was off because we assigned the config to the `@controller` variable, and not on `ActionController::Base`. The test failure was reproducible with, and now passes after this: ``` bin/test test/controller/log_subscriber_test.rb --seed 19918 ```
-
由 Kasper Timm Hansen 提交于
-
由 Kasper Timm Hansen 提交于
The entry was a result of a combination of changes in Action View and Action Controller.
-
由 Kasper Timm Hansen 提交于
-
由 Kasper Timm Hansen 提交于
-
由 Kasper Timm Hansen 提交于
Better logging of cached partial renders
-
由 Kasper Timm Hansen 提交于
Fix Accept header overwritten issue when "xhr: true" in integration test
-
由 Stan Lo 提交于
Implement naive partial caching mechanism. Add test for LogSubscriber Use ActionView::Base#log_payload to store log_subscriber's payload, so we can pass cache result into it. Fixed tests Remove useless settings Check if #log_payload exists before calling it. Because other classes also includes CacheHelper but don't have is attribute Use @log_payload_for_partial_reder instead of #log_payload to carry ActionView's payload. Update test's hash syntax Add configuration to enable/disable fragment caching logging Remove unless test and add new test to ensure cache info won't effect next rendering's log Move :enable_fragment_cache_logging config from ActionView to ActionPack Apply new config to tests Update actionview's changelog Update configuration guide Improve actionview's changelog Refactor PartialRenderer#render and log tests Mute subscriber's log instead of disabling instrumentation. Fix typo, remove useless comment and use new hash syntax Improve actionpack's log_subscriber test Fix rebase mistake Apply new config to all caching intstrument actions
-
- 07 8月, 2016 11 次提交
-
-
由 David Chen 提交于
In integration test when specify the "Accept" header with "xhr: true" option, the Accept header is overridden with a default xhr Accept header. The issue only affects HTTP header "Accept" but not CGI variable "HTTP_ACCEPT". For example: get '/page', headers: { 'Accept' => 'application/json' }, xhr: true # This is WRONG! And the response.content_type is also affected. # It should be "application/json" assert_equal "text/javascript, text/html, ...", request.accept assert_equal 'text/html', response.content_type The issue is in `ActionDispatch::Integration::RequestHelpers`. When setting "xhr: true" the helper sets a default HTTP_ACCEPT if blank. But the code doesn't consider supporting both HTTP header style and CGI variable style. For detail see this GitHub issue: https://github.com/rails/rails/issues/25859
-
由 Kasper Timm Hansen 提交于
`ActiveRecord::PredicateBuilder#expand` to be private
-
由 Kasper Timm Hansen 提交于
show error message when error raised in rails runner
-
由 Kasper Timm Hansen 提交于
Eagerly requiring Rake could put 100ms on to the Rails boot time. Shimmy that down to 0 by requiring Rake when no native Rails command exists and we try to run a Rake task. Or when printing all the Rake commands through `rails help`. Fixes #25029
-
由 Vijay Dev 提交于
-
由 Xavier Noria 提交于
Add `Style/EmptyLines` in `.rubocop.yml` and remove extra empty lines
-
由 Ryuta Kamizono 提交于
-
由 yui-knk 提交于
This method is not touched from outside.
-
由 Sean Griffin 提交于
Revert passing arel node with splat binds for `where`
-
由 Guillermo Iguaran 提交于
.to_i is unnecessary for puma threads.
-
由 Xavier Noria 提交于
-