提交 · 12a70404cd164008879e63cc320356e6afee3adc · 张重言 / rails

07 8月, 2016 27 次提交
- X
  
  modernizes hash syntax in actioncable · 12a70404
  由 Xavier Noria 提交于 8月 06, 2016
  
  12a70404
- X
  applies new string literal convention to the rest of the project · e6ab70c4
  由 Xavier Noria 提交于 8月 06, 2016
```
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
```
  e6ab70c4
- X
  applies new string literal convention in the gemspecs · adca8154
  由 Xavier Noria 提交于 8月 06, 2016
```
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
```
  adca8154
- X
  applies new string literal convention in Gemfile · 9ed74044
  由 Xavier Noria 提交于 8月 06, 2016
```
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
```
  9ed74044
- X
  applies new string literal convention in tools · 92e2d16a
  由 Xavier Noria 提交于 8月 06, 2016
```
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
```
  92e2d16a
- X
  applies new string literal convention in tasks · 78d3f849
  由 Xavier Noria 提交于 8月 06, 2016
```
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
```
  78d3f849
- X
  applies new string literal convention in guides · 6b3719b7
  由 Xavier Noria 提交于 8月 06, 2016
```
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
```
  6b3719b7
- X
  applies new string literal convention in ci · 8b4e6bf2
  由 Xavier Noria 提交于 8月 06, 2016
```
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
```
  8b4e6bf2
- X
  applies new string literal convention in railties/test · 783763bd
  由 Xavier Noria 提交于 8月 06, 2016
```
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
```
  783763bd
- X
  applies new string literal convention in railties/lib · 69ab3eb5
  由 Xavier Noria 提交于 8月 06, 2016
```
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
```
  69ab3eb5
- X
  applies new string literal convention in actioncable/test · f8477f13
  由 Xavier Noria 提交于 8月 06, 2016
```
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
```
  f8477f13
- X
  applies new string literal convention in actioncable/lib · b678eb57
  由 Xavier Noria 提交于 8月 06, 2016
```
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
```
  b678eb57
- X
  applies new string literal convention in actionmailer/test · b91ff557
  由 Xavier Noria 提交于 8月 06, 2016
```
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
```
  b91ff557
- X
  applies new string literal convention in actionmailer/lib · c3e7abdd
  由 Xavier Noria 提交于 8月 06, 2016
```
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
```
  c3e7abdd
- X
  applies new string literal convention in actionpack/test · 35b3de80
  由 Xavier Noria 提交于 8月 06, 2016
```
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
```
  35b3de80
- X
  applies new string literal convention in actionpack/lib · 628e51ff
  由 Xavier Noria 提交于 8月 06, 2016
```
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
```
  628e51ff
- X
  applies new string literal convention in actionview/test · 4b6c68df
  由 Xavier Noria 提交于 8月 06, 2016
```
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
```
  4b6c68df
- X
  applies new string literal convention in actionview/lib · 66a7cfa9
  由 Xavier Noria 提交于 8月 06, 2016
```
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
```
  66a7cfa9
- X
  applies new string literal convention in activejob/test · bde6547b
  由 Xavier Noria 提交于 8月 06, 2016
```
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
```
  bde6547b
- X
  applies new string literal convention in activejob/lib · 93c9534c
  由 Xavier Noria 提交于 8月 06, 2016
```
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
```
  93c9534c
- X
  applies new string literal convention in activemodel/test · 4c208254
  由 Xavier Noria 提交于 8月 06, 2016
```
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
```
  4c208254
- X
  applies new string literal convention in activemodel/lib · 18a25137
  由 Xavier Noria 提交于 8月 06, 2016
```
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
```
  18a25137
- X
  applies new string literal convention in activerecord/test · 9617db20
  由 Xavier Noria 提交于 8月 06, 2016
```
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
```
  9617db20
- X
  applies new string literal convention in activerecord/lib · 4df2b779
  由 Xavier Noria 提交于 8月 06, 2016
```
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
```
  4df2b779
- X
  applies new string literal convention in activesupport/test · a731125f
  由 Xavier Noria 提交于 8月 06, 2016
```
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
```
  a731125f
- X
  applies new string literal convention in activesupport/lib · d66e7835
  由 Xavier Noria 提交于 8月 06, 2016
```
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
```
  d66e7835
- X
  
  adds a few cops and sorts · 77eb40da
  由 Xavier Noria 提交于 8月 06, 2016
  
  77eb40da
06 8月, 2016 8 次提交

E
Merge pull request #25998 from kamipo/enum_with_alias_attribute · 6510f998
由 Eileen M. Uchitelle 提交于 8月 06, 2016
```
Fix `enum` with `alias_attribute`
```
6510f998
E
Merge pull request #26023 from tekin/correct-acceptance-guidelines · 78a87740
由 Eileen M. Uchitelle 提交于 8月 06, 2016
```
Correct usage for acceptance validator in guide
```
78a87740
C
Merge pull request #26070 from claudiob/fix-404 · d59dc69f
由 Claudio B 提交于 8月 05, 2016
```
[ci skip] Fix broken URL in guides
```
d59dc69f
C

[ci skip] Fix broken URL in guides · 2ea3342c
由 claudiob 提交于 8月 05, 2016

2ea3342c
E
Merge pull request #25665 from kamipo/remove_unused_table_arg · 53607c8e
由 Eileen M. Uchitelle 提交于 8月 05, 2016
```
Remove unused `table` arg for `UniquenessValidator#scope_relation`
```
53607c8e
E
Merge pull request #26051 from kamipo/make_name_and_binds_to_optional_args · 2bd9ec6b
由 Eileen M. Uchitelle 提交于 8月 05, 2016
```
Make `name` and `binds` to optional args for `exec_{insert,update,delete}`
```
2bd9ec6b

Fix GET JSON integration test request to use method override · af1680f5

由 eileencodes 提交于 8月 05, 2016

When a `GET` request is sent `as: :json` in an integration test the test
should use Rack's method override to change to a post request so the
paramters are included in the postdata. Otherwise it will not encode the
parameters correctly for the integration test.

Because integration test sets up it's own middleware,
`Rack::MethodOverride` needs to be included in the integration tests as
well.

`headers ||= {}` was moved so that headers are never nil. They should
default to a hash.

Fixes #26033

[Eileen M. Uchitelle & Aaron Patterson]

af1680f5

Add note about limitations of Windows Subsystem for Linux · 70f2f981

由 Andrew White 提交于 8月 05, 2016

Due to the limited support for inotify (Microsoft/BashOnWindows#216) in
WSL the best thing to do at moment is add a note about skipping spring
and listen when generating your application in the Getting Started guide.

[skip ci]

Fixes #26054.

70f2f981

05 8月, 2016 5 次提交

Don't assume all hashes are from multiparameter assignment in `composed_of` · b63d532f

由 Sean Griffin 提交于 8月 05, 2016

So this bug is kinda funky. The code path is basically "if we weren't passed an
instance of the class we compose to, and we have a converter, call that".
Ignoring the hash case for a moment, everything after that was roughly intended
to be the "else" clause, meaning that we are expected to have an instance of
the class we compose to. Really, we should be blowing up in that case, as we
can give a much better error message than what they user will likely get (e.g.
`NameError: No method first for String` or something). Still, Ruby is duck
typed, so if the object you're assigning responds to the same methods as the
type you compose to, knock yourself out.

The hash case was added in 36e9be85 to remove a bunch of special cased code from
multiparameter assignment. I wrongly assumed that the only time we'd get a hash
there is in that case. Multiparameter assignment will construct a very specific
hash though, where the keys are integers, and we will have a set of keys
covering `1..part.size` exactly. I'm pretty sure this could actually be passed
around as an array, but that's a different story. Really I should convert this
to something like `class MultiParameterAssignment < Hash; end`, which I might
do soon. However for a change that I'm willing to backport to 4-2-stable, this
is what I want to go with for the time being.

Fixes #25978

b63d532f

D
Merge pull request #26059 from rails/rename-deadlock-detected-to-deadlocked · 320d4012
由 David Heinemeier Hansson 提交于 8月 04, 2016
```
The problem isn't the detection but the deadlock itself
```
320d4012
D

Offer invitations to use retry_on/discard_on for common cases · 01a69e27
由 David Heinemeier Hansson 提交于 8月 04, 2016

01a69e27
D

Leave internal pgsql name intact as const reference · 7443a332
由 David Heinemeier Hansson 提交于 8月 04, 2016

7443a332
D

The problem isn't the detection but the deadlock itself · ac76d551
由 David Heinemeier Hansson 提交于 8月 04, 2016

ac76d551