1. 19 12月, 2014 1 次提交
  2. 17 12月, 2014 1 次提交
  3. 16 12月, 2014 2 次提交
    • T
      allow reseting of request variants · e1fb3483
      Timo Schilling 提交于
      The current implementation of `variants=` don't allow a resetting to nil, wich is the default value.
      
      This results in the following code smell:
      ```ruby
      case request.user_agent
      when /iPhone/
        request.variants = :phone
      when /iPad/
        request.variants = :ipad
      end
      ```
      
      With the ability to reset variants to nil, it could be:
      ```ruby
      request.variants = case request.user_agent
      when /iPhone/
        :phone
      when /iPad/
        :ipad
      end
      ```
      e1fb3483
    • C
      Remove misleading test: around_action return false · 8dfa585d
      claudiob 提交于
      When an `around_action` does not `yield`, then the corresponding action is
      *never* executed and the `after_` actions are *never* invoked.
      
      The value returned by the `around_action` does not have any impact on this:
      an `around_action` can "return" `true`, `false`, or `"pizza"`, but as long
      as `yield` is not invoked, the corresponding action and after callbacks are
      not executed.
      
      The test suite for `ActionController::Callbacks` currently includes separate
      tests to distinguish the cases in which a non-yielding `around_actions` returns
      `true` or `false`.
      
      In my opinion, having such tests is misleading, giving the impression that the
      returned value might have some sort of impact, while it does not. At least
      that's the impression I got when I read those tests.
      
      For completeness, the tests were introduced 7 years ago by @NZKoz in e80fabbb.
      8dfa585d
  4. 15 12月, 2014 1 次提交
  5. 14 12月, 2014 2 次提交
  6. 13 12月, 2014 1 次提交
  7. 12 12月, 2014 1 次提交
  8. 06 12月, 2014 1 次提交
  9. 05 12月, 2014 1 次提交
  10. 04 12月, 2014 1 次提交
    • C
      Remove "rescue" clause around "require 'openssl'" · e428ddec
      claudiob 提交于
      Some `require 'openssl'` statements were surrounded by `rescue` blocks to deal with Ruby versions that did not support `OpenSSL::Digest::SHA1` or `OpenSSL::PKCS5`.
      
      [As @jeremy explains](https://github.com/rails/rails/commit/a6a0904fcb12b876469c48b1c885aadafe9188cf#commitcomment-8826666) in the original commit:
      
      > If jruby didn't have jruby-openssl gem, the require wouldn't work. Not sure whether either of these are still relevant today.
      
      According to the [release notes for JRuby 1.7.13](http://www.jruby.org/2014/06/24/jruby-1-7-13.html):
      
      > jruby-openssl 0.9.5 bundled
      
      which means the above `rescue` block is not needed anymore.
      
      All the Ruby versions supported by the current version of Rails provide those OpenSSL libraries, so Travis CI should also be happy by removing the `rescue` blocks.
      
      ---
      
      Just to confirm, with JRuby:
      
          $ ruby --version #=> jruby 1.7.16.1 (1.9.3p392) 2014-10-28 4e93f31 on Java HotSpot(TM) 64-Bit Server VM 1.8.0_20-b26 +jit [darwin-x86_64]
          $ irb
          irb(main):001:0> require 'openssl' #=> true
          irb(main):002:0> OpenSSL::Digest::SHA1 #=> OpenSSL::Digest::SHA1
          irb(main):003:0> OpenSSL::PKCS5 # => OpenSSL::PKCS5
      
      And with Ruby 2.1:
      
          $ ruby --version #=> ruby 2.1.2p95 (2014-05-08 revision 45877) [x86_64-darwin13.0]
          $ irb
          irb(main):001:0> require 'openssl' #=> true
          irb(main):002:0> OpenSSL::Digest::SHA1 #=> OpenSSL::Digest::SHA1
          irb(main):003:0> OpenSSL::PKCS5 #=> OpenSSL::PKCS5
      e428ddec
  11. 03 12月, 2014 1 次提交
  12. 02 12月, 2014 2 次提交
  13. 29 11月, 2014 3 次提交
  14. 27 11月, 2014 1 次提交
  15. 25 11月, 2014 3 次提交
  16. 24 11月, 2014 1 次提交
  17. 23 11月, 2014 4 次提交
  18. 19 11月, 2014 1 次提交
  19. 17 11月, 2014 2 次提交
  20. 16 11月, 2014 1 次提交
  21. 14 11月, 2014 1 次提交
  22. 11 11月, 2014 1 次提交
  23. 10 11月, 2014 2 次提交
    • G
      Remove useless `only_path: true` in path helpers · 6625000b
      Godfrey Chan 提交于
      We added a deprecation warning for these cases in aa1fadd4, so these are now
      causing deprecation warnings in the test output. AFAICT, in these two cases, the
      option is not integral to the purpose of the test, so they can be safely removed
      6625000b
    • G
      Pass the route name explicitly · aa6637d1
      Godfrey Chan 提交于
      Follow up to 212057b9. Since that commit, we need to pass the `route_name`
      explicitly. This is one of the left-over cases that was not handled in that
      commit, which was causing `use_route` to be ignored in functional tests.
      aa6637d1
  24. 05 11月, 2014 1 次提交
  25. 30 10月, 2014 1 次提交
  26. 29 10月, 2014 1 次提交
    • G
      Deprecate the `only_path` option on `*_path` helpers. · aa1fadd4
      Godfrey Chan 提交于
      In cases where this option is set to `true`, the option is redundant and can
      be safely removed; otherwise, the corresponding `*_url` helper should be
      used instead.
      
      Fixes #17294.
      
      See also #17363.
      
      [Dan Olson, Godfrey Chan]
      aa1fadd4
  27. 25 10月, 2014 1 次提交
  28. 24 10月, 2014 1 次提交