- 24 1月, 2018 2 次提交
-
-
由 Sean Griffin 提交于
We don't implement much custom marshalling logic for these objects, but the proc default case needs to be handled separately. Unfortunately there's no way to just say "do what you would have done but with this value for one ivar", so we have to manually implement `marshal_load` as well. The test case is a little bit funky, but I'd really like an equality test in there, and there's no easy way to add one now that this is out of AR (since the `attributes` method isn't here) Fixes #31216
-
由 Ryuta Kamizono 提交于
Fix actionmailer lambda default
-
- 23 1月, 2018 15 次提交
-
-
由 Yuji Yaginuma 提交于
Fix locale_selector JS bug in ActionMailer Preview
-
由 Hitoshi Nakashima 提交于
-
由 Rafael França 提交于
Improve fault tolerance for redis cache store
-
由 fatkodima 提交于
-
由 George Claghorn 提交于
-
由 Rafael França 提交于
remove text repetition
-
由 utilum 提交于
[ci skip]
-
由 Rafael Mendonça França 提交于
Add support for connection pooling on RedisCacheStore
-
由 Rafael França 提交于
Update guide text not to contradict image
-
由 utilum 提交于
The bottom line in the image of `ActionController::UnknownFormat`is not truncated. Now the text does not say it is. [ci skip]
-
由 Ryuta Kamizono 提交于
Support for PostgreSQL foreign tables
-
由 Ryuta Kamizono 提交于
Fixes #31762.
-
由 fatkodima 提交于
-
由 fatkodima 提交于
-
由 Ryuta Kamizono 提交于
Ignores a default subclass when `becomes(Parent)`
-
- 22 1月, 2018 9 次提交
-
-
由 Leonel Galan 提交于
Fixes issue described in #30399: A default value on the inheritance column prevented `child.becomes(Parent)` to return an instance of `Parent` as expected, instead it returns an instance of the default subclass. The change was introduced by #17169 and it was meant to affect initialization, alone. Where `Parent.new` is expected to return an instance of the default subclass.
-
由 Matthew Draper 提交于
Don't perform unnecessary check with false, just use true/false values
-
由 Ryuta Kamizono 提交于
Don't update counter cache when through record was not destroyed
-
由 George Claghorn 提交于
-
由 George Claghorn 提交于
bin/yarn: Pass through arguments with spaces
-
由 Ryuta Kamizono 提交于
Use singular define_attribute_method
-
由 Daniel Colson 提交于
`define_attribute_methods` splats the arguments, then calls out to `define_attribute_method` for each. When defining a singule attribute, using the singular version of the method saves us an array and an extra method call.
-
由 Ryuta Kamizono 提交于
#30985 caused `object.save` performance regression since calling `changes` in `changes_applied` is very slow. We don't need to call the expensive method in `changes_applied` as long as `@attributes` is tracked by mutation tracker. https://gist.github.com/kamipo/1a9f4f3891803b914fc72ede98268aa2 Before: ``` Warming up -------------------------------------- create_string_columns 73.000 i/100ms Calculating ------------------------------------- create_string_columns 722.256 (± 5.8%) i/s - 3.650k in 5.073031s ``` After: ``` Warming up -------------------------------------- create_string_columns 96.000 i/100ms Calculating ------------------------------------- create_string_columns 950.224 (± 7.7%) i/s - 4.800k in 5.084837s ```
-
由 Jake Teton-Landis 提交于
Previously, the `bin/yarn` wrapper would "unquote" arguments to yarn like this: `yarn run add-copyright "(c) 2017, 2018 MyCompany"` That results in an ARGV of ['run', 'add-copyright', '(c) 2017, 2018 MyCompany'] in the yarn wrapper, but a ARGV in the yarn executable of ['run', 'add-copyright', '(c)', '2017,', '2018', MyCompany']
-
- 21 1月, 2018 1 次提交
-
-
由 George Claghorn 提交于
-
- 20 1月, 2018 5 次提交
-
-
由 Yuji Yaginuma 提交于
Use dup'ed options hash
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
Fix typos and improve text_helper documentation regarding sanitization [ci skip]
-
由 James Lovejoy 提交于
[ci skip]
-
由 George Claghorn 提交于
-
- 19 1月, 2018 8 次提交
-
-
由 George Claghorn 提交于
-
由 Matthew Draper 提交于
Enable autocorrect for `Lint/EndAlignment` cop
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
This was added in #31727, but it is unused.
-
由 Ryuta Kamizono 提交于
This test case which was added in #28287 checks that `ActiveRecord::Schema.define` loads migration versions in subdirectories. It should be kept it as it was.
-
由 Ryuta Kamizono 提交于
Fix minor typo [ci skip]
-
由 Tom Copeland 提交于
Updated the method counts and unified them all on numerals.
-
由 yuuji.yaginuma 提交于
Follow up to e1473e0c
-