- 10 11月, 2014 1 次提交
-
-
由 Sammy Larbi 提交于
-
- 08 11月, 2014 2 次提交
-
-
由 alfa-jpn 提交于
fixes #17495
-
由 Aaron Patterson 提交于
if you specify a default scope on a model, it will break caching. We cannot predict what will happen inside the scope, so play it safe for now. fixes #17495
-
- 07 11月, 2014 2 次提交
-
-
由 Yves Senn 提交于
-
由 Franky W 提交于
Currently, there is no messages which get printed out. Convoluted system may have hooks that create other objects in which case we only fail with no messages. This commit changes this information allowing you to know which object is the one that actually raised the error.
-
- 06 11月, 2014 2 次提交
-
-
由 Sean Griffin 提交于
-
由 Sean Griffin 提交于
We introduced a performance hit by adding an additional iteration through a model's attributes on creation. We don't actually need the values from `Result` to be a hash, we can separate the columns and values and zip them up ourself during the iteration that we have to do.
-
- 05 11月, 2014 2 次提交
-
-
由 Paul Annesley 提交于
-
由 Ted O'Meara 提交于
-
- 04 11月, 2014 1 次提交
-
-
由 Rafael Mendonça França 提交于
-
- 03 11月, 2014 7 次提交
-
-
由 Pablo Herrero 提交于
-
由 Andrew White 提交于
-
由 yuuji.yaginuma 提交于
This reverts commit 482fdad5. Fixes #17237.
-
由 Sean Griffin 提交于
We should not behave differently just because a class has a default scope.
-
由 Sean Griffin 提交于
This method is still used by `update_all`
-
由 Sean Griffin 提交于
These appear to be implementation relics of times past. They duplicate the logic in Relation, and are no longer used internally.
-
由 Sean Griffin 提交于
Arel specifically handles `SelectManager`, with the same logic we're currently performing. The AST is `Enumerable`, which Arel looks for separately now.
-
- 02 11月, 2014 7 次提交
-
-
由 Sean Griffin 提交于
-
由 Sean Griffin 提交于
We need to re-order the bind parameters since the AST returned by the relation will have the where statement as the first bp, which breaks on PG.
-
由 Pablo Herrero 提交于
-
由 Sean Griffin 提交于
MySQL reports the column name as `"MAX(developer_id)"`. PG will report it as `"max"`
-
由 Sean Griffin 提交于
-
由 Sean Griffin 提交于
In practical terms, this allows serialized columns and tz aware columns to be used in wheres that go through joins, where they previously would not behave correctly. Internally, this removes 1/3 of the cases where we rely on Arel to perform type casting for us. There were two non-obvious changes required for this. `update_all` on relation was merging its bind values with arel's in the wrong order. Additionally, through associations were assuming there would be no bind parameters in the preloader (presumably because the where would always be part of a join) [Melanie Gilman & Sean Griffin]
-
由 Sean Griffin 提交于
This slightly simplifies the code, and reduces the number of times we need to iterate over the attributes by one.
-
- 01 11月, 2014 11 次提交
-
-
由 Vipul A M 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Joe Rafaniello 提交于
Skip setting sequence on a table create if the value is 0 since it will start the first value at 1 anyway. This fixes the PG error 'setval: value 0 is out of bounds for sequence vms_id_seq...' encountered when migrating a new DB. BugzID: 15452,9772,13475,16850
-
由 Melanie Gilman 提交于
We end up re-ordering them either way when we construct the Arel AST (in order to deal with rewhere, etc), so we shouldn't bother giving it a number in the first place beforehand.
-
由 Sean Griffin 提交于
-
由 Sean Griffin 提交于
Nothing is directly using the columns for the default values anymore. This step helps us get closer not not mutating the columns hash.
-
由 Sean Griffin 提交于
Fixes #17170
-
由 Sean Griffin 提交于
We had accidentally gone one power of two too far. In addition, we need to handle minimum values as well as the maximum.
-
由 Sean Griffin 提交于
Sufficiently large integers cause `find` and `find_by` to raise `StatementInvalid` instead of `RecordNotFound` or just returning `nil`. Given that we can't cast to `nil` for `Integer` like we would with junk data for other types, we raise a `RangeError` instead, and rescue in places where it would be highly unexpected to get an exception from casting. Fixes #17380
-
由 Sean Griffin 提交于
It is internal use only. This is to avoid conflicting with users' method names. Fixes #17458
-
- 31 10月, 2014 2 次提交
-
-
由 Sean Griffin 提交于
Arel has changed so that `.sum` no longer aliases `SUM(the_column)` to `sum_id`. This means the type returned by the adapter will be at the key `"SUM(the_column)"`. Longer term, we should eventually be able to retain type information from the AR::Base subclasses used in joined queries
-
由 Godfrey Chan 提交于
-
- 30 10月, 2014 3 次提交
-
-
由 claudiob 提交于
-
由 Sean Griffin 提交于
Passing ranges to `#in` has been deprecated in Arel.
-
由 Aaron Patterson 提交于
-