- 24 7月, 2017 22 次提交
-
-
由 Sean Griffin 提交于
Remove duplicated assertion in `test_count_with_join`
-
由 Sean Griffin 提交于
There's an actual bug in 213796fb around prepared statements being disabled. I'm looking into it, but in the mean time this gets the build green so it doesn't block other PRs
-
由 Sean Griffin 提交于
A common source of bugs and code bloat within Active Record has been the need for us to maintain the list of bind values separately from the AST they're associated with. This makes any sort of AST manipulation incredibly difficult, as any time we want to potentially insert or remove an AST node, we need to traverse the entire tree to find where the associated bind parameters are. With this change, the bind parameters now live on the AST directly. Active Record does not need to know or care about them until the final AST traversal for SQL construction. Rather than returning just the SQL, the Arel collector will now return both the SQL and the bind parameters. At this point the connection adapter will have all the values that it had before. A bit of this code is janky and something I'd like to refactor later. In particular, I don't like how we're handling associations in the predicate builder, the special casing of `StatementCache::Substitute` in `QueryAttribute`, or generally how we're handling bind value replacement in the statement cache when prepared statements are disabled. This also mostly reverts #26378, as it moved all the code into a location that I wanted to delete. /cc @metaskills @yahonda, this change will affect the adapters Fixes #29766. Fixes #29804. Fixes #26541. Close #28539. Close #24769. Close #26468. Close #26202. There are probably other issues/PRs that can be closed because of this commit, but that's all I could find on the first few pages.
-
由 Kasper Timm Hansen 提交于
Avoid modifying frozen string in check_schema_file
-
由 Kasper Timm Hansen 提交于
Fix test failure in message verifier tests
-
由 Kasper Timm Hansen 提交于
Add tests to MessageVerifier
-
由 David Rodríguez 提交于
Without this, I get the following result on my machine ``` # Running: F Failure: MessageVerifierTest#test_backward_compatibility_messages_signed_without_metadata [/home/deivid/Code/rails/activesupport/test/message_verifier_test.rb:91]: --- expected +++ actual @@ -1 +1 @@ -{:some=>"data", :now=>2010-01-01 00:00:00 +0100} +{:some=>"data", :now=>2010-01-01 00:00:00 +0000} bin/test test/message_verifier_test.rb:89 ```
-
由 Assain 提交于
-
由 Kasper Timm Hansen 提交于
The paragraphs retread ground covered by the title and the usage examples, so let's just remove them. [ Assain Jaleel & Kasper Timm Hansen ]
-
由 Kasper Timm Hansen 提交于
Document metadata support for MessageEncryptor
-
由 Assain 提交于
[ci skip]
-
由 Assain 提交于
[ci skip]
-
由 Rafael França 提交于
Remove time stubs after each test
-
由 Ryuta Kamizono 提交于
The queries both `res2` and `res3` are completely the same. And also, `assert_nothing_raised` is covered by following assertion.
-
由 Sean Griffin 提交于
Use frozen string literal in actioncable/
-
由 Sean Griffin 提交于
Make actionview ready for frozen strings
-
由 Kir Shatrov 提交于
-
由 Sean Griffin 提交于
Make actioncable ready for frozen strings
-
由 Kir Shatrov 提交于
-
由 Kir Shatrov 提交于
-
由 Eugene Kenny 提交于
This was missed when the frozen string literal pragma was added to this file because the string is only modified when running in the context of a full Rails app, which wasn't covered by the test suite.
-
由 Richard Schneeman 提交于
Use frozen string literal in actionmailer/
-
- 23 7月, 2017 8 次提交
-
-
由 Kir Shatrov 提交于
-
由 Kasper Timm Hansen 提交于
-
由 Kasper Timm Hansen 提交于
Fix a failued AR test when using OracleAdapter
-
由 Kasper Timm Hansen 提交于
[ Assain Jaleel & Kasper Timm Hansen ]
-
由 Kasper Timm Hansen 提交于
[ Assain Jaleel & Kasper Timm Hansen ]
-
由 Kasper Timm Hansen 提交于
-
由 Kasper Timm Hansen 提交于
So releasing 5.1 and 5.0 together won't require manual copy and paste.
-
由 Kasper Timm Hansen 提交于
Basically revises the release flow to: * Update the version in RAILS_VERSION + rake changelog:header * Run rake all:verify (click around in the booted app) * If that checks out, run rake release.
-
- 22 7月, 2017 10 次提交
-
-
由 Eileen M. Uchitelle 提交于
Sort enabled adapter extensions in schema dump
-
由 George Claghorn 提交于
Reverts 7abb6e00.
-
由 Sean Griffin 提交于
Use `TRUE` and `FALSE` boolean literals for MySQL
-
由 Rafael França 提交于
Use `ArgumentError` instead of own error class
-
由 Rafael França 提交于
Make `type_map` to private because it is only used in the connection adapter
-
由 Rafael França 提交于
Updates Rails upgrade guide on `ActionView::Helpers::RecordTagHelper`
-
由 Rafael França 提交于
Fix false positive test related to wrong app root path.
-
由 Rafael França 提交于
Match destroyed_by_association for has_one to has_many
-
由 Rafael França 提交于
Use frozen-string-literal in ActiveRecord
-
由 Sean Griffin 提交于
This reverts commit b6ad4052. This is not something that the majority of Active Record should be testing or care about. We should look at having fewer places rely on these details, not make it easier to rely on them.
-