Merge pull request #29820 from kirs/frozen-actioncable

Use frozen string literal in actioncable/

.rubocop.yml

@@ -89,6 +89,7 @@ Style/FrozenStringLiteralComment:
   Include:
     - 'activesupport/**/*'
     - 'activemodel/**/*'
+    - 'actioncable/**/*'
     - 'activejob/**/*'
     - 'activerecord/**/*'
     - 'actionmailer/**/*'

actioncable/Rakefile

+# frozen_string_literal: true
+
 require "rake/testtask"
 require "pathname"
 require "open3"

actioncable/actioncable.gemspec

+# frozen_string_literal: true
+
 version = File.read(File.expand_path("../RAILS_VERSION", __dir__)).strip
 
 Gem::Specification.new do |s|

actioncable/bin/test

 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 COMPONENT_ROOT = File.expand_path("..", __dir__)
 require_relative "../../tools/test"

actioncable/lib/action_cable.rb

+# frozen_string_literal: true
+
 #--
 # Copyright (c) 2015-2017 Basecamp, LLC
 #

actioncable/lib/action_cable/channel.rb

+# frozen_string_literal: true
+
 module ActionCable
   module Channel
     extend ActiveSupport::Autoload

actioncable/lib/action_cable/channel/base.rb

@@ -270,7 +270,7 @@ def dispatch_action(action, data)
         end
 
         def action_signature(action, data)
-          "#{self.class.name}##{action}".tap do |signature|
+          "#{self.class.name}##{action}".dup.tap do |signature|
             if (arguments = data.except("action")).any?
               signature << "(#{arguments.inspect})"
             end

actioncable/lib/action_cable/channel/broadcasting.rb

+# frozen_string_literal: true
+
 require "active_support/core_ext/object/to_param"
 
 module ActionCable

actioncable/lib/action_cable/channel/callbacks.rb

+# frozen_string_literal: true
+
 require "active_support/callbacks"
 
 module ActionCable

actioncable/lib/action_cable/channel/naming.rb

+# frozen_string_literal: true
+
 module ActionCable
   module Channel
     module Naming

actioncable/lib/action_cable/channel/periodic_timers.rb

+# frozen_string_literal: true
+
 module ActionCable
   module Channel
     module PeriodicTimers

actioncable/lib/action_cable/channel/streams.rb

+# frozen_string_literal: true
+
 module ActionCable
   module Channel
     # Streams allow channels to route broadcastings to the subscriber. A broadcasting is, as discussed elsewhere, a pubsub queue where any data

actioncable/lib/action_cable/connection.rb

+# frozen_string_literal: true
+
 module ActionCable
   module Connection
     extend ActiveSupport::Autoload

actioncable/lib/action_cable/connection/authorization.rb

+# frozen_string_literal: true
+
 module ActionCable
   module Connection
     module Authorization

actioncable/lib/action_cable/connection/base.rb

+# frozen_string_literal: true
+
 require "action_dispatch"
 
 module ActionCable

actioncable/lib/action_cable/connection/client_socket.rb

+# frozen_string_literal: true
+
 require "websocket/driver"
 
 module ActionCable

actioncable/lib/action_cable/connection/identification.rb

+# frozen_string_literal: true
+
 require "set"
 
 module ActionCable

actioncable/lib/action_cable/connection/internal_channel.rb

+# frozen_string_literal: true
+
 module ActionCable
   module Connection
     # Makes it possible for the RemoteConnection to disconnect a specific connection.

actioncable/lib/action_cable/connection/message_buffer.rb

+# frozen_string_literal: true
+
 module ActionCable
   module Connection
     # Allows us to buffer messages received from the WebSocket before the Connection has been fully initialized, and is ready to receive them.

actioncable/lib/action_cable/connection/stream.rb

+# frozen_string_literal: true
+
 require "thread"
 
 module ActionCable

actioncable/lib/action_cable/connection/stream_event_loop.rb

+# frozen_string_literal: true
+
 require "nio"
 require "thread"
 

actioncable/lib/action_cable/connection/subscriptions.rb

+# frozen_string_literal: true
+
 require "active_support/core_ext/hash/indifferent_access"
 
 module ActionCable

actioncable/lib/action_cable/connection/tagged_logger_proxy.rb

+# frozen_string_literal: true
+
 module ActionCable
   module Connection
     # Allows the use of per-connection tags against the server logger. This wouldn't work using the traditional

actioncable/lib/action_cable/connection/web_socket.rb

+# frozen_string_literal: true
+
 require "websocket/driver"
 
 module ActionCable

actioncable/lib/action_cable/engine.rb

+# frozen_string_literal: true
+
 require "rails"
 require "action_cable"
 require_relative "helpers/action_cable_helper"

actioncable/lib/action_cable/gem_version.rb

+# frozen_string_literal: true
+
 module ActionCable
   # Returns the version of the currently loaded Action Cable as a <tt>Gem::Version</tt>.
   def self.gem_version

actioncable/lib/action_cable/helpers/action_cable_helper.rb

+# frozen_string_literal: true
+
 module ActionCable
   module Helpers
     module ActionCableHelper

actioncable/lib/action_cable/remote_connections.rb

+# frozen_string_literal: true
+
 module ActionCable
   # If you need to disconnect a given connection, you can go through the
   # RemoteConnections. You can find the connections you're looking for by

actioncable/lib/action_cable/server.rb

+# frozen_string_literal: true
+
 module ActionCable
   module Server
     extend ActiveSupport::Autoload

actioncable/lib/action_cable/server/base.rb

+# frozen_string_literal: true
+
 require "monitor"
 
 module ActionCable

actioncable/lib/action_cable/server/broadcasting.rb

+# frozen_string_literal: true
+
 module ActionCable
   module Server
     # Broadcasting is how other parts of your application can send messages to a channel's subscribers. As explained in Channel, most of the time, these

actioncable/lib/action_cable/server/configuration.rb

+# frozen_string_literal: true
+
 module ActionCable
   module Server
     # An instance of this configuration object is available via ActionCable.server.config, which allows you to tweak Action Cable configuration

actioncable/lib/action_cable/server/connections.rb

+# frozen_string_literal: true
+
 module ActionCable
   module Server
     # Collection class for all the connections that have been established on this specific server. Remember, usually you'll run many Action Cable servers, so

actioncable/lib/action_cable/server/worker.rb

+# frozen_string_literal: true
+
 require "active_support/callbacks"
 require "active_support/core_ext/module/attribute_accessors_per_thread"
 require "concurrent"

actioncable/lib/action_cable/server/worker/active_record_connection_management.rb

+# frozen_string_literal: true
+
 module ActionCable
   module Server
     class Worker

actioncable/lib/action_cable/subscription_adapter.rb

+# frozen_string_literal: true
+
 module ActionCable
   module SubscriptionAdapter
     extend ActiveSupport::Autoload

actioncable/lib/action_cable/subscription_adapter/async.rb

+# frozen_string_literal: true
+
 require_relative "inline"
 
 module ActionCable

actioncable/lib/action_cable/subscription_adapter/base.rb

+# frozen_string_literal: true
+
 module ActionCable
   module SubscriptionAdapter
     class Base

actioncable/lib/action_cable/subscription_adapter/channel_prefix.rb

+# frozen_string_literal: true
+
 module ActionCable
   module SubscriptionAdapter
     module ChannelPrefix # :nodoc:

actioncable/lib/action_cable/subscription_adapter/evented_redis.rb

+# frozen_string_literal: true
+
 require "thread"
 
 gem "em-hiredis", "~> 0.3.0"

actioncable/lib/action_cable/subscription_adapter/inline.rb

+# frozen_string_literal: true
+
 module ActionCable
   module SubscriptionAdapter
     class Inline < Base # :nodoc:

actioncable/lib/action_cable/subscription_adapter/postgresql.rb

+# frozen_string_literal: true
+
 gem "pg", "~> 0.18"
 require "pg"
 require "thread"

actioncable/lib/action_cable/subscription_adapter/redis.rb

+# frozen_string_literal: true
+
 require "thread"
 
 gem "redis", "~> 3.0"

actioncable/lib/action_cable/subscription_adapter/subscriber_map.rb

+# frozen_string_literal: true
+
 module ActionCable
   module SubscriptionAdapter
     class SubscriberMap

actioncable/lib/action_cable/version.rb

+# frozen_string_literal: true
+
 require_relative "gem_version"
 
 module ActionCable

actioncable/lib/rails/generators/channel/channel_generator.rb

+# frozen_string_literal: true
+
 module Rails
   module Generators
     class ChannelGenerator < NamedBase

actioncable/test/channel/base_test.rb

+# frozen_string_literal: true
+
 require "test_helper"
 require "stubs/test_connection"
 require "stubs/room"

actioncable/test/channel/broadcasting_test.rb

+# frozen_string_literal: true
+
 require "test_helper"
 require "stubs/test_connection"
 require "stubs/room"

actioncable/test/channel/naming_test.rb

+# frozen_string_literal: true
+
 require "test_helper"
 
 class ActionCable::Channel::NamingTest < ActiveSupport::TestCase

actioncable/test/channel/periodic_timers_test.rb

+# frozen_string_literal: true
+
 require "test_helper"
 require "stubs/test_connection"
 require "stubs/room"

actioncable/test/channel/rejection_test.rb

+# frozen_string_literal: true
+
 require "test_helper"
 require "stubs/test_connection"
 require "stubs/room"

actioncable/test/channel/stream_test.rb

+# frozen_string_literal: true
+
 require "test_helper"
 require "stubs/test_connection"
 require "stubs/room"

actioncable/test/client_test.rb

+# frozen_string_literal: true
+
 require "test_helper"
 require "concurrent"
 

actioncable/test/connection/authorization_test.rb

+# frozen_string_literal: true
+
 require "test_helper"
 require "stubs/test_server"
 

actioncable/test/connection/base_test.rb

+# frozen_string_literal: true
+
 require "test_helper"
 require "stubs/test_server"
 require "active_support/core_ext/object/json"

actioncable/test/connection/client_socket_test.rb

+# frozen_string_literal: true
+
 require "test_helper"
 require "stubs/test_server"
 

actioncable/test/connection/cross_site_forgery_test.rb

+# frozen_string_literal: true
+
 require "test_helper"
 require "stubs/test_server"
 

actioncable/test/connection/identifier_test.rb

+# frozen_string_literal: true
+
 require "test_helper"
 require "stubs/test_server"
 require "stubs/user"

actioncable/test/connection/multiple_identifiers_test.rb

+# frozen_string_literal: true
+
 require "test_helper"
 require "stubs/test_server"
 require "stubs/user"

actioncable/test/connection/stream_test.rb

+# frozen_string_literal: true
+
 require "test_helper"
 require "stubs/test_server"
 

actioncable/test/connection/string_identifier_test.rb

+# frozen_string_literal: true
+
 require "test_helper"
 require "stubs/test_server"
 

actioncable/test/connection/subscriptions_test.rb

+# frozen_string_literal: true
+
 require "test_helper"
 
 class ActionCable::Connection::SubscriptionsTest < ActionCable::TestCase

actioncable/test/server/base_test.rb

+# frozen_string_literal: true
+
 require "test_helper"
 require "stubs/test_server"
 require "active_support/core_ext/hash/indifferent_access"

actioncable/test/server/broadcasting_test.rb

+# frozen_string_literal: true
+
 require "test_helper"
 require "stubs/test_server"
 

actioncable/test/stubs/global_id.rb

+# frozen_string_literal: true
+
 class GlobalID
   attr_reader :uri
   delegate :to_param, :to_s, to: :uri

actioncable/test/stubs/room.rb

+# frozen_string_literal: true
+
 class Room
   attr_reader :id, :name
 

actioncable/test/stubs/test_adapter.rb

+# frozen_string_literal: true
+
 class SuccessAdapter < ActionCable::SubscriptionAdapter::Base
   def broadcast(channel, payload)
   end

actioncable/test/stubs/test_connection.rb

+# frozen_string_literal: true
+
 require "stubs/user"
 
 class TestConnection

actioncable/test/stubs/test_server.rb

+# frozen_string_literal: true
+
 require "ostruct"
 
 class TestServer

actioncable/test/stubs/user.rb

+# frozen_string_literal: true
+
 class User
   attr_reader :name
 

actioncable/test/subscription_adapter/async_test.rb

+# frozen_string_literal: true
+
 require "test_helper"
 require_relative "common"
 

actioncable/test/subscription_adapter/base_test.rb

+# frozen_string_literal: true
+
 require "test_helper"
 require "stubs/test_server"
 

actioncable/test/subscription_adapter/channel_prefix.rb

+# frozen_string_literal: true
+
 require "test_helper"
 
 class ActionCable::Server::WithIndependentConfig < ActionCable::Server::Base

actioncable/test/subscription_adapter/common.rb

+# frozen_string_literal: true
+
 require "test_helper"
 require "concurrent"
 

actioncable/test/subscription_adapter/evented_redis_test.rb

+# frozen_string_literal: true
+
 require "test_helper"
 require_relative "common"
 require_relative "channel_prefix"

actioncable/test/subscription_adapter/inline_test.rb

+# frozen_string_literal: true
+
 require "test_helper"
 require_relative "common"
 

actioncable/test/subscription_adapter/postgresql_test.rb

+# frozen_string_literal: true
+
 require "test_helper"
 require_relative "common"
 

actioncable/test/subscription_adapter/redis_test.rb

+# frozen_string_literal: true
+
 require "test_helper"
 require_relative "common"
 require_relative "channel_prefix"

actioncable/test/subscription_adapter/subscriber_map_test.rb

+# frozen_string_literal: true
+
 require "test_helper"
 
 class SubscriberMapTest < ActionCable::TestCase

actioncable/test/test_helper.rb

+# frozen_string_literal: true
+
 require "action_cable"
 require "active_support/testing/autorun"
 

actioncable/test/worker_test.rb

+# frozen_string_literal: true
+
 require "test_helper"
 
 class WorkerTest < ActiveSupport::TestCase