• E
    Drop load_database_yaml and fix test · 6b5df90f
    Eileen Uchitelle 提交于
    We originally did the whole `load_database_yaml` thing because this test
    wasn't cooperating and we needed to finish the namespaced rake tasks for
    multiple databases.
    
    However, it turns out that YAML can't eval ERB if you don't tell it it's
    ERB so you get Pysch parse errors if you're using multi-line ERB or
    ERB with conditionals. It's a hot mess.
    
    After trying a few things and thinking it over we decided that it wasn't
    worth bandaiding over, the test needed to be improved. The test was
    added in #31135 to test that the env is loaded in these tasks. But it
    was blowing up because we were trying to read a database name out of the
    configuration - however that's not the purpose of this change. We want
    to read environment files in the rake tasks, but not in the config
    file.
    
    In this PR we changed the test to test what the PR was actually fixing.
    We've also deleted the `load_database_yaml` because it caused more
    problems than it was worth. This should fix the issues described in
    https://github.com/rails/rails/pull/32274#issuecomment-384161057. We
    also had these problems at GitHub.
    Co-authored-by: Nalimi <aibrahim2k2@gmail.com>
    6b5df90f
database_tasks.rb 12.9 KB