- 29 8月, 2018 6 次提交
-
-
由 Eileen M. Uchitelle 提交于
Drop load_database_yaml and fix test
-
由 Eileen Uchitelle 提交于
We originally did the whole `load_database_yaml` thing because this test wasn't cooperating and we needed to finish the namespaced rake tasks for multiple databases. However, it turns out that YAML can't eval ERB if you don't tell it it's ERB so you get Pysch parse errors if you're using multi-line ERB or ERB with conditionals. It's a hot mess. After trying a few things and thinking it over we decided that it wasn't worth bandaiding over, the test needed to be improved. The test was added in #31135 to test that the env is loaded in these tasks. But it was blowing up because we were trying to read a database name out of the configuration - however that's not the purpose of this change. We want to read environment files in the rake tasks, but not in the config file. In this PR we changed the test to test what the PR was actually fixing. We've also deleted the `load_database_yaml` because it caused more problems than it was worth. This should fix the issues described in https://github.com/rails/rails/pull/32274#issuecomment-384161057. We also had these problems at GitHub. Co-authored-by: Nalimi <aibrahim2k2@gmail.com>
-
由 Matthew Draper 提交于
Finish converting whitelist and blacklist references
-
由 yuuji.yaginuma 提交于
In the system test template, enter a value based on label. However, since `label` method does not use `titleize` by default. If generate a value including underscore, cannot find a label and the test will fail. ``` $ ./bin/rails g scaffold user name:string phone_number:string $ ./bin/rails t test/system/users_test.rb E Error: UsersTest#test_creating_a_User: Capybara::ElementNotFound: Unable to find field "Phone Number" test/system/users_test.rb:18:in `block in <class:UsersTest>' ``` This removes unnecessary `titleize` so that the generated file will pass even if the attribute contains an underscore.
-
由 Rafael Mendonça França 提交于
-
由 James Brooks 提交于
-
- 28 8月, 2018 10 次提交
-
-
由 Ryuta Kamizono 提交于
Use the HTTPS protocol for links to Edges Guides [ci skip]
-
由 Ryuta Kamizono 提交于
Mutation tracker should be cleared before continuing around callbacks
-
由 tleneveu 提交于
Edges Guides is now available in HTTPS, it would be better to use the HTTPS protocol directly.
-
由 Rob Race 提交于
* Update the comments for TimeWithZone subtraction While reading the description/documentation comments for the subtraction method, it was confusing. While in practical usage, the returned values make sense. It seems as though the explanation could be a bit clearer. * Removed erroneous closing parenthesis [ci skip] [Rob Race + Ryuta Kamizono]
-
由 Ryuta Kamizono 提交于
Fix numericality validator to still use value before type cast except Active Record
-
由 Yuya Tanaka 提交于
`changes_applied` should be called before continuing around callback chain. Otherwise the mutation tracker returns old value for methods like `changed`? or `id_in_database` in around callbacks. Also methods depend on `id_in_database`, like `update_column`, are not working in `around_create` callbacks. ``` class Foo < ActiveRecord::Base around_create :around_create_callback def around_create_callback ... yield p id_in_database # => nil update_column(:generated_column, generate_value) # silently fails end ... end ```
-
由 speckins 提交于
* Call block to #redirect_to in controller context The documentation for ActionController::Redirecting states that a Proc argument "will be executed in the controller's context." However, unless #instance_eval is used (removed in 6b3ad0ca), that statement is false for procs defined outside of the controller instance. This commit restores the documented behavior. Fixes #33731. * Move test proc into a constant in another class Per @rafaelfranca's suggestion. [Steven Peckins + Rafael Mendonça França]
-
由 Nate Pinsky 提交于
* Add documentation for `:collation` option The table definition supports a `:collation` option for string and text columns, but this is not documented anywhere that I could find. I'm not sure if the "If not specified" part is accurate. From [this PR](https://github.com/rails/rails/commit/1515c4d98da3f730ef971fa5a13cad828bd9bef4), it looks like it passes `nil` and lets the database handle the collation, but I'm happy to change it if I misread the code. [ci skip] * FIX remove whitespace [Nate Pinsky + Rafael Mendonça França]
-
由 Rafael França 提交于
Update "Action View Form Helpers" guide
-
由 bogdanvlviv 提交于
-
- 27 8月, 2018 4 次提交
-
-
由 Kevin Deisz 提交于
-
由 Ryuta Kamizono 提交于
Follow up #33523 [ci skip]
-
由 bogdanvlviv 提交于
-
由 bogdanvlviv 提交于
This commit is the next work after #33523. Also, this commit removes mention about hidden `utf8` input. Since form helpers don't generate this input by default since #32125. Note that I also had created PR #31972 with improvements to "Action View Form Helpers" guide, but I'll rebase it after merging the current PR.
-
- 25 8月, 2018 12 次提交
-
-
由 Ryuta Kamizono 提交于
-
由 Matthew Draper 提交于
Clarify example of the test [ci skip]
-
由 黄松 提交于
ActionDispatch::TestProcess::FixtureFile
-
由 Ryuta Kamizono 提交于
Add test case to test enum in has_many
-
由 Rich 提交于
There is test in has_one to test enum, but there is no for has_many. [Rich Chen]
-
由 Ryuta Kamizono 提交于
Format respond_to method as code in doc [ci skip]
-
由 Rob Zolkos 提交于
This updates the `respond_to` method to be code formatted rather than plain text (as it refers to the method)
-
由 yuuji.yaginuma 提交于
Because there are tests that fail due to the influence of the `async_exec` deprecate message. https://travis-ci.org/rails/rails/jobs/420345370 Related to #33188.
-
由 Kevin Deisz 提交于
-
由 Kevin Deisz 提交于
-
由 Kevin Deisz 提交于
-
由 Kevin Deisz 提交于
-
- 24 8月, 2018 7 次提交
-
-
由 George Claghorn 提交于
Handle only specifically relevant Azure HTTPErrors ActiveStorage::Service::AzureStorageService#upload and #delete
-
由 Cameron Bothner 提交于
The Azure gem uses `Azure::Core::Http::HTTPError` for everything: checksum mismatch, missing object, network unavailable, and many more. (https://www.rubydoc.info/github/yaxia/azure-storage-ruby/Azure/Core/Http/HTTPError). Rescuing that class obscures all sorts of configuration errors. We should check the type of error in those rescue blocks, and reraise when needed.
-
由 George Claghorn 提交于
This reverts commit b204d167, reversing changes made to de6a200f.
-
由 George Claghorn 提交于
Handle only specifically relevant Azure HTTPErrors in ActiveStorage::Service::AzureStorageService
-
由 Cameron Bothner 提交于
The Azure gem uses `Azure::Core::Http::HTTPError` for everything: checksum mismatch, missing object, network unavailable, and many more. (https://www.rubydoc.info/github/yaxia/azure-storage-ruby/Azure/Core/Http/HTTPError). Rescuing that class obscures all sorts of configuration errors. We should check the type of error in those rescue blocks, and reraise when needed.
-
由 Aaron Patterson 提交于
[ci skip] change all instances of blacklist and whitelist to denylist…
-
由 Matthew Draper 提交于
Prevent deadlocks when waiting for connection from pool.
-
- 23 8月, 2018 1 次提交
-
-
由 Ryuta Kamizono 提交于
The purpose of fe9547b6 is to work type casting to value from database. But that was caused not to use the value before type cast even except Active Record. There we never guarantees that the value before type cast was going to the used in this validation, but we should not change the behavior unless there is some particular reason. To restore original behavior, still use the value before type cast if `came_from_user?` is undefined (i.e. except Active Record). Fixes #33651. Fixes #33686.
-