• V
    Abandon TOP support. · 41b92914
    Vladimir Kochnev 提交于
    Initially, `TOP` was introduced to support `limit` for MSSQL database.
    Unlike PostgreSQL/MySQL/SQLite, MSSQL does not have native `LIMIT`/`OFFSET` support.
    The commit adding `TOP` is 1a246f71.
    
    However, it figured out that `TOP` implementation was weak and it's not sufficient
    to also support `OFFSET`, then `TOP` was substituted with
    `ROW_NUMBER()` subquery in be48ed30.
    This is a well known trick in MSSQL -
    https://stackoverflow.com/questions/2135418/equivalent-of-limit-and-offset-for-sql-server.
    
    So now we don't need this `visit_Arel_Nodes_Top` at all.
    It does nothing useful but also adds an extra space after `SELECT` when `LIMIT` is being
    used for **any** database.
    41b92914
mssql.rb 3.2 KB