- 25 9月, 2018 4 次提交
-
-
由 Vladimir Kochnev 提交于
Initially, `TOP` was introduced to support `limit` for MSSQL database. Unlike PostgreSQL/MySQL/SQLite, MSSQL does not have native `LIMIT`/`OFFSET` support. The commit adding `TOP` is 1a246f71. However, it figured out that `TOP` implementation was weak and it's not sufficient to also support `OFFSET`, then `TOP` was substituted with `ROW_NUMBER()` subquery in be48ed30. This is a well known trick in MSSQL - https://stackoverflow.com/questions/2135418/equivalent-of-limit-and-offset-for-sql-server. So now we don't need this `visit_Arel_Nodes_Top` at all. It does nothing useful but also adds an extra space after `SELECT` when `LIMIT` is being used for **any** database.
-
由 Rafael França 提交于
Fix rails guides markdown.rb and renderer.rb to use custom header id
-
由 Rafael França 提交于
Improve phrasing of one sentence in the contributing guide
-
由 Ryuta Kamizono 提交于
Eagerly define attribute methods in production
-
- 24 9月, 2018 8 次提交
-
-
由 Pascal Lamouric 提交于
-
由 Ryuta Kamizono 提交于
update mini_magick to the latest version
-
由 utilum 提交于
v 4.9.2 avoids some warnings that show in our tests. Although Gemfile.lock currently specifies 4.8.0, the CI already runs 4.9.2 so 4.8.0 warnings do not show in our CI logs.
-
由 Eugene Kenny 提交于
The attribute methods for a model are currently defined lazily the first time that model is instantiated, even when `config.eager_load` is true. This means the first request to use each model incurs the cost, which usually involves a database round trip to fetch the schema definition. By defining the attribute methods for all models while the application is booting, we move that work out of any individual request. When using a forking web server, this also reduces the number of times the schema definition is queried by doing it once in the parent process instead of from each forked process during their first request.
-
由 Kasper Timm Hansen 提交于
Similar to Action View's and Action Controller's instrument helpers.
-
由 Ryuta Kamizono 提交于
-
由 Kasper Timm Hansen 提交于
Encode Content-Disposition filenames on send_data and send_file
-
由 Kasper Timm Hansen 提交于
Remove private def
-
- 23 9月, 2018 6 次提交
-
-
由 Sakshi Jain 提交于
-
由 George Claghorn 提交于
Added mandatory region and bucket
-
由 wagurano 提交于
-
由 Yuji Yaginuma 提交于
Enable `Performance/UnfreezeString` cop
-
由 Asaf Bartov 提交于
The 'setup' section was misleadingly leaving out :bucket and :region in the sample, but servers don't start without them.
-
由 yuuji.yaginuma 提交于
In Ruby 2.3 or later, `String#+@` is available and `+@` is faster than `dup`. ```ruby # frozen_string_literal: true require "bundler/inline" gemfile(true) do source "https://rubygems.org" gem "benchmark-ips" end Benchmark.ips do |x| x.report('+@') { +"" } x.report('dup') { "".dup } x.compare! end ``` ``` $ ruby -v benchmark.rb ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-linux] Warming up -------------------------------------- +@ 282.289k i/100ms dup 187.638k i/100ms Calculating ------------------------------------- +@ 6.775M (± 3.6%) i/s - 33.875M in 5.006253s dup 3.320M (± 2.2%) i/s - 16.700M in 5.032125s Comparison: +@: 6775299.3 i/s dup: 3320400.7 i/s - 2.04x slower ```
-
- 22 9月, 2018 5 次提交
-
-
由 Rafael Mendonça França 提交于
Before this change this test was passing even if we revert #31135. The reason for that is that `app 'development'` will load the environment in the test process and it is happening before db_create_and_drop is called. This was not asserting that the environment was loaded in the db:create task itself. To test it we enhance the db:create task with a block that writes to a tmp file the value of the config. If the environment is loaded before that task enhancement runs the content of the file will have "true" insteand of "false".
-
由 yuuji.yaginuma 提交于
-
由 Rafael França 提交于
Let escape_javascript handle conversion to string
-
由 Rafael Mendonça França 提交于
-
由 Andrew Vit 提交于
This brings `escape_javascript` in line with the behavior of `json_escape` and allows other value types to be output without needing explicit casting in the view template. Example: <%= javascript_tag do %> var locale = '<%== j I18n.locale %>'; // locale is a symbol <% end %>
-
- 21 9月, 2018 17 次提交
-
-
由 Richard Schneeman 提交于
[close #33907] Error when using "recyclable" cache keys with a store that does not support it
-
由 Ryuta Kamizono 提交于
Replace line items with chapters [ci skip]
-
由 Ian Fleeton 提交于
Line items are a holdover from when orders were used in the examples instead of books.
-
由 Ryuta Kamizono 提交于
Add missing test case for `redirect_to` when request includes a port.
-
由 Richard Schneeman 提交于
[ci skip] document collection_caching.rb
-
由 schneems 提交于
- Moving the `supports_cache_versioning?` check to a class method. - Shorten the method doc. - Expand on the error message.
-
由 Guo Xiang Tan 提交于
-
由 Yuji Yaginuma 提交于
Fix missing curly brace in documentation
-
由 David Celis 提交于
This example was just missing a closing curly brace to complete the closure
😄 -
由 Rafael França 提交于
Ignore psqlrc files when executing psql commands
-
由 schneems 提交于
If you are using the "in cache versioning" also known as "recyclable cache keys" the cache store must be aware of this scheme, otherwise you will generate cache entries that never invalidate. This PR adds a check to the initialization process to ensure that if recyclable cache keys are being used via ``` config.active_record.cache_versioning = true ``` Then the cache store needs to show that it supports this versioning scheme. Cache stores can let Rails know that they support this scheme by adding a method `supports_in_cache_versioning?` and returning true.
-
由 George Claghorn 提交于
Correct spelling in "Contributing to Ruby on Rails" guide [ci skip]
-
由 bogdanvlviv 提交于
ambigity -> ambiguity Related to #33891
-
由 Rafael França 提交于
Make sure `assert_enqueued_with()` & `assert_performed_with()` work reliably with hash arguments
-
由 Rafael França 提交于
Contributing to Ruby on Rails Guide: standardize git remote names [ci skip].
-
由 Ryuta Kamizono 提交于
Since #33875, Rails dropped supporting MySQL 5.1 which does not support utf8mb4. We no longer need to use legacy utf8 (utf8mb3) conservatively.
-
由 Sharang Dashputre 提交于
The test helpers now treat `{ a: 1, b: 2 }` and `{ b: 2, a: 1 }` as equals
-