routing_test.rb 67.2 KB
Newer Older
1
# encoding: utf-8
2 3
require 'abstract_unit'
require 'controller/fake_controllers'
4
require 'active_support/dependencies'
5

J
Jeremy Kemper 已提交
6 7 8 9 10 11
class MilestonesController < ActionController::Base
  def index() head :ok end
  alias_method :show, :index
  def rescue_action(e) raise e end
end

12
ROUTING = ActionController::Routing
13

14 15
class ROUTING::RouteBuilder
  attr_reader :warn_output
16

17 18
  def warn(msg)
    (@warn_output ||= []) << msg
19
  end
20
end
21

22
# See RFC 3986, section 3.3 for allowed path characters.
23 24 25 26
class UriReservedCharactersRoutingTest < Test::Unit::TestCase
  def setup
    @set = ActionController::Routing::RouteSet.new
    @set.draw do |map|
27
      map.connect ':controller/:action/:variable/*additional'
28
    end
29

30
    safe, unsafe = %w(: @ & = + $ , ;), %w(^ / ? # [ ])
31 32
    hex = unsafe.map { |char| '%' + char.unpack('H2').first.upcase }

33 34
    @segment = "#{safe.join}#{unsafe.join}".freeze
    @escaped = "#{safe.join}#{hex.join}".freeze
35
  end
36 37

  def test_route_generation_escapes_unsafe_path_characters
38 39 40
    @set.generate(:controller => "content", :action => "act#{@segment}ion", :variable => "variable", :additional => "foo")
    assert_equal "/content/act#{@escaped}ion/var#{@escaped}iable/add#{@escaped}itional-1/add#{@escaped}itional-2",
      @set.generate(:controller => "content",
41
                    :action => "act#{@segment}ion",
42 43
                    :variable => "var#{@segment}iable",
                    :additional => ["add#{@segment}itional-1", "add#{@segment}itional-2"])
44
  end
45 46

  def test_route_recognition_unescapes_path_components
47
    options = { :controller => "content",
48
                :action => "act#{@segment}ion",
49 50
                :variable => "var#{@segment}iable",
                :additional => ["add#{@segment}itional-1", "add#{@segment}itional-2"] }
51
    assert_equal options, @set.recognize_path("/content/act#{@escaped}ion/var#{@escaped}iable/add#{@escaped}itional-1/add#{@escaped}itional-2")
52
  end
53 54

  def test_route_generation_allows_passing_non_string_values_to_generated_helper
55
    assert_equal "/content/action/variable/1/2", @set.generate(:controller => "content",
56 57 58 59
                                                                  :action => "action",
                                                                  :variable => "variable",
                                                                  :additional => [1, 2])
  end
60 61
end

62 63 64 65 66 67
class RoutingTest < Test::Unit::TestCase
  def test_normalize_unix_paths
    load_paths = %w(. config/../app/controllers config/../app//helpers script/../config/../vendor/rails/actionpack/lib vendor/rails/railties/builtin/rails_info app/models lib script/../config/../foo/bar/../../app/models .foo/../.bar foo.bar/../config)
    paths = ActionController::Routing.normalize_paths(load_paths)
    assert_equal %w(vendor/rails/railties/builtin/rails_info vendor/rails/actionpack/lib app/controllers app/helpers app/models config .bar lib .), paths
  end
68

69 70 71 72
  def test_normalize_windows_paths
    load_paths = %w(. config\\..\\app\\controllers config\\..\\app\\\\helpers script\\..\\config\\..\\vendor\\rails\\actionpack\\lib vendor\\rails\\railties\\builtin\\rails_info app\\models lib script\\..\\config\\..\\foo\\bar\\..\\..\\app\\models .foo\\..\\.bar foo.bar\\..\\config)
    paths = ActionController::Routing.normalize_paths(load_paths)
    assert_equal %w(vendor\\rails\\railties\\builtin\\rails_info vendor\\rails\\actionpack\\lib app\\controllers app\\helpers app\\models config .bar lib .), paths
73 74
  end

75 76
  def test_routing_helper_module
    assert_kind_of Module, ActionController::Routing::Helpers
77

78 79 80 81 82
    h = ActionController::Routing::Helpers
    c = Class.new
    assert ! c.ancestors.include?(h)
    ActionController::Routing::Routes.install_helpers c
    assert c.ancestors.include?(h)
83
  end
84
end
85

86 87
class MockController
  attr_accessor :routes
88

89 90 91
  def initialize(routes)
    self.routes = routes
  end
92

93 94
  def url_for(options)
    only_path = options.delete(:only_path)
95

96 97
    port        = options.delete(:port) || 80
    port_string = port == 80 ? '' : ":#{port}"
98

99 100 101
    protocol = options.delete(:protocol) || "http"
    host     = options.delete(:host) || "test.host"
    anchor   = "##{options.delete(:anchor)}" if options.key?(:anchor)
102

103
    path = routes.generate(options)
104

105 106
    only_path ? "#{path}#{anchor}" : "#{protocol}://#{host}#{port_string}#{path}#{anchor}"
  end
107

108 109
  def request
    @request ||= ActionController::TestRequest.new
110
  end
111
end
112

113 114
class LegacyRouteSetTests < Test::Unit::TestCase
  attr_reader :rs
115

116 117 118 119 120 121 122 123
  def setup
    # These tests assume optimisation is on, so re-enable it.
    ActionController::Base.optimise_named_routes = true

    @rs = ::ActionController::Routing::RouteSet.new

    ActionController::Routing.use_controllers! %w(content admin/user admin/news_feed)
  end
J
Joshua Peek 已提交
124

125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180
  def teardown
    @rs.clear!
  end

  def test_default_setup
    @rs.draw {|m| m.connect ':controller/:action/:id' }
    assert_equal({:controller => "content", :action => 'index'}, rs.recognize_path("/content"))
    assert_equal({:controller => "content", :action => 'list'}, rs.recognize_path("/content/list"))
    assert_equal({:controller => "content", :action => 'show', :id => '10'}, rs.recognize_path("/content/show/10"))

    assert_equal({:controller => "admin/user", :action => 'show', :id => '10'}, rs.recognize_path("/admin/user/show/10"))

    assert_equal '/admin/user/show/10', rs.generate(:controller => 'admin/user', :action => 'show', :id => 10)

    assert_equal '/admin/user/show', rs.generate({:action => 'show'}, {:controller => 'admin/user', :action => 'list', :id => '10'})
    assert_equal '/admin/user/list/10', rs.generate({}, {:controller => 'admin/user', :action => 'list', :id => '10'})

    assert_equal '/admin/stuff', rs.generate({:controller => 'stuff'}, {:controller => 'admin/user', :action => 'list', :id => '10'})
    assert_equal '/stuff', rs.generate({:controller => '/stuff'}, {:controller => 'admin/user', :action => 'list', :id => '10'})
  end

  def test_ignores_leading_slash
    @rs.clear!
    @rs.draw {|m| m.connect '/:controller/:action/:id'}
    test_default_setup
  end

  def test_time_recognition
    # We create many routes to make situation more realistic
    @rs = ::ActionController::Routing::RouteSet.new
    @rs.draw { |map|
      map.frontpage '', :controller => 'search', :action => 'new'
      map.resources :videos do |video|
        video.resources :comments
        video.resource  :file,      :controller => 'video_file'
        video.resource  :share,     :controller => 'video_shares'
        video.resource  :abuse,     :controller => 'video_abuses'
      end
      map.resources :abuses, :controller => 'video_abuses'
      map.resources :video_uploads
      map.resources :video_visits

      map.resources :users do |user|
        user.resource  :settings
        user.resources :videos
      end
      map.resources :channels do |channel|
        channel.resources :videos, :controller => 'channel_videos'
      end
      map.resource  :session
      map.resource  :lost_password
      map.search    'search', :controller => 'search'
      map.resources :pages
      map.connect ':controller/:action/:id'
    }
  end
181

182 183 184 185
  def test_route_with_colon_first
    rs.draw do |map|
      map.connect '/:controller/:action/:id', :action => 'index', :id => nil
      map.connect ':url', :controller => 'tiny_url', :action => 'translate'
186
    end
187 188 189 190 191 192
  end

  def test_route_with_regexp_for_controller
    rs.draw do |map|
      map.connect ':controller/:admintoken/:action/:id', :controller => /admin\/.+/
      map.connect ':controller/:action/:id'
193
    end
194 195 196 197 198 199
    assert_equal({:controller => "admin/user", :admintoken => "foo", :action => "index"},
        rs.recognize_path("/admin/user/foo"))
    assert_equal({:controller => "content", :action => "foo"}, rs.recognize_path("/content/foo"))
    assert_equal '/admin/user/foo', rs.generate(:controller => "admin/user", :admintoken => "foo", :action => "index")
    assert_equal '/content/foo', rs.generate(:controller => "content", :action => "foo")
  end
200

201 202 203 204 205 206
  def test_route_with_regexp_and_captures_for_controller
    rs.draw do |map|
      map.connect ':controller/:action/:id', :controller => /admin\/(accounts|users)/
    end
    assert_equal({:controller => "admin/accounts", :action => "index"}, rs.recognize_path("/admin/accounts"))
    assert_equal({:controller => "admin/users", :action => "index"}, rs.recognize_path("/admin/users"))
207
    assert_raise(ActionController::RoutingError) { rs.recognize_path("/admin/products") }
208 209
  end

210 211 212 213 214 215 216 217 218 219 220 221 222 223
  def test_route_with_regexp_and_dot
    rs.draw do |map|
      map.connect ':controller/:action/:file',
                        :controller => /admin|user/,
                        :action => /upload|download/,
                        :defaults => {:file => nil},
                        :requirements => {:file => %r{[^/]+(\.[^/]+)?}}
    end
    # Without a file extension
    assert_equal '/user/download/file',
      rs.generate(:controller => "user", :action => "download", :file => "file")
    assert_equal(
      {:controller => "user", :action => "download", :file => "file"},
      rs.recognize_path("/user/download/file"))
224

225 226 227 228 229 230 231 232
    # Now, let's try a file with an extension, really a dot (.)
    assert_equal '/user/download/file.jpg',
      rs.generate(
        :controller => "user", :action => "download", :file => "file.jpg")
    assert_equal(
      {:controller => "user", :action => "download", :file => "file.jpg"},
      rs.recognize_path("/user/download/file.jpg"))
  end
233

234
  def test_basic_named_route
235 236 237
    rs.draw do |map|
      map.home '', :controller => 'content', :action => 'list'
    end
238 239 240 241
    x = setup_for_named_route
    assert_equal("http://test.host/",
                 x.send(:home_url))
  end
242

243
  def test_named_route_with_option
244 245 246
    rs.draw do |map|
      map.page 'page/:title', :controller => 'content', :action => 'show_page'
    end
247 248 249 250
    x = setup_for_named_route
    assert_equal("http://test.host/page/new%20stuff",
                 x.send(:page_url, :title => 'new stuff'))
  end
251

252
  def test_named_route_with_default
253 254 255
    rs.draw do |map|
      map.page 'page/:title', :controller => 'content', :action => 'show_page', :title => 'AboutPage'
    end
256 257 258
    x = setup_for_named_route
    assert_equal("http://test.host/page/AboutRails",
                 x.send(:page_url, :title => "AboutRails"))
259

260
  end
261

262
  def test_named_route_with_name_prefix
263 264 265
    rs.draw do |map|
      map.page 'page', :controller => 'content', :action => 'show_page', :name_prefix => 'my_'
    end
266 267 268 269
    x = setup_for_named_route
    assert_equal("http://test.host/page",
                 x.send(:my_page_url))
  end
J
Joshua Peek 已提交
270

271
  def test_named_route_with_path_prefix
272 273 274
    rs.draw do |map|
      map.page 'page', :controller => 'content', :action => 'show_page', :path_prefix => 'my'
    end
275 276 277 278
    x = setup_for_named_route
    assert_equal("http://test.host/my/page",
                 x.send(:page_url))
  end
279

280
  def test_named_route_with_blank_path_prefix
281 282 283
    rs.draw do |map|
      map.page 'page', :controller => 'content', :action => 'show_page', :path_prefix => ''
    end
284 285 286 287 288
    x = setup_for_named_route
    assert_equal("http://test.host/page",
                 x.send(:page_url))
  end

289
  def test_named_route_with_nested_controller
290 291 292
    rs.draw do |map|
      map.users 'admin/user', :controller => 'admin/user', :action => 'index'
    end
293 294 295 296
    x = setup_for_named_route
    assert_equal("http://test.host/admin/user",
                 x.send(:users_url))
  end
297

298
  def test_optimised_named_route_with_host
299 300 301
    rs.draw do |map|
      map.pages 'pages', :controller => 'content', :action => 'show_page', :host => 'foo.com'
    end
302 303 304 305
    x = setup_for_named_route
    x.expects(:url_for).with(:host => 'foo.com', :only_path => false, :controller => 'content', :action => 'show_page', :use_route => :pages).once
    x.send(:pages_url)
  end
306

307 308 309 310 311
  def setup_for_named_route
    klass = Class.new(MockController)
    rs.install_helpers(klass)
    klass.new(rs)
  end
312

313 314 315
  def test_named_route_without_hash
    rs.draw do |map|
      map.normal ':controller/:action/:id'
316
    end
317
  end
318

319 320 321
  def test_named_route_root
    rs.draw do |map|
      map.root :controller => "hello"
322
    end
323 324 325 326
    x = setup_for_named_route
    assert_equal("http://test.host/", x.send(:root_url))
    assert_equal("/", x.send(:root_path))
  end
327

328 329 330 331 332
  def test_named_route_with_regexps
    rs.draw do |map|
      map.article 'page/:year/:month/:day/:title', :controller => 'page', :action => 'show',
        :year => /\d+/, :month => /\d+/, :day => /\d+/
      map.connect ':controller/:action/:id'
333
    end
334 335 336 337 338 339 340 341 342 343
    x = setup_for_named_route
    # assert_equal(
    #   {:controller => 'page', :action => 'show', :title => 'hi', :use_route => :article, :only_path => false},
    #   x.send(:article_url, :title => 'hi')
    # )
    assert_equal(
      "http://test.host/page/2005/6/10/hi",
      x.send(:article_url, :title => 'hi', :day => 10, :year => 2005, :month => 6)
    )
  end
344

345 346
  def test_changing_controller
    @rs.draw {|m| m.connect ':controller/:action/:id' }
347

348 349 350 351 352
    assert_equal '/admin/stuff/show/10', rs.generate(
      {:controller => 'stuff', :action => 'show', :id => 10},
      {:controller => 'admin/user', :action => 'index'}
    )
  end
353

354 355 356 357
  def test_paths_escaped
    rs.draw do |map|
      map.path 'file/*path', :controller => 'content', :action => 'show_file'
      map.connect ':controller/:action/:id'
358
    end
359

360 361 362 363
    # No + to space in URI escaping, only for query params.
    results = rs.recognize_path "/file/hello+world/how+are+you%3F"
    assert results, "Recognition should have succeeded"
    assert_equal ['hello+world', 'how+are+you?'], results[:path]
364

365 366 367 368
    # Use %20 for space instead.
    results = rs.recognize_path "/file/hello%20world/how%20are%20you%3F"
    assert results, "Recognition should have succeeded"
    assert_equal ['hello world', 'how are you?'], results[:path]
369

370 371 372 373
    results = rs.recognize_path "/file"
    assert results, "Recognition should have succeeded"
    assert_equal [], results[:path]
  end
374

375
  def test_paths_slashes_unescaped_with_ordered_parameters
376 377 378
    rs.draw do |map|
      map.path '/file/*path', :controller => 'content'
    end
379

380 381 382 383
    # No / to %2F in URI, only for query params.
    x = setup_for_named_route
    assert_equal("/file/hello/world", x.send(:path_path, 'hello/world'))
  end
384

385 386 387
  def test_non_controllers_cannot_be_matched
    rs.draw do |map|
      map.connect ':controller/:action/:id'
388
    end
389
    assert_raise(ActionController::RoutingError) { rs.recognize_path("/not_a/show/10") }
390
  end
391

392
  def test_paths_do_not_accept_defaults
393
    assert_raise(ActionController::RoutingError) do
394
      rs.draw do |map|
395 396
        map.path 'file/*path', :controller => 'content', :action => 'show_file', :path => %w(fake default)
        map.connect ':controller/:action/:id'
397 398 399
      end
    end

400 401 402
    rs.draw do |map|
      map.path 'file/*path', :controller => 'content', :action => 'show_file', :path => []
      map.connect ':controller/:action/:id'
403
    end
404
  end
405

406 407 408
  def test_should_list_options_diff_when_routing_requirements_dont_match
    rs.draw do |map|
      map.post 'post/:id', :controller=> 'post', :action=> 'show', :requirements => {:id => /\d+/}
409
    end
410
    assert_raise(ActionController::RoutingError) { rs.generate(:controller => 'post', :action => 'show', :bad_param => "foo", :use_route => "post") }
411 412 413 414 415 416
  end

  def test_dynamic_path_allowed
    rs.draw do |map|
      map.connect '*path', :controller => 'content', :action => 'show_file'
    end
417

418 419
    assert_equal '/pages/boo', rs.generate(:controller => 'content', :action => 'show_file', :path => %w(pages boo))
  end
420

421 422 423
  def test_dynamic_recall_paths_allowed
    rs.draw do |map|
      map.connect '*path', :controller => 'content', :action => 'show_file'
424 425
    end

426
    assert_equal '/pages/boo', rs.generate({}, :controller => 'content', :action => 'show_file', :path => %w(pages boo))
427
  end
428

429 430 431 432
  def test_backwards
    rs.draw do |map|
      map.connect 'page/:id/:action', :controller => 'pages', :action => 'show'
      map.connect ':controller/:action/:id'
433 434
    end

435 436 437 438 439 440 441 442 443
    assert_equal '/page/20', rs.generate({:id => 20}, {:controller => 'pages', :action => 'show'})
    assert_equal '/page/20', rs.generate(:controller => 'pages', :id => 20, :action => 'show')
    assert_equal '/pages/boo', rs.generate(:controller => 'pages', :action => 'boo')
  end

  def test_route_with_fixnum_default
    rs.draw do |map|
      map.connect 'page/:id', :controller => 'content', :action => 'show_page', :id => 1
      map.connect ':controller/:action/:id'
444 445
    end

446 447 448 449
    assert_equal '/page', rs.generate(:controller => 'content', :action => 'show_page')
    assert_equal '/page', rs.generate(:controller => 'content', :action => 'show_page', :id => 1)
    assert_equal '/page', rs.generate(:controller => 'content', :action => 'show_page', :id => '1')
    assert_equal '/page/10', rs.generate(:controller => 'content', :action => 'show_page', :id => 10)
450

451 452 453 454 455 456 457 458 459 460
    assert_equal({:controller => "content", :action => 'show_page', :id => '1'}, rs.recognize_path("/page"))
    assert_equal({:controller => "content", :action => 'show_page', :id => '1'}, rs.recognize_path("/page/1"))
    assert_equal({:controller => "content", :action => 'show_page', :id => '10'}, rs.recognize_path("/page/10"))
  end

  # For newer revision
  def test_route_with_text_default
    rs.draw do |map|
      map.connect 'page/:id', :controller => 'content', :action => 'show_page', :id => 1
      map.connect ':controller/:action/:id'
461 462
    end

463 464
    assert_equal '/page/foo', rs.generate(:controller => 'content', :action => 'show_page', :id => 'foo')
    assert_equal({:controller => "content", :action => 'show_page', :id => 'foo'}, rs.recognize_path("/page/foo"))
465

466 467
    token = "\321\202\320\265\320\272\321\201\321\202" # 'text' in russian
    escaped_token = CGI::escape(token)
468

469 470 471
    assert_equal '/page/' + escaped_token, rs.generate(:controller => 'content', :action => 'show_page', :id => token)
    assert_equal({:controller => "content", :action => 'show_page', :id => token}, rs.recognize_path("/page/#{escaped_token}"))
  end
472

473 474 475 476
  def test_action_expiry
    @rs.draw {|m| m.connect ':controller/:action/:id' }
    assert_equal '/content', rs.generate({:controller => 'content'}, {:controller => 'content', :action => 'show'})
  end
477

478 479 480
  def test_requirement_should_prevent_optional_id
    rs.draw do |map|
      map.post 'post/:id', :controller=> 'post', :action=> 'show', :requirements => {:id => /\d+/}
481 482
    end

483
    assert_equal '/post/10', rs.generate(:controller => 'post', :action => 'show', :id => 10)
484

485
    assert_raise ActionController::RoutingError do
486
      rs.generate(:controller => 'post', :action => 'show')
487
    end
488
  end
489

490 491 492 493 494 495 496 497
  def test_both_requirement_and_optional
    rs.draw do |map|
      map.blog('test/:year', :controller => 'post', :action => 'show',
        :defaults => { :year => nil },
        :requirements => { :year => /\d{4}/ }
      )
      map.connect ':controller/:action/:id'
    end
498

499 500 501 502 503 504 505
    assert_equal '/test', rs.generate(:controller => 'post', :action => 'show')
    assert_equal '/test', rs.generate(:controller => 'post', :action => 'show', :year => nil)

    x = setup_for_named_route
    assert_equal("http://test.host/test",
                 x.send(:blog_url))
  end
506

507 508 509 510
  def test_set_to_nil_forgets
    rs.draw do |map|
      map.connect 'pages/:year/:month/:day', :controller => 'content', :action => 'list_pages', :month => nil, :day => nil
      map.connect ':controller/:action/:id'
511 512
    end

513 514 515 516 517 518
    assert_equal '/pages/2005',
      rs.generate(:controller => 'content', :action => 'list_pages', :year => 2005)
    assert_equal '/pages/2005/6',
      rs.generate(:controller => 'content', :action => 'list_pages', :year => 2005, :month => 6)
    assert_equal '/pages/2005/6/12',
      rs.generate(:controller => 'content', :action => 'list_pages', :year => 2005, :month => 6, :day => 12)
519

520 521
    assert_equal '/pages/2005/6/4',
      rs.generate({:day => 4}, {:controller => 'content', :action => 'list_pages', :year => '2005', :month => '6', :day => '12'})
522

523 524
    assert_equal '/pages/2005/6',
      rs.generate({:day => nil}, {:controller => 'content', :action => 'list_pages', :year => '2005', :month => '6', :day => '12'})
525

526 527 528
    assert_equal '/pages/2005',
      rs.generate({:day => nil, :month => nil}, {:controller => 'content', :action => 'list_pages', :year => '2005', :month => '6', :day => '12'})
  end
529

530 531 532 533
  def test_url_with_no_action_specified
    rs.draw do |map|
      map.connect '', :controller => 'content'
      map.connect ':controller/:action/:id'
534 535
    end

536 537 538
    assert_equal '/', rs.generate(:controller => 'content', :action => 'index')
    assert_equal '/', rs.generate(:controller => 'content')
  end
539

540 541 542 543
  def test_named_url_with_no_action_specified
    rs.draw do |map|
      map.home '', :controller => 'content'
      map.connect ':controller/:action/:id'
544 545
    end

546 547
    assert_equal '/', rs.generate(:controller => 'content', :action => 'index')
    assert_equal '/', rs.generate(:controller => 'content')
548

549 550 551 552
    x = setup_for_named_route
    assert_equal("http://test.host/",
                 x.send(:home_url))
  end
553

554 555
  def test_url_generated_when_forgetting_action
    [{:controller => 'content', :action => 'index'}, {:controller => 'content'}].each do |hash|
556
      rs.draw do |map|
557
        map.home '', hash
558 559
        map.connect ':controller/:action/:id'
      end
560 561 562 563 564
      assert_equal '/', rs.generate({:action => nil}, {:controller => 'content', :action => 'hello'})
      assert_equal '/', rs.generate({:controller => 'content'})
      assert_equal '/content/hi', rs.generate({:controller => 'content', :action => 'hi'})
    end
  end
565

566 567 568 569
  def test_named_route_method
    rs.draw do |map|
      map.categories 'categories', :controller => 'content', :action => 'categories'
      map.connect ':controller/:action/:id'
570 571
    end

572 573 574 575 576 577 578 579
    assert_equal '/categories', rs.generate(:controller => 'content', :action => 'categories')
    assert_equal '/content/hi', rs.generate({:controller => 'content', :action => 'hi'})
  end

  def test_named_routes_array
    test_named_route_method
    assert_equal [:categories], rs.named_routes.names
  end
580

581 582 583 584 585 586 587 588
  def test_nil_defaults
    rs.draw do |map|
      map.connect 'journal',
        :controller => 'content',
        :action => 'list_journal',
        :date => nil, :user_id => nil
      map.connect ':controller/:action/:id'
    end
589

590 591
    assert_equal '/journal', rs.generate(:controller => 'content', :action => 'list_journal', :date => nil, :user_id => nil)
  end
592

593 594 595 596
  def setup_request_method_routes_for(method)
    @request = ActionController::TestRequest.new
    @request.env["REQUEST_METHOD"] = method
    @request.request_uri = "/match"
597

598 599 600 601 602
    rs.draw do |r|
      r.connect '/match', :controller => 'books', :action => 'get', :conditions => { :method => :get }
      r.connect '/match', :controller => 'books', :action => 'post', :conditions => { :method => :post }
      r.connect '/match', :controller => 'books', :action => 'put', :conditions => { :method => :put }
      r.connect '/match', :controller => 'books', :action => 'delete', :conditions => { :method => :delete }
603
    end
604
  end
605

606 607
  %w(GET POST PUT DELETE).each do |request_method|
    define_method("test_request_method_recognized_with_#{request_method}") do
608 609 610
      setup_request_method_routes_for(request_method)
      assert_nothing_raised { rs.recognize(@request) }
      assert_equal request_method.downcase, @request.path_parameters[:action]
611 612
    end
  end
613

614 615 616 617
  def test_recognize_array_of_methods
    rs.draw do |r|
      r.connect '/match', :controller => 'books', :action => 'get_or_post', :conditions => { :method => [:get, :post] }
      r.connect '/match', :controller => 'books', :action => 'not_get_or_post'
618 619
    end

620 621 622 623 624
    @request = ActionController::TestRequest.new
    @request.env["REQUEST_METHOD"] = 'POST'
    @request.request_uri = "/match"
    assert_nothing_raised { rs.recognize(@request) }
    assert_equal 'get_or_post', @request.path_parameters[:action]
625

626 627 628 629 630 631 632
    # have to recreate or else the RouteSet uses a cached version:
    @request = ActionController::TestRequest.new
    @request.env["REQUEST_METHOD"] = 'PUT'
    @request.request_uri = "/match"
    assert_nothing_raised { rs.recognize(@request) }
    assert_equal 'not_get_or_post', @request.path_parameters[:action]
  end
633

634 635 636 637 638 639
  def test_subpath_recognized
    rs.draw do |r|
      r.connect '/books/:id/edit', :controller => 'subpath_books', :action => 'edit'
      r.connect '/items/:id/:action', :controller => 'subpath_books'
      r.connect '/posts/new/:action', :controller => 'subpath_books'
      r.connect '/posts/:id', :controller => 'subpath_books', :action => "show"
640 641
    end

642 643 644
    hash = rs.recognize_path "/books/17/edit"
    assert_not_nil hash
    assert_equal %w(subpath_books 17 edit), [hash[:controller], hash[:id], hash[:action]]
645

646 647 648 649 650 651 652 653 654 655 656 657
    hash = rs.recognize_path "/items/3/complete"
    assert_not_nil hash
    assert_equal %w(subpath_books 3 complete), [hash[:controller], hash[:id], hash[:action]]

    hash = rs.recognize_path "/posts/new/preview"
    assert_not_nil hash
    assert_equal %w(subpath_books preview), [hash[:controller], hash[:action]]

    hash = rs.recognize_path "/posts/7"
    assert_not_nil hash
    assert_equal %w(subpath_books show 7), [hash[:controller], hash[:action], hash[:id]]
  end
658

659 660 661 662 663
  def test_subpath_generated
    rs.draw do |r|
      r.connect '/books/:id/edit', :controller => 'subpath_books', :action => 'edit'
      r.connect '/items/:id/:action', :controller => 'subpath_books'
      r.connect '/posts/new/:action', :controller => 'subpath_books'
664 665
    end

666 667 668 669
    assert_equal "/books/7/edit", rs.generate(:controller => "subpath_books", :id => 7, :action => "edit")
    assert_equal "/items/15/complete", rs.generate(:controller => "subpath_books", :id => 15, :action => "complete")
    assert_equal "/posts/new/preview", rs.generate(:controller => "subpath_books", :action => "preview")
  end
670

671 672 673
  def test_failed_requirements_raises_exception_with_violated_requirements
    rs.draw do |r|
      r.foo_with_requirement 'foos/:id', :controller=>'foos', :requirements=>{:id=>/\d+/}
674 675
    end

676
    x = setup_for_named_route
677
    assert_raise(ActionController::RoutingError) do
678 679 680
      x.send(:foo_with_requirement_url, "I am Against the requirements")
    end
  end
681

682 683 684 685 686 687 688 689 690
  def test_routes_changed_correctly_after_clear
    ActionController::Base.optimise_named_routes = true
    rs = ::ActionController::Routing::RouteSet.new
    rs.draw do |r|
      r.connect 'ca', :controller => 'ca', :action => "aa"
      r.connect 'cb', :controller => 'cb', :action => "ab"
      r.connect 'cc', :controller => 'cc', :action => "ac"
      r.connect ':controller/:action/:id'
      r.connect ':controller/:action/:id.:format'
691 692
    end

693
    hash = rs.recognize_path "/cc"
694

695 696
    assert_not_nil hash
    assert_equal %w(cc ac), [hash[:controller], hash[:action]]
697

698 699 700 701 702
    rs.draw do |r|
      r.connect 'cb', :controller => 'cb', :action => "ab"
      r.connect 'cc', :controller => 'cc', :action => "ac"
      r.connect ':controller/:action/:id'
      r.connect ':controller/:action/:id.:format'
703 704
    end

705
    hash = rs.recognize_path "/cc"
706

707 708
    assert_not_nil hash
    assert_equal %w(cc ac), [hash[:controller], hash[:action]]
709

710 711
  end
end
712

713
class RouteSetTest < ActiveSupport::TestCase
714 715 716
  def set
    @set ||= ROUTING::RouteSet.new
  end
717

718 719 720
  def request
    @request ||= ActionController::TestRequest.new
  end
721

722 723
  def default_route_set
    @default_route_set ||= begin
J
Joshua Peek 已提交
724 725 726
      set = ROUTING::RouteSet.new
      set.draw do |map|
        map.connect '/:controller/:action/:id/'
727 728 729 730 731
      end
      set
    end
  end

732 733 734 735
  def test_generate_extras
    set.draw { |m| m.connect ':controller/:action/:id' }
    path, extras = set.generate_extras(:controller => "foo", :action => "bar", :id => 15, :this => "hello", :that => "world")
    assert_equal "/foo/bar/15", path
736
    assert_equal %w(that this), extras.map { |e| e.to_s }.sort
737
  end
738

739 740 741
  def test_extra_keys
    set.draw { |m| m.connect ':controller/:action/:id' }
    extras = set.extra_keys(:controller => "foo", :action => "bar", :id => 15, :this => "hello", :that => "world")
742
    assert_equal %w(that this), extras.map { |e| e.to_s }.sort
743
  end
744

745 746 747 748
  def test_generate_extras_not_first
    set.draw do |map|
      map.connect ':controller/:action/:id.:format'
      map.connect ':controller/:action/:id'
749
    end
750 751
    path, extras = set.generate_extras(:controller => "foo", :action => "bar", :id => 15, :this => "hello", :that => "world")
    assert_equal "/foo/bar/15", path
752
    assert_equal %w(that this), extras.map { |e| e.to_s }.sort
753
  end
754

755 756 757 758
  def test_generate_not_first
    set.draw do |map|
      map.connect ':controller/:action/:id.:format'
      map.connect ':controller/:action/:id'
759
    end
760 761
    assert_equal "/foo/bar/15?this=hello", set.generate(:controller => "foo", :action => "bar", :id => 15, :this => "hello")
  end
762

763 764 765 766
  def test_extra_keys_not_first
    set.draw do |map|
      map.connect ':controller/:action/:id.:format'
      map.connect ':controller/:action/:id'
767
    end
768
    extras = set.extra_keys(:controller => "foo", :action => "bar", :id => 15, :this => "hello", :that => "world")
769
    assert_equal %w(that this), extras.map { |e| e.to_s }.sort
770
  end
771

772 773 774 775
  def test_draw
    assert_equal 0, set.routes.size
    set.draw do |map|
      map.connect '/hello/world', :controller => 'a', :action => 'b'
776
    end
777 778
    assert_equal 1, set.routes.size
  end
779

780 781 782 783 784 785 786 787 788 789 790
  def test_draw_symbol_controller_name
    assert_equal 0, set.routes.size
    set.draw do |map|
      map.connect '/users/index', :controller => :users, :action => :index
    end
    @request = ActionController::TestRequest.new
    @request.request_uri = '/users/index'
    assert_nothing_raised { set.recognize(@request) }
    assert_equal 1, set.routes.size
  end

791 792 793 794
  def test_named_draw
    assert_equal 0, set.routes.size
    set.draw do |map|
      map.hello '/hello/world', :controller => 'a', :action => 'b'
795
    end
796 797 798
    assert_equal 1, set.routes.size
    assert_equal set.routes.first, set.named_routes[:hello]
  end
799

800 801 802 803
  def test_later_named_routes_take_precedence
    set.draw do |map|
      map.hello '/hello/world', :controller => 'a', :action => 'b'
      map.hello '/hello', :controller => 'a', :action => 'b'
804
    end
805 806
    assert_equal set.routes.last, set.named_routes[:hello]
  end
807

808 809 810 811 812 813
  def setup_named_route_test
    set.draw do |map|
      map.show '/people/:id', :controller => 'people', :action => 'show'
      map.index '/people', :controller => 'people', :action => 'index'
      map.multi '/people/go/:foo/:bar/joe/:id', :controller => 'people', :action => 'multi'
      map.users '/admin/users', :controller => 'admin/users', :action => 'index'
814 815
    end

816 817 818 819
    klass = Class.new(MockController)
    set.install_helpers(klass)
    klass.new(set)
  end
820

821 822 823 824 825 826 827 828 829 830 831 832 833 834 835
  def test_named_route_hash_access_method
    controller = setup_named_route_test

    assert_equal(
      { :controller => 'people', :action => 'show', :id => 5, :use_route => :show, :only_path => false },
      controller.send(:hash_for_show_url, :id => 5))

    assert_equal(
      { :controller => 'people', :action => 'index', :use_route => :index, :only_path => false },
      controller.send(:hash_for_index_url))

    assert_equal(
      { :controller => 'people', :action => 'show', :id => 5, :use_route => :show, :only_path => true },
      controller.send(:hash_for_show_path, :id => 5)
    )
836 837
  end

838 839
  def test_named_route_url_method
    controller = setup_named_route_test
840

841 842
    assert_equal "http://test.host/people/5", controller.send(:show_url, :id => 5)
    assert_equal "/people/5", controller.send(:show_path, :id => 5)
843

844 845
    assert_equal "http://test.host/people", controller.send(:index_url)
    assert_equal "/people", controller.send(:index_path)
846

847 848 849 850
    assert_equal "http://test.host/admin/users", controller.send(:users_url)
    assert_equal '/admin/users', controller.send(:users_path)
    assert_equal '/admin/users', set.generate(controller.send(:hash_for_users_url), {:controller => 'users', :action => 'index'})
  end
851

852 853
  def test_named_route_url_method_with_anchor
    controller = setup_named_route_test
854

855 856
    assert_equal "http://test.host/people/5#location", controller.send(:show_url, :id => 5, :anchor => 'location')
    assert_equal "/people/5#location", controller.send(:show_path, :id => 5, :anchor => 'location')
857

858 859
    assert_equal "http://test.host/people#location", controller.send(:index_url, :anchor => 'location')
    assert_equal "/people#location", controller.send(:index_path, :anchor => 'location')
860

861 862
    assert_equal "http://test.host/admin/users#location", controller.send(:users_url, :anchor => 'location')
    assert_equal '/admin/users#location', controller.send(:users_path, :anchor => 'location')
863

864 865
    assert_equal "http://test.host/people/go/7/hello/joe/5#location",
      controller.send(:multi_url, 7, "hello", 5, :anchor => 'location')
866

867 868
    assert_equal "http://test.host/people/go/7/hello/joe/5?baz=bar#location",
      controller.send(:multi_url, 7, "hello", 5, :baz => "bar", :anchor => 'location')
869

870 871 872
    assert_equal "http://test.host/people?baz=bar#location",
      controller.send(:index_url, :baz => "bar", :anchor => 'location')
  end
873

874 875 876 877
  def test_named_route_url_method_with_port
    controller = setup_named_route_test
    assert_equal "http://test.host:8080/people/5", controller.send(:show_url, 5, :port=>8080)
  end
878

879 880 881 882
  def test_named_route_url_method_with_host
    controller = setup_named_route_test
    assert_equal "http://some.example.com/people/5", controller.send(:show_url, 5, :host=>"some.example.com")
  end
883

884 885 886 887
  def test_named_route_url_method_with_protocol
    controller = setup_named_route_test
    assert_equal "https://test.host/people/5", controller.send(:show_url, 5, :protocol => "https")
  end
888

889 890 891 892 893
  def test_named_route_url_method_with_ordered_parameters
    controller = setup_named_route_test
    assert_equal "http://test.host/people/go/7/hello/joe/5",
      controller.send(:multi_url, 7, "hello", 5)
  end
894

895 896 897 898 899
  def test_named_route_url_method_with_ordered_parameters_and_hash
    controller = setup_named_route_test
    assert_equal "http://test.host/people/go/7/hello/joe/5?baz=bar",
      controller.send(:multi_url, 7, "hello", 5, :baz => "bar")
  end
900

901 902 903 904 905
  def test_named_route_url_method_with_ordered_parameters_and_empty_hash
    controller = setup_named_route_test
    assert_equal "http://test.host/people/go/7/hello/joe/5",
      controller.send(:multi_url, 7, "hello", 5, {})
  end
906

907 908 909 910 911
  def test_named_route_url_method_with_no_positional_arguments
    controller = setup_named_route_test
    assert_equal "http://test.host/people?baz=bar",
      controller.send(:index_url, :baz => "bar")
  end
912

913
  def test_draw_default_route
J
Joshua Peek 已提交
914 915 916
    set.draw do |map|
      map.connect '/:controller/:action/:id'
    end
917

J
Joshua Peek 已提交
918
    assert_equal 1, set.routes.size
919

J
Joshua Peek 已提交
920 921
    assert_equal '/users/show/10', set.generate(:controller => 'users', :action => 'show', :id => 10)
    assert_equal '/users/index/10', set.generate(:controller => 'users', :id => 10)
922

J
Joshua Peek 已提交
923 924
    assert_equal({:controller => 'users', :action => 'index', :id => '10'}, set.recognize_path('/users/index/10'))
    assert_equal({:controller => 'users', :action => 'index', :id => '10'}, set.recognize_path('/users/index/10/'))
925
  end
926

927
  def test_draw_default_route_with_default_controller
J
Joshua Peek 已提交
928 929
    set.draw do |map|
      map.connect '/:controller/:action/:id', :controller => 'users'
930
    end
J
Joshua Peek 已提交
931
    assert_equal({:controller => 'users', :action => 'index'}, set.recognize_path('/'))
932
  end
933

934
  def test_route_with_parameter_shell
J
Joshua Peek 已提交
935 936 937 938
    set.draw do |map|
      map.connect 'page/:id', :controller => 'pages', :action => 'show', :id => /\d+/
      map.connect '/:controller/:action/:id'
    end
939

J
Joshua Peek 已提交
940 941 942
    assert_equal({:controller => 'pages', :action => 'index'}, set.recognize_path('/pages'))
    assert_equal({:controller => 'pages', :action => 'index'}, set.recognize_path('/pages/index'))
    assert_equal({:controller => 'pages', :action => 'list'}, set.recognize_path('/pages/list'))
943

J
Joshua Peek 已提交
944 945
    assert_equal({:controller => 'pages', :action => 'show', :id => '10'}, set.recognize_path('/pages/show/10'))
    assert_equal({:controller => 'pages', :action => 'show', :id => '10'}, set.recognize_path('/page/10'))
946
  end
947

948
  def test_route_requirements_with_anchor_chars_are_invalid
949
    assert_raise ArgumentError do
950 951
      set.draw do |map|
        map.connect 'page/:id', :controller => 'pages', :action => 'show', :id => /^\d+/
952
      end
953
    end
954
    assert_raise ArgumentError do
955 956
      set.draw do |map|
        map.connect 'page/:id', :controller => 'pages', :action => 'show', :id => /\A\d+/
957 958
      end
    end
959
    assert_raise ArgumentError do
960 961
      set.draw do |map|
        map.connect 'page/:id', :controller => 'pages', :action => 'show', :id => /\d+$/
962 963
      end
    end
964
    assert_raise ArgumentError do
965 966
      set.draw do |map|
        map.connect 'page/:id', :controller => 'pages', :action => 'show', :id => /\d+\Z/
967 968
      end
    end
969
    assert_raise ArgumentError do
970
      set.draw do |map|
971
        map.connect 'page/:id', :controller => 'pages', :action => 'show', :id => /\d+\z/
972
      end
973 974
    end
  end
975

976
  def test_route_requirements_with_invalid_http_method_is_invalid
977
    assert_raise ArgumentError do
978
      set.draw do |map|
979
        map.connect 'valid/route', :controller => 'pages', :action => 'show', :conditions => {:method => :invalid}
980 981
      end
    end
982
  end
983

984 985 986 987 988 989 990 991
  def test_route_requirements_with_options_method_condition_is_valid
    assert_nothing_raised do
      set.draw do |map|
        map.connect 'valid/route', :controller => 'pages', :action => 'show', :conditions => {:method => :options}
      end
    end
  end

992
  def test_route_requirements_with_head_method_condition_is_invalid
993
    assert_raise ArgumentError do
994
      set.draw do |map|
995
        map.connect 'valid/route', :controller => 'pages', :action => 'show', :conditions => {:method => :head}
996
      end
997 998
    end
  end
999

1000 1001 1002 1003 1004
  def test_non_path_route_requirements_match_all
    set.draw do |map|
      map.connect 'page/37s', :controller => 'pages', :action => 'show', :name => /(jamis|david)/
    end
    assert_equal '/page/37s', set.generate(:controller => 'pages', :action => 'show', :name => 'jamis')
1005
    assert_raise ActionController::RoutingError do
1006 1007
      set.generate(:controller => 'pages', :action => 'show', :name => 'not_jamis')
    end
1008
    assert_raise ActionController::RoutingError do
1009 1010 1011
      set.generate(:controller => 'pages', :action => 'show', :name => 'nor_jamis_and_david')
    end
  end
1012

1013 1014 1015 1016
  def test_recognize_with_encoded_id_and_regex
    set.draw do |map|
      map.connect 'page/:id', :controller => 'pages', :action => 'show', :id => /[a-zA-Z0-9\+]+/
    end
1017

1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030
    assert_equal({:controller => 'pages', :action => 'show', :id => '10'}, set.recognize_path('/page/10'))
    assert_equal({:controller => 'pages', :action => 'show', :id => 'hello+world'}, set.recognize_path('/page/hello+world'))
  end

  def test_recognize_with_conditions
    set.draw do |map|
      map.with_options(:controller => "people") do |people|
        people.people  "/people",     :action => "index",   :conditions => { :method => :get }
        people.connect "/people",     :action => "create",  :conditions => { :method => :post }
        people.person  "/people/:id", :action => "show",    :conditions => { :method => :get }
        people.connect "/people/:id", :action => "update",  :conditions => { :method => :put }
        people.connect "/people/:id", :action => "destroy", :conditions => { :method => :delete }
      end
1031 1032
    end

1033
    request.request_uri = "/people"
1034 1035 1036 1037
    request.env["REQUEST_METHOD"] = "GET"
    assert_nothing_raised { set.recognize(request) }
    assert_equal("index", request.path_parameters[:action])
    request.recycle!
1038

1039 1040 1041 1042
    request.env["REQUEST_METHOD"] = "POST"
    assert_nothing_raised { set.recognize(request) }
    assert_equal("create", request.path_parameters[:action])
    request.recycle!
1043

1044 1045 1046 1047
    request.env["REQUEST_METHOD"] = "PUT"
    assert_nothing_raised { set.recognize(request) }
    assert_equal("update", request.path_parameters[:action])
    request.recycle!
1048

1049
    assert_raise(ActionController::UnknownHttpMethod) {
1050 1051 1052 1053
      request.env["REQUEST_METHOD"] = "BACON"
      set.recognize(request)
    }
    request.recycle!
1054

1055
    request.request_uri = "/people/5"
1056 1057 1058 1059 1060
    request.env["REQUEST_METHOD"] = "GET"
    assert_nothing_raised { set.recognize(request) }
    assert_equal("show", request.path_parameters[:action])
    assert_equal("5", request.path_parameters[:id])
    request.recycle!
1061

1062 1063 1064 1065 1066
    request.env["REQUEST_METHOD"] = "PUT"
    assert_nothing_raised { set.recognize(request) }
    assert_equal("update", request.path_parameters[:action])
    assert_equal("5", request.path_parameters[:id])
    request.recycle!
1067

1068 1069 1070 1071 1072
    request.env["REQUEST_METHOD"] = "DELETE"
    assert_nothing_raised { set.recognize(request) }
    assert_equal("destroy", request.path_parameters[:action])
    assert_equal("5", request.path_parameters[:id])
    request.recycle!
1073

1074 1075 1076 1077 1078 1079
    begin
      request.env["REQUEST_METHOD"] = "POST"
      set.recognize(request)
      flunk 'Should have raised MethodNotAllowed'
    rescue ActionController::MethodNotAllowed => e
      assert_equal [:get, :put, :delete], e.allowed_methods
1080
    end
1081 1082
    request.recycle!
  end
1083

1084 1085 1086 1087 1088
  def test_recognize_with_alias_in_conditions
    set.draw do |map|
      map.people "/people", :controller => 'people', :action => "index",
        :conditions => { :method => :get }
      map.root   :people
1089
    end
1090

1091 1092 1093 1094 1095
    request.path = "/people"
    request.env["REQUEST_METHOD"] = "GET"
    assert_nothing_raised { set.recognize(request) }
    assert_equal("people", request.path_parameters[:controller])
    assert_equal("index", request.path_parameters[:action])
1096

1097 1098 1099 1100 1101 1102
    request.path = "/"
    request.env["REQUEST_METHOD"] = "GET"
    assert_nothing_raised { set.recognize(request) }
    assert_equal("people", request.path_parameters[:controller])
    assert_equal("index", request.path_parameters[:action])
  end
1103

1104 1105 1106 1107 1108
  def test_typo_recognition
    set.draw do |map|
      map.connect 'articles/:year/:month/:day/:title',
             :controller => 'articles', :action => 'permalink',
             :year => /\d{4}/, :day => /\d{1,2}/, :month => /\d{1,2}/
1109
    end
1110

1111 1112 1113 1114 1115 1116 1117 1118 1119
    request.path = "/articles/2005/11/05/a-very-interesting-article"
    request.env["REQUEST_METHOD"] = "GET"
    assert_nothing_raised { set.recognize(request) }
    assert_equal("permalink", request.path_parameters[:action])
    assert_equal("2005", request.path_parameters[:year])
    assert_equal("11", request.path_parameters[:month])
    assert_equal("05", request.path_parameters[:day])
    assert_equal("a-very-interesting-article", request.path_parameters[:title])
  end
1120

1121 1122 1123 1124
  def test_routing_traversal_does_not_load_extra_classes
    assert !Object.const_defined?("Profiler__"), "Profiler should not be loaded"
    set.draw do |map|
      map.connect '/profile', :controller => 'profile'
1125 1126
    end

1127
    request.path = '/profile'
1128

1129
    set.recognize(request) rescue nil
1130

1131 1132 1133 1134 1135 1136 1137 1138 1139
    assert !Object.const_defined?("Profiler__"), "Profiler should not be loaded"
  end

  def test_recognize_with_conditions_and_format
    set.draw do |map|
      map.with_options(:controller => "people") do |people|
        people.person  "/people/:id", :action => "show",    :conditions => { :method => :get }
        people.connect "/people/:id", :action => "update",  :conditions => { :method => :put }
        people.connect "/people/:id.:_format", :action => "show", :conditions => { :method => :get }
1140
      end
1141 1142
    end

1143
    request.request_uri = "/people/5"
1144 1145 1146 1147 1148 1149 1150 1151 1152 1153
    request.env["REQUEST_METHOD"] = "GET"
    assert_nothing_raised { set.recognize(request) }
    assert_equal("show", request.path_parameters[:action])
    assert_equal("5", request.path_parameters[:id])
    request.recycle!

    request.env["REQUEST_METHOD"] = "PUT"
    assert_nothing_raised { set.recognize(request) }
    assert_equal("update", request.path_parameters[:action])
    request.recycle!
1154

1155
    request.request_uri = "/people/5.png"
1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166
    request.env["REQUEST_METHOD"] = "GET"
    assert_nothing_raised { set.recognize(request) }
    assert_equal("show", request.path_parameters[:action])
    assert_equal("5", request.path_parameters[:id])
    assert_equal("png", request.path_parameters[:_format])
  end

  def test_generate_with_default_action
    set.draw do |map|
      map.connect "/people", :controller => "people"
      map.connect "/people/list", :controller => "people", :action => "list"
1167 1168
    end

1169 1170 1171
    url = set.generate(:controller => "people", :action => "list")
    assert_equal "/people/list", url
  end
1172

1173 1174
  def test_root_map
    set.draw { |map| map.root :controller => "people" }
1175

1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187
    request.path = ""
    request.env["REQUEST_METHOD"] = "GET"
    assert_nothing_raised { set.recognize(request) }
    assert_equal("people", request.path_parameters[:controller])
    assert_equal("index", request.path_parameters[:action])
  end

  def test_namespace
    set.draw do |map|

      map.namespace 'api' do |api|
        api.route 'inventory', :controller => "products", :action => 'inventory'
1188
      end
1189

1190 1191
    end

1192 1193 1194 1195 1196 1197
    request.path = "/api/inventory"
    request.env["REQUEST_METHOD"] = "GET"
    assert_nothing_raised { set.recognize(request) }
    assert_equal("api/products", request.path_parameters[:controller])
    assert_equal("inventory", request.path_parameters[:action])
  end
1198

1199 1200
  def test_namespaced_root_map
    set.draw do |map|
1201

1202 1203
      map.namespace 'api' do |api|
        api.root :controller => "products"
1204 1205 1206 1207
      end

    end

1208 1209 1210 1211 1212 1213
    request.path = "/api"
    request.env["REQUEST_METHOD"] = "GET"
    assert_nothing_raised { set.recognize(request) }
    assert_equal("api/products", request.path_parameters[:controller])
    assert_equal("index", request.path_parameters[:action])
  end
1214

1215 1216 1217 1218
  def test_namespace_with_path_prefix
    set.draw do |map|
      map.namespace 'api', :path_prefix => 'prefix' do |api|
        api.route 'inventory', :controller => "products", :action => 'inventory'
1219
      end
1220 1221
    end

1222 1223 1224 1225 1226 1227
    request.path = "/prefix/inventory"
    request.env["REQUEST_METHOD"] = "GET"
    assert_nothing_raised { set.recognize(request) }
    assert_equal("api/products", request.path_parameters[:controller])
    assert_equal("inventory", request.path_parameters[:action])
  end
1228

1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242
  def test_namespace_with_blank_path_prefix
    set.draw do |map|
      map.namespace 'api', :path_prefix => '' do |api|
        api.route 'inventory', :controller => "products", :action => 'inventory'
      end
    end

    request.path = "/inventory"
    request.env["REQUEST_METHOD"] = "GET"
    assert_nothing_raised { set.recognize(request) }
    assert_equal("api/products", request.path_parameters[:controller])
    assert_equal("inventory", request.path_parameters[:action])
  end

1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253
  def test_generate_changes_controller_module
    set.draw { |map| map.connect ':controller/:action/:id' }
    current = { :controller => "bling/bloop", :action => "bap", :id => 9 }
    url = set.generate({:controller => "foo/bar", :action => "baz", :id => 7}, current)
    assert_equal "/foo/bar/baz/7", url
  end

  def test_id_is_not_impossibly_sticky
    set.draw do |map|
      map.connect 'foo/:number', :controller => "people", :action => "index"
      map.connect ':controller/:action/:id'
1254 1255
    end

1256 1257 1258 1259
    url = set.generate({:controller => "people", :action => "index", :number => 3},
      {:controller => "people", :action => "index", :id => "21"})
    assert_equal "/foo/3", url
  end
1260

1261 1262 1263
  def test_id_is_sticky_when_it_ought_to_be
    set.draw do |map|
      map.connect ':controller/:id/:action'
1264
    end
1265

1266 1267 1268
    url = set.generate({:action => "destroy"}, {:controller => "people", :action => "show", :id => "7"})
    assert_equal "/people/7/destroy", url
  end
1269

1270 1271 1272 1273
  def test_use_static_path_when_possible
    set.draw do |map|
      map.connect 'about', :controller => "welcome", :action => "about"
      map.connect ':controller/:action/:id'
1274 1275
    end

1276 1277 1278 1279
    url = set.generate({:controller => "welcome", :action => "about"},
      {:controller => "welcome", :action => "get", :id => "7"})
    assert_equal "/about", url
  end
1280

1281 1282
  def test_generate
    set.draw { |map| map.connect ':controller/:action/:id' }
1283

1284 1285 1286 1287 1288
    args = { :controller => "foo", :action => "bar", :id => "7", :x => "y" }
    assert_equal "/foo/bar/7?x=y", set.generate(args)
    assert_equal ["/foo/bar/7", [:x]], set.generate_extras(args)
    assert_equal [:x], set.extra_keys(args)
  end
1289

1290 1291
  def test_generate_with_path_prefix
    set.draw { |map| map.connect ':controller/:action/:id', :path_prefix => 'my' }
1292

1293 1294 1295 1296
    args = { :controller => "foo", :action => "bar", :id => "7", :x => "y" }
    assert_equal "/my/foo/bar/7?x=y", set.generate(args)
  end

1297 1298 1299 1300 1301 1302 1303
  def test_generate_with_blank_path_prefix
    set.draw { |map| map.connect ':controller/:action/:id', :path_prefix => '' }

    args = { :controller => "foo", :action => "bar", :id => "7", :x => "y" }
    assert_equal "/foo/bar/7?x=y", set.generate(args)
  end

1304 1305 1306 1307 1308
  def test_named_routes_are_never_relative_to_modules
    set.draw do |map|
      map.connect "/connection/manage/:action", :controller => 'connection/manage'
      map.connect "/connection/connection", :controller => "connection/connection"
      map.family_connection "/connection", :controller => "connection"
1309
    end
1310

1311 1312 1313 1314 1315 1316 1317 1318 1319 1320
    url = set.generate({:controller => "connection"}, {:controller => 'connection/manage'})
    assert_equal "/connection/connection", url

    url = set.generate({:use_route => :family_connection, :controller => "connection"}, {:controller => 'connection/manage'})
    assert_equal "/connection", url
  end

  def test_action_left_off_when_id_is_recalled
    set.draw do |map|
      map.connect ':controller/:action/:id'
1321
    end
1322 1323 1324
    assert_equal '/books', set.generate(
      {:controller => 'books', :action => 'index'},
      {:controller => 'books', :action => 'show', :id => '10'}
1325 1326
    )
  end
1327

1328 1329
  def test_query_params_will_be_shown_when_recalled
    set.draw do |map|
1330
      map.connect 'show_weblog/:parameter', :controller => 'weblog', :action => 'show'
1331
      map.connect ':controller/:action/:id'
1332
    end
1333
    assert_equal '/weblog/edit?parameter=1', set.generate(
1334
      {:action => 'edit', :parameter => 1},
1335
      {:controller => 'weblog', :action => 'show', :parameter => 1}
1336 1337
    )
  end
1338

1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354
  def test_format_is_not_inherit
    set.draw do |map|
      map.connect '/posts.:format', :controller => 'posts'
    end

    assert_equal '/posts', set.generate(
      {:controller => 'posts'},
      {:controller => 'posts', :action => 'index', :format => 'xml'}
    )

    assert_equal '/posts.xml', set.generate(
      {:controller => 'posts', :format => 'xml'},
      {:controller => 'posts', :action => 'index', :format => 'xml'}
    )
  end

1355 1356
  def test_expiry_determination_should_consider_values_with_to_param
    set.draw { |map| map.connect 'projects/:project_id/:controller/:action' }
1357
    assert_equal '/projects/1/weblog/show', set.generate(
1358
      {:action => 'show', :project_id => 1},
1359
      {:controller => 'weblog', :action => 'show', :project_id => '1'})
1360
  end
1361

1362 1363 1364 1365
  def test_named_route_in_nested_resource
    set.draw do |map|
      map.resources :projects do |project|
        project.milestones 'milestones', :controller => 'milestones', :action => 'index'
1366 1367
      end
    end
1368

1369 1370 1371 1372 1373 1374
    request.path = "/projects/1/milestones"
    request.env["REQUEST_METHOD"] = "GET"
    assert_nothing_raised { set.recognize(request) }
    assert_equal("milestones", request.path_parameters[:controller])
    assert_equal("index", request.path_parameters[:action])
  end
1375

1376 1377 1378 1379 1380
  def test_setting_root_in_namespace_using_symbol
    assert_nothing_raised do
      set.draw do |map|
        map.namespace :admin do |admin|
          admin.root :controller => 'home'
1381 1382 1383
        end
      end
    end
1384
  end
1385

1386 1387 1388 1389 1390
  def test_setting_root_in_namespace_using_string
    assert_nothing_raised do
      set.draw do |map|
        map.namespace 'admin' do |admin|
          admin.root :controller => 'home'
1391 1392 1393
        end
      end
    end
1394
  end
1395

1396
  def test_route_requirements_with_unsupported_regexp_options_must_error
1397
    assert_raise ArgumentError do
1398 1399 1400
      set.draw do |map|
        map.connect 'page/:name', :controller => 'pages',
          :action => 'show',
1401
          :requirements => {:name => /(david|jamis)/m}
1402
      end
1403
    end
1404
  end
1405

1406 1407
  def test_route_requirements_with_supported_options_must_not_error
    assert_nothing_raised do
1408 1409 1410 1411 1412 1413
      set.draw do |map|
        map.connect 'page/:name', :controller => 'pages',
          :action => 'show',
          :requirements => {:name => /(david|jamis)/i}
      end
    end
1414
    assert_nothing_raised do
1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425
      set.draw do |map|
        map.connect 'page/:name', :controller => 'pages',
          :action => 'show',
          :requirements => {:name => / # Desperately overcommented regexp
                                      ( #Either
                                       david #The Creator
                                      | #Or
                                        jamis #The Deployer
                                      )/x}
      end
    end
1426
  end
1427

1428 1429 1430 1431 1432 1433 1434
  def test_route_requirement_recognize_with_ignore_case
    set.draw do |map|
      map.connect 'page/:name', :controller => 'pages',
        :action => 'show',
        :requirements => {:name => /(david|jamis)/i}
    end
    assert_equal({:controller => 'pages', :action => 'show', :name => 'jamis'}, set.recognize_path('/page/jamis'))
1435
    assert_raise ActionController::RoutingError do
1436
      set.recognize_path('/page/davidjamis')
1437
    end
1438 1439
    assert_equal({:controller => 'pages', :action => 'show', :name => 'DAVID'}, set.recognize_path('/page/DAVID'))
  end
1440

1441 1442 1443 1444 1445 1446 1447 1448
  def test_route_requirement_generate_with_ignore_case
    set.draw do |map|
      map.connect 'page/:name', :controller => 'pages',
        :action => 'show',
        :requirements => {:name => /(david|jamis)/i}
    end
    url = set.generate({:controller => 'pages', :action => 'show', :name => 'david'})
    assert_equal "/page/david", url
1449
    assert_raise ActionController::RoutingError do
1450
      url = set.generate({:controller => 'pages', :action => 'show', :name => 'davidjamis'})
J
Jeremy Kemper 已提交
1451
    end
1452 1453 1454
    url = set.generate({:controller => 'pages', :action => 'show', :name => 'JAMIS'})
    assert_equal "/page/JAMIS", url
  end
J
Jeremy Kemper 已提交
1455

1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468
  def test_route_requirement_recognize_with_extended_syntax
    set.draw do |map|
      map.connect 'page/:name', :controller => 'pages',
        :action => 'show',
        :requirements => {:name => / # Desperately overcommented regexp
                                    ( #Either
                                     david #The Creator
                                    | #Or
                                      jamis #The Deployer
                                    )/x}
    end
    assert_equal({:controller => 'pages', :action => 'show', :name => 'jamis'}, set.recognize_path('/page/jamis'))
    assert_equal({:controller => 'pages', :action => 'show', :name => 'david'}, set.recognize_path('/page/david'))
1469
    assert_raise ActionController::RoutingError do
1470 1471
      set.recognize_path('/page/david #The Creator')
    end
1472
    assert_raise ActionController::RoutingError do
1473
      set.recognize_path('/page/David')
1474 1475
    end
  end
1476

1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489
  def test_route_requirement_generate_with_extended_syntax
    set.draw do |map|
      map.connect 'page/:name', :controller => 'pages',
        :action => 'show',
        :requirements => {:name => / # Desperately overcommented regexp
                                    ( #Either
                                     david #The Creator
                                    | #Or
                                      jamis #The Deployer
                                    )/x}
    end
    url = set.generate({:controller => 'pages', :action => 'show', :name => 'david'})
    assert_equal "/page/david", url
1490
    assert_raise ActionController::RoutingError do
1491 1492
      url = set.generate({:controller => 'pages', :action => 'show', :name => 'davidjamis'})
    end
1493
    assert_raise ActionController::RoutingError do
1494 1495 1496
      url = set.generate({:controller => 'pages', :action => 'show', :name => 'JAMIS'})
    end
  end
1497

1498 1499 1500 1501 1502 1503 1504 1505 1506 1507
  def test_route_requirement_generate_with_xi_modifiers
    set.draw do |map|
      map.connect 'page/:name', :controller => 'pages',
        :action => 'show',
        :requirements => {:name => / # Desperately overcommented regexp
                                    ( #Either
                                     david #The Creator
                                    | #Or
                                      jamis #The Deployer
                                    )/xi}
1508
    end
1509 1510 1511
    url = set.generate({:controller => 'pages', :action => 'show', :name => 'JAMIS'})
    assert_equal "/page/JAMIS", url
  end
1512

1513 1514 1515 1516 1517 1518 1519 1520 1521 1522
  def test_route_requirement_recognize_with_xi_modifiers
    set.draw do |map|
      map.connect 'page/:name', :controller => 'pages',
        :action => 'show',
        :requirements => {:name => / # Desperately overcommented regexp
                                    ( #Either
                                     david #The Creator
                                    | #Or
                                      jamis #The Deployer
                                    )/xi}
1523
    end
1524 1525
    assert_equal({:controller => 'pages', :action => 'show', :name => 'JAMIS'}, set.recognize_path('/page/JAMIS'))
  end
1526 1527 1528 1529 1530 1531 1532 1533 1534 1535

  def test_routes_with_symbols
    set.draw do |map|
      map.connect 'unnamed', :controller => :pages, :action => :show, :name => :as_symbol
      map.named   'named',   :controller => :pages, :action => :show, :name => :as_symbol
    end
    assert_equal({:controller => 'pages', :action => 'show', :name => :as_symbol}, set.recognize_path('/unnamed'))
    assert_equal({:controller => 'pages', :action => 'show', :name => :as_symbol}, set.recognize_path('/named'))
  end

1536
  def test_interpolation_chunk_should_respect_raw
J
Joshua Peek 已提交
1537 1538
    set.draw do |map|
      map.connect '/Hello World', :controller => 'hello'
1539
    end
J
Joshua Peek 已提交
1540 1541 1542 1543

    assert_equal '/Hello%20World', set.generate(:controller => 'hello')
    assert_equal({:controller => "hello", :action => "index"}, set.recognize_path('/Hello World'))
    assert_raise(ActionController::RoutingError) { set.recognize_path('/Hello%20World') }
1544 1545 1546
  end

  def test_value_should_not_be_double_unescaped
J
Joshua Peek 已提交
1547 1548
    set.draw do |map|
      map.connect '/Карта', :controller => 'foo'
1549
    end
J
Joshua Peek 已提交
1550 1551 1552 1553

    assert_equal '/%D0%9A%D0%B0%D1%80%D1%82%D0%B0', set.generate(:controller => 'foo')
    assert_equal({:controller => "foo", :action => "index"}, set.recognize_path('/Карта'))
    assert_raise(ActionController::RoutingError) { set.recognize_path('/%D0%9A%D0%B0%D1%80%D1%82%D0%B0') }
1554 1555 1556
  end

  def test_regexp_chunk_should_escape_specials
J
Joshua Peek 已提交
1557 1558 1559 1560
    set.draw do |map|
      map.connect '/Hello*World', :controller => 'foo'
      map.connect '/HelloWorld', :controller => 'bar'
    end
1561

J
Joshua Peek 已提交
1562 1563
    assert_equal '/Hello*World', set.generate(:controller => 'foo')
    assert_equal '/HelloWorld', set.generate(:controller => 'bar')
1564

J
Joshua Peek 已提交
1565 1566
    assert_equal({:controller => "foo", :action => "index"}, set.recognize_path('/Hello*World'))
    assert_equal({:controller => "bar", :action => "index"}, set.recognize_path('/HelloWorld'))
1567 1568 1569
  end

  def test_regexp_chunk_should_add_question_mark_for_optionals
J
Joshua Peek 已提交
1570 1571 1572 1573
    set.draw do |map|
      map.connect '/', :controller => 'foo'
      map.connect '/hello', :controller => 'bar'
    end
1574

J
Joshua Peek 已提交
1575 1576
    assert_equal '/', set.generate(:controller => 'foo')
    assert_equal '/hello', set.generate(:controller => 'bar')
1577

J
Joshua Peek 已提交
1578 1579
    assert_equal({:controller => "foo", :action => "index"}, set.recognize_path('/'))
    assert_equal({:controller => "bar", :action => "index"}, set.recognize_path('/hello'))
1580 1581 1582
  end

  def test_assign_route_options_with_anchor_chars
J
Joshua Peek 已提交
1583 1584 1585
    set.draw do |map|
      map.connect '/cars/:action/:person/:car/', :controller => 'cars'
    end
1586

J
Joshua Peek 已提交
1587
    assert_equal '/cars/buy/1/2', set.generate(:controller => 'cars', :action => 'buy', :person => '1', :car => '2')
1588

J
Joshua Peek 已提交
1589
    assert_equal({:controller => "cars", :action => "buy", :person => "1", :car => "2"}, set.recognize_path('/cars/buy/1/2'))
1590 1591 1592
  end

  def test_segmentation_of_dot_path
J
Joshua Peek 已提交
1593 1594 1595
    set.draw do |map|
      map.connect '/books/:action.rss', :controller => 'books'
    end
1596

J
Joshua Peek 已提交
1597
    assert_equal '/books/list.rss', set.generate(:controller => 'books', :action => 'list')
1598

J
Joshua Peek 已提交
1599
    assert_equal({:controller => "books", :action => "list"}, set.recognize_path('/books/list.rss'))
1600 1601 1602
  end

  def test_segmentation_of_dynamic_dot_path
J
Joshua Peek 已提交
1603 1604 1605
    set.draw do |map|
      map.connect '/books/:action.:format', :controller => 'books'
    end
1606

J
Joshua Peek 已提交
1607 1608 1609 1610
    assert_equal '/books/list.rss', set.generate(:controller => 'books', :action => 'list', :format => 'rss')
    assert_equal '/books/list.xml', set.generate(:controller => 'books', :action => 'list', :format => 'xml')
    assert_equal '/books/list', set.generate(:controller => 'books', :action => 'list')
    assert_equal '/books', set.generate(:controller => 'books', :action => 'index')
1611

J
Joshua Peek 已提交
1612 1613 1614 1615
    assert_equal({:controller => "books", :action => "list", :format => "rss"}, set.recognize_path('/books/list.rss'))
    assert_equal({:controller => "books", :action => "list", :format => "xml"}, set.recognize_path('/books/list.xml'))
    assert_equal({:controller => "books", :action => "list"}, set.recognize_path('/books/list'))
    assert_equal({:controller => "books", :action => "index"}, set.recognize_path('/books'))
1616 1617 1618
  end

  def test_slashes_are_implied
1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632
    ['/:controller/:action/:id/', '/:controller/:action/:id',
      ':controller/:action/:id', '/:controller/:action/:id/'
    ].each do |path|
      @set = nil
      set.draw { |map| map.connect(path) }

      assert_equal '/content', set.generate(:controller => 'content', :action => 'index')
      assert_equal '/content/list', set.generate(:controller => 'content', :action => 'list')
      assert_equal '/content/show/1', set.generate(:controller => 'content', :action => 'show', :id => '1')

      assert_equal({:controller => "content", :action => "index"}, set.recognize_path('/content'))
      assert_equal({:controller => "content", :action => "index"}, set.recognize_path('/content/index'))
      assert_equal({:controller => "content", :action => "list"}, set.recognize_path('/content/list'))
      assert_equal({:controller => "content", :action => "show", :id => "1"}, set.recognize_path('/content/show/1'))
1633 1634 1635 1636
    end
  end

  def test_default_route_recognition
J
Joshua Peek 已提交
1637 1638 1639
    expected = {:controller => 'pages', :action => 'show', :id => '10'}
    assert_equal expected, default_route_set.recognize_path('/pages/show/10')
    assert_equal expected, default_route_set.recognize_path('/pages/show/10/')
1640 1641

    expected[:id] = 'jamis'
J
Joshua Peek 已提交
1642
    assert_equal expected, default_route_set.recognize_path('/pages/show/jamis/')
1643 1644

    expected.delete :id
J
Joshua Peek 已提交
1645 1646
    assert_equal expected, default_route_set.recognize_path('/pages/show')
    assert_equal expected, default_route_set.recognize_path('/pages/show/')
1647 1648

    expected[:action] = 'index'
J
Joshua Peek 已提交
1649 1650
    assert_equal expected, default_route_set.recognize_path('/pages/')
    assert_equal expected, default_route_set.recognize_path('/pages')
1651 1652

    assert_raise(ActionController::RoutingError) { default_route_set.recognize_path('/') }
J
Joshua Peek 已提交
1653
    assert_raise(ActionController::RoutingError) { default_route_set.recognize_path('/pages/how/goood/it/is/to/be/free') }
1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668
  end

  def test_default_route_should_omit_default_action
    assert_equal '/accounts', default_route_set.generate({:controller => 'accounts', :action => 'index'})
  end

  def test_default_route_should_include_default_action_when_id_present
    assert_equal '/accounts/index/20', default_route_set.generate({:controller => 'accounts', :action => 'index', :id => '20'})
  end

  def test_default_route_should_work_with_action_but_no_id
    assert_equal '/accounts/list_all', default_route_set.generate({:controller => 'accounts', :action => 'list_all'})
  end

  def test_default_route_should_uri_escape_pluses
J
Joshua Peek 已提交
1669 1670 1671 1672
    expected = { :controller => 'pages', :action => 'show', :id => 'hello world' }
    assert_equal expected, default_route_set.recognize_path('/pages/show/hello world')
    assert_equal expected, default_route_set.recognize_path('/pages/show/hello%20world')
    assert_equal '/pages/show/hello%20world', default_route_set.generate(expected, expected)
1673 1674

    expected[:id] = 'hello+world'
J
Joshua Peek 已提交
1675 1676 1677
    assert_equal expected, default_route_set.recognize_path('/pages/show/hello+world')
    assert_equal expected, default_route_set.recognize_path('/pages/show/hello%2Bworld')
    assert_equal '/pages/show/hello+world', default_route_set.generate(expected, expected)
1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699
  end

  def test_parameter_shell
    page_url = ROUTING::Route.new
    page_url.requirements = {:controller => 'pages', :action => 'show', :id => /\d+/}
    assert_equal({:controller => 'pages', :action => 'show'}, page_url.parameter_shell)
  end

  def test_defaults
    route = ROUTING::RouteBuilder.new.build '/users/:id.:format', :controller => "users", :action => "show", :format => "html"
    assert_equal(
      { :controller => "users", :action => "show", :format => "html" },
      route.defaults)
  end

  def test_builder_complains_without_controller
    assert_raise(ArgumentError) do
      ROUTING::RouteBuilder.new.build '/contact', :contoller => "contact", :action => "index"
    end
  end

  def test_build_empty_query_string
J
Joshua Peek 已提交
1700
    assert_uri_equal '/foo', default_route_set.generate({:controller => 'foo'})
1701 1702 1703
  end

  def test_build_query_string_with_nil_value
J
Joshua Peek 已提交
1704
    assert_uri_equal '/foo', default_route_set.generate({:controller => 'foo', :x => nil})
1705 1706 1707
  end

  def test_simple_build_query_string
J
Joshua Peek 已提交
1708
    assert_uri_equal '/foo?x=1&y=2', default_route_set.generate({:controller => 'foo', :x => '1', :y => '2'})
1709 1710 1711
  end

  def test_convert_ints_build_query_string
J
Joshua Peek 已提交
1712
    assert_uri_equal '/foo?x=1&y=2', default_route_set.generate({:controller => 'foo', :x => 1, :y => 2})
1713 1714 1715
  end

  def test_escape_spaces_build_query_string
J
Joshua Peek 已提交
1716
    assert_uri_equal '/foo?x=hello+world&y=goodbye+world', default_route_set.generate({:controller => 'foo', :x => 'hello world', :y => 'goodbye world'})
1717 1718 1719
  end

  def test_expand_array_build_query_string
J
Joshua Peek 已提交
1720
    assert_uri_equal '/foo?x%5B%5D=1&x%5B%5D=2', default_route_set.generate({:controller => 'foo', :x => [1, 2]})
1721 1722 1723
  end

  def test_escape_spaces_build_query_string_selected_keys
J
Joshua Peek 已提交
1724
    assert_uri_equal '/foo?x=hello+world', default_route_set.generate({:controller => 'foo', :x => 'hello world'})
1725
  end
J
Joshua Peek 已提交
1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736

  private
    def assert_uri_equal(expected, actual)
      assert_equal(sort_query_string_params(expected), sort_query_string_params(actual))
    end

    def sort_query_string_params(uri)
      path, qs = uri.split('?')
      qs = qs.split('&').sort.join('&') if qs
      qs ? "#{path}?#{qs}" : path
    end
1737
end
1738

1739 1740 1741
class RouteLoadingTest < Test::Unit::TestCase
  def setup
    routes.instance_variable_set '@routes_last_modified', nil
1742 1743
    Object.remove_const(:RAILS_ROOT) if defined?(::RAILS_ROOT)
    Object.const_set :RAILS_ROOT, '.'
1744
    routes.add_configuration_file(File.join(RAILS_ROOT, 'config', 'routes.rb'))
1745

1746 1747
    @stat = stub_everything
  end
1748

1749 1750 1751 1752
  def teardown
    ActionController::Routing::Routes.configuration_files.clear
    Object.send :remove_const, :RAILS_ROOT
  end
1753

1754 1755 1756
  def test_load
    File.expects(:stat).returns(@stat)
    routes.expects(:load).with(regexp_matches(/routes\.rb$/))
1757

1758 1759
    routes.reload
  end
1760

1761 1762 1763 1764
  def test_no_reload_when_not_modified
    @stat.expects(:mtime).times(2).returns(1)
    File.expects(:stat).times(2).returns(@stat)
    routes.expects(:load).with(regexp_matches(/routes\.rb$/)).at_most_once
1765

1766 1767
    2.times { routes.reload }
  end
1768

1769 1770 1771 1772
  def test_reload_when_modified
    @stat.expects(:mtime).at_least(2).returns(1, 2)
    File.expects(:stat).at_least(2).returns(@stat)
    routes.expects(:load).with(regexp_matches(/routes\.rb$/)).times(2)
1773

1774 1775
    2.times { routes.reload }
  end
1776

1777 1778 1779 1780
  def test_bang_forces_reload
    @stat.expects(:mtime).at_least(2).returns(1)
    File.expects(:stat).at_least(2).returns(@stat)
    routes.expects(:load).with(regexp_matches(/routes\.rb$/)).times(2)
1781

1782 1783
    2.times { routes.reload! }
  end
1784

1785 1786 1787
  def test_adding_inflections_forces_reload
    ActiveSupport::Inflector::Inflections.instance.expects(:uncountable).with('equipment')
    routes.expects(:reload!)
1788

1789 1790
    ActiveSupport::Inflector.inflections { |inflect| inflect.uncountable('equipment') }
  end
1791

1792 1793 1794 1795 1796
  def test_load_with_configuration
    routes.configuration_files.clear
    routes.add_configuration_file("foobarbaz")
    File.expects(:stat).returns(@stat)
    routes.expects(:load).with("foobarbaz")
1797

1798
    routes.reload
1799
  end
J
Joshua Peek 已提交
1800

1801 1802
  def test_load_multiple_configurations
    routes.add_configuration_file("engines.rb")
J
Joshua Peek 已提交
1803

1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815
    File.expects(:stat).at_least_once.returns(@stat)

    routes.expects(:load).with('./config/routes.rb')
    routes.expects(:load).with('engines.rb')

    routes.reload
  end

  private
    def routes
      ActionController::Routing::Routes
    end
1816
end