routing_test.rb 90.9 KB
Newer Older
1 2
require 'abstract_unit'
require 'controller/fake_controllers'
3

J
Jeremy Kemper 已提交
4 5 6 7 8 9
class MilestonesController < ActionController::Base
  def index() head :ok end
  alias_method :show, :index
  def rescue_action(e) raise e end
end

10
RunTimeTests = ARGV.include? 'time'
11
ROUTING = ActionController::Routing
12

13 14
class ROUTING::RouteBuilder
  attr_reader :warn_output
15

16 17
  def warn(msg)
    (@warn_output ||= []) << msg
18
  end
19
end
20

21
# See RFC 3986, section 3.3 for allowed path characters.
22 23 24 25 26
class UriReservedCharactersRoutingTest < Test::Unit::TestCase
  def setup
    ActionController::Routing.use_controllers! ['controller']
    @set = ActionController::Routing::RouteSet.new
    @set.draw do |map|
27
      map.connect ':controller/:action/:variable/*additional'
28
    end
29

30
    safe, unsafe = %w(: @ & = + $ , ;), %w(^ / ? # [ ])
31 32
    hex = unsafe.map { |char| '%' + char.unpack('H2').first.upcase }

33 34
    @segment = "#{safe.join}#{unsafe.join}".freeze
    @escaped = "#{safe.join}#{hex.join}".freeze
35
  end
36 37

  def test_route_generation_escapes_unsafe_path_characters
38
    assert_equal "/contr#{@segment}oller/act#{@escaped}ion/var#{@escaped}iable/add#{@escaped}itional-1/add#{@escaped}itional-2",
39 40
      @set.generate(:controller => "contr#{@segment}oller",
                    :action => "act#{@segment}ion",
41 42
                    :variable => "var#{@segment}iable",
                    :additional => ["add#{@segment}itional-1", "add#{@segment}itional-2"])
43
  end
44 45 46 47

  def test_route_recognition_unescapes_path_components
    options = { :controller => "controller",
                :action => "act#{@segment}ion",
48 49 50
                :variable => "var#{@segment}iable",
                :additional => ["add#{@segment}itional-1", "add#{@segment}itional-2"] }
    assert_equal options, @set.recognize_path("/controller/act#{@escaped}ion/var#{@escaped}iable/add#{@escaped}itional-1/add#{@escaped}itional-2")
51
  end
52 53 54 55 56 57 58

  def test_route_generation_allows_passing_non_string_values_to_generated_helper
    assert_equal "/controller/action/variable/1/2", @set.generate(:controller => "controller",
                                                                  :action => "action",
                                                                  :variable => "variable",
                                                                  :additional => [1, 2])
  end
59 60
end

61 62 63 64 65 66
class SegmentTest < Test::Unit::TestCase
  def test_first_segment_should_interpolate_for_structure
    s = ROUTING::Segment.new
    def s.interpolation_statement(array) 'hello' end
    assert_equal 'hello', s.continue_string_structure([])
  end
67

68
  def test_interpolation_statement
69
    s = ROUTING::StaticSegment.new("Hello")
70 71
    assert_equal "Hello", eval(s.interpolation_statement([]))
    assert_equal "HelloHello", eval(s.interpolation_statement([s]))
72

73
    s2 = ROUTING::StaticSegment.new("-")
74
    assert_equal "Hello-Hello", eval(s.interpolation_statement([s, s2]))
75

76
    s3 = ROUTING::StaticSegment.new("World")
77 78 79 80 81 82
    assert_equal "Hello-World", eval(s3.interpolation_statement([s, s2]))
  end
end

class StaticSegmentTest < Test::Unit::TestCase
  def test_interpolation_chunk_should_respect_raw
83 84
    s = ROUTING::StaticSegment.new('Hello World')
    assert !s.raw?
85 86
    assert_equal 'Hello%20World', s.interpolation_chunk

87
    s = ROUTING::StaticSegment.new('Hello World', :raw => true)
88
    assert s.raw?
89
    assert_equal 'Hello World', s.interpolation_chunk
90
  end
91

92
  def test_regexp_chunk_should_escape_specials
93
    s = ROUTING::StaticSegment.new('Hello*World')
94
    assert_equal 'Hello\*World', s.regexp_chunk
95

96
    s = ROUTING::StaticSegment.new('HelloWorld')
97 98
    assert_equal 'HelloWorld', s.regexp_chunk
  end
99

100
  def test_regexp_chunk_should_add_question_mark_for_optionals
101
    s = ROUTING::StaticSegment.new("/", :optional => true)
102
    assert_equal "/?", s.regexp_chunk
103

104
    s = ROUTING::StaticSegment.new("hello", :optional => true)
105 106 107 108 109
    assert_equal "(?:hello)?", s.regexp_chunk
  end
end

class DynamicSegmentTest < Test::Unit::TestCase
110
  def segment(options = {})
111
    unless @segment
112
      @segment = ROUTING::DynamicSegment.new(:a, options)
113 114 115
    end
    @segment
  end
116

117
  def test_extract_value
118
    s = ROUTING::DynamicSegment.new(:a)
119

120 121
    hash = {:a => '10', :b => '20'}
    assert_equal '10', eval(s.extract_value)
122

123 124
    hash = {:b => '20'}
    assert_equal nil, eval(s.extract_value)
125

126 127 128
    s.default = '20'
    assert_equal '20', eval(s.extract_value)
  end
129

130 131 132 133
  def test_default_local_name
    assert_equal 'a_value', segment.local_name,
      "Unexpected name -- all value_check tests will fail!"
  end
134

135 136 137 138
  def test_presence_value_check
    a_value = 10
    assert eval(segment.value_check)
  end
139

140
  def test_regexp_value_check_rejects_nil
141 142
    segment = segment(:regexp => /\d+/)

143
    a_value = nil
144
    assert !eval(segment.value_check)
145
  end
146

147
  def test_optional_regexp_value_check_should_accept_nil
148 149
    segment = segment(:regexp => /\d+/, :optional => true)

150 151 152
    a_value = nil
    assert eval(segment.value_check)
  end
153

154
  def test_regexp_value_check_rejects_no_match
155
    segment = segment(:regexp => /\d+/)
156

157
    a_value = "Hello20World"
158
    assert !eval(segment.value_check)
159

160
    a_value = "20Hi"
161
    assert !eval(segment.value_check)
162
  end
163

164
  def test_regexp_value_check_accepts_match
165
    segment = segment(:regexp => /\d+/)
166 167 168
    a_value = "30"
    assert eval(segment.value_check)
  end
169

170 171 172 173
  def test_value_check_fails_on_nil
    a_value = nil
    assert ! eval(segment.value_check)
  end
174

175
  def test_optional_value_needs_no_check
176 177
    segment = segment(:optional => true)

178 179 180
    a_value = nil
    assert_equal nil, segment.value_check
  end
181

182
  def test_regexp_value_check_should_accept_match_with_default
183
    segment = segment(:regexp => /\d+/, :default => '200')
184

185 186 187
    a_value = '100'
    assert eval(segment.value_check)
  end
188

189
  def test_expiry_should_not_trigger_once_expired
190
    expired = true
191 192 193
    hash = merged = {:a => 2, :b => 3}
    options = {:b => 3}
    expire_on = Hash.new { raise 'No!!!' }
194

195 196
    eval(segment.expiry_statement)
  rescue RuntimeError
197
    flunk "Expiry check should not have occurred!"
198
  end
199

200
  def test_expiry_should_occur_according_to_expire_on
201
    expired = false
202 203
    hash = merged = {:a => 2, :b => 3}
    options = {:b => 3}
204

205 206
    expire_on = {:b => true, :a => false}
    eval(segment.expiry_statement)
207
    assert !expired
208
    assert_equal({:a => 2, :b => 3}, hash)
209

210 211
    expire_on = {:b => true, :a => true}
    eval(segment.expiry_statement)
212
    assert expired
213 214
    assert_equal({:b => 3}, hash)
  end
215

216 217 218 219
  def test_extraction_code_should_return_on_nil
    hash = merged = {:b => 3}
    options = {:b => 3}
    a_value = nil
220

221 222 223
    # Local jump because of return inside eval.
    assert_raises(LocalJumpError) { eval(segment.extraction_code) }
  end
224

225
  def test_extraction_code_should_return_on_mismatch
226
    segment = segment(:regexp => /\d+/)
227 228 229
    hash = merged = {:a => 'Hi', :b => '3'}
    options = {:b => '3'}
    a_value = nil
230

231 232 233
    # Local jump because of return inside eval.
    assert_raises(LocalJumpError) { eval(segment.extraction_code) }
  end
234

235 236 237 238
  def test_extraction_code_should_accept_value_and_set_local
    hash = merged = {:a => 'Hi', :b => '3'}
    options = {:b => '3'}
    a_value = nil
239 240
    expired = true

241 242 243
    eval(segment.extraction_code)
    assert_equal 'Hi', a_value
  end
244

245 246 247 248 249
  def test_extraction_should_work_without_value_check
    segment.default = 'hi'
    hash = merged = {:b => '3'}
    options = {:b => '3'}
    a_value = nil
250
    expired = true
251

252 253 254
    eval(segment.extraction_code)
    assert_equal 'hi', a_value
  end
255

256
  def test_extraction_code_should_perform_expiry
257
    expired = false
258 259 260 261
    hash = merged = {:a => 'Hi', :b => '3'}
    options = {:b => '3'}
    expire_on = {:a => true}
    a_value = nil
262

263 264
    eval(segment.extraction_code)
    assert_equal 'Hi', a_value
265
    assert expired
266 267
    assert_equal options, hash
  end
268

269 270 271 272
  def test_interpolation_chunk_should_replace_value
    a_value = 'Hi'
    assert_equal a_value, eval(%("#{segment.interpolation_chunk}"))
  end
273

274 275 276 277
  def test_interpolation_chunk_should_accept_nil
    a_value = nil
    assert_equal '', eval(%("#{segment.interpolation_chunk('a_value')}"))
  end
278

279 280 281
  def test_value_regexp_should_be_nil_without_regexp
    assert_equal nil, segment.value_regexp
  end
282

283
  def test_value_regexp_should_match_exacly
284
    segment = segment(:regexp => /\d+/)
285 286 287 288 289
    assert_no_match segment.value_regexp, "Hello 10 World"
    assert_no_match segment.value_regexp, "Hello 10"
    assert_no_match segment.value_regexp, "10 World"
    assert_match segment.value_regexp, "10"
  end
290

291
  def test_regexp_chunk_should_return_string
292
    segment = segment(:regexp => /\d+/)
293 294
    assert_kind_of String, segment.regexp_chunk
  end
295

296
  def test_build_pattern_non_optional_with_no_captures
297
    # Non optional
298
    a_segment = ROUTING::DynamicSegment.new(nil, :regexp => /\d+/)
299 300 301 302
    assert_equal "(\\d+)stuff", a_segment.build_pattern('stuff')
  end

  def test_build_pattern_non_optional_with_captures
303
    # Non optional
304
    a_segment = ROUTING::DynamicSegment.new(nil, :regexp => /(\d+)(.*?)/)
305 306 307 308
    assert_equal "((\\d+)(.*?))stuff", a_segment.build_pattern('stuff')
  end

  def test_optionality_implied
309
    a_segment = ROUTING::DynamicSegment.new(:id)
310 311
    assert a_segment.optionality_implied?

312
    a_segment = ROUTING::DynamicSegment.new(:action)
313 314
    assert a_segment.optionality_implied?
  end
315 316

  def test_modifiers_must_be_handled_sensibly
317
    a_segment = ROUTING::DynamicSegment.new(nil, :regexp => /david|jamis/i)
318
    assert_equal "((?i-mx:david|jamis))stuff", a_segment.build_pattern('stuff')
319
    a_segment = ROUTING::DynamicSegment.new(nil, :regexp =>  /david|jamis/x)
320
    assert_equal "((?x-mi:david|jamis))stuff", a_segment.build_pattern('stuff')
321
    a_segment = ROUTING::DynamicSegment.new(nil, :regexp => /david|jamis/)
322 323
    assert_equal "(david|jamis)stuff", a_segment.build_pattern('stuff')
  end
324 325 326 327 328 329 330
end

class ControllerSegmentTest < Test::Unit::TestCase
  def test_regexp_should_only_match_possible_controllers
    ActionController::Routing.with_controllers %w(admin/accounts admin/users account pages) do
      cs = ROUTING::ControllerSegment.new :controller
      regexp = %r{\A#{cs.regexp_chunk}\Z}
331

332 333 334
      ActionController::Routing.possible_controllers.each do |name|
        assert_match regexp, name
        assert_no_match regexp, "#{name}_fake"
335

336 337 338 339 340 341 342
        match = regexp.match name
        assert_equal name, match[1]
      end
    end
  end
end

343 344 345
class RouteBuilderTest < Test::Unit::TestCase
  def builder
    @builder ||= ROUTING::RouteBuilder.new
346 347
  end

348 349
  def build(path, options)
    builder.build(path, options)
350 351
  end

352 353 354
  def test_options_should_not_be_modified
    requirements1 = { :id => /\w+/, :controller => /(?:[a-z](?:-?[a-z]+)*)/ }
    requirements2 = requirements1.dup
355

356
    assert_equal requirements1, requirements2
357

358 359 360
    with_options(:controller => 'folder',
                 :requirements => requirements2) do |m|
      m.build 'folders/new', :action => 'new'
361
    end
362

363
    assert_equal requirements1, requirements2
364 365
  end

366 367 368 369 370 371
  def test_segment_for_static
    segment, rest = builder.segment_for 'ulysses'
    assert_equal '', rest
    assert_kind_of ROUTING::StaticSegment, segment
    assert_equal 'ulysses', segment.value
  end
372

373 374 375 376 377 378 379
  def test_segment_for_action
    segment, rest = builder.segment_for ':action'
    assert_equal '', rest
    assert_kind_of ROUTING::DynamicSegment, segment
    assert_equal :action, segment.key
    assert_equal 'index', segment.default
  end
380

381 382 383 384 385 386 387 388
  def test_segment_for_dynamic
    segment, rest = builder.segment_for ':login'
    assert_equal '', rest
    assert_kind_of ROUTING::DynamicSegment, segment
    assert_equal :login, segment.key
    assert_equal nil, segment.default
    assert ! segment.optional?
  end
389

390 391 392 393 394 395 396 397 398 399 400
  def test_segment_for_with_rest
    segment, rest = builder.segment_for ':login/:action'
    assert_equal :login, segment.key
    assert_equal '/:action', rest
    segment, rest = builder.segment_for rest
    assert_equal '/', segment.value
    assert_equal ':action', rest
    segment, rest = builder.segment_for rest
    assert_equal :action, segment.key
    assert_equal '', rest
  end
401

402 403
  def test_segments_for
    segments = builder.segments_for_route_path '/:controller/:action/:id'
404

405 406
    assert_kind_of ROUTING::DividerSegment, segments[0]
    assert_equal '/', segments[2].value
407

408 409
    assert_kind_of ROUTING::DynamicSegment, segments[1]
    assert_equal :controller, segments[1].key
410

411 412
    assert_kind_of ROUTING::DividerSegment, segments[2]
    assert_equal '/', segments[2].value
413

414 415
    assert_kind_of ROUTING::DynamicSegment, segments[3]
    assert_equal :action, segments[3].key
416

417 418
    assert_kind_of ROUTING::DividerSegment, segments[4]
    assert_equal '/', segments[4].value
419

420 421 422
    assert_kind_of ROUTING::DynamicSegment, segments[5]
    assert_equal :id, segments[5].key
  end
423

424 425 426 427 428
  def test_segment_for_action
    s, r = builder.segment_for(':action/something/else')
    assert_equal '/something/else', r
    assert_equal :action, s.key
  end
429

430 431 432 433 434 435
  def test_action_default_should_not_trigger_on_prefix
    s, r = builder.segment_for ':action_name/something/else'
    assert_equal '/something/else', r
    assert_equal :action_name, s.key
    assert_equal nil, s.default
  end
436

437 438 439 440 441 442
  def test_divide_route_options
    segments = builder.segments_for_route_path '/cars/:action/:person/:car/'
    defaults, requirements = builder.divide_route_options(segments,
      :action => 'buy', :person => /\w+/, :car => /\w+/,
      :defaults => {:person => nil, :car => nil}
    )
443

444 445 446
    assert_equal({:action => 'buy', :person => nil, :car => nil}, defaults)
    assert_equal({:person => /\w+/, :car => /\w+/}, requirements)
  end
447

448 449 450 451
  def test_assign_route_options
    segments = builder.segments_for_route_path '/cars/:action/:person/:car/'
    defaults = {:action => 'buy', :person => nil, :car => nil}
    requirements = {:person => /\w+/, :car => /\w+/}
452

453 454
    route_requirements = builder.assign_route_options(segments, defaults, requirements)
    assert_equal({}, route_requirements)
455

456 457
    assert_equal :action, segments[3].key
    assert_equal 'buy', segments[3].default
458

459 460 461
    assert_equal :person, segments[5].key
    assert_equal %r/\w+/, segments[5].regexp
    assert segments[5].optional?
462

463 464 465 466
    assert_equal :car, segments[7].key
    assert_equal %r/\w+/, segments[7].regexp
    assert segments[7].optional?
  end
467

468 469 470 471
  def test_assign_route_options_with_anchor_chars
    segments = builder.segments_for_route_path '/cars/:action/:person/:car/'
    defaults = {:action => 'buy', :person => nil, :car => nil}
    requirements = {:person => /\w+/, :car => /^\w+$/}
472

473 474 475
    assert_raises ArgumentError do
      route_requirements = builder.assign_route_options(segments, defaults, requirements)
    end
476

477 478 479
    requirements[:car] = /[^\/]+/
    route_requirements = builder.assign_route_options(segments, defaults, requirements)
  end
480 481 482 483 484

  def test_optional_segments_preceding_required_segments
    segments = builder.segments_for_route_path '/cars/:action/:person/:car/'
    defaults = {:action => 'buy', :person => nil, :car => "model-t"}
    assert builder.assign_route_options(segments, defaults, {}).empty?
485

486 487
    0.upto(1) { |i| assert !segments[i].optional?, "segment #{i} is optional and it shouldn't be" }
    assert segments[2].optional?
488

489 490
    assert_equal nil, builder.warn_output # should only warn on the :person segment
  end
491

492 493 494 495 496 497
  def test_segmentation_of_dot_path
    segments = builder.segments_for_route_path '/books/:action.rss'
    assert builder.assign_route_options(segments, {}, {}).empty?
    assert_equal 6, segments.length # "/", "books", "/", ":action", ".", "rss"
    assert !segments.any? { |seg| seg.optional? }
  end
498

499 500 501 502 503 504 505
  def test_segmentation_of_dynamic_dot_path
    segments = builder.segments_for_route_path '/books/:action.:format'
    assert builder.assign_route_options(segments, {}, {}).empty?
    assert_equal 6, segments.length # "/", "books", "/", ":action", ".", ":format"
    assert !segments.any? { |seg| seg.optional? }
    assert_kind_of ROUTING::DynamicSegment, segments.last
  end
506

507 508 509
  def test_assignment_of_default_options
    segments = builder.segments_for_route_path '/:controller/:action/:id/'
    action, id = segments[-4], segments[-2]
510

511 512 513 514
    assert_equal :action, action.key
    assert_equal :id, id.key
    assert ! action.optional?
    assert ! id.optional?
515

516
    builder.assign_default_route_options(segments)
517

518 519 520 521
    assert_equal 'index', action.default
    assert action.optional?
    assert id.optional?
  end
522

523 524 525
  def test_assignment_of_default_options_respects_existing_defaults
    segments = builder.segments_for_route_path '/:controller/:action/:id/'
    action, id = segments[-4], segments[-2]
526

527 528 529 530
    assert_equal :action, action.key
    assert_equal :id, id.key
    action.default = 'show'
    action.is_optional = true
531

532 533
    id.default = 'Welcome'
    id.is_optional = true
534

535
    builder.assign_default_route_options(segments)
536

537 538 539 540 541
    assert_equal 'show', action.default
    assert action.optional?
    assert_equal 'Welcome', id.default
    assert id.optional?
  end
542

543 544 545
  def test_assignment_of_default_options_respects_regexps
    segments = builder.segments_for_route_path '/:controller/:action/:id/'
    action = segments[-4]
546

547
    assert_equal :action, action.key
548
    segments[-4] = ROUTING::DynamicSegment.new(:action, :regexp => /show|in/)
549

550
    builder.assign_default_route_options(segments)
551

552 553 554
    assert_equal nil, action.default
    assert ! action.optional?
  end
555

556 557 558 559 560 561 562
  def test_assignment_of_is_optional_when_default
    segments = builder.segments_for_route_path '/books/:action.rss'
    assert_equal segments[3].key, :action
    segments[3].default = 'changes'
    builder.ensure_required_segments(segments)
    assert ! segments[3].optional?
  end
563

564 565 566
  def test_is_optional_is_assigned_to_default_segments
    segments = builder.segments_for_route_path '/books/:action'
    builder.assign_route_options(segments, {:action => 'index'}, {})
567

568 569 570 571 572
    assert_equal segments[3].key, :action
    assert segments[3].optional?
    assert_kind_of ROUTING::DividerSegment, segments[2]
    assert segments[2].optional?
  end
573

574 575
  # XXX is optional not being set right?
  # /blah/:defaulted_segment <-- is the second slash optional? it should be.
576

577 578 579
  def test_route_build
    ActionController::Routing.with_controllers %w(users pages) do
      r = builder.build '/:controller/:action/:id/', :action => nil
580

581 582 583 584 585
      [0, 2, 4].each do |i|
        assert_kind_of ROUTING::DividerSegment, r.segments[i]
        assert_equal '/', r.segments[i].value
        assert r.segments[i].optional? if i > 1
      end
586

587 588 589
      assert_kind_of ROUTING::DynamicSegment, r.segments[1]
      assert_equal :controller, r.segments[1].key
      assert_equal nil, r.segments[1].default
590

591 592 593
      assert_kind_of ROUTING::DynamicSegment, r.segments[3]
      assert_equal :action, r.segments[3].key
      assert_equal 'index', r.segments[3].default
594

595 596 597 598 599
      assert_kind_of ROUTING::DynamicSegment, r.segments[5]
      assert_equal :id, r.segments[5].key
      assert r.segments[5].optional?
    end
  end
600

601 602 603 604 605 606 607 608 609 610 611 612 613 614 615
  def test_slashes_are_implied
    routes = [
      builder.build('/:controller/:action/:id/', :action => nil),
      builder.build('/:controller/:action/:id', :action => nil),
      builder.build(':controller/:action/:id', :action => nil),
      builder.build('/:controller/:action/:id/', :action => nil)
    ]
    expected = routes.first.segments.length
    routes.each_with_index do |route, i|
      found = route.segments.length
      assert_equal expected, found, "Route #{i + 1} has #{found} segments, expected #{expected}"
    end
  end
end

616 617 618
class RoutingTest < Test::Unit::TestCase
  def test_possible_controllers
    true_controller_paths = ActionController::Routing.controller_paths
619

620
    ActionController::Routing.use_controllers! nil
621

622 623 624
    silence_warnings do
      Object.send(:const_set, :RAILS_ROOT, File.dirname(__FILE__) + '/controller_fixtures')
    end
625

626 627 628
    ActionController::Routing.controller_paths = [
      RAILS_ROOT, RAILS_ROOT + '/app/controllers', RAILS_ROOT + '/vendor/plugins/bad_plugin/lib'
    ]
629

630 631 632 633 634 635 636
    assert_equal ["admin/user", "plugin", "user"], ActionController::Routing.possible_controllers.sort
  ensure
    if true_controller_paths
      ActionController::Routing.controller_paths = true_controller_paths
    end
    ActionController::Routing.use_controllers! nil
    Object.send(:remove_const, :RAILS_ROOT) rescue nil
637 638
  end

639 640 641
  def test_possible_controllers_are_reset_on_each_load
    true_possible_controllers = ActionController::Routing.possible_controllers
    true_controller_paths = ActionController::Routing.controller_paths
642

643 644
    ActionController::Routing.use_controllers! nil
    root = File.dirname(__FILE__) + '/controller_fixtures'
645

646 647
    ActionController::Routing.controller_paths = []
    assert_equal [], ActionController::Routing.possible_controllers
648

649 650 651
    ActionController::Routing.controller_paths = [
      root, root + '/app/controllers', root + '/vendor/plugins/bad_plugin/lib'
    ]
652
    ActionController::Routing::Routes.load!
653

654 655 656 657 658
    assert_equal ["admin/user", "plugin", "user"], ActionController::Routing.possible_controllers.sort
  ensure
    ActionController::Routing.controller_paths = true_controller_paths
    ActionController::Routing.use_controllers! true_possible_controllers
    Object.send(:remove_const, :RAILS_ROOT) rescue nil
659

660 661
    ActionController::Routing::Routes.clear!
    ActionController::Routing::Routes.load_routes!
662 663
  end

664 665 666 667 668 669
  def test_with_controllers
    c = %w(admin/accounts admin/users account pages)
    ActionController::Routing.with_controllers c do
      assert_equal c, ActionController::Routing.possible_controllers
    end
  end
670

671 672 673 674 675
  def test_normalize_unix_paths
    load_paths = %w(. config/../app/controllers config/../app//helpers script/../config/../vendor/rails/actionpack/lib vendor/rails/railties/builtin/rails_info app/models lib script/../config/../foo/bar/../../app/models .foo/../.bar foo.bar/../config)
    paths = ActionController::Routing.normalize_paths(load_paths)
    assert_equal %w(vendor/rails/railties/builtin/rails_info vendor/rails/actionpack/lib app/controllers app/helpers app/models config .bar lib .), paths
  end
676

677 678 679 680
  def test_normalize_windows_paths
    load_paths = %w(. config\\..\\app\\controllers config\\..\\app\\\\helpers script\\..\\config\\..\\vendor\\rails\\actionpack\\lib vendor\\rails\\railties\\builtin\\rails_info app\\models lib script\\..\\config\\..\\foo\\bar\\..\\..\\app\\models .foo\\..\\.bar foo.bar\\..\\config)
    paths = ActionController::Routing.normalize_paths(load_paths)
    assert_equal %w(vendor\\rails\\railties\\builtin\\rails_info vendor\\rails\\actionpack\\lib app\\controllers app\\helpers app\\models config .bar lib .), paths
681 682
  end

683 684
  def test_routing_helper_module
    assert_kind_of Module, ActionController::Routing::Helpers
685

686 687 688 689 690
    h = ActionController::Routing::Helpers
    c = Class.new
    assert ! c.ancestors.include?(h)
    ActionController::Routing::Routes.install_helpers c
    assert c.ancestors.include?(h)
691
  end
692
end
693

694 695 696
uses_mocha 'LegacyRouteSet, Route, RouteSet and RouteLoading' do
  class MockController
    attr_accessor :routes
697

698 699 700
    def initialize(routes)
      self.routes = routes
    end
701

702 703
    def url_for(options)
      only_path = options.delete(:only_path)
704

705 706
      port        = options.delete(:port) || 80
      port_string = port == 80 ? '' : ":#{port}"
707

708
      protocol = options.delete(:protocol) || "http"
709
      host     = options.delete(:host) || "test.host"
710
      anchor   = "##{options.delete(:anchor)}" if options.key?(:anchor)
711

712
      path = routes.generate(options)
713

714
      only_path ? "#{path}#{anchor}" : "#{protocol}://#{host}#{port_string}#{path}#{anchor}"
715
    end
716

717
    def request
718
      @request ||= ActionController::TestRequest.new
719 720
    end
  end
721

722 723 724 725 726 727 728 729 730 731
  class LegacyRouteSetTests < Test::Unit::TestCase
    attr_reader :rs

    def setup
      # These tests assume optimisation is on, so re-enable it.
      ActionController::Base.optimise_named_routes = true

      @rs = ::ActionController::Routing::RouteSet.new

      ActionController::Routing.use_controllers! %w(content admin/user admin/news_feed)
732
    end
733 734 735 736
    
    def teardown
      @rs.clear!
    end
737

738
    def test_default_setup
739
      @rs.draw {|m| m.connect ':controller/:action/:id' }
740 741 742
      assert_equal({:controller => "content", :action => 'index'}, rs.recognize_path("/content"))
      assert_equal({:controller => "content", :action => 'list'}, rs.recognize_path("/content/list"))
      assert_equal({:controller => "content", :action => 'show', :id => '10'}, rs.recognize_path("/content/show/10"))
743

744
      assert_equal({:controller => "admin/user", :action => 'show', :id => '10'}, rs.recognize_path("/admin/user/show/10"))
745

746 747 748 749 750 751 752
      assert_equal '/admin/user/show/10', rs.generate(:controller => 'admin/user', :action => 'show', :id => 10)

      assert_equal '/admin/user/show', rs.generate({:action => 'show'}, {:controller => 'admin/user', :action => 'list', :id => '10'})
      assert_equal '/admin/user/list/10', rs.generate({}, {:controller => 'admin/user', :action => 'list', :id => '10'})

      assert_equal '/admin/stuff', rs.generate({:controller => 'stuff'}, {:controller => 'admin/user', :action => 'list', :id => '10'})
      assert_equal '/stuff', rs.generate({:controller => '/stuff'}, {:controller => 'admin/user', :action => 'list', :id => '10'})
753 754
    end

755
    def test_ignores_leading_slash
756
      @rs.clear!
757 758
      @rs.draw {|m| m.connect '/:controller/:action/:id'}
      test_default_setup
759
    end
760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805

    def test_time_recognition
      # We create many routes to make situation more realistic
      @rs = ::ActionController::Routing::RouteSet.new
      @rs.draw { |map|
        map.frontpage '', :controller => 'search', :action => 'new'
        map.resources :videos do |video|
          video.resources :comments
          video.resource  :file,      :controller => 'video_file'
          video.resource  :share,     :controller => 'video_shares'
          video.resource  :abuse,     :controller => 'video_abuses'
        end
        map.resources :abuses, :controller => 'video_abuses'
        map.resources :video_uploads
        map.resources :video_visits

        map.resources :users do |user|
          user.resource  :settings
          user.resources :videos
        end
        map.resources :channels do |channel|
          channel.resources :videos, :controller => 'channel_videos'
        end
        map.resource  :session
        map.resource  :lost_password
        map.search    'search', :controller => 'search'
        map.resources :pages
        map.connect ':controller/:action/:id'
      }
      n = 1000
      if RunTimeTests
        GC.start
        rectime = Benchmark.realtime do
          n.times do
            rs.recognize_path("/videos/1234567", {:method => :get})
            rs.recognize_path("/videos/1234567/abuse", {:method => :get})
            rs.recognize_path("/users/1234567/settings", {:method => :get})
            rs.recognize_path("/channels/1234567", {:method => :get})
            rs.recognize_path("/session/new", {:method => :get})
            rs.recognize_path("/admin/user/show/10", {:method => :get})
          end
        end
        puts "\n\nRecognition (#{rs.routes.size} routes):"
        per_url = rectime / (n * 6)
        puts "#{per_url * 1000} ms/url"
        puts "#{1 / per_url} url/s\n\n"
806 807
      end
    end
J
Joshua Peek 已提交
808

809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833
    def test_time_generation
      n = 5000
      if RunTimeTests
        GC.start
        pairs = [
          [{:controller => 'content', :action => 'index'}, {:controller => 'content', :action => 'show'}],
          [{:controller => 'content'}, {:controller => 'content', :action => 'index'}],
          [{:controller => 'content', :action => 'list'}, {:controller => 'content', :action => 'index'}],
          [{:controller => 'content', :action => 'show', :id => '10'}, {:controller => 'content', :action => 'list'}],
          [{:controller => 'admin/user', :action => 'index'}, {:controller => 'admin/user', :action => 'show'}],
          [{:controller => 'admin/user'}, {:controller => 'admin/user', :action => 'index'}],
          [{:controller => 'admin/user', :action => 'list'}, {:controller => 'admin/user', :action => 'index'}],
          [{:controller => 'admin/user', :action => 'show', :id => '10'}, {:controller => 'admin/user', :action => 'list'}],
        ]
        p = nil
        gentime = Benchmark.realtime do
          n.times do
          pairs.each {|(a, b)| rs.generate(a, b)}
          end
        end

        puts "\n\nGeneration (RouteSet): (#{(n * 8)} urls)"
        per_url = gentime / (n * 8)
        puts "#{per_url * 1000} ms/url"
        puts "#{1 / per_url} url/s\n\n"
834 835
      end
    end
836 837 838 839 840

    def test_route_with_colon_first
      rs.draw do |map|
        map.connect '/:controller/:action/:id', :action => 'index', :id => nil
        map.connect ':url', :controller => 'tiny_url', :action => 'translate'
841 842
      end
    end
843 844 845 846 847

    def test_route_with_regexp_for_controller
      rs.draw do |map|
        map.connect ':controller/:admintoken/:action/:id', :controller => /admin\/.+/
        map.connect ':controller/:action/:id'
848
      end
849 850 851 852 853
      assert_equal({:controller => "admin/user", :admintoken => "foo", :action => "index"},
          rs.recognize_path("/admin/user/foo"))
      assert_equal({:controller => "content", :action => "foo"}, rs.recognize_path("/content/foo"))
      assert_equal '/admin/user/foo', rs.generate(:controller => "admin/user", :admintoken => "foo", :action => "index")
      assert_equal '/content/foo', rs.generate(:controller => "content", :action => "foo")
854
    end
855 856 857 858 859 860 861 862

    def test_route_with_regexp_and_dot
      rs.draw do |map|
        map.connect ':controller/:action/:file',
                          :controller => /admin|user/,
                          :action => /upload|download/,
                          :defaults => {:file => nil},
                          :requirements => {:file => %r{[^/]+(\.[^/]+)?}}
863
      end
864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882
      # Without a file extension
      assert_equal '/user/download/file',
        rs.generate(:controller => "user", :action => "download", :file => "file")
      assert_equal(
        {:controller => "user", :action => "download", :file => "file"},
        rs.recognize_path("/user/download/file"))

      # Now, let's try a file with an extension, really a dot (.)
      assert_equal '/user/download/file.jpg',
        rs.generate(
          :controller => "user", :action => "download", :file => "file.jpg")
      assert_equal(
        {:controller => "user", :action => "download", :file => "file.jpg"},
        rs.recognize_path("/user/download/file.jpg"))
    end

    def test_basic_named_route
      rs.add_named_route :home, '', :controller => 'content', :action => 'list'
      x = setup_for_named_route
883
      assert_equal("http://test.host/",
884
                   x.send(:home_url))
885
    end
886

887 888 889
    def test_basic_named_route_with_relative_url_root
      rs.add_named_route :home, '', :controller => 'content', :action => 'list'
      x = setup_for_named_route
890
      ActionController::Base.relative_url_root = "/foo"
891
      assert_equal("http://test.host/foo/",
892 893
                   x.send(:home_url))
      assert_equal "/foo/", x.send(:home_path)
894
      ActionController::Base.relative_url_root = nil
895
    end
896

897 898 899
    def test_named_route_with_option
      rs.add_named_route :page, 'page/:title', :controller => 'content', :action => 'show_page'
      x = setup_for_named_route
900
      assert_equal("http://test.host/page/new%20stuff",
901
                   x.send(:page_url, :title => 'new stuff'))
902 903
    end

904 905 906
    def test_named_route_with_default
      rs.add_named_route :page, 'page/:title', :controller => 'content', :action => 'show_page', :title => 'AboutPage'
      x = setup_for_named_route
907
      assert_equal("http://test.host/page/AboutRails",
908
                   x.send(:page_url, :title => "AboutRails"))
909

910
    end
911

912 913 914
    def test_named_route_with_name_prefix
      rs.add_named_route :page, 'page', :controller => 'content', :action => 'show_page', :name_prefix => 'my_'
      x = setup_for_named_route
915
      assert_equal("http://test.host/page",
916 917 918 919 920 921
                   x.send(:my_page_url))
    end

    def test_named_route_with_path_prefix
      rs.add_named_route :page, 'page', :controller => 'content', :action => 'show_page', :path_prefix => 'my'
      x = setup_for_named_route
922
      assert_equal("http://test.host/my/page",
923 924 925
                   x.send(:page_url))
    end

926 927 928
    def test_named_route_with_nested_controller
      rs.add_named_route :users, 'admin/user', :controller => 'admin/user', :action => 'index'
      x = setup_for_named_route
929
      assert_equal("http://test.host/admin/user",
930 931
                   x.send(:users_url))
    end
932

933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967
    def test_optimised_named_route_call_never_uses_url_for
      rs.add_named_route :users, 'admin/user', :controller => '/admin/user', :action => 'index'
      rs.add_named_route :user, 'admin/user/:id', :controller=>'/admin/user', :action=>'show'
      x = setup_for_named_route
      x.expects(:url_for).never
      x.send(:users_url)
      x.send(:users_path)
      x.send(:user_url, 2, :foo=>"bar")
      x.send(:user_path, 3, :bar=>"foo")
    end

    def test_optimised_named_route_with_host
      rs.add_named_route :pages, 'pages', :controller => 'content', :action => 'show_page', :host => 'foo.com'
      x = setup_for_named_route
      x.expects(:url_for).with(:host => 'foo.com', :only_path => false, :controller => 'content', :action => 'show_page', :use_route => :pages).once
      x.send(:pages_url)
    end

    def setup_for_named_route
      klass = Class.new(MockController)
      rs.install_helpers(klass)
      klass.new(rs)
    end

    def test_named_route_without_hash
      rs.draw do |map|
        map.normal ':controller/:action/:id'
      end
    end

    def test_named_route_root
      rs.draw do |map|
        map.root :controller => "hello"
      end
      x = setup_for_named_route
968
      assert_equal("http://test.host/", x.send(:root_url))
969 970 971 972 973 974 975 976 977 978 979 980 981 982 983
      assert_equal("/", x.send(:root_path))
    end

    def test_named_route_with_regexps
      rs.draw do |map|
        map.article 'page/:year/:month/:day/:title', :controller => 'page', :action => 'show',
          :year => /\d+/, :month => /\d+/, :day => /\d+/
        map.connect ':controller/:action/:id'
      end
      x = setup_for_named_route
      # assert_equal(
      #   {:controller => 'page', :action => 'show', :title => 'hi', :use_route => :article, :only_path => false},
      #   x.send(:article_url, :title => 'hi')
      # )
      assert_equal(
984
        "http://test.host/page/2005/6/10/hi",
985 986 987 988 989
        x.send(:article_url, :title => 'hi', :day => 10, :year => 2005, :month => 6)
      )
    end

    def test_changing_controller
990 991
      @rs.draw {|m| m.connect ':controller/:action/:id' }

992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144
      assert_equal '/admin/stuff/show/10', rs.generate(
        {:controller => 'stuff', :action => 'show', :id => 10},
        {:controller => 'admin/user', :action => 'index'}
      )
    end

    def test_paths_escaped
      rs.draw do |map|
        map.path 'file/*path', :controller => 'content', :action => 'show_file'
        map.connect ':controller/:action/:id'
      end

      # No + to space in URI escaping, only for query params.
      results = rs.recognize_path "/file/hello+world/how+are+you%3F"
      assert results, "Recognition should have succeeded"
      assert_equal ['hello+world', 'how+are+you?'], results[:path]

      # Use %20 for space instead.
      results = rs.recognize_path "/file/hello%20world/how%20are%20you%3F"
      assert results, "Recognition should have succeeded"
      assert_equal ['hello world', 'how are you?'], results[:path]

      results = rs.recognize_path "/file"
      assert results, "Recognition should have succeeded"
      assert_equal [], results[:path]
    end

    def test_paths_slashes_unescaped_with_ordered_parameters
      rs.add_named_route :path, '/file/*path', :controller => 'content'

      # No / to %2F in URI, only for query params.
      x = setup_for_named_route
      assert_equal("/file/hello/world", x.send(:path_path, 'hello/world'))
    end

    def test_non_controllers_cannot_be_matched
      rs.draw do |map|
        map.connect ':controller/:action/:id'
      end
      assert_raises(ActionController::RoutingError) { rs.recognize_path("/not_a/show/10") }
    end

    def test_paths_do_not_accept_defaults
      assert_raises(ActionController::RoutingError) do
        rs.draw do |map|
          map.path 'file/*path', :controller => 'content', :action => 'show_file', :path => %w(fake default)
          map.connect ':controller/:action/:id'
        end
      end

      rs.draw do |map|
        map.path 'file/*path', :controller => 'content', :action => 'show_file', :path => []
        map.connect ':controller/:action/:id'
      end
    end

    def test_should_list_options_diff_when_routing_requirements_dont_match
      rs.draw do |map|
        map.post 'post/:id', :controller=> 'post', :action=> 'show', :requirements => {:id => /\d+/}
      end
      exception = assert_raise(ActionController::RoutingError) { rs.generate(:controller => 'post', :action => 'show', :bad_param => "foo", :use_route => "post") }
      assert_match /^post_url failed to generate/, exception.message
      from_match = exception.message.match(/from \{[^\}]+\}/).to_s
      assert_match /:bad_param=>"foo"/,   from_match
      assert_match /:action=>"show"/,     from_match
      assert_match /:controller=>"post"/, from_match

      expected_match = exception.message.match(/expected: \{[^\}]+\}/).to_s
      assert_no_match /:bad_param=>"foo"/,   expected_match
      assert_match    /:action=>"show"/,     expected_match
      assert_match    /:controller=>"post"/, expected_match

      diff_match = exception.message.match(/diff: \{[^\}]+\}/).to_s
      assert_match    /:bad_param=>"foo"/,   diff_match
      assert_no_match /:action=>"show"/,     diff_match
      assert_no_match /:controller=>"post"/, diff_match
    end

    # this specifies the case where your formerly would get a very confusing error message with an empty diff
    def test_should_have_better_error_message_when_options_diff_is_empty
      rs.draw do |map|
        map.content '/content/:query', :controller => 'content', :action => 'show'
      end

      exception = assert_raise(ActionController::RoutingError) { rs.generate(:controller => 'content', :action => 'show', :use_route => "content") }
      assert_match %r[:action=>"show"], exception.message
      assert_match %r[:controller=>"content"], exception.message
      assert_match %r[you may have ambiguous routes, or you may need to supply additional parameters for this route], exception.message
      assert_match %r[content_url has the following required parameters: \["content", :query\] - are they all satisfied?], exception.message
    end

    def test_dynamic_path_allowed
      rs.draw do |map|
        map.connect '*path', :controller => 'content', :action => 'show_file'
      end

      assert_equal '/pages/boo', rs.generate(:controller => 'content', :action => 'show_file', :path => %w(pages boo))
    end

    def test_dynamic_recall_paths_allowed
      rs.draw do |map|
        map.connect '*path', :controller => 'content', :action => 'show_file'
      end

      recall_path = ActionController::Routing::PathSegment::Result.new(%w(pages boo))
      assert_equal '/pages/boo', rs.generate({}, :controller => 'content', :action => 'show_file', :path => recall_path)
    end

    def test_backwards
      rs.draw do |map|
        map.connect 'page/:id/:action', :controller => 'pages', :action => 'show'
        map.connect ':controller/:action/:id'
      end

      assert_equal '/page/20', rs.generate({:id => 20}, {:controller => 'pages', :action => 'show'})
      assert_equal '/page/20', rs.generate(:controller => 'pages', :id => 20, :action => 'show')
      assert_equal '/pages/boo', rs.generate(:controller => 'pages', :action => 'boo')
    end

    def test_route_with_fixnum_default
      rs.draw do |map|
        map.connect 'page/:id', :controller => 'content', :action => 'show_page', :id => 1
        map.connect ':controller/:action/:id'
      end

      assert_equal '/page', rs.generate(:controller => 'content', :action => 'show_page')
      assert_equal '/page', rs.generate(:controller => 'content', :action => 'show_page', :id => 1)
      assert_equal '/page', rs.generate(:controller => 'content', :action => 'show_page', :id => '1')
      assert_equal '/page/10', rs.generate(:controller => 'content', :action => 'show_page', :id => 10)

      assert_equal({:controller => "content", :action => 'show_page', :id => '1'}, rs.recognize_path("/page"))
      assert_equal({:controller => "content", :action => 'show_page', :id => '1'}, rs.recognize_path("/page/1"))
      assert_equal({:controller => "content", :action => 'show_page', :id => '10'}, rs.recognize_path("/page/10"))
    end

    # For newer revision
    def test_route_with_text_default
      rs.draw do |map|
        map.connect 'page/:id', :controller => 'content', :action => 'show_page', :id => 1
        map.connect ':controller/:action/:id'
      end

      assert_equal '/page/foo', rs.generate(:controller => 'content', :action => 'show_page', :id => 'foo')
      assert_equal({:controller => "content", :action => 'show_page', :id => 'foo'}, rs.recognize_path("/page/foo"))

      token = "\321\202\320\265\320\272\321\201\321\202" # 'text' in russian
      escaped_token = CGI::escape(token)

      assert_equal '/page/' + escaped_token, rs.generate(:controller => 'content', :action => 'show_page', :id => token)
      assert_equal({:controller => "content", :action => 'show_page', :id => token}, rs.recognize_path("/page/#{escaped_token}"))
    end

    def test_action_expiry
1145
      @rs.draw {|m| m.connect ':controller/:action/:id' }
1146 1147 1148 1149
      assert_equal '/content', rs.generate({:controller => 'content'}, {:controller => 'content', :action => 'show'})
    end

    def test_recognition_with_uppercase_controller_name
1150
      @rs.draw {|m| m.connect ':controller/:action/:id' }
1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184
      assert_equal({:controller => "content", :action => 'index'}, rs.recognize_path("/Content"))
      assert_equal({:controller => "content", :action => 'list'}, rs.recognize_path("/ConTent/list"))
      assert_equal({:controller => "content", :action => 'show', :id => '10'}, rs.recognize_path("/CONTENT/show/10"))

      # these used to work, before the routes rewrite, but support for this was pulled in the new version...
      #assert_equal({'controller' => "admin/news_feed", 'action' => 'index'}, rs.recognize_path("Admin/NewsFeed"))
      #assert_equal({'controller' => "admin/news_feed", 'action' => 'index'}, rs.recognize_path("Admin/News_Feed"))
    end

    def test_requirement_should_prevent_optional_id
      rs.draw do |map|
        map.post 'post/:id', :controller=> 'post', :action=> 'show', :requirements => {:id => /\d+/}
      end

      assert_equal '/post/10', rs.generate(:controller => 'post', :action => 'show', :id => 10)

      assert_raises ActionController::RoutingError do
        rs.generate(:controller => 'post', :action => 'show')
      end
    end

    def test_both_requirement_and_optional
      rs.draw do |map|
        map.blog('test/:year', :controller => 'post', :action => 'show',
          :defaults => { :year => nil },
          :requirements => { :year => /\d{4}/ }
        )
        map.connect ':controller/:action/:id'
      end

      assert_equal '/test', rs.generate(:controller => 'post', :action => 'show')
      assert_equal '/test', rs.generate(:controller => 'post', :action => 'show', :year => nil)

      x = setup_for_named_route
1185
      assert_equal("http://test.host/test",
1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231
                   x.send(:blog_url))
    end

    def test_set_to_nil_forgets
      rs.draw do |map|
        map.connect 'pages/:year/:month/:day', :controller => 'content', :action => 'list_pages', :month => nil, :day => nil
        map.connect ':controller/:action/:id'
      end

      assert_equal '/pages/2005',
        rs.generate(:controller => 'content', :action => 'list_pages', :year => 2005)
      assert_equal '/pages/2005/6',
        rs.generate(:controller => 'content', :action => 'list_pages', :year => 2005, :month => 6)
      assert_equal '/pages/2005/6/12',
        rs.generate(:controller => 'content', :action => 'list_pages', :year => 2005, :month => 6, :day => 12)

      assert_equal '/pages/2005/6/4',
        rs.generate({:day => 4}, {:controller => 'content', :action => 'list_pages', :year => '2005', :month => '6', :day => '12'})

      assert_equal '/pages/2005/6',
        rs.generate({:day => nil}, {:controller => 'content', :action => 'list_pages', :year => '2005', :month => '6', :day => '12'})

      assert_equal '/pages/2005',
        rs.generate({:day => nil, :month => nil}, {:controller => 'content', :action => 'list_pages', :year => '2005', :month => '6', :day => '12'})
    end

    def test_url_with_no_action_specified
      rs.draw do |map|
        map.connect '', :controller => 'content'
        map.connect ':controller/:action/:id'
      end

      assert_equal '/', rs.generate(:controller => 'content', :action => 'index')
      assert_equal '/', rs.generate(:controller => 'content')
    end

    def test_named_url_with_no_action_specified
      rs.draw do |map|
        map.home '', :controller => 'content'
        map.connect ':controller/:action/:id'
      end

      assert_equal '/', rs.generate(:controller => 'content', :action => 'index')
      assert_equal '/', rs.generate(:controller => 'content')

      x = setup_for_named_route
1232
      assert_equal("http://test.host/",
1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302
                   x.send(:home_url))
    end

    def test_url_generated_when_forgetting_action
      [{:controller => 'content', :action => 'index'}, {:controller => 'content'}].each do |hash|
        rs.draw do |map|
          map.home '', hash
          map.connect ':controller/:action/:id'
        end
        assert_equal '/', rs.generate({:action => nil}, {:controller => 'content', :action => 'hello'})
        assert_equal '/', rs.generate({:controller => 'content'})
        assert_equal '/content/hi', rs.generate({:controller => 'content', :action => 'hi'})
      end
    end

    def test_named_route_method
      rs.draw do |map|
        map.categories 'categories', :controller => 'content', :action => 'categories'
        map.connect ':controller/:action/:id'
      end

      assert_equal '/categories', rs.generate(:controller => 'content', :action => 'categories')
      assert_equal '/content/hi', rs.generate({:controller => 'content', :action => 'hi'})
    end

    def test_named_routes_array
      test_named_route_method
      assert_equal [:categories], rs.named_routes.names
    end

    def test_nil_defaults
      rs.draw do |map|
        map.connect 'journal',
          :controller => 'content',
          :action => 'list_journal',
          :date => nil, :user_id => nil
        map.connect ':controller/:action/:id'
      end

      assert_equal '/journal', rs.generate(:controller => 'content', :action => 'list_journal', :date => nil, :user_id => nil)
    end

    def setup_request_method_routes_for(method)
      @request = ActionController::TestRequest.new
      @request.env["REQUEST_METHOD"] = method
      @request.request_uri = "/match"

      rs.draw do |r|
        r.connect '/match', :controller => 'books', :action => 'get', :conditions => { :method => :get }
        r.connect '/match', :controller => 'books', :action => 'post', :conditions => { :method => :post }
        r.connect '/match', :controller => 'books', :action => 'put', :conditions => { :method => :put }
        r.connect '/match', :controller => 'books', :action => 'delete', :conditions => { :method => :delete }
      end
    end

    %w(GET POST PUT DELETE).each do |request_method|
      define_method("test_request_method_recognized_with_#{request_method}") do
        begin
          Object.const_set(:BooksController, Class.new(ActionController::Base))

          setup_request_method_routes_for(request_method)

          assert_nothing_raised { rs.recognize(@request) }
          assert_equal request_method.downcase, @request.path_parameters[:action]
        ensure
          Object.send(:remove_const, :BooksController) rescue nil
        end
      end
    end

1303
    def test_recognize_array_of_methods
J
Jeremy Kemper 已提交
1304 1305 1306 1307
      Object.const_set(:BooksController, Class.new(ActionController::Base))
      rs.draw do |r|
        r.connect '/match', :controller => 'books', :action => 'get_or_post', :conditions => { :method => [:get, :post] }
        r.connect '/match', :controller => 'books', :action => 'not_get_or_post'
1308 1309
      end

J
Jeremy Kemper 已提交
1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325
      @request = ActionController::TestRequest.new
      @request.env["REQUEST_METHOD"] = 'POST'
      @request.request_uri = "/match"
      assert_nothing_raised { rs.recognize(@request) }
      assert_equal 'get_or_post', @request.path_parameters[:action]

      # have to recreate or else the RouteSet uses a cached version:
      @request = ActionController::TestRequest.new
      @request.env["REQUEST_METHOD"] = 'PUT'
      @request.request_uri = "/match"
      assert_nothing_raised { rs.recognize(@request) }
      assert_equal 'not_get_or_post', @request.path_parameters[:action]
    ensure
      Object.send(:remove_const, :BooksController) rescue nil
    end

1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380
    def test_subpath_recognized
      Object.const_set(:SubpathBooksController, Class.new(ActionController::Base))

      rs.draw do |r|
        r.connect '/books/:id/edit', :controller => 'subpath_books', :action => 'edit'
        r.connect '/items/:id/:action', :controller => 'subpath_books'
        r.connect '/posts/new/:action', :controller => 'subpath_books'
        r.connect '/posts/:id', :controller => 'subpath_books', :action => "show"
      end

      hash = rs.recognize_path "/books/17/edit"
      assert_not_nil hash
      assert_equal %w(subpath_books 17 edit), [hash[:controller], hash[:id], hash[:action]]

      hash = rs.recognize_path "/items/3/complete"
      assert_not_nil hash
      assert_equal %w(subpath_books 3 complete), [hash[:controller], hash[:id], hash[:action]]

      hash = rs.recognize_path "/posts/new/preview"
      assert_not_nil hash
      assert_equal %w(subpath_books preview), [hash[:controller], hash[:action]]

      hash = rs.recognize_path "/posts/7"
      assert_not_nil hash
      assert_equal %w(subpath_books show 7), [hash[:controller], hash[:action], hash[:id]]
    ensure
      Object.send(:remove_const, :SubpathBooksController) rescue nil
    end

    def test_subpath_generated
      Object.const_set(:SubpathBooksController, Class.new(ActionController::Base))

      rs.draw do |r|
        r.connect '/books/:id/edit', :controller => 'subpath_books', :action => 'edit'
        r.connect '/items/:id/:action', :controller => 'subpath_books'
        r.connect '/posts/new/:action', :controller => 'subpath_books'
      end

      assert_equal "/books/7/edit", rs.generate(:controller => "subpath_books", :id => 7, :action => "edit")
      assert_equal "/items/15/complete", rs.generate(:controller => "subpath_books", :id => 15, :action => "complete")
      assert_equal "/posts/new/preview", rs.generate(:controller => "subpath_books", :action => "preview")
    ensure
      Object.send(:remove_const, :SubpathBooksController) rescue nil
    end

    def test_failed_requirements_raises_exception_with_violated_requirements
      rs.draw do |r|
        r.foo_with_requirement 'foos/:id', :controller=>'foos', :requirements=>{:id=>/\d+/}
      end

      x = setup_for_named_route
      assert_raises(ActionController::RoutingError) do
        x.send(:foo_with_requirement_url, "I am Against the requirements")
      end
    end
1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410

    def test_routes_changed_correctly_after_clear
      ActionController::Base.optimise_named_routes = true
      rs = ::ActionController::Routing::RouteSet.new
      rs.draw do |r|
        r.connect 'ca', :controller => 'ca', :action => "aa"
        r.connect 'cb', :controller => 'cb', :action => "ab"
        r.connect 'cc', :controller => 'cc', :action => "ac"
        r.connect ':controller/:action/:id'
        r.connect ':controller/:action/:id.:format'
      end

      hash = rs.recognize_path "/cc"

      assert_not_nil hash
      assert_equal %w(cc ac), [hash[:controller], hash[:action]]

      rs.draw do |r|
        r.connect 'cb', :controller => 'cb', :action => "ab"
        r.connect 'cc', :controller => 'cc', :action => "ac"
        r.connect ':controller/:action/:id'
        r.connect ':controller/:action/:id.:format'
      end

      hash = rs.recognize_path "/cc"

      assert_not_nil hash
      assert_equal %w(cc ac), [hash[:controller], hash[:action]]

    end
1411 1412 1413 1414 1415 1416 1417 1418
  end

  class RouteTest < Test::Unit::TestCase
    def setup
      @route = ROUTING::Route.new
    end

    def slash_segment(is_optional = false)
1419
      ROUTING::DividerSegment.new('/', :optional => is_optional)
1420 1421 1422 1423
    end

    def default_route
      unless defined?(@default_route)
1424 1425 1426 1427 1428 1429 1430 1431 1432
        segments = []
        segments << ROUTING::StaticSegment.new('/', :raw => true)
        segments << ROUTING::DynamicSegment.new(:controller)
        segments << slash_segment(:optional)
        segments << ROUTING::DynamicSegment.new(:action, :default => 'index', :optional => true)
        segments << slash_segment(:optional)
        segments << ROUTING::DynamicSegment.new(:id, :optional => true)
        segments << slash_segment(:optional)
        @default_route = ROUTING::Route.new(segments).freeze
1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519
      end
      @default_route
    end

    def test_default_route_recognition
      expected = {:controller => 'accounts', :action => 'show', :id => '10'}
      assert_equal expected, default_route.recognize('/accounts/show/10')
      assert_equal expected, default_route.recognize('/accounts/show/10/')

      expected[:id] = 'jamis'
      assert_equal expected, default_route.recognize('/accounts/show/jamis/')

      expected.delete :id
      assert_equal expected, default_route.recognize('/accounts/show')
      assert_equal expected, default_route.recognize('/accounts/show/')

      expected[:action] = 'index'
      assert_equal expected, default_route.recognize('/accounts/')
      assert_equal expected, default_route.recognize('/accounts')

      assert_equal nil, default_route.recognize('/')
      assert_equal nil, default_route.recognize('/accounts/how/goood/it/is/to/be/free')
    end

    def test_default_route_should_omit_default_action
      o = {:controller => 'accounts', :action => 'index'}
      assert_equal '/accounts', default_route.generate(o, o, {})
    end

    def test_default_route_should_include_default_action_when_id_present
      o = {:controller => 'accounts', :action => 'index', :id => '20'}
      assert_equal '/accounts/index/20', default_route.generate(o, o, {})
    end

    def test_default_route_should_work_with_action_but_no_id
      o = {:controller => 'accounts', :action => 'list_all'}
      assert_equal '/accounts/list_all', default_route.generate(o, o, {})
    end

    def test_default_route_should_uri_escape_pluses
      expected = { :controller => 'accounts', :action => 'show', :id => 'hello world' }
      assert_equal expected, default_route.recognize('/accounts/show/hello world')
      assert_equal expected, default_route.recognize('/accounts/show/hello%20world')
      assert_equal '/accounts/show/hello%20world', default_route.generate(expected, expected, {})

      expected[:id] = 'hello+world'
      assert_equal expected, default_route.recognize('/accounts/show/hello+world')
      assert_equal expected, default_route.recognize('/accounts/show/hello%2Bworld')
      assert_equal '/accounts/show/hello+world', default_route.generate(expected, expected, {})
    end

    def test_matches_controller_and_action
      # requirement_for should only be called for the action and controller _once_
      @route.expects(:requirement_for).with(:controller).times(1).returns('pages')
      @route.expects(:requirement_for).with(:action).times(1).returns('show')

      @route.requirements = {:controller => 'pages', :action => 'show'}
      assert @route.matches_controller_and_action?('pages', 'show')
      assert !@route.matches_controller_and_action?('not_pages', 'show')
      assert !@route.matches_controller_and_action?('pages', 'not_show')
    end

    def test_parameter_shell
      page_url = ROUTING::Route.new
      page_url.requirements = {:controller => 'pages', :action => 'show', :id => /\d+/}
      assert_equal({:controller => 'pages', :action => 'show'}, page_url.parameter_shell)
    end

    def test_defaults
      route = ROUTING::RouteBuilder.new.build '/users/:id.:format', :controller => "users", :action => "show", :format => "html"
      assert_equal(
        { :controller => "users", :action => "show", :format => "html" },
        route.defaults)
    end

    def test_builder_complains_without_controller
      assert_raises(ArgumentError) do
        ROUTING::RouteBuilder.new.build '/contact', :contoller => "contact", :action => "index"
      end
    end

    def test_significant_keys_for_default_route
      keys = default_route.significant_keys.sort_by {|k| k.to_s }
      assert_equal [:action, :controller, :id], keys
    end

    def test_significant_keys
1520 1521 1522 1523 1524 1525
      segments = []
      segments << ROUTING::StaticSegment.new('/', :raw => true)
      segments << ROUTING::StaticSegment.new('user')
      segments << ROUTING::StaticSegment.new('/', :raw => true, :optional => true)
      segments << ROUTING::DynamicSegment.new(:user)
      segments << ROUTING::StaticSegment.new('/', :raw => true, :optional => true)
1526

1527
      requirements = {:controller => 'users', :action => 'show'}
1528

1529
      user_url = ROUTING::Route.new(segments, requirements)
1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573
      keys = user_url.significant_keys.sort_by { |k| k.to_s }
      assert_equal [:action, :controller, :user], keys
    end

    def test_build_empty_query_string
      assert_equal '', @route.build_query_string({})
    end

    def test_build_query_string_with_nil_value
      assert_equal '', @route.build_query_string({:x => nil})
    end

    def test_simple_build_query_string
      assert_equal '?x=1&y=2', order_query_string(@route.build_query_string(:x => '1', :y => '2'))
    end

    def test_convert_ints_build_query_string
      assert_equal '?x=1&y=2', order_query_string(@route.build_query_string(:x => 1, :y => 2))
    end

    def test_escape_spaces_build_query_string
      assert_equal '?x=hello+world&y=goodbye+world', order_query_string(@route.build_query_string(:x => 'hello world', :y => 'goodbye world'))
    end

    def test_expand_array_build_query_string
      assert_equal '?x%5B%5D=1&x%5B%5D=2', order_query_string(@route.build_query_string(:x => [1, 2]))
    end

    def test_escape_spaces_build_query_string_selected_keys
      assert_equal '?x=hello+world', order_query_string(@route.build_query_string({:x => 'hello world', :y => 'goodbye world'}, [:x]))
    end

    private
      def order_query_string(qs)
        '?' + qs[1..-1].split('&').sort.join('&')
      end
  end

  class RouteSetTest < Test::Unit::TestCase
    def set
      @set ||= ROUTING::RouteSet.new
    end

    def request
1574
      @request ||= ActionController::TestRequest.new
1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674
    end

    def test_generate_extras
      set.draw { |m| m.connect ':controller/:action/:id' }
      path, extras = set.generate_extras(:controller => "foo", :action => "bar", :id => 15, :this => "hello", :that => "world")
      assert_equal "/foo/bar/15", path
      assert_equal %w(that this), extras.map(&:to_s).sort
    end

    def test_extra_keys
      set.draw { |m| m.connect ':controller/:action/:id' }
      extras = set.extra_keys(:controller => "foo", :action => "bar", :id => 15, :this => "hello", :that => "world")
      assert_equal %w(that this), extras.map(&:to_s).sort
    end

    def test_generate_extras_not_first
      set.draw do |map|
        map.connect ':controller/:action/:id.:format'
        map.connect ':controller/:action/:id'
      end
      path, extras = set.generate_extras(:controller => "foo", :action => "bar", :id => 15, :this => "hello", :that => "world")
      assert_equal "/foo/bar/15", path
      assert_equal %w(that this), extras.map(&:to_s).sort
    end

    def test_generate_not_first
      set.draw do |map|
        map.connect ':controller/:action/:id.:format'
        map.connect ':controller/:action/:id'
      end
      assert_equal "/foo/bar/15?this=hello", set.generate(:controller => "foo", :action => "bar", :id => 15, :this => "hello")
    end

    def test_extra_keys_not_first
      set.draw do |map|
        map.connect ':controller/:action/:id.:format'
        map.connect ':controller/:action/:id'
      end
      extras = set.extra_keys(:controller => "foo", :action => "bar", :id => 15, :this => "hello", :that => "world")
      assert_equal %w(that this), extras.map(&:to_s).sort
    end

    def test_draw
      assert_equal 0, set.routes.size
      set.draw do |map|
        map.connect '/hello/world', :controller => 'a', :action => 'b'
      end
      assert_equal 1, set.routes.size
    end

    def test_named_draw
      assert_equal 0, set.routes.size
      set.draw do |map|
        map.hello '/hello/world', :controller => 'a', :action => 'b'
      end
      assert_equal 1, set.routes.size
      assert_equal set.routes.first, set.named_routes[:hello]
    end

    def test_later_named_routes_take_precedence
      set.draw do |map|
        map.hello '/hello/world', :controller => 'a', :action => 'b'
        map.hello '/hello', :controller => 'a', :action => 'b'
      end
      assert_equal set.routes.last, set.named_routes[:hello]
    end

    def setup_named_route_test
      set.draw do |map|
        map.show '/people/:id', :controller => 'people', :action => 'show'
        map.index '/people', :controller => 'people', :action => 'index'
        map.multi '/people/go/:foo/:bar/joe/:id', :controller => 'people', :action => 'multi'
        map.users '/admin/users', :controller => 'admin/users', :action => 'index'
      end

      klass = Class.new(MockController)
      set.install_helpers(klass)
      klass.new(set)
    end

    def test_named_route_hash_access_method
      controller = setup_named_route_test

      assert_equal(
        { :controller => 'people', :action => 'show', :id => 5, :use_route => :show, :only_path => false },
        controller.send(:hash_for_show_url, :id => 5))

      assert_equal(
        { :controller => 'people', :action => 'index', :use_route => :index, :only_path => false },
        controller.send(:hash_for_index_url))

      assert_equal(
        { :controller => 'people', :action => 'show', :id => 5, :use_route => :show, :only_path => true },
        controller.send(:hash_for_show_path, :id => 5)
      )
    end

    def test_named_route_url_method
      controller = setup_named_route_test

1675
      assert_equal "http://test.host/people/5", controller.send(:show_url, :id => 5)
1676 1677
      assert_equal "/people/5", controller.send(:show_path, :id => 5)

1678
      assert_equal "http://test.host/people", controller.send(:index_url)
1679 1680
      assert_equal "/people", controller.send(:index_path)

1681
      assert_equal "http://test.host/admin/users", controller.send(:users_url)
1682 1683 1684 1685 1686 1687 1688
      assert_equal '/admin/users', controller.send(:users_path)
      assert_equal '/admin/users', set.generate(controller.send(:hash_for_users_url), {:controller => 'users', :action => 'index'})
    end

    def test_named_route_url_method_with_anchor
      controller = setup_named_route_test

1689
      assert_equal "http://test.host/people/5#location", controller.send(:show_url, :id => 5, :anchor => 'location')
1690 1691
      assert_equal "/people/5#location", controller.send(:show_path, :id => 5, :anchor => 'location')

1692
      assert_equal "http://test.host/people#location", controller.send(:index_url, :anchor => 'location')
1693 1694
      assert_equal "/people#location", controller.send(:index_path, :anchor => 'location')

1695
      assert_equal "http://test.host/admin/users#location", controller.send(:users_url, :anchor => 'location')
1696 1697
      assert_equal '/admin/users#location', controller.send(:users_path, :anchor => 'location')

1698
      assert_equal "http://test.host/people/go/7/hello/joe/5#location",
1699 1700
        controller.send(:multi_url, 7, "hello", 5, :anchor => 'location')

1701
      assert_equal "http://test.host/people/go/7/hello/joe/5?baz=bar#location",
1702 1703
        controller.send(:multi_url, 7, "hello", 5, :baz => "bar", :anchor => 'location')

1704
      assert_equal "http://test.host/people?baz=bar#location",
1705 1706 1707 1708 1709
        controller.send(:index_url, :baz => "bar", :anchor => 'location')
    end

    def test_named_route_url_method_with_port
      controller = setup_named_route_test
1710
      assert_equal "http://test.host:8080/people/5", controller.send(:show_url, 5, :port=>8080)
1711 1712 1713 1714 1715 1716 1717
    end

    def test_named_route_url_method_with_host
      controller = setup_named_route_test
      assert_equal "http://some.example.com/people/5", controller.send(:show_url, 5, :host=>"some.example.com")
    end

1718 1719
    def test_named_route_url_method_with_protocol
      controller = setup_named_route_test
1720
      assert_equal "https://test.host/people/5", controller.send(:show_url, 5, :protocol => "https")
1721 1722
    end

1723 1724
    def test_named_route_url_method_with_ordered_parameters
      controller = setup_named_route_test
1725
      assert_equal "http://test.host/people/go/7/hello/joe/5",
1726 1727 1728 1729 1730
        controller.send(:multi_url, 7, "hello", 5)
    end

    def test_named_route_url_method_with_ordered_parameters_and_hash
      controller = setup_named_route_test
1731
      assert_equal "http://test.host/people/go/7/hello/joe/5?baz=bar",
1732 1733 1734
        controller.send(:multi_url, 7, "hello", 5, :baz => "bar")
    end

1735 1736
    def test_named_route_url_method_with_ordered_parameters_and_empty_hash
      controller = setup_named_route_test
1737
      assert_equal "http://test.host/people/go/7/hello/joe/5",
1738 1739 1740
        controller.send(:multi_url, 7, "hello", 5, {})
    end

1741 1742
    def test_named_route_url_method_with_no_positional_arguments
      controller = setup_named_route_test
1743
      assert_equal "http://test.host/people?baz=bar",
1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826
        controller.send(:index_url, :baz => "bar")
    end

    def test_draw_default_route
      ActionController::Routing.with_controllers(['users']) do
        set.draw do |map|
          map.connect '/:controller/:action/:id'
        end

        assert_equal 1, set.routes.size
        route = set.routes.first

        assert route.segments.last.optional?

        assert_equal '/users/show/10', set.generate(:controller => 'users', :action => 'show', :id => 10)
        assert_equal '/users/index/10', set.generate(:controller => 'users', :id => 10)

        assert_equal({:controller => 'users', :action => 'index', :id => '10'}, set.recognize_path('/users/index/10'))
        assert_equal({:controller => 'users', :action => 'index', :id => '10'}, set.recognize_path('/users/index/10/'))
      end
    end

    def test_draw_default_route_with_default_controller
      ActionController::Routing.with_controllers(['users']) do
        set.draw do |map|
          map.connect '/:controller/:action/:id', :controller => 'users'
        end
        assert_equal({:controller => 'users', :action => 'index'}, set.recognize_path('/'))
      end
    end

    def test_route_with_parameter_shell
      ActionController::Routing.with_controllers(['users', 'pages']) do
        set.draw do |map|
          map.connect 'page/:id', :controller => 'pages', :action => 'show', :id => /\d+/
          map.connect '/:controller/:action/:id'
        end

        assert_equal({:controller => 'pages', :action => 'index'}, set.recognize_path('/pages'))
        assert_equal({:controller => 'pages', :action => 'index'}, set.recognize_path('/pages/index'))
        assert_equal({:controller => 'pages', :action => 'list'}, set.recognize_path('/pages/list'))

        assert_equal({:controller => 'pages', :action => 'show', :id => '10'}, set.recognize_path('/pages/show/10'))
        assert_equal({:controller => 'pages', :action => 'show', :id => '10'}, set.recognize_path('/page/10'))
      end
    end

    def test_route_requirements_with_anchor_chars_are_invalid
      assert_raises ArgumentError do
        set.draw do |map|
          map.connect 'page/:id', :controller => 'pages', :action => 'show', :id => /^\d+/
        end
      end
      assert_raises ArgumentError do
        set.draw do |map|
          map.connect 'page/:id', :controller => 'pages', :action => 'show', :id => /\A\d+/
        end
      end
      assert_raises ArgumentError do
        set.draw do |map|
          map.connect 'page/:id', :controller => 'pages', :action => 'show', :id => /\d+$/
        end
      end
      assert_raises ArgumentError do
        set.draw do |map|
          map.connect 'page/:id', :controller => 'pages', :action => 'show', :id => /\d+\Z/
        end
      end
      assert_raises ArgumentError do
        set.draw do |map|
          map.connect 'page/:id', :controller => 'pages', :action => 'show', :id => /\d+\z/
        end
      end
      assert_nothing_raised do
        set.draw do |map|
          map.connect 'page/:id', :controller => 'pages', :action => 'show', :id => /\d+/, :name => /^(david|jamis)/
        end
        assert_raises ActionController::RoutingError do
          set.generate :controller => 'pages', :action => 'show', :id => 10
        end
      end
    end

1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842
    def test_route_requirements_with_invalid_http_method_is_invalid
      assert_raises ArgumentError do
        set.draw do |map|
          map.connect 'valid/route', :controller => 'pages', :action => 'show', :conditions => {:method => :invalid}
        end
      end
    end

    def test_route_requirements_with_head_method_condition_is_invalid
      assert_raises ArgumentError do
        set.draw do |map|
          map.connect 'valid/route', :controller => 'pages', :action => 'show', :conditions => {:method => :head}
        end
      end
    end

1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876
    def test_non_path_route_requirements_match_all
      set.draw do |map|
        map.connect 'page/37s', :controller => 'pages', :action => 'show', :name => /(jamis|david)/
      end
      assert_equal '/page/37s', set.generate(:controller => 'pages', :action => 'show', :name => 'jamis')
      assert_raises ActionController::RoutingError do
        set.generate(:controller => 'pages', :action => 'show', :name => 'not_jamis')
      end
      assert_raises ActionController::RoutingError do
        set.generate(:controller => 'pages', :action => 'show', :name => 'nor_jamis_and_david')
      end
    end

    def test_recognize_with_encoded_id_and_regex
      set.draw do |map|
        map.connect 'page/:id', :controller => 'pages', :action => 'show', :id => /[a-zA-Z0-9\+]+/
      end

      assert_equal({:controller => 'pages', :action => 'show', :id => '10'}, set.recognize_path('/page/10'))
      assert_equal({:controller => 'pages', :action => 'show', :id => 'hello+world'}, set.recognize_path('/page/hello+world'))
    end

    def test_recognize_with_conditions
      Object.const_set(:PeopleController, Class.new)

      set.draw do |map|
        map.with_options(:controller => "people") do |people|
          people.people  "/people",     :action => "index",   :conditions => { :method => :get }
          people.connect "/people",     :action => "create",  :conditions => { :method => :post }
          people.person  "/people/:id", :action => "show",    :conditions => { :method => :get }
          people.connect "/people/:id", :action => "update",  :conditions => { :method => :put }
          people.connect "/people/:id", :action => "destroy", :conditions => { :method => :delete }
        end
      end
1877

1878
      request.path = "/people"
1879
      request.env["REQUEST_METHOD"] = "GET"
1880 1881
      assert_nothing_raised { set.recognize(request) }
      assert_equal("index", request.path_parameters[:action])
1882
      request.recycle!
1883

1884
      request.env["REQUEST_METHOD"] = "POST"
1885 1886
      assert_nothing_raised { set.recognize(request) }
      assert_equal("create", request.path_parameters[:action])
1887
      request.recycle!
1888

1889
      request.env["REQUEST_METHOD"] = "PUT"
1890 1891
      assert_nothing_raised { set.recognize(request) }
      assert_equal("update", request.path_parameters[:action])
1892
      request.recycle!
1893

1894 1895
      assert_raises(ActionController::UnknownHttpMethod) {
        request.env["REQUEST_METHOD"] = "BACON"
1896
        set.recognize(request)
1897 1898
      }
      request.recycle!
1899 1900

      request.path = "/people/5"
1901
      request.env["REQUEST_METHOD"] = "GET"
1902 1903 1904
      assert_nothing_raised { set.recognize(request) }
      assert_equal("show", request.path_parameters[:action])
      assert_equal("5", request.path_parameters[:id])
1905
      request.recycle!
1906

1907
      request.env["REQUEST_METHOD"] = "PUT"
1908 1909 1910
      assert_nothing_raised { set.recognize(request) }
      assert_equal("update", request.path_parameters[:action])
      assert_equal("5", request.path_parameters[:id])
1911
      request.recycle!
1912

1913
      request.env["REQUEST_METHOD"] = "DELETE"
1914 1915 1916
      assert_nothing_raised { set.recognize(request) }
      assert_equal("destroy", request.path_parameters[:action])
      assert_equal("5", request.path_parameters[:id])
1917
      request.recycle!
1918 1919

      begin
1920
        request.env["REQUEST_METHOD"] = "POST"
1921 1922 1923 1924 1925
        set.recognize(request)
        flunk 'Should have raised MethodNotAllowed'
      rescue ActionController::MethodNotAllowed => e
        assert_equal [:get, :put, :delete], e.allowed_methods
      end
1926
      request.recycle!
1927 1928 1929

    ensure
      Object.send(:remove_const, :PeopleController)
1930 1931
    end

1932 1933 1934 1935 1936 1937 1938 1939
    def test_recognize_with_alias_in_conditions
      Object.const_set(:PeopleController, Class.new)

      set.draw do |map|
        map.people "/people", :controller => 'people', :action => "index",
          :conditions => { :method => :get }
        map.root   :people
      end
1940

1941
      request.path = "/people"
1942
      request.env["REQUEST_METHOD"] = "GET"
1943 1944 1945 1946 1947
      assert_nothing_raised { set.recognize(request) }
      assert_equal("people", request.path_parameters[:controller])
      assert_equal("index", request.path_parameters[:action])

      request.path = "/"
1948
      request.env["REQUEST_METHOD"] = "GET"
1949 1950 1951 1952 1953
      assert_nothing_raised { set.recognize(request) }
      assert_equal("people", request.path_parameters[:controller])
      assert_equal("index", request.path_parameters[:action])
    ensure
      Object.send(:remove_const, :PeopleController)
1954 1955
    end

1956 1957
    def test_typo_recognition
      Object.const_set(:ArticlesController, Class.new)
1958

1959 1960 1961 1962 1963
      set.draw do |map|
        map.connect 'articles/:year/:month/:day/:title',
               :controller => 'articles', :action => 'permalink',
               :year => /\d{4}/, :day => /\d{1,2}/, :month => /\d{1,2}/
      end
1964

1965
      request.path = "/articles/2005/11/05/a-very-interesting-article"
1966
      request.env["REQUEST_METHOD"] = "GET"
1967 1968 1969 1970 1971 1972 1973 1974 1975
      assert_nothing_raised { set.recognize(request) }
      assert_equal("permalink", request.path_parameters[:action])
      assert_equal("2005", request.path_parameters[:year])
      assert_equal("11", request.path_parameters[:month])
      assert_equal("05", request.path_parameters[:day])
      assert_equal("a-very-interesting-article", request.path_parameters[:title])

    ensure
      Object.send(:remove_const, :ArticlesController)
1976 1977
    end

1978 1979 1980 1981 1982 1983 1984
    def test_routing_traversal_does_not_load_extra_classes
      assert !Object.const_defined?("Profiler__"), "Profiler should not be loaded"
      set.draw do |map|
        map.connect '/profile', :controller => 'profile'
      end

      request.path = '/profile'
1985

1986 1987 1988 1989
      set.recognize(request) rescue nil

      assert !Object.const_defined?("Profiler__"), "Profiler should not be loaded"
    end
1990

1991 1992
    def test_recognize_with_conditions_and_format
      Object.const_set(:PeopleController, Class.new)
1993

1994 1995 1996 1997 1998 1999
      set.draw do |map|
        map.with_options(:controller => "people") do |people|
          people.person  "/people/:id", :action => "show",    :conditions => { :method => :get }
          people.connect "/people/:id", :action => "update",  :conditions => { :method => :put }
          people.connect "/people/:id.:_format", :action => "show", :conditions => { :method => :get }
        end
2000
      end
2001 2002

      request.path = "/people/5"
2003
      request.env["REQUEST_METHOD"] = "GET"
2004 2005 2006
      assert_nothing_raised { set.recognize(request) }
      assert_equal("show", request.path_parameters[:action])
      assert_equal("5", request.path_parameters[:id])
2007
      request.recycle!
2008

2009
      request.env["REQUEST_METHOD"] = "PUT"
2010 2011
      assert_nothing_raised { set.recognize(request) }
      assert_equal("update", request.path_parameters[:action])
2012
      request.recycle!
2013 2014

      request.path = "/people/5.png"
2015
      request.env["REQUEST_METHOD"] = "GET"
2016 2017 2018 2019 2020 2021
      assert_nothing_raised { set.recognize(request) }
      assert_equal("show", request.path_parameters[:action])
      assert_equal("5", request.path_parameters[:id])
      assert_equal("png", request.path_parameters[:_format])
    ensure
      Object.send(:remove_const, :PeopleController)
2022 2023
    end

2024 2025 2026 2027 2028 2029 2030 2031 2032
    def test_generate_with_default_action
      set.draw do |map|
        map.connect "/people", :controller => "people"
        map.connect "/people/list", :controller => "people", :action => "list"
      end

      url = set.generate(:controller => "people", :action => "list")
      assert_equal "/people/list", url
    end
2033

2034 2035
    def test_root_map
      Object.const_set(:PeopleController, Class.new)
2036

2037
      set.draw { |map| map.root :controller => "people" }
2038

2039
      request.path = ""
2040
      request.env["REQUEST_METHOD"] = "GET"
2041 2042 2043 2044 2045
      assert_nothing_raised { set.recognize(request) }
      assert_equal("people", request.path_parameters[:controller])
      assert_equal("index", request.path_parameters[:action])
    ensure
      Object.send(:remove_const, :PeopleController)
2046 2047
    end

2048 2049
    def test_namespace
      Object.const_set(:Api, Module.new { |m| m.const_set(:ProductsController, Class.new) })
2050

2051
      set.draw do |map|
2052

2053 2054 2055
        map.namespace 'api' do |api|
          api.route 'inventory', :controller => "products", :action => 'inventory'
        end
2056 2057

      end
2058 2059

      request.path = "/api/inventory"
2060
      request.env["REQUEST_METHOD"] = "GET"
2061 2062 2063 2064 2065
      assert_nothing_raised { set.recognize(request) }
      assert_equal("api/products", request.path_parameters[:controller])
      assert_equal("inventory", request.path_parameters[:action])
    ensure
      Object.send(:remove_const, :Api)
2066 2067
    end

2068 2069
    def test_namespaced_root_map
      Object.const_set(:Api, Module.new { |m| m.const_set(:ProductsController, Class.new) })
2070

2071 2072 2073 2074 2075
      set.draw do |map|

        map.namespace 'api' do |api|
          api.root :controller => "products"
        end
2076 2077

      end
2078 2079

      request.path = "/api"
2080
      request.env["REQUEST_METHOD"] = "GET"
2081 2082 2083 2084 2085
      assert_nothing_raised { set.recognize(request) }
      assert_equal("api/products", request.path_parameters[:controller])
      assert_equal("index", request.path_parameters[:action])
    ensure
      Object.send(:remove_const, :Api)
2086 2087
    end

2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099
    def test_namespace_with_path_prefix
      Object.const_set(:Api, Module.new { |m| m.const_set(:ProductsController, Class.new) })

      set.draw do |map|

        map.namespace 'api', :path_prefix => 'prefix' do |api|
          api.route 'inventory', :controller => "products", :action => 'inventory'
        end

      end

      request.path = "/prefix/inventory"
2100
      request.env["REQUEST_METHOD"] = "GET"
2101 2102 2103 2104 2105 2106 2107
      assert_nothing_raised { set.recognize(request) }
      assert_equal("api/products", request.path_parameters[:controller])
      assert_equal("inventory", request.path_parameters[:action])
    ensure
      Object.send(:remove_const, :Api)
    end

2108 2109 2110 2111 2112
    def test_generate_finds_best_fit
      set.draw do |map|
        map.connect "/people", :controller => "people", :action => "index"
        map.connect "/ws/people", :controller => "people", :action => "index", :ws => true
      end
2113

2114 2115
      url = set.generate(:controller => "people", :action => "index", :ws => true)
      assert_equal "/ws/people", url
2116 2117
    end

2118 2119 2120 2121 2122 2123
    def test_generate_changes_controller_module
      set.draw { |map| map.connect ':controller/:action/:id' }
      current = { :controller => "bling/bloop", :action => "bap", :id => 9 }
      url = set.generate({:controller => "foo/bar", :action => "baz", :id => 7}, current)
      assert_equal "/foo/bar/baz/7", url
    end
2124

2125 2126 2127 2128 2129
    def test_id_is_not_impossibly_sticky
      set.draw do |map|
        map.connect 'foo/:number', :controller => "people", :action => "index"
        map.connect ':controller/:action/:id'
      end
2130

2131 2132 2133
      url = set.generate({:controller => "people", :action => "index", :number => 3},
        {:controller => "people", :action => "index", :id => "21"})
      assert_equal "/foo/3", url
2134 2135
    end

2136 2137 2138 2139
    def test_id_is_sticky_when_it_ought_to_be
      set.draw do |map|
        map.connect ':controller/:id/:action'
      end
2140

2141 2142
      url = set.generate({:action => "destroy"}, {:controller => "people", :action => "show", :id => "7"})
      assert_equal "/people/7/destroy", url
2143 2144
    end

2145 2146 2147 2148 2149
    def test_use_static_path_when_possible
      set.draw do |map|
        map.connect 'about', :controller => "welcome", :action => "about"
        map.connect ':controller/:action/:id'
      end
2150

2151 2152 2153
      url = set.generate({:controller => "welcome", :action => "about"},
        {:controller => "welcome", :action => "get", :id => "7"})
      assert_equal "/about", url
2154 2155
    end

2156 2157
    def test_generate
      set.draw { |map| map.connect ':controller/:action/:id' }
2158

2159 2160 2161 2162 2163
      args = { :controller => "foo", :action => "bar", :id => "7", :x => "y" }
      assert_equal "/foo/bar/7?x=y", set.generate(args)
      assert_equal ["/foo/bar/7", [:x]], set.generate_extras(args)
      assert_equal [:x], set.extra_keys(args)
    end
2164

2165 2166 2167 2168 2169 2170 2171
    def test_generate_with_path_prefix
      set.draw { |map| map.connect ':controller/:action/:id', :path_prefix => 'my' }

      args = { :controller => "foo", :action => "bar", :id => "7", :x => "y" }
      assert_equal "/my/foo/bar/7?x=y", set.generate(args)
    end

2172 2173 2174 2175 2176 2177
    def test_named_routes_are_never_relative_to_modules
      set.draw do |map|
        map.connect "/connection/manage/:action", :controller => 'connection/manage'
        map.connect "/connection/connection", :controller => "connection/connection"
        map.family_connection "/connection", :controller => "connection"
      end
2178

2179 2180
      url = set.generate({:controller => "connection"}, {:controller => 'connection/manage'})
      assert_equal "/connection/connection", url
2181

2182 2183 2184
      url = set.generate({:use_route => :family_connection, :controller => "connection"}, {:controller => 'connection/manage'})
      assert_equal "/connection", url
    end
2185

2186 2187 2188 2189 2190 2191 2192 2193
    def test_action_left_off_when_id_is_recalled
      set.draw do |map|
        map.connect ':controller/:action/:id'
      end
      assert_equal '/post', set.generate(
        {:controller => 'post', :action => 'index'},
        {:controller => 'post', :action => 'show', :id => '10'}
      )
2194
    end
2195 2196 2197 2198 2199 2200 2201 2202 2203 2204

    def test_query_params_will_be_shown_when_recalled
      set.draw do |map|
        map.connect 'show_post/:parameter', :controller => 'post', :action => 'show'
        map.connect ':controller/:action/:id'
      end
      assert_equal '/post/edit?parameter=1', set.generate(
        {:action => 'edit', :parameter => 1},
        {:controller => 'post', :action => 'show', :parameter => 1}
      )
2205
    end
2206

2207 2208 2209 2210 2211 2212
    def test_expiry_determination_should_consider_values_with_to_param
      set.draw { |map| map.connect 'projects/:project_id/:controller/:action' }
      assert_equal '/projects/1/post/show', set.generate(
        {:action => 'show', :project_id => 1},
        {:controller => 'post', :action => 'show', :project_id => '1'})
    end
2213

2214 2215 2216 2217 2218 2219 2220 2221 2222 2223 2224 2225
    def test_generate_all
      set.draw do |map|
        map.connect 'show_post/:id', :controller => 'post', :action => 'show'
        map.connect ':controller/:action/:id'
      end
      all = set.generate(
        {:action => 'show', :id => 10, :generate_all => true},
        {:controller => 'post', :action => 'show'}
      )
      assert_equal 2, all.length
      assert_equal '/show_post/10', all.first
      assert_equal '/post/show/10', all.last
2226
    end
2227 2228

    def test_named_route_in_nested_resource
2229
      set.draw do |map|
2230 2231
        map.resources :projects do |project|
          project.milestones 'milestones', :controller => 'milestones', :action => 'index'
2232 2233
        end
      end
2234 2235

      request.path = "/projects/1/milestones"
2236
      request.env["REQUEST_METHOD"] = "GET"
2237 2238 2239
      assert_nothing_raised { set.recognize(request) }
      assert_equal("milestones", request.path_parameters[:controller])
      assert_equal("index", request.path_parameters[:action])
2240
    end
2241 2242 2243 2244 2245 2246 2247

    def test_setting_root_in_namespace_using_symbol
      assert_nothing_raised do
        set.draw do |map|
          map.namespace :admin do |admin|
            admin.root :controller => 'home'
          end
2248 2249 2250
        end
      end
    end
2251

2252 2253 2254 2255 2256 2257 2258 2259 2260 2261 2262 2263 2264 2265 2266 2267 2268 2269 2270 2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290 2291 2292 2293 2294
    def test_setting_root_in_namespace_using_string
      assert_nothing_raised do
        set.draw do |map|
          map.namespace 'admin' do |admin|
            admin.root :controller => 'home'
          end
        end
      end
    end

    def test_route_requirements_with_unsupported_regexp_options_must_error
      assert_raises ArgumentError do
        set.draw do |map|
          map.connect 'page/:name', :controller => 'pages',
            :action => 'show',
            :requirements => {:name => /(david|jamis)/m}
        end
      end
    end

    def test_route_requirements_with_supported_options_must_not_error
      assert_nothing_raised do
        set.draw do |map|
          map.connect 'page/:name', :controller => 'pages',
            :action => 'show',
            :requirements => {:name => /(david|jamis)/i}
        end
      end
      assert_nothing_raised do
        set.draw do |map|
          map.connect 'page/:name', :controller => 'pages',
            :action => 'show',
            :requirements => {:name => / # Desperately overcommented regexp
                                        ( #Either
                                         david #The Creator
                                        | #Or
                                          jamis #The Deployer
                                        )/x}
        end
      end
    end

    def test_route_requirement_recognize_with_ignore_case
2295 2296 2297
      set.draw do |map|
        map.connect 'page/:name', :controller => 'pages',
          :action => 'show',
2298 2299 2300 2301 2302
          :requirements => {:name => /(david|jamis)/i}
      end
      assert_equal({:controller => 'pages', :action => 'show', :name => 'jamis'}, set.recognize_path('/page/jamis'))
      assert_raises ActionController::RoutingError do
        set.recognize_path('/page/davidjamis')
2303
      end
2304
      assert_equal({:controller => 'pages', :action => 'show', :name => 'DAVID'}, set.recognize_path('/page/DAVID'))
2305 2306
    end

2307
    def test_route_requirement_generate_with_ignore_case
2308 2309 2310 2311 2312
      set.draw do |map|
        map.connect 'page/:name', :controller => 'pages',
          :action => 'show',
          :requirements => {:name => /(david|jamis)/i}
      end
2313 2314 2315 2316 2317 2318 2319
      url = set.generate({:controller => 'pages', :action => 'show', :name => 'david'})
      assert_equal "/page/david", url
      assert_raises ActionController::RoutingError do
        url = set.generate({:controller => 'pages', :action => 'show', :name => 'davidjamis'})
      end
      url = set.generate({:controller => 'pages', :action => 'show', :name => 'JAMIS'})
      assert_equal "/page/JAMIS", url
2320
    end
2321 2322

    def test_route_requirement_recognize_with_extended_syntax
2323 2324 2325 2326 2327 2328 2329 2330 2331 2332
      set.draw do |map|
        map.connect 'page/:name', :controller => 'pages',
          :action => 'show',
          :requirements => {:name => / # Desperately overcommented regexp
                                      ( #Either
                                       david #The Creator
                                      | #Or
                                        jamis #The Deployer
                                      )/x}
      end
2333 2334 2335 2336 2337 2338 2339 2340
      assert_equal({:controller => 'pages', :action => 'show', :name => 'jamis'}, set.recognize_path('/page/jamis'))
      assert_equal({:controller => 'pages', :action => 'show', :name => 'david'}, set.recognize_path('/page/david'))
      assert_raises ActionController::RoutingError do
        set.recognize_path('/page/david #The Creator')
      end
      assert_raises ActionController::RoutingError do
        set.recognize_path('/page/David')
      end
2341 2342
    end

2343 2344 2345 2346 2347 2348 2349 2350 2351 2352 2353 2354 2355 2356 2357 2358 2359 2360 2361
    def test_route_requirement_generate_with_extended_syntax
      set.draw do |map|
        map.connect 'page/:name', :controller => 'pages',
          :action => 'show',
          :requirements => {:name => / # Desperately overcommented regexp
                                      ( #Either
                                       david #The Creator
                                      | #Or
                                        jamis #The Deployer
                                      )/x}
      end
      url = set.generate({:controller => 'pages', :action => 'show', :name => 'david'})
      assert_equal "/page/david", url
      assert_raises ActionController::RoutingError do
        url = set.generate({:controller => 'pages', :action => 'show', :name => 'davidjamis'})
      end
      assert_raises ActionController::RoutingError do
        url = set.generate({:controller => 'pages', :action => 'show', :name => 'JAMIS'})
      end
2362 2363
    end

2364 2365 2366 2367 2368 2369 2370 2371 2372 2373 2374
    def test_route_requirement_generate_with_xi_modifiers
      set.draw do |map|
        map.connect 'page/:name', :controller => 'pages',
          :action => 'show',
          :requirements => {:name => / # Desperately overcommented regexp
                                      ( #Either
                                       david #The Creator
                                      | #Or
                                        jamis #The Deployer
                                      )/xi}
      end
2375
      url = set.generate({:controller => 'pages', :action => 'show', :name => 'JAMIS'})
2376
      assert_equal "/page/JAMIS", url
J
Jeremy Kemper 已提交
2377 2378
    end

2379 2380 2381 2382 2383 2384 2385 2386 2387 2388 2389 2390
    def test_route_requirement_recognize_with_xi_modifiers
      set.draw do |map|
        map.connect 'page/:name', :controller => 'pages',
          :action => 'show',
          :requirements => {:name => / # Desperately overcommented regexp
                                      ( #Either
                                       david #The Creator
                                      | #Or
                                        jamis #The Deployer
                                      )/xi}
      end
      assert_equal({:controller => 'pages', :action => 'show', :name => 'JAMIS'}, set.recognize_path('/page/JAMIS'))
2391 2392
    end
  end
2393

2394 2395 2396 2397
  class RouteLoadingTest < Test::Unit::TestCase
    def setup
      routes.instance_variable_set '@routes_last_modified', nil
      silence_warnings { Object.const_set :RAILS_ROOT, '.' }
2398
      routes.add_configuration_file(File.join(RAILS_ROOT, 'config', 'routes.rb'))
2399 2400 2401 2402 2403

      @stat = stub_everything
    end

    def teardown
2404
      ActionController::Routing::Routes.configuration_files.clear
2405 2406 2407 2408 2409 2410 2411 2412 2413 2414 2415 2416 2417 2418 2419 2420 2421 2422 2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435 2436 2437 2438 2439
      Object.send :remove_const, :RAILS_ROOT
    end

    def test_load
      File.expects(:stat).returns(@stat)
      routes.expects(:load).with(regexp_matches(/routes\.rb$/))

      routes.reload
    end

    def test_no_reload_when_not_modified
      @stat.expects(:mtime).times(2).returns(1)
      File.expects(:stat).times(2).returns(@stat)
      routes.expects(:load).with(regexp_matches(/routes\.rb$/)).at_most_once

      2.times { routes.reload }
    end

    def test_reload_when_modified
      @stat.expects(:mtime).at_least(2).returns(1, 2)
      File.expects(:stat).at_least(2).returns(@stat)
      routes.expects(:load).with(regexp_matches(/routes\.rb$/)).times(2)

      2.times { routes.reload }
    end

    def test_bang_forces_reload
      @stat.expects(:mtime).at_least(2).returns(1)
      File.expects(:stat).at_least(2).returns(@stat)
      routes.expects(:load).with(regexp_matches(/routes\.rb$/)).times(2)

      2.times { routes.reload! }
    end

    def test_adding_inflections_forces_reload
2440
      ActiveSupport::Inflector::Inflections.instance.expects(:uncountable).with('equipment')
2441 2442
      routes.expects(:reload!)

2443
      ActiveSupport::Inflector.inflections { |inflect| inflect.uncountable('equipment') }
2444
    end
2445

2446
    def test_load_with_configuration
2447 2448
      routes.configuration_files.clear
      routes.add_configuration_file("foobarbaz")
2449 2450 2451 2452 2453
      File.expects(:stat).returns(@stat)
      routes.expects(:load).with("foobarbaz")

      routes.reload
    end
2454 2455 2456 2457 2458 2459 2460 2461 2462 2463 2464
    
    def test_load_multiple_configurations
      routes.add_configuration_file("engines.rb")
      
      File.expects(:stat).at_least_once.returns(@stat)

      routes.expects(:load).with('./config/routes.rb')
      routes.expects(:load).with('engines.rb')

      routes.reload
    end
2465 2466

    private
2467 2468 2469
      def routes
        ActionController::Routing::Routes
      end
2470 2471
  end
end