has_one_associations_test.rb 18.3 KB
Newer Older
1
require "cases/helper"
2
require 'models/developer'
A
Arun Agrawal 已提交
3
require 'models/computer'
4 5
require 'models/project'
require 'models/company'
6 7
require 'models/ship'
require 'models/pirate'
8
require 'models/car'
9
require 'models/bulb'
10
require 'models/author'
11
require 'models/image'
12
require 'models/post'
13 14

class HasOneAssociationsTest < ActiveRecord::TestCase
15
  self.use_transactional_tests = false unless supports_savepoints?
16
  fixtures :accounts, :companies, :developers, :projects, :developers_projects, :ships, :pirates
17 18 19 20 21 22 23 24 25

  def setup
    Account.destroyed_account_ids.clear
  end

  def test_has_one
    assert_equal companies(:first_firm).account, Account.find(1)
    assert_equal Account.find(1).credit_limit, companies(:first_firm).account.credit_limit
  end
26

27 28 29 30 31 32 33
  def test_has_one_does_not_use_order_by
    ActiveRecord::SQLCounter.clear_log
    companies(:first_firm).account
  ensure
    assert ActiveRecord::SQLCounter.log_all.all? { |sql| /order by/i !~ sql }, 'ORDER BY was used in the query'
  end

34 35 36 37 38
  def test_has_one_cache_nils
    firm = companies(:another_firm)
    assert_queries(1) { assert_nil firm.account }
    assert_queries(0) { assert_nil firm.account }

39
    firms = Firm.all.merge!(:includes => :account).to_a
40 41 42
    assert_queries(0) { firms.each(&:account) }
  end

43 44
  def test_with_select
    assert_equal Firm.find(1).account_with_select.attributes.size, 2
45
    assert_equal Firm.all.merge!(:includes => :account_with_select).find(1).account_with_select.attributes.size, 2
46 47
  end

48 49
  def test_finding_using_primary_key
    firm = companies(:first_firm)
50
    assert_equal Account.find_by_firm_id(firm.id), firm.account
51 52 53
    firm.firm_id = companies(:rails_core).id
    assert_equal accounts(:rails_core_account), firm.account_using_primary_key
  end
54 55 56 57

  def test_update_with_foreign_and_primary_keys
    firm = companies(:first_firm)
    account = firm.account_using_foreign_and_primary_keys
58
    assert_equal Account.find_by_firm_name(firm.name), account
59 60 61 62
    firm.save
    firm.reload
    assert_equal account, firm.account_using_foreign_and_primary_keys
  end
63

64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81
  def test_can_marshal_has_one_association_with_nil_target
    firm = Firm.new
    assert_nothing_raised do
      assert_equal firm.attributes, Marshal.load(Marshal.dump(firm)).attributes
    end

    firm.account
    assert_nothing_raised do
      assert_equal firm.attributes, Marshal.load(Marshal.dump(firm)).attributes
    end
  end

  def test_proxy_assignment
    company = companies(:first_firm)
    assert_nothing_raised { company.account = company.account }
  end

  def test_type_mismatch
82 83
    assert_raise(ActiveRecord::AssociationTypeMismatch) { companies(:first_firm).account = 1 }
    assert_raise(ActiveRecord::AssociationTypeMismatch) { companies(:first_firm).account = Project.find(1) }
84 85 86 87 88 89 90 91 92 93 94 95 96 97 98
  end

  def test_natural_assignment
    apple = Firm.create("name" => "Apple")
    citibank = Account.create("credit_limit" => 10)
    apple.account = citibank
    assert_equal apple.id, citibank.firm_id
  end

  def test_natural_assignment_to_nil
    old_account_id = companies(:first_firm).account.id
    companies(:first_firm).account = nil
    companies(:first_firm).save
    assert_nil companies(:first_firm).account
    # account is dependent, therefore is destroyed when reference to owner is lost
99
    assert_raise(ActiveRecord::RecordNotFound) { Account.find(old_account_id) }
100 101
  end

102 103 104
  def test_nullification_on_association_change
    firm = companies(:rails_core)
    old_account_id = firm.account.id
105
    firm.account = Account.new(:credit_limit => 5)
106 107 108 109
    # account is dependent with nullify, therefore its firm_id should be nil
    assert_nil Account.find(old_account_id).firm_id
  end

110 111 112 113 114 115 116 117 118
  def test_natural_assignment_to_nil_after_destroy
    firm = companies(:rails_core)
    old_account_id = firm.account.id
    firm.account.destroy
    firm.account = nil
    assert_nil companies(:rails_core).account
    assert_raise(ActiveRecord::RecordNotFound) { Account.find(old_account_id) }
  end

119
  def test_association_change_calls_delete
120
    companies(:first_firm).deletable_account = Account.new(:credit_limit => 5)
121 122 123 124
    assert_equal [], Account.destroyed_account_ids[companies(:first_firm).id]
  end

  def test_association_change_calls_destroy
125
    companies(:first_firm).account = Account.new(:credit_limit => 5)
126 127 128
    assert_equal [companies(:first_firm).id], Account.destroyed_account_ids[companies(:first_firm).id]
  end

129 130 131 132 133 134 135 136 137 138
  def test_natural_assignment_to_already_associated_record
    company = companies(:first_firm)
    account = accounts(:signals37)
    assert_equal company.account, account
    company.account = account
    company.reload
    account.reload
    assert_equal company.account, account
  end

139 140 141 142
  def test_dependence
    num_accounts = Account.count

    firm = Firm.find(1)
143
    assert_not_nil firm.account
144 145 146 147 148 149 150 151 152 153 154 155
    account_id = firm.account.id
    assert_equal [], Account.destroyed_account_ids[firm.id]

    firm.destroy
    assert_equal num_accounts - 1, Account.count
    assert_equal [account_id], Account.destroyed_account_ids[firm.id]
  end

  def test_exclusive_dependence
    num_accounts = Account.count

    firm = ExclusivelyDependentFirm.find(9)
156
    assert_not_nil firm.account
157 158 159 160 161 162 163 164 165 166 167 168 169
    assert_equal [], Account.destroyed_account_ids[firm.id]

    firm.destroy
    assert_equal num_accounts - 1, Account.count
    assert_equal [], Account.destroyed_account_ids[firm.id]
  end

  def test_dependence_with_nil_associate
    firm = DependentFirm.new(:name => 'nullify')
    firm.save!
    assert_nothing_raised { firm.destroy }
  end

170 171
  def test_restrict_with_exception
    firm = RestrictedWithExceptionFirm.create!(:name => 'restrict')
172 173 174 175
    firm.create_account(:credit_limit => 10)

    assert_not_nil firm.account

176 177
    assert_raise(ActiveRecord::DeleteRestrictionError) { firm.destroy }
    assert RestrictedWithExceptionFirm.exists?(:name => 'restrict')
178
    assert firm.account.present?
179 180
  end

181 182
  def test_restrict_with_error
    firm = RestrictedWithErrorFirm.create!(:name => 'restrict')
183 184 185 186 187 188 189
    firm.create_account(:credit_limit => 10)

    assert_not_nil firm.account

    firm.destroy

    assert !firm.errors.empty?
190 191
    assert_equal "Cannot delete record because a dependent account exists", firm.errors[:base].first
    assert RestrictedWithErrorFirm.exists?(:name => 'restrict')
192 193 194
    assert firm.account.present?
  end

195
  def test_successful_build_association
196 197 198 199 200 201 202 203
    firm = Firm.new("name" => "GlobalMegaCorp")
    firm.save

    account = firm.build_account("credit_limit" => 1000)
    assert account.save
    assert_equal account, firm.account
  end

204
  def test_build_association_dont_create_transaction
205
    assert_no_queries(ignore_none: false) {
206 207 208 209
      Firm.new.build_account
    }
  end

210 211 212
  def test_building_the_associated_object_with_implicit_sti_base_class
    firm = DependentFirm.new
    company = firm.build_company
213
    assert_kind_of Company, company, "Expected #{company.class} to be a Company"
214 215 216 217 218
  end

  def test_building_the_associated_object_with_explicit_sti_base_class
    firm = DependentFirm.new
    company = firm.build_company(:type => "Company")
219
    assert_kind_of Company, company, "Expected #{company.class} to be a Company"
220 221 222 223 224
  end

  def test_building_the_associated_object_with_sti_subclass
    firm = DependentFirm.new
    company = firm.build_company(:type => "Client")
225
    assert_kind_of Client, company, "Expected #{company.class} to be a Client"
226 227 228 229 230 231 232 233 234 235 236 237
  end

  def test_building_the_associated_object_with_an_invalid_type
    firm = DependentFirm.new
    assert_raise(ActiveRecord::SubclassNotFound) { firm.build_company(:type => "Invalid") }
  end

  def test_building_the_associated_object_with_an_unrelated_type
    firm = DependentFirm.new
    assert_raise(ActiveRecord::SubclassNotFound) { firm.build_company(:type => "Account") }
  end

238 239
  def test_build_and_create_should_not_happen_within_scope
    pirate = pirates(:blackbeard)
240
    scope = pirate.association(:foo_bulb).scope.where_values_hash
241

242
    bulb = pirate.build_foo_bulb
243
    assert_not_equal scope, bulb.scope_after_initialize.where_values_hash
244

245
    bulb = pirate.create_foo_bulb
246
    assert_not_equal scope, bulb.scope_after_initialize.where_values_hash
247

248
    bulb = pirate.create_foo_bulb!
249
    assert_not_equal scope, bulb.scope_after_initialize.where_values_hash
250 251
  end

252 253 254 255 256 257
  def test_create_association
    firm = Firm.create(:name => "GlobalMegaCorp")
    account = firm.create_account(:credit_limit => 1000)
    assert_equal account, firm.reload.account
  end

258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275
  def test_create_association_with_bang
    firm = Firm.create(:name => "GlobalMegaCorp")
    account = firm.create_account!(:credit_limit => 1000)
    assert_equal account, firm.reload.account
  end

  def test_create_association_with_bang_failing
    firm = Firm.create(:name => "GlobalMegaCorp")
    assert_raise ActiveRecord::RecordInvalid do
      firm.create_account!
    end
    account = firm.account
    assert_not_nil account
    account.credit_limit = 5
    account.save
    assert_equal account, firm.reload.account
  end

276 277 278
  def test_create_with_inexistent_foreign_key_failing
    firm = Firm.create(name: 'GlobalMegaCorp')

R
Robin Dupret 已提交
279
    assert_raises(ActiveRecord::UnknownAttributeError) do
280 281 282 283
      firm.create_account_with_inexistent_foreign_key
    end
  end

284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309
  def test_build
    firm = Firm.new("name" => "GlobalMegaCorp")
    firm.save

    firm.account = account = Account.new("credit_limit" => 1000)
    assert_equal account, firm.account
    assert account.save
    assert_equal account, firm.account
  end

  def test_create
    firm = Firm.new("name" => "GlobalMegaCorp")
    firm.save
    firm.account = account = Account.create("credit_limit" => 1000)
    assert_equal account, firm.account
  end

  def test_create_before_save
    firm = Firm.new("name" => "GlobalMegaCorp")
    firm.account = account = Account.create("credit_limit" => 1000)
    assert_equal account, firm.account
  end

  def test_dependence_with_missing_association
    Account.destroy_all
    firm = Firm.find(1)
310
    assert_nil firm.account
311 312 313 314 315
    firm.destroy
  end

  def test_dependence_with_missing_association_and_nullify
    Account.destroy_all
316
    firm = DependentFirm.first
317
    assert_nil firm.account
318 319 320
    firm.destroy
  end

321
  def test_finding_with_interpolated_condition
322
    firm = Firm.first
323 324 325 326 327 328
    superior = firm.clients.create(:name => 'SuperiorCo')
    superior.rating = 10
    superior.save
    assert_equal 10, firm.clients_with_interpolated_conditions.first.rating
  end

329 330 331
  def test_assignment_before_child_saved
    firm = Firm.find(1)
    firm.account = a = Account.new("credit_limit" => 1000)
332
    assert a.persisted?
333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351
    assert_equal a, firm.account
    assert_equal a, firm.account
    assert_equal a, firm.account(true)
  end

  def test_save_still_works_after_accessing_nil_has_one
    jp = Company.new :name => 'Jaded Pixel'
    jp.dummy_account.nil?

    assert_nothing_raised do
      jp.save!
    end
  end

  def test_cant_save_readonly_association
    assert_raise(ActiveRecord::ReadOnlyRecord) { companies(:first_firm).readonly_account.save!  }
    assert companies(:first_firm).readonly_account.readonly?
  end

352
  def test_has_one_proxy_should_not_respond_to_private_methods
353 354
    assert_raise(NoMethodError) { accounts(:signals37).private_method }
    assert_raise(NoMethodError) { companies(:first_firm).account.private_method }
355 356 357 358 359 360 361
  end

  def test_has_one_proxy_should_respond_to_private_methods_via_send
    accounts(:signals37).send(:private_method)
    companies(:first_firm).account.send(:private_method)
  end

362 363 364 365 366 367
  def test_save_of_record_with_loaded_has_one
    @firm = companies(:first_firm)
    assert_not_nil @firm.account

    assert_nothing_raised do
      Firm.find(@firm.id).save!
368
      Firm.all.merge!(:includes => :account).find(@firm.id).save!
369 370 371 372 373 374
    end

    @firm.account.destroy

    assert_nothing_raised do
      Firm.find(@firm.id).save!
375
      Firm.all.merge!(:includes => :account).find(@firm.id).save!
376 377
    end
  end
378 379 380 381 382 383 384 385 386

  def test_build_respects_hash_condition
    account = companies(:first_firm).build_account_limit_500_with_hash_conditions
    assert account.save
    assert_equal 500, account.credit_limit
  end

  def test_create_respects_hash_condition
    account = companies(:first_firm).create_account_limit_500_with_hash_conditions
387
    assert       account.persisted?
388 389
    assert_equal 500, account.credit_limit
  end
390 391 392 393 394

  def test_attributes_are_being_set_when_initialized_from_has_one_association_with_where_clause
    new_account = companies(:first_firm).build_account(:firm_name => 'Account')
    assert_equal new_account.firm_name, "Account"
  end
395 396 397

  def test_creation_failure_without_dependent_option
    pirate = pirates(:blackbeard)
398
    orig_ship = pirate.ship
399 400 401 402 403 404 405 406 407 408 409 410

    assert_equal ships(:black_pearl), orig_ship
    new_ship = pirate.create_ship
    assert_not_equal ships(:black_pearl), new_ship
    assert_equal new_ship, pirate.ship
    assert new_ship.new_record?
    assert_nil orig_ship.pirate_id
    assert !orig_ship.changed? # check it was saved
  end

  def test_creation_failure_with_dependent_option
    pirate = pirates(:blackbeard).becomes(DestructivePirate)
411
    orig_ship = pirate.dependent_ship
412 413 414 415 416

    new_ship = pirate.create_dependent_ship
    assert new_ship.new_record?
    assert orig_ship.destroyed?
  end
417

418 419 420 421
  def test_creation_failure_due_to_new_record_should_raise_error
    pirate = pirates(:redbeard)
    new_ship = Ship.new

422
    error = assert_raise(ActiveRecord::RecordNotSaved) do
423 424
      pirate.ship = new_ship
    end
425 426

    assert_equal "Failed to save the new associated ship.", error.message
427 428 429 430
    assert_nil pirate.ship
    assert_nil new_ship.pirate_id
  end

431 432 433 434 435
  def test_replacement_failure_due_to_existing_record_should_raise_error
    pirate = pirates(:blackbeard)
    pirate.ship.name = nil

    assert !pirate.ship.valid?
436
    error = assert_raise(ActiveRecord::RecordNotSaved) do
437 438
      pirate.ship = ships(:interceptor)
    end
439

440 441
    assert_equal ships(:black_pearl), pirate.ship
    assert_equal pirate.id, pirate.ship.pirate_id
442 443
    assert_equal "Failed to remove the existing associated ship. " +
                 "The record failed to save after its foreign key was set to nil.", error.message
444
  end
445 446 447 448 449

  def test_replacement_failure_due_to_new_record_should_raise_error
    pirate = pirates(:blackbeard)
    new_ship = Ship.new

450
    error = assert_raise(ActiveRecord::RecordNotSaved) do
451 452
      pirate.ship = new_ship
    end
453 454

    assert_equal "Failed to save the new associated ship.", error.message
455 456 457 458
    assert_equal ships(:black_pearl), pirate.ship
    assert_equal pirate.id, pirate.ship.pirate_id
    assert_equal pirate.id, ships(:black_pearl).reload.pirate_id
    assert_nil new_ship.pirate_id
459
  end
460

461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476
  def test_association_keys_bypass_attribute_protection
    car = Car.create(:name => 'honda')

    bulb = car.build_bulb
    assert_equal car.id, bulb.car_id

    bulb = car.build_bulb :car_id => car.id + 1
    assert_equal car.id, bulb.car_id

    bulb = car.create_bulb
    assert_equal car.id, bulb.car_id

    bulb = car.create_bulb :car_id => car.id + 1
    assert_equal car.id, bulb.car_id
  end

477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492
  def test_association_protect_foreign_key
    pirate = Pirate.create!(:catchphrase => "Don' botharrr talkin' like one, savvy?")

    ship = pirate.build_ship
    assert_equal pirate.id, ship.pirate_id

    ship = pirate.build_ship :pirate_id => pirate.id + 1
    assert_equal pirate.id, ship.pirate_id

    ship = pirate.create_ship
    assert_equal pirate.id, ship.pirate_id

    ship = pirate.create_ship :pirate_id => pirate.id + 1
    assert_equal pirate.id, ship.pirate_id
  end

493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512
  def test_build_with_block
    car = Car.create(:name => 'honda')

    bulb = car.build_bulb{ |b| b.color = 'Red' }
    assert_equal 'RED!', bulb.color
  end

  def test_create_with_block
    car = Car.create(:name => 'honda')

    bulb = car.create_bulb{ |b| b.color = 'Red' }
    assert_equal 'RED!', bulb.color
  end

  def test_create_bang_with_block
    car = Car.create(:name => 'honda')

    bulb = car.create_bulb!{ |b| b.color = 'Red' }
    assert_equal 'RED!', bulb.color
  end
513 514 515 516 517 518 519

  def test_association_attributes_are_available_to_after_initialize
    car = Car.create(:name => 'honda')
    bulb = car.create_bulb

    assert_equal car.id, bulb.attributes_after_initialize['car_id']
  end
520

521 522 523 524 525 526 527 528 529 530 531
  def test_has_one_transaction
    company = companies(:first_firm)
    account = Account.find(1)

    company.account # force loading
    assert_no_queries { company.account = account }

    company.account = nil
    assert_no_queries { company.account = nil }
    account = Account.find(2)
    assert_queries { company.account = account }
532 533

    assert_no_queries { Firm.new.account = account }
534
  end
535

C
Carlos Antonio da Silva 已提交
536
  def test_has_one_assignment_dont_trigger_save_on_change_of_same_object
537 538 539 540 541 542
    pirate = Pirate.create!(catchphrase: "Don' botharrr talkin' like one, savvy?")
    ship = pirate.build_ship(name: 'old name')
    ship.save!

    ship.name = 'new name'
    assert ship.changed?
543 544 545 546 547 548 549 550 551 552 553 554 555 556
    assert_queries(1) do
      # One query for updating name, not triggering query for updating pirate_id
      pirate.ship = ship
    end

    assert_equal 'new name', pirate.ship.reload.name
  end

  def test_has_one_assignment_triggers_save_on_change_on_replacing_object
    pirate = Pirate.create!(catchphrase: "Don' botharrr talkin' like one, savvy?")
    ship = pirate.build_ship(name: 'old name')
    ship.save!

    new_ship = Ship.create(name: 'new name')
557 558
    assert_queries(2) do
      # One query for updating name and second query for updating pirate_id
559
      pirate.ship = new_ship
560 561 562 563 564
    end

    assert_equal 'new name', pirate.ship.reload.name
  end

565 566 567 568 569 570 571 572 573 574 575
  def test_has_one_autosave_with_primary_key_manually_set
    post = Post.create(id: 1234, title: "Some title", body: 'Some content')
    author = Author.new(id: 33, name: 'Hank Moody')

    author.post = post
    author.save
    author.reload

    assert_not_nil author.post
    assert_equal author.post, post
  end
576

577 578 579
  def test_has_one_loading_for_new_record
    post = Post.create!(author_id: 42, title: 'foo', body: 'bar')
    author = Author.new(id: 42)
580
    assert_equal post, author.post
581 582
  end

583 584 585 586 587 588 589
  def test_has_one_relationship_cannot_have_a_counter_cache
    assert_raise(ArgumentError) do
      Class.new(ActiveRecord::Base) do
        has_one :thing, counter_cache: true
      end
    end
  end
590

591 592 593 594 595 596 597 598 599 600
  def test_with_polymorphic_has_one_with_custom_columns_name
    post = Post.create! :title => 'foo', :body => 'bar'
    image = Image.create!

    post.main_image = image
    post.reload

    assert_equal image, post.main_image
  end

601 602 603 604 605 606 607 608 609
  test 'dangerous association name raises ArgumentError' do
    [:errors, 'errors', :save, 'save'].each do |name|
      assert_raises(ArgumentError, "Association #{name} should not be allowed") do
        Class.new(ActiveRecord::Base) do
          has_one name
        end
      end
    end
  end
610
end