has_one_associations_test.rb 17.7 KB
Newer Older
1
require "cases/helper"
2
require 'models/developer'
A
Arun Agrawal 已提交
3
require 'models/computer'
4 5
require 'models/project'
require 'models/company'
6 7
require 'models/ship'
require 'models/pirate'
8
require 'models/car'
9
require 'models/bulb'
10 11
require 'models/author'
require 'models/post'
12 13

class HasOneAssociationsTest < ActiveRecord::TestCase
14
  self.use_transactional_fixtures = false unless supports_savepoints?
15
  fixtures :accounts, :companies, :developers, :projects, :developers_projects, :ships, :pirates
16 17 18 19 20 21 22 23 24

  def setup
    Account.destroyed_account_ids.clear
  end

  def test_has_one
    assert_equal companies(:first_firm).account, Account.find(1)
    assert_equal Account.find(1).credit_limit, companies(:first_firm).account.credit_limit
  end
25

26 27 28 29 30 31 32
  def test_has_one_does_not_use_order_by
    ActiveRecord::SQLCounter.clear_log
    companies(:first_firm).account
  ensure
    assert ActiveRecord::SQLCounter.log_all.all? { |sql| /order by/i !~ sql }, 'ORDER BY was used in the query'
  end

33 34 35 36 37
  def test_has_one_cache_nils
    firm = companies(:another_firm)
    assert_queries(1) { assert_nil firm.account }
    assert_queries(0) { assert_nil firm.account }

38
    firms = Firm.all.merge!(:includes => :account).to_a
39 40 41
    assert_queries(0) { firms.each(&:account) }
  end

42 43
  def test_with_select
    assert_equal Firm.find(1).account_with_select.attributes.size, 2
44
    assert_equal Firm.all.merge!(:includes => :account_with_select).find(1).account_with_select.attributes.size, 2
45 46
  end

47 48
  def test_finding_using_primary_key
    firm = companies(:first_firm)
49
    assert_equal Account.find_by_firm_id(firm.id), firm.account
50 51 52
    firm.firm_id = companies(:rails_core).id
    assert_equal accounts(:rails_core_account), firm.account_using_primary_key
  end
53 54 55 56

  def test_update_with_foreign_and_primary_keys
    firm = companies(:first_firm)
    account = firm.account_using_foreign_and_primary_keys
57
    assert_equal Account.find_by_firm_name(firm.name), account
58 59 60 61
    firm.save
    firm.reload
    assert_equal account, firm.account_using_foreign_and_primary_keys
  end
62

63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80
  def test_can_marshal_has_one_association_with_nil_target
    firm = Firm.new
    assert_nothing_raised do
      assert_equal firm.attributes, Marshal.load(Marshal.dump(firm)).attributes
    end

    firm.account
    assert_nothing_raised do
      assert_equal firm.attributes, Marshal.load(Marshal.dump(firm)).attributes
    end
  end

  def test_proxy_assignment
    company = companies(:first_firm)
    assert_nothing_raised { company.account = company.account }
  end

  def test_type_mismatch
81 82
    assert_raise(ActiveRecord::AssociationTypeMismatch) { companies(:first_firm).account = 1 }
    assert_raise(ActiveRecord::AssociationTypeMismatch) { companies(:first_firm).account = Project.find(1) }
83 84 85 86 87 88 89 90 91 92 93 94 95 96 97
  end

  def test_natural_assignment
    apple = Firm.create("name" => "Apple")
    citibank = Account.create("credit_limit" => 10)
    apple.account = citibank
    assert_equal apple.id, citibank.firm_id
  end

  def test_natural_assignment_to_nil
    old_account_id = companies(:first_firm).account.id
    companies(:first_firm).account = nil
    companies(:first_firm).save
    assert_nil companies(:first_firm).account
    # account is dependent, therefore is destroyed when reference to owner is lost
98
    assert_raise(ActiveRecord::RecordNotFound) { Account.find(old_account_id) }
99 100
  end

101 102 103
  def test_nullification_on_association_change
    firm = companies(:rails_core)
    old_account_id = firm.account.id
104
    firm.account = Account.new(:credit_limit => 5)
105 106 107 108
    # account is dependent with nullify, therefore its firm_id should be nil
    assert_nil Account.find(old_account_id).firm_id
  end

109 110 111 112 113 114 115 116 117
  def test_natural_assignment_to_nil_after_destroy
    firm = companies(:rails_core)
    old_account_id = firm.account.id
    firm.account.destroy
    firm.account = nil
    assert_nil companies(:rails_core).account
    assert_raise(ActiveRecord::RecordNotFound) { Account.find(old_account_id) }
  end

118
  def test_association_change_calls_delete
119
    companies(:first_firm).deletable_account = Account.new(:credit_limit => 5)
120 121 122 123
    assert_equal [], Account.destroyed_account_ids[companies(:first_firm).id]
  end

  def test_association_change_calls_destroy
124
    companies(:first_firm).account = Account.new(:credit_limit => 5)
125 126 127
    assert_equal [companies(:first_firm).id], Account.destroyed_account_ids[companies(:first_firm).id]
  end

128 129 130 131 132 133 134 135 136 137
  def test_natural_assignment_to_already_associated_record
    company = companies(:first_firm)
    account = accounts(:signals37)
    assert_equal company.account, account
    company.account = account
    company.reload
    account.reload
    assert_equal company.account, account
  end

138 139 140 141
  def test_dependence
    num_accounts = Account.count

    firm = Firm.find(1)
142
    assert_not_nil firm.account
143 144 145 146 147 148 149 150 151 152 153 154
    account_id = firm.account.id
    assert_equal [], Account.destroyed_account_ids[firm.id]

    firm.destroy
    assert_equal num_accounts - 1, Account.count
    assert_equal [account_id], Account.destroyed_account_ids[firm.id]
  end

  def test_exclusive_dependence
    num_accounts = Account.count

    firm = ExclusivelyDependentFirm.find(9)
155
    assert_not_nil firm.account
156 157 158 159 160 161 162 163 164 165 166 167 168
    assert_equal [], Account.destroyed_account_ids[firm.id]

    firm.destroy
    assert_equal num_accounts - 1, Account.count
    assert_equal [], Account.destroyed_account_ids[firm.id]
  end

  def test_dependence_with_nil_associate
    firm = DependentFirm.new(:name => 'nullify')
    firm.save!
    assert_nothing_raised { firm.destroy }
  end

169 170
  def test_restrict_with_exception
    firm = RestrictedWithExceptionFirm.create!(:name => 'restrict')
171 172 173 174
    firm.create_account(:credit_limit => 10)

    assert_not_nil firm.account

175 176
    assert_raise(ActiveRecord::DeleteRestrictionError) { firm.destroy }
    assert RestrictedWithExceptionFirm.exists?(:name => 'restrict')
177
    assert firm.account.present?
178 179
  end

180 181
  def test_restrict_with_error
    firm = RestrictedWithErrorFirm.create!(:name => 'restrict')
182 183 184 185 186 187 188
    firm.create_account(:credit_limit => 10)

    assert_not_nil firm.account

    firm.destroy

    assert !firm.errors.empty?
189 190
    assert_equal "Cannot delete record because a dependent account exists", firm.errors[:base].first
    assert RestrictedWithErrorFirm.exists?(:name => 'restrict')
191 192 193
    assert firm.account.present?
  end

194
  def test_successful_build_association
195 196 197 198 199 200 201 202
    firm = Firm.new("name" => "GlobalMegaCorp")
    firm.save

    account = firm.build_account("credit_limit" => 1000)
    assert account.save
    assert_equal account, firm.account
  end

203
  def test_build_association_dont_create_transaction
204
    assert_no_queries(ignore_none: false) {
205 206 207 208
      Firm.new.build_account
    }
  end

209 210 211
  def test_building_the_associated_object_with_implicit_sti_base_class
    firm = DependentFirm.new
    company = firm.build_company
212
    assert_kind_of Company, company, "Expected #{company.class} to be a Company"
213 214 215 216 217
  end

  def test_building_the_associated_object_with_explicit_sti_base_class
    firm = DependentFirm.new
    company = firm.build_company(:type => "Company")
218
    assert_kind_of Company, company, "Expected #{company.class} to be a Company"
219 220 221 222 223
  end

  def test_building_the_associated_object_with_sti_subclass
    firm = DependentFirm.new
    company = firm.build_company(:type => "Client")
224
    assert_kind_of Client, company, "Expected #{company.class} to be a Client"
225 226 227 228 229 230 231 232 233 234 235 236
  end

  def test_building_the_associated_object_with_an_invalid_type
    firm = DependentFirm.new
    assert_raise(ActiveRecord::SubclassNotFound) { firm.build_company(:type => "Invalid") }
  end

  def test_building_the_associated_object_with_an_unrelated_type
    firm = DependentFirm.new
    assert_raise(ActiveRecord::SubclassNotFound) { firm.build_company(:type => "Account") }
  end

237 238
  def test_build_and_create_should_not_happen_within_scope
    pirate = pirates(:blackbeard)
J
Jon Leighton 已提交
239
    scoped_count = pirate.association(:foo_bulb).scope.where_values.count
240

241 242
    bulb = pirate.build_foo_bulb
    assert_not_equal scoped_count, bulb.scope_after_initialize.where_values.count
243

244 245
    bulb = pirate.create_foo_bulb
    assert_not_equal scoped_count, bulb.scope_after_initialize.where_values.count
246

247 248
    bulb = pirate.create_foo_bulb!
    assert_not_equal scoped_count, bulb.scope_after_initialize.where_values.count
249 250
  end

251 252 253 254 255 256
  def test_create_association
    firm = Firm.create(:name => "GlobalMegaCorp")
    account = firm.create_account(:credit_limit => 1000)
    assert_equal account, firm.reload.account
  end

257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274
  def test_create_association_with_bang
    firm = Firm.create(:name => "GlobalMegaCorp")
    account = firm.create_account!(:credit_limit => 1000)
    assert_equal account, firm.reload.account
  end

  def test_create_association_with_bang_failing
    firm = Firm.create(:name => "GlobalMegaCorp")
    assert_raise ActiveRecord::RecordInvalid do
      firm.create_account!
    end
    account = firm.account
    assert_not_nil account
    account.credit_limit = 5
    account.save
    assert_equal account, firm.reload.account
  end

275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300
  def test_build
    firm = Firm.new("name" => "GlobalMegaCorp")
    firm.save

    firm.account = account = Account.new("credit_limit" => 1000)
    assert_equal account, firm.account
    assert account.save
    assert_equal account, firm.account
  end

  def test_create
    firm = Firm.new("name" => "GlobalMegaCorp")
    firm.save
    firm.account = account = Account.create("credit_limit" => 1000)
    assert_equal account, firm.account
  end

  def test_create_before_save
    firm = Firm.new("name" => "GlobalMegaCorp")
    firm.account = account = Account.create("credit_limit" => 1000)
    assert_equal account, firm.account
  end

  def test_dependence_with_missing_association
    Account.destroy_all
    firm = Firm.find(1)
301
    assert_nil firm.account
302 303 304 305 306
    firm.destroy
  end

  def test_dependence_with_missing_association_and_nullify
    Account.destroy_all
307
    firm = DependentFirm.first
308
    assert_nil firm.account
309 310 311
    firm.destroy
  end

312
  def test_finding_with_interpolated_condition
313
    firm = Firm.first
314 315 316 317 318 319
    superior = firm.clients.create(:name => 'SuperiorCo')
    superior.rating = 10
    superior.save
    assert_equal 10, firm.clients_with_interpolated_conditions.first.rating
  end

320 321 322
  def test_assignment_before_child_saved
    firm = Firm.find(1)
    firm.account = a = Account.new("credit_limit" => 1000)
323
    assert a.persisted?
324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342
    assert_equal a, firm.account
    assert_equal a, firm.account
    assert_equal a, firm.account(true)
  end

  def test_save_still_works_after_accessing_nil_has_one
    jp = Company.new :name => 'Jaded Pixel'
    jp.dummy_account.nil?

    assert_nothing_raised do
      jp.save!
    end
  end

  def test_cant_save_readonly_association
    assert_raise(ActiveRecord::ReadOnlyRecord) { companies(:first_firm).readonly_account.save!  }
    assert companies(:first_firm).readonly_account.readonly?
  end

343
  def test_has_one_proxy_should_not_respond_to_private_methods
344 345
    assert_raise(NoMethodError) { accounts(:signals37).private_method }
    assert_raise(NoMethodError) { companies(:first_firm).account.private_method }
346 347 348 349 350 351 352
  end

  def test_has_one_proxy_should_respond_to_private_methods_via_send
    accounts(:signals37).send(:private_method)
    companies(:first_firm).account.send(:private_method)
  end

353 354 355 356 357 358
  def test_save_of_record_with_loaded_has_one
    @firm = companies(:first_firm)
    assert_not_nil @firm.account

    assert_nothing_raised do
      Firm.find(@firm.id).save!
359
      Firm.all.merge!(:includes => :account).find(@firm.id).save!
360 361 362 363 364 365
    end

    @firm.account.destroy

    assert_nothing_raised do
      Firm.find(@firm.id).save!
366
      Firm.all.merge!(:includes => :account).find(@firm.id).save!
367 368
    end
  end
369 370 371 372 373 374 375 376 377

  def test_build_respects_hash_condition
    account = companies(:first_firm).build_account_limit_500_with_hash_conditions
    assert account.save
    assert_equal 500, account.credit_limit
  end

  def test_create_respects_hash_condition
    account = companies(:first_firm).create_account_limit_500_with_hash_conditions
378
    assert       account.persisted?
379 380
    assert_equal 500, account.credit_limit
  end
381 382 383 384 385

  def test_attributes_are_being_set_when_initialized_from_has_one_association_with_where_clause
    new_account = companies(:first_firm).build_account(:firm_name => 'Account')
    assert_equal new_account.firm_name, "Account"
  end
386 387 388

  def test_creation_failure_without_dependent_option
    pirate = pirates(:blackbeard)
389
    orig_ship = pirate.ship
390 391 392 393 394 395 396 397 398 399 400 401

    assert_equal ships(:black_pearl), orig_ship
    new_ship = pirate.create_ship
    assert_not_equal ships(:black_pearl), new_ship
    assert_equal new_ship, pirate.ship
    assert new_ship.new_record?
    assert_nil orig_ship.pirate_id
    assert !orig_ship.changed? # check it was saved
  end

  def test_creation_failure_with_dependent_option
    pirate = pirates(:blackbeard).becomes(DestructivePirate)
402
    orig_ship = pirate.dependent_ship
403 404 405 406 407

    new_ship = pirate.create_dependent_ship
    assert new_ship.new_record?
    assert orig_ship.destroyed?
  end
408

409 410 411 412
  def test_creation_failure_due_to_new_record_should_raise_error
    pirate = pirates(:redbeard)
    new_ship = Ship.new

413
    error = assert_raise(ActiveRecord::RecordNotSaved) do
414 415
      pirate.ship = new_ship
    end
416 417

    assert_equal "Failed to save the new associated ship.", error.message
418 419 420 421
    assert_nil pirate.ship
    assert_nil new_ship.pirate_id
  end

422 423 424 425 426
  def test_replacement_failure_due_to_existing_record_should_raise_error
    pirate = pirates(:blackbeard)
    pirate.ship.name = nil

    assert !pirate.ship.valid?
427
    error = assert_raise(ActiveRecord::RecordNotSaved) do
428 429
      pirate.ship = ships(:interceptor)
    end
430

431 432
    assert_equal ships(:black_pearl), pirate.ship
    assert_equal pirate.id, pirate.ship.pirate_id
433 434
    assert_equal "Failed to remove the existing associated ship. " +
                 "The record failed to save after its foreign key was set to nil.", error.message
435
  end
436 437 438 439 440

  def test_replacement_failure_due_to_new_record_should_raise_error
    pirate = pirates(:blackbeard)
    new_ship = Ship.new

441
    error = assert_raise(ActiveRecord::RecordNotSaved) do
442 443
      pirate.ship = new_ship
    end
444 445

    assert_equal "Failed to save the new associated ship.", error.message
446 447 448 449
    assert_equal ships(:black_pearl), pirate.ship
    assert_equal pirate.id, pirate.ship.pirate_id
    assert_equal pirate.id, ships(:black_pearl).reload.pirate_id
    assert_nil new_ship.pirate_id
450
  end
451

452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467
  def test_association_keys_bypass_attribute_protection
    car = Car.create(:name => 'honda')

    bulb = car.build_bulb
    assert_equal car.id, bulb.car_id

    bulb = car.build_bulb :car_id => car.id + 1
    assert_equal car.id, bulb.car_id

    bulb = car.create_bulb
    assert_equal car.id, bulb.car_id

    bulb = car.create_bulb :car_id => car.id + 1
    assert_equal car.id, bulb.car_id
  end

468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483
  def test_association_protect_foreign_key
    pirate = Pirate.create!(:catchphrase => "Don' botharrr talkin' like one, savvy?")

    ship = pirate.build_ship
    assert_equal pirate.id, ship.pirate_id

    ship = pirate.build_ship :pirate_id => pirate.id + 1
    assert_equal pirate.id, ship.pirate_id

    ship = pirate.create_ship
    assert_equal pirate.id, ship.pirate_id

    ship = pirate.create_ship :pirate_id => pirate.id + 1
    assert_equal pirate.id, ship.pirate_id
  end

484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503
  def test_build_with_block
    car = Car.create(:name => 'honda')

    bulb = car.build_bulb{ |b| b.color = 'Red' }
    assert_equal 'RED!', bulb.color
  end

  def test_create_with_block
    car = Car.create(:name => 'honda')

    bulb = car.create_bulb{ |b| b.color = 'Red' }
    assert_equal 'RED!', bulb.color
  end

  def test_create_bang_with_block
    car = Car.create(:name => 'honda')

    bulb = car.create_bulb!{ |b| b.color = 'Red' }
    assert_equal 'RED!', bulb.color
  end
504 505 506 507 508 509 510

  def test_association_attributes_are_available_to_after_initialize
    car = Car.create(:name => 'honda')
    bulb = car.create_bulb

    assert_equal car.id, bulb.attributes_after_initialize['car_id']
  end
511

512 513 514 515 516 517 518 519 520 521 522
  def test_has_one_transaction
    company = companies(:first_firm)
    account = Account.find(1)

    company.account # force loading
    assert_no_queries { company.account = account }

    company.account = nil
    assert_no_queries { company.account = nil }
    account = Account.find(2)
    assert_queries { company.account = account }
523 524

    assert_no_queries { Firm.new.account = account }
525
  end
526

C
Carlos Antonio da Silva 已提交
527
  def test_has_one_assignment_dont_trigger_save_on_change_of_same_object
528 529 530 531 532 533
    pirate = Pirate.create!(catchphrase: "Don' botharrr talkin' like one, savvy?")
    ship = pirate.build_ship(name: 'old name')
    ship.save!

    ship.name = 'new name'
    assert ship.changed?
534 535 536 537 538 539 540 541 542 543 544 545 546 547
    assert_queries(1) do
      # One query for updating name, not triggering query for updating pirate_id
      pirate.ship = ship
    end

    assert_equal 'new name', pirate.ship.reload.name
  end

  def test_has_one_assignment_triggers_save_on_change_on_replacing_object
    pirate = Pirate.create!(catchphrase: "Don' botharrr talkin' like one, savvy?")
    ship = pirate.build_ship(name: 'old name')
    ship.save!

    new_ship = Ship.create(name: 'new name')
548 549
    assert_queries(2) do
      # One query for updating name and second query for updating pirate_id
550
      pirate.ship = new_ship
551 552 553 554 555
    end

    assert_equal 'new name', pirate.ship.reload.name
  end

556 557 558 559 560 561 562 563 564 565 566
  def test_has_one_autosave_with_primary_key_manually_set
    post = Post.create(id: 1234, title: "Some title", body: 'Some content')
    author = Author.new(id: 33, name: 'Hank Moody')

    author.post = post
    author.save
    author.reload

    assert_not_nil author.post
    assert_equal author.post, post
  end
567 568 569 570 571 572 573 574

  def test_has_one_relationship_cannot_have_a_counter_cache
    assert_raise(ArgumentError) do
      Class.new(ActiveRecord::Base) do
        has_one :thing, counter_cache: true
      end
    end
  end
575 576 577 578 579 580 581 582 583 584

  test 'dangerous association name raises ArgumentError' do
    [:errors, 'errors', :save, 'save'].each do |name|
      assert_raises(ArgumentError, "Association #{name} should not be allowed") do
        Class.new(ActiveRecord::Base) do
          has_one name
        end
      end
    end
  end
585
end