relations_test.rb 39.3 KB
Newer Older
1
require "cases/helper"
2
require 'models/tag'
3
require 'models/tagging'
4 5
require 'models/post'
require 'models/topic'
6
require 'models/comment'
7
require 'models/author'
8
require 'models/comment'
9 10
require 'models/entrant'
require 'models/developer'
11
require 'models/reply'
12
require 'models/company'
13
require 'models/bird'
14 15 16
require 'models/car'
require 'models/engine'
require 'models/tyre'
17
require 'models/minivan'
18

19

E
Emilio Tagua 已提交
20
class RelationTest < ActiveRecord::TestCase
21
  fixtures :authors, :topics, :entrants, :developers, :companies, :developers_projects, :accounts, :categories, :categorizations, :posts, :comments,
22 23 24 25 26 27 28
    :tags, :taggings, :cars, :minivans

  def test_do_not_double_quote_string_id
    van = Minivan.last
    assert van
    assert_equal van.id, Minivan.where(:minivan_id => van).to_a.first.minivan_id
  end
29

30 31 32 33 34 35
  def test_do_not_double_quote_string_id_with_array
    van = Minivan.last
    assert van
    assert_equal van, Minivan.where(:minivan_id => [van]).to_a.first
  end

A
Aaron Patterson 已提交
36 37 38 39 40 41 42 43 44
  def test_bind_values
    relation = Post.scoped
    assert_equal [], relation.bind_values

    relation2 = relation.bind 'foo'
    assert_equal %w{ foo }, relation2.bind_values
    assert_equal [], relation.bind_values
  end

45
  def test_two_scopes_with_includes_should_not_drop_any_include
46
    car = Car.incl_engines.incl_tyres.first
47 48
    assert_no_queries { car.tyres.length }
    assert_no_queries { car.engines.length }
49
  end
50

51 52 53 54 55
  def test_dynamic_finder
    x = Post.where('author_id = ?', 1)
    assert x.klass.respond_to?(:find_by_id), '@klass should handle dynamic finders'
  end

56 57 58 59 60
  def test_multivalue_where
    posts = Post.where('author_id = ? AND id = ?', 1, 1)
    assert_equal 1, posts.to_a.size
  end

61 62 63 64 65 66
  def test_scoped
    topics = Topic.scoped
    assert_kind_of ActiveRecord::Relation, topics
    assert_equal 4, topics.size
  end

67 68 69 70 71 72 73 74 75 76
  def test_to_json
    assert_nothing_raised  { Bird.scoped.to_json }
    assert_nothing_raised  { Bird.scoped.all.to_json }
  end

  def test_to_yaml
    assert_nothing_raised  { Bird.scoped.to_yaml }
    assert_nothing_raised  { Bird.scoped.all.to_yaml }
  end

77 78 79 80 81
  def test_to_xml
    assert_nothing_raised  { Bird.scoped.to_xml }
    assert_nothing_raised  { Bird.scoped.all.to_xml }
  end

82 83 84 85 86 87
  def test_scoped_all
    topics = Topic.scoped.all
    assert_kind_of Array, topics
    assert_no_queries { assert_equal 4, topics.size }
  end

P
Pratik Naik 已提交
88 89 90 91 92 93 94 95 96 97 98
  def test_loaded_all
    topics = Topic.scoped

    assert_queries(1) do
      2.times { assert_equal 4, topics.all.size }
    end

    assert topics.loaded?
  end

  def test_scoped_first
P
Pratik Naik 已提交
99
    topics = Topic.scoped.order('id ASC')
P
Pratik Naik 已提交
100 101 102 103 104 105 106 107 108

    assert_queries(1) do
      2.times { assert_equal "The First Topic", topics.first.title }
    end

    assert ! topics.loaded?
  end

  def test_loaded_first
P
Pratik Naik 已提交
109
    topics = Topic.scoped.order('id ASC')
P
Pratik Naik 已提交
110 111 112 113 114 115 116 117 118

    assert_queries(1) do
      topics.all # force load
      2.times { assert_equal "The First Topic", topics.first.title }
    end

    assert topics.loaded?
  end

119 120 121 122 123 124 125 126 127
  def test_reload
    topics = Topic.scoped

    assert_queries(1) do
      2.times { topics.to_a }
    end

    assert topics.loaded?

128 129
    original_size = topics.to_a.size
    Topic.create! :title => 'fake'
130

131 132 133
    assert_queries(1) { topics.reload }
    assert_equal original_size + 1, topics.size
    assert topics.loaded?
134 135
  end

136 137 138 139 140 141 142
  def test_finiding_with_subquery
    relation = Topic.where(:approved => true)
    assert_equal relation.to_a, Topic.select('*').from(relation).to_a
    assert_equal relation.to_a, Topic.select('subquery.*').from(relation).to_a
    assert_equal relation.to_a, Topic.select('a.*').from(relation, :a).to_a
  end

143
  def test_finding_with_conditions
144 145
    assert_equal ["David"], Author.where(:name => 'David').map(&:name)
    assert_equal ['Mary'],  Author.where(["name = ?", 'Mary']).map(&:name)
146
    assert_equal ['Mary'],  Author.where("name = ?", 'Mary').map(&:name)
147 148 149
  end

  def test_finding_with_order
150
    topics = Topic.order('id')
151
    assert_equal 4, topics.to_a.size
152 153 154
    assert_equal topics(:first).title, topics.first.title
  end

155 156 157 158 159 160 161 162 163 164 165 166

  def test_finding_with_arel_order
    topics = Topic.order(Topic.arel_table[:id].asc)
    assert_equal 4, topics.to_a.size
    assert_equal topics(:first).title, topics.first.title
  end

  def test_finding_last_with_arel_order
    topics = Topic.order(Topic.arel_table[:id].asc)
    assert_equal topics(:fourth).title, topics.last.title
  end

167 168 169 170 171 172
  def test_finding_with_order_concatenated
    topics = Topic.order('author_name').order('title')
    assert_equal 4, topics.to_a.size
    assert_equal topics(:fourth).title, topics.first.title
  end

S
Sebastian Martinez 已提交
173 174 175 176 177
  def test_finding_with_reorder
    topics = Topic.order('author_name').order('title').reorder('id').all
    topics_titles = topics.map{ |t| t.title }
    assert_equal ['The First Topic', 'The Second Topic of the day', 'The Third Topic of the day', 'The Fourth Topic of the day'], topics_titles
  end
178

179
  def test_finding_with_order_and_take
180
    entrants = Entrant.order("id ASC").limit(2).to_a
181

P
Pratik Naik 已提交
182 183
    assert_equal 2, entrants.size
    assert_equal entrants(:first).name, entrants.first.name
184 185
  end

186
  def test_finding_with_cross_table_order_and_limit
187
    tags = Tag.includes(:taggings).
188 189
              order("tags.name asc", "taggings.taggable_id asc", "REPLACE('abc', taggings.taggable_type, taggings.taggable_type)").
              limit(1).to_a
190 191 192
    assert_equal 1, tags.length
  end

193
  def test_finding_with_complex_order_and_limit
194
    tags = Tag.includes(:taggings).references(:taggings).order("REPLACE('abc', taggings.taggable_type, taggings.taggable_type)").limit(1).to_a
195 196 197 198
    assert_equal 1, tags.length
  end

  def test_finding_with_complex_order
199
    tags = Tag.includes(:taggings).references(:taggings).order("REPLACE('abc', taggings.taggable_type, taggings.taggable_type)").to_a
200
    assert_equal 3, tags.length
201 202
  end

203
  def test_finding_with_order_limit_and_offset
204
    entrants = Entrant.order("id ASC").limit(2).offset(1)
205

206
    assert_equal 2, entrants.to_a.size
P
Pratik Naik 已提交
207
    assert_equal entrants(:second).name, entrants.first.name
208

209
    entrants = Entrant.order("id ASC").limit(2).offset(2)
210
    assert_equal 1, entrants.to_a.size
P
Pratik Naik 已提交
211
    assert_equal entrants(:third).name, entrants.first.name
212 213 214
  end

  def test_finding_with_group
215
    developers = Developer.group("salary").select("salary").to_a
216 217 218 219
    assert_equal 4, developers.size
    assert_equal 4, developers.map(&:salary).uniq.size
  end

220 221
  def test_select_with_block
    even_ids = Developer.scoped.select {|d| d.id % 2 == 0 }.map(&:id)
222
    assert_equal [2, 4, 6, 8, 10], even_ids.sort
223 224
  end

225 226 227 228
  def test_none
    assert_no_queries do
      assert_equal [], Developer.none
      assert_equal [], Developer.scoped.none
229
      assert           Developer.none.is_a?(ActiveRecord::NullRelation)
230 231 232 233 234 235 236 237 238
    end
  end

  def test_none_chainable
    assert_no_queries do
      assert_equal [], Developer.none.where(:name => 'David')
    end
  end

239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264
  def test_none_chained_to_methods_firing_queries_straight_to_db
    assert_no_queries do
      assert_equal [],    Developer.none.pluck(:id) # => uses select_all
      assert_equal 0,     Developer.none.delete_all
      assert_equal 0,     Developer.none.update_all(:name => 'David')
      assert_equal 0,     Developer.none.delete(1)
      assert_equal false, Developer.none.exists?(1)
    end
  end

  def test_null_relation_content_size_methods
    assert_no_queries do
      assert_equal 0,     Developer.none.size
      assert_equal 0,     Developer.none.count
      assert_equal true,  Developer.none.empty?
      assert_equal false, Developer.none.any?
      assert_equal false, Developer.none.many?
    end
  end

  def test_null_relation_calculations_methods
    assert_no_queries do
      assert_equal 0,     Developer.none.count
      assert_equal nil,   Developer.none.calculate(:average, 'salary')
    end
  end
265

266 267 268 269 270
  def test_null_relation_metadata_methods
    assert_equal "", Developer.none.to_sql
    assert_equal({}, Developer.none.where_values_hash)
  end

271 272 273 274
  def test_joins_with_nil_argument
    assert_nothing_raised { DependentFirm.joins(nil).first }
  end

275
  def test_finding_with_hash_conditions_on_joined_table
276
    firms = DependentFirm.joins(:account).where({:name => 'RailsCore', :accounts => { :credit_limit => 55..60 }}).to_a
277 278 279 280 281
    assert_equal 1, firms.size
    assert_equal companies(:rails_core), firms.first
  end

  def test_find_all_with_join
282
    developers_on_project_one = Developer.joins('LEFT JOIN developers_projects ON developers.id = developers_projects.developer_id').
283
      where('project_id=1').to_a
284 285 286 287 288 289 290 291

    assert_equal 3, developers_on_project_one.length
    developer_names = developers_on_project_one.map { |d| d.name }
    assert developer_names.include?('David')
    assert developer_names.include?('Jamis')
  end

  def test_find_on_hash_conditions
J
Jon Leighton 已提交
292
    assert_equal Topic.scoped(:where => {:approved => false}).all, Topic.where({ :approved => false }).to_a
293 294 295
  end

  def test_joins_with_string_array
296
    person_with_reader_and_post = Post.joins([
297 298 299 300 301 302
        "INNER JOIN categorizations ON categorizations.post_id = posts.id",
        "INNER JOIN categories ON categories.id = categorizations.category_id AND categories.type = 'SpecialCategory'"
      ]
    ).to_a
    assert_equal 1, person_with_reader_and_post.size
  end
303

304 305
  def test_scoped_responds_to_delegated_methods
    relation = Topic.scoped
306 307

    ["map", "uniq", "sort", "insert", "delete", "update"].each do |method|
308
      assert_respond_to relation, method, "Topic.scoped should respond to #{method.inspect}"
309 310 311
    end
  end

312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330
  def test_respond_to_delegates_to_relation
    relation = Topic.scoped
    fake_arel = Struct.new(:responds) {
      def respond_to? method, access = false
        responds << [method, access]
      end
    }.new []

    relation.extend(Module.new { attr_accessor :arel })
    relation.arel = fake_arel

    relation.respond_to?(:matching_attributes)
    assert_equal [:matching_attributes, false], fake_arel.responds.first

    fake_arel.responds = []
    relation.respond_to?(:matching_attributes, true)
    assert_equal [:matching_attributes, true], fake_arel.responds.first
  end

331 332 333 334
  def test_respond_to_dynamic_finders
    relation = Topic.scoped

    ["find_by_title", "find_by_title_and_author_name", "find_or_create_by_title", "find_or_initialize_by_title_and_author_name"].each do |method|
335
      assert_respond_to relation, method, "Topic.scoped should respond to #{method.inspect}"
336 337
    end
  end
338

339
  def test_respond_to_class_methods_and_scopes
340 341 342
    assert Topic.scoped.respond_to?(:by_lifo)
  end

343
  def test_find_with_readonly_option
344 345
    Developer.scoped.each { |d| assert !d.readonly? }
    Developer.scoped.readonly.each { |d| assert d.readonly? }
346
  end
347 348

  def test_eager_association_loading_of_stis_with_multiple_references
349
    authors = Author.eager_load(:posts => { :special_comments => { :post => [ :special_comments, :very_special_comment ] } }).
350
      order('comments.body, very_special_comments_posts.body').where('posts.id = 4').to_a
351

352 353 354 355 356 357 358
    assert_equal [authors(:david)], authors
    assert_no_queries do
      authors.first.posts.first.special_comments.first.post.special_comments
      authors.first.posts.first.special_comments.first.post.very_special_comment
    end
  end

359
  def test_find_with_preloaded_associations
360
    assert_queries(2) do
361
      posts = Post.preload(:comments).order('posts.id')
362
      assert posts.first.comments.first
363
    end
364

C
Carlos Antonio da Silva 已提交
365
    assert_queries(2) do
366
      posts = Post.preload(:comments).order('posts.id')
367
      assert posts.first.comments.first
368
    end
369

370
    assert_queries(2) do
371
      posts = Post.preload(:author).order('posts.id')
372
      assert posts.first.author
373
    end
374

C
Carlos Antonio da Silva 已提交
375
    assert_queries(2) do
376
      posts = Post.preload(:author).order('posts.id')
377 378 379
      assert posts.first.author
    end

C
Carlos Antonio da Silva 已提交
380
    assert_queries(3) do
381
      posts = Post.preload(:author, :comments).order('posts.id')
382
      assert posts.first.author
383 384 385 386 387 388
      assert posts.first.comments.first
    end
  end

  def test_find_with_included_associations
    assert_queries(2) do
389
      posts = Post.includes(:comments).order('posts.id')
390 391 392
      assert posts.first.comments.first
    end

C
Carlos Antonio da Silva 已提交
393
    assert_queries(2) do
394
      posts = Post.scoped.includes(:comments).order('posts.id')
395 396 397 398
      assert posts.first.comments.first
    end

    assert_queries(2) do
399
      posts = Post.includes(:author).order('posts.id')
400 401 402
      assert posts.first.author
    end

C
Carlos Antonio da Silva 已提交
403
    assert_queries(3) do
404
      posts = Post.includes(:author, :comments).order('posts.id')
405
      assert posts.first.author
406
      assert posts.first.comments.first
407 408
    end
  end
409

P
Pratik Naik 已提交
410
  def test_default_scope_with_conditions_string
J
Jon Leighton 已提交
411
    assert_equal Developer.where(name: 'David').map(&:id).sort, DeveloperCalledDavid.scoped.map(&:id).sort
412
    assert_nil DeveloperCalledDavid.create!.name
413 414 415
  end

  def test_default_scope_with_conditions_hash
J
Jon Leighton 已提交
416
    assert_equal Developer.where(name: 'Jamis').map(&:id).sort, DeveloperCalledJamis.scoped.map(&:id).sort
417 418 419
    assert_equal 'Jamis', DeveloperCalledJamis.create!.name
  end

420 421
  def test_default_scoping_finder_methods
    developers = DeveloperCalledDavid.order('id').map(&:id).sort
J
Jon Leighton 已提交
422
    assert_equal Developer.where(name: 'David').map(&:id).sort, developers
423 424
  end

425 426
  def test_loading_with_one_association
    posts = Post.preload(:comments)
427 428 429 430
    post = posts.find { |p| p.id == 1 }
    assert_equal 2, post.comments.size
    assert post.comments.include?(comments(:greetings))

431
    post = Post.where("posts.title = 'Welcome to the weblog'").preload(:comments).first
432 433 434
    assert_equal 2, post.comments.size
    assert post.comments.include?(comments(:greetings))

435
    posts = Post.preload(:last_comment)
436 437 438 439 440
    post = posts.find { |p| p.id == 1 }
    assert_equal Post.find(1).last_comment, post.last_comment
  end

  def test_loading_with_one_association_with_non_preload
441
    posts = Post.eager_load(:last_comment).order('comments.id DESC')
442 443 444
    post = posts.find { |p| p.id == 1 }
    assert_equal Post.find(1).last_comment, post.last_comment
  end
445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463

  def test_dynamic_find_by_attributes
    david = authors(:david)
    author = Author.preload(:taggings).find_by_id(david.id)
    expected_taggings = taggings(:welcome_general, :thinking_general)

    assert_no_queries do
      assert_equal expected_taggings, author.taggings.uniq.sort_by { |t| t.id }
    end

    authors = Author.scoped
    assert_equal david, authors.find_by_id_and_name(david.id, david.name)
    assert_equal david, authors.find_by_id_and_name!(david.id, david.name)
  end

  def test_dynamic_find_by_attributes_bang
    author = Author.scoped.find_by_id!(authors(:david).id)
    assert_equal "David", author.name

P
Pratik Naik 已提交
464
    assert_raises(ActiveRecord::RecordNotFound) { Author.scoped.find_by_id_and_name!(20, 'invalid') }
465 466
  end

P
Pratik Naik 已提交
467 468 469 470 471 472
  def test_find_id
    authors = Author.scoped

    david = authors.find(authors(:david).id)
    assert_equal 'David', david.name

P
Pratik Naik 已提交
473
    assert_raises(ActiveRecord::RecordNotFound) { authors.where(:name => 'lifo').find('42') }
P
Pratik Naik 已提交
474
  end
475

P
Pratik Naik 已提交
476 477 478 479 480 481 482 483 484 485
  def test_find_ids
    authors = Author.order('id ASC')

    results = authors.find(authors(:david).id, authors(:mary).id)
    assert_kind_of Array, results
    assert_equal 2, results.size
    assert_equal 'David', results[0].name
    assert_equal 'Mary', results[1].name
    assert_equal results, authors.find([authors(:david).id, authors(:mary).id])

P
Pratik Naik 已提交
486 487
    assert_raises(ActiveRecord::RecordNotFound) { authors.where(:name => 'lifo').find(authors(:david).id, '42') }
    assert_raises(ActiveRecord::RecordNotFound) { authors.find(['42', 43]) }
P
Pratik Naik 已提交
488 489
  end

490 491
  def test_find_in_empty_array
    authors = Author.scoped.where(:id => [])
492
    assert_blank authors.all
493 494
  end

495 496 497 498 499 500
  def test_where_with_ar_object
    author = Author.first
    authors = Author.scoped.where(:id => author)
    assert_equal 1, authors.all.length
  end

501 502 503 504 505 506
  def test_find_with_list_of_ar
    author = Author.first
    authors = Author.find([author])
    assert_equal author, authors.first
  end

507 508 509 510 511 512 513
  class Mary < Author; end

  def test_find_by_classname
    Author.create!(:name => Mary.name)
    assert_equal 1, Author.where(:name => Mary).size
  end

514 515 516 517 518 519
  def test_find_by_id_with_list_of_ar
    author = Author.first
    authors = Author.find_by_id([author])
    assert_equal author, authors
  end

520 521 522 523 524 525
  def test_find_all_using_where_twice_should_or_the_relation
    david = authors(:david)
    relation = Author.unscoped
    relation = relation.where(:name => david.name)
    relation = relation.where(:name => 'Santiago')
    relation = relation.where(:id => david.id)
A
Aaron Patterson 已提交
526
    assert_equal [], relation.all
527 528
  end

A
Aaron Patterson 已提交
529 530 531 532 533 534 535 536
  def test_multi_where_ands_queries
    relation = Author.unscoped
    david = authors(:david)
    sql = relation.where(:name => david.name).where(:name => 'Santiago').to_sql
    assert_match('AND', sql)
  end

  def test_find_all_with_multiple_should_use_and
A
Aaron Patterson 已提交
537 538 539 540 541 542 543 544
    david = authors(:david)
    relation = [
      { :name => david.name },
      { :name => 'Santiago' },
      { :name => 'tenderlove' },
    ].inject(Author.unscoped) do |memo, param|
      memo.where(param)
    end
A
Aaron Patterson 已提交
545
    assert_equal [], relation.all
A
Aaron Patterson 已提交
546
  end
A
Aaron Patterson 已提交
547

548 549 550 551 552 553 554 555 556 557
  def test_find_all_using_where_with_relation
    david = authors(:david)
    # switching the lines below would succeed in current rails
    # assert_queries(2) {
    assert_queries(1) {
      relation = Author.where(:id => Author.where(:id => david.id))
      assert_equal [david], relation.all
    }
  end

558 559 560 561 562 563 564 565 566 567
  def test_find_all_using_where_with_relation_and_alternate_primary_key
    cool_first = minivans(:cool_first)
    # switching the lines below would succeed in current rails
    # assert_queries(2) {
    assert_queries(1) {
      relation = Minivan.where(:minivan_id => Minivan.where(:name => cool_first.name))
      assert_equal [cool_first], relation.all
    }
  end

568 569 570 571 572 573 574 575 576 577 578 579 580
  def test_find_all_using_where_with_relation_does_not_alter_select_values
    david = authors(:david)

    subquery = Author.where(:id => david.id)

    assert_queries(1) {
      relation = Author.where(:id => subquery)
      assert_equal [david], relation.all
    }

    assert_equal 0, subquery.select_values.size
  end

581 582 583 584 585 586 587 588
  def test_find_all_using_where_with_relation_with_joins
    david = authors(:david)
    assert_queries(1) {
      relation = Author.where(:id => Author.joins(:posts).where(:id => david.id))
      assert_equal [david], relation.all
    }
  end

A
Aaron Patterson 已提交
589

590 591 592 593 594 595
  def test_find_all_using_where_with_relation_with_select_to_build_subquery
    david = authors(:david)
    assert_queries(1) {
      relation = Author.where(:name => Author.where(:id => david.id).select(:name))
      assert_equal [david], relation.all
    }
A
Aaron Patterson 已提交
596 597
  end

P
Pratik Naik 已提交
598 599 600 601 602
  def test_exists
    davids = Author.where(:name => 'David')
    assert davids.exists?
    assert davids.exists?(authors(:david).id)
    assert ! davids.exists?(authors(:mary).id)
P
Pratik Naik 已提交
603 604
    assert ! davids.exists?("42")
    assert ! davids.exists?(42)
605
    assert ! davids.exists?(davids.new)
P
Pratik Naik 已提交
606 607 608 609 610

    fake  = Author.where(:name => 'fake author')
    assert ! fake.exists?
    assert ! fake.exists?(authors(:david).id)
  end
611 612 613

  def test_last
    authors = Author.scoped
614
    assert_equal authors(:bob), authors.last
615 616
  end

P
Pratik Naik 已提交
617 618 619 620 621 622 623 624 625 626 627 628 629
  def test_destroy_all
    davids = Author.where(:name => 'David')

    # Force load
    assert_equal [authors(:david)], davids.to_a
    assert davids.loaded?

    assert_difference('Author.count', -1) { davids.destroy_all }

    assert_equal [], davids.to_a
    assert davids.loaded?
  end

P
Pratik Naik 已提交
630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649
  def test_delete_all
    davids = Author.where(:name => 'David')

    assert_difference('Author.count', -1) { davids.delete_all }
    assert ! davids.loaded?
  end

  def test_delete_all_loaded
    davids = Author.where(:name => 'David')

    # Force load
    assert_equal [authors(:david)], davids.to_a
    assert davids.loaded?

    assert_difference('Author.count', -1) { davids.delete_all }

    assert_equal [], davids.to_a
    assert davids.loaded?
  end

650 651 652 653
  def test_delete_all_limit_error
    assert_raises(ActiveRecord::ActiveRecordError) { Author.limit(10).delete_all }
  end

654 655 656 657
  def test_select_argument_error
    assert_raises(ArgumentError) { Developer.select }
  end

658
  def test_relation_merging
659
    devs = Developer.where("salary >= 80000").merge(Developer.limit(2)).merge(Developer.order('id ASC').where("id < 3"))
660 661
    assert_equal [developers(:david), developers(:jamis)], devs.to_a

662
    dev_with_count = Developer.limit(1).merge(Developer.order('id DESC')).merge(Developer.select('developers.*'))
663
    assert_equal [developers(:poor_jamis)], dev_with_count.to_a
664 665 666 667
  end

  def test_relation_merging_with_eager_load
    relations = []
668 669
    relations << Post.order('comments.id DESC').merge(Post.eager_load(:last_comment)).merge(Post.scoped)
    relations << Post.eager_load(:last_comment).merge(Post.order('comments.id DESC')).merge(Post.scoped)
670

671 672 673 674 675 676
    relations.each do |posts|
      post = posts.find { |p| p.id == 1 }
      assert_equal Post.find(1).last_comment, post.last_comment
    end
  end

677
  def test_relation_merging_with_locks
678
    devs = Developer.lock.where("salary >= 80000").order("id DESC").merge(Developer.limit(2))
679
    assert_present devs.locked
680 681
  end

682
  def test_relation_merging_with_preload
C
Carlos Antonio da Silva 已提交
683 684
    [Post.scoped.merge(Post.preload(:author)), Post.preload(:author).merge(Post.scoped)].each do |posts|
      assert_queries(2) { assert posts.first.author }
M
Marcin Raczkowski 已提交
685
    end
686
  end
687

688
  def test_relation_merging_with_joins
689
    comments = Comment.joins(:post).where(:body => 'Thank you for the welcome').merge(Post.where(:body => 'Such a lovely day'))
690 691 692
    assert_equal 1, comments.count
  end

P
Pratik Naik 已提交
693 694 695
  def test_count
    posts = Post.scoped

696 697 698
    assert_equal 11, posts.count
    assert_equal 11, posts.count(:all)
    assert_equal 11, posts.count(:id)
P
Pratik Naik 已提交
699 700

    assert_equal 1, posts.where('comments_count > 1').count
701
    assert_equal 9, posts.where(:comments_count => 0).count
P
Pratik Naik 已提交
702 703 704 705 706 707
  end

  def test_count_with_distinct
    posts = Post.scoped

    assert_equal 3, posts.count(:comments_count, :distinct => true)
708
    assert_equal 11, posts.count(:comments_count, :distinct => false)
P
Pratik Naik 已提交
709 710

    assert_equal 3, posts.select(:comments_count).count(:distinct => true)
711
    assert_equal 11, posts.select(:comments_count).count(:distinct => false)
P
Pratik Naik 已提交
712 713 714 715 716 717
  end

  def test_count_explicit_columns
    Post.update_all(:comments_count => nil)
    posts = Post.scoped

P
Pratik Naik 已提交
718
    assert_equal [0], posts.select('comments_count').where('id is not null').group('id').order('id').count.values.uniq
719
    assert_equal 0, posts.where('id is not null').select('comments_count').count
720

721
    assert_equal 11, posts.select('comments_count').count('id')
P
Pratik Naik 已提交
722 723 724 725
    assert_equal 0, posts.select('comments_count').count
    assert_equal 0, posts.count(:comments_count)
    assert_equal 0, posts.count('comments_count')
  end
726

727 728 729 730 731 732
  def test_multiple_selects
    post = Post.scoped.select('comments_count').select('title').order("id ASC").first
    assert_equal "Welcome to the weblog", post.title
    assert_equal 2, post.comments_count
  end

733 734 735
  def test_size
    posts = Post.scoped

736
    assert_queries(1) { assert_equal 11, posts.size }
737 738 739 740
    assert ! posts.loaded?

    best_posts = posts.where(:comments_count => 0)
    best_posts.to_a # force load
741
    assert_no_queries { assert_equal 9, best_posts.size }
742 743
  end

744
  def test_size_with_limit
745
    posts = Post.limit(10)
746

747
    assert_queries(1) { assert_equal 10, posts.size }
748 749 750 751
    assert ! posts.loaded?

    best_posts = posts.where(:comments_count => 0)
    best_posts.to_a # force load
752
    assert_no_queries { assert_equal 9, best_posts.size }
753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771
  end

  def test_size_with_zero_limit
    posts = Post.limit(0)

    assert_no_queries { assert_equal 0, posts.size }
    assert ! posts.loaded?

    posts.to_a # force load
    assert_no_queries { assert_equal 0, posts.size }
  end

  def test_empty_with_zero_limit
    posts = Post.limit(0)

    assert_no_queries { assert_equal true, posts.empty? }
    assert ! posts.loaded?
  end

772 773 774 775 776 777 778
  def test_count_complex_chained_relations
    posts = Post.select('comments_count').where('id is not null').group("author_id").where("comments_count > 0")

    expected = { 1 => 2 }
    assert_equal expected, posts.count
  end

779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795
  def test_empty
    posts = Post.scoped

    assert_queries(1) { assert_equal false, posts.empty? }
    assert ! posts.loaded?

    no_posts = posts.where(:title => "")
    assert_queries(1) { assert_equal true, no_posts.empty? }
    assert ! no_posts.loaded?

    best_posts = posts.where(:comments_count => 0)
    best_posts.to_a # force load
    assert_no_queries { assert_equal false, best_posts.empty? }
  end

  def test_empty_complex_chained_relations
    posts = Post.select("comments_count").where("id is not null").group("author_id").where("comments_count > 0")
A
Andrew White 已提交
796

797 798 799 800 801 802 803 804
    assert_queries(1) { assert_equal false, posts.empty? }
    assert ! posts.loaded?

    no_posts = posts.where(:title => "")
    assert_queries(1) { assert_equal true, no_posts.empty? }
    assert ! no_posts.loaded?
  end

P
Pratik Naik 已提交
805 806 807
  def test_any
    posts = Post.scoped

808 809 810 811 812 813 814 815
    # This test was failing when run on its own (as opposed to running the entire suite).
    # The second line in the assert_queries block was causing visit_Arel_Attributes_Attribute
    # in Arel::Visitors::ToSql to trigger a SHOW TABLES query. Running that line here causes
    # the SHOW TABLES result to be cached so we don't have to do it again in the block.
    #
    # This is obviously a rubbish fix but it's the best I can come up with for now...
    posts.where(:id => nil).any?

P
Pratik Naik 已提交
816 817 818 819 820 821 822 823 824 825 826 827 828
    assert_queries(3) do
      assert posts.any? # Uses COUNT()
      assert ! posts.where(:id => nil).any?

      assert posts.any? {|p| p.id > 0 }
      assert ! posts.any? {|p| p.id <= 0 }
    end

    assert posts.loaded?
  end

  def test_many
    posts = Post.scoped
829

P
Pratik Naik 已提交
830 831 832 833 834
    assert_queries(2) do
      assert posts.many? # Uses COUNT()
      assert posts.many? {|p| p.id > 0 }
      assert ! posts.many? {|p| p.id < 2 }
    end
835

P
Pratik Naik 已提交
836 837 838
    assert posts.loaded?
  end

839 840 841 842 843 844
  def test_many_with_limits
    posts = Post.scoped

    assert posts.many?
    assert ! posts.limit(1).many?
  end
P
Pratik Naik 已提交
845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860

  def test_build
    posts = Post.scoped

    post = posts.new
    assert_kind_of Post, post
  end

  def test_scoped_build
    posts = Post.where(:title => 'You told a lie')

    post = posts.new
    assert_kind_of Post, post
    assert_equal 'You told a lie', post.title
  end

861 862 863 864 865
  def test_create
    birds = Bird.scoped

    sparrow = birds.create
    assert_kind_of Bird, sparrow
866
    assert !sparrow.persisted?
867 868

    hen = birds.where(:name => 'hen').create
869
    assert hen.persisted?
870 871 872 873 874 875 876 877 878 879
    assert_equal 'hen', hen.name
  end

  def test_create_bang
    birds = Bird.scoped

    assert_raises(ActiveRecord::RecordInvalid) { birds.create! }

    hen = birds.where(:name => 'hen').create!
    assert_kind_of Bird, hen
880
    assert hen.persisted?
881 882
    assert_equal 'hen', hen.name
  end
P
Pratik Naik 已提交
883

884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958
  def test_first_or_create
    parrot = Bird.where(:color => 'green').first_or_create(:name => 'parrot')
    assert_kind_of Bird, parrot
    assert parrot.persisted?
    assert_equal 'parrot', parrot.name
    assert_equal 'green', parrot.color

    same_parrot = Bird.where(:color => 'green').first_or_create(:name => 'parakeet')
    assert_kind_of Bird, same_parrot
    assert same_parrot.persisted?
    assert_equal parrot, same_parrot
  end

  def test_first_or_create_with_no_parameters
    parrot = Bird.where(:color => 'green').first_or_create
    assert_kind_of Bird, parrot
    assert !parrot.persisted?
    assert_equal 'green', parrot.color
  end

  def test_first_or_create_with_block
    parrot = Bird.where(:color => 'green').first_or_create { |bird| bird.name = 'parrot' }
    assert_kind_of Bird, parrot
    assert parrot.persisted?
    assert_equal 'green', parrot.color
    assert_equal 'parrot', parrot.name

    same_parrot = Bird.where(:color => 'green').first_or_create { |bird| bird.name = 'parakeet' }
    assert_equal parrot, same_parrot
  end

  def test_first_or_create_with_array
    several_green_birds = Bird.where(:color => 'green').first_or_create([{:name => 'parrot'}, {:name => 'parakeet'}])
    assert_kind_of Array, several_green_birds
    several_green_birds.each { |bird| assert bird.persisted? }

    same_parrot = Bird.where(:color => 'green').first_or_create([{:name => 'hummingbird'}, {:name => 'macaw'}])
    assert_kind_of Bird, same_parrot
    assert_equal several_green_birds.first, same_parrot
  end

  def test_first_or_create_bang_with_valid_options
    parrot = Bird.where(:color => 'green').first_or_create!(:name => 'parrot')
    assert_kind_of Bird, parrot
    assert parrot.persisted?
    assert_equal 'parrot', parrot.name
    assert_equal 'green', parrot.color

    same_parrot = Bird.where(:color => 'green').first_or_create!(:name => 'parakeet')
    assert_kind_of Bird, same_parrot
    assert same_parrot.persisted?
    assert_equal parrot, same_parrot
  end

  def test_first_or_create_bang_with_invalid_options
    assert_raises(ActiveRecord::RecordInvalid) { Bird.where(:color => 'green').first_or_create!(:pirate_id => 1) }
  end

  def test_first_or_create_bang_with_no_parameters
    assert_raises(ActiveRecord::RecordInvalid) { Bird.where(:color => 'green').first_or_create! }
  end

  def test_first_or_create_bang_with_valid_block
    parrot = Bird.where(:color => 'green').first_or_create! { |bird| bird.name = 'parrot' }
    assert_kind_of Bird, parrot
    assert parrot.persisted?
    assert_equal 'green', parrot.color
    assert_equal 'parrot', parrot.name

    same_parrot = Bird.where(:color => 'green').first_or_create! { |bird| bird.name = 'parakeet' }
    assert_equal parrot, same_parrot
  end

  def test_first_or_create_bang_with_invalid_block
    assert_raise(ActiveRecord::RecordInvalid) do
959
      Bird.where(:color => 'green').first_or_create! { |bird| bird.pirate_id = 1 }
960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976
    end
  end

  def test_first_or_create_with_valid_array
    several_green_birds = Bird.where(:color => 'green').first_or_create!([{:name => 'parrot'}, {:name => 'parakeet'}])
    assert_kind_of Array, several_green_birds
    several_green_birds.each { |bird| assert bird.persisted? }

    same_parrot = Bird.where(:color => 'green').first_or_create!([{:name => 'hummingbird'}, {:name => 'macaw'}])
    assert_kind_of Bird, same_parrot
    assert_equal several_green_birds.first, same_parrot
  end

  def test_first_or_create_with_invalid_array
    assert_raises(ActiveRecord::RecordInvalid) { Bird.where(:color => 'green').first_or_create!([ {:name => 'parrot'}, {:pirate_id => 1} ]) }
  end

977 978
  def test_first_or_initialize
    parrot = Bird.where(:color => 'green').first_or_initialize(:name => 'parrot')
979 980 981 982 983 984 985 986
    assert_kind_of Bird, parrot
    assert !parrot.persisted?
    assert parrot.valid?
    assert parrot.new_record?
    assert_equal 'parrot', parrot.name
    assert_equal 'green', parrot.color
  end

987 988
  def test_first_or_initialize_with_no_parameters
    parrot = Bird.where(:color => 'green').first_or_initialize
989 990 991 992 993 994 995
    assert_kind_of Bird, parrot
    assert !parrot.persisted?
    assert !parrot.valid?
    assert parrot.new_record?
    assert_equal 'green', parrot.color
  end

996 997
  def test_first_or_initialize_with_block
    parrot = Bird.where(:color => 'green').first_or_initialize { |bird| bird.name = 'parrot' }
998 999 1000 1001 1002 1003 1004 1005
    assert_kind_of Bird, parrot
    assert !parrot.persisted?
    assert parrot.valid?
    assert parrot.new_record?
    assert_equal 'green', parrot.color
    assert_equal 'parrot', parrot.name
  end

1006 1007 1008 1009 1010 1011 1012 1013
  def test_explicit_create_scope
    hens = Bird.where(:name => 'hen')
    assert_equal 'hen', hens.new.name

    hens = hens.create_with(:name => 'cock')
    assert_equal 'cock', hens.new.name
  end

P
Pratik Naik 已提交
1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024
  def test_except
    relation = Post.where(:author_id => 1).order('id ASC').limit(1)
    assert_equal [posts(:welcome)], relation.all

    author_posts = relation.except(:order, :limit)
    assert_equal Post.where(:author_id => 1).all, author_posts.all

    all_posts = relation.except(:where, :order, :limit)
    assert_equal Post.all, all_posts.all
  end

E
Emilio Tagua 已提交
1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035
  def test_only
    relation = Post.where(:author_id => 1).order('id ASC').limit(1)
    assert_equal [posts(:welcome)], relation.all

    author_posts = relation.only(:where)
    assert_equal Post.where(:author_id => 1).all, author_posts.all

    all_posts = relation.only(:limit)
    assert_equal Post.limit(1).all.first, all_posts.first
  end

P
Pratik Naik 已提交
1036
  def test_anonymous_extension
1037
    relation = Post.where(:author_id => 1).order('id ASC').extending do
P
Pratik Naik 已提交
1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051
      def author
        'lifo'
      end
    end

    assert_equal "lifo", relation.author
    assert_equal "lifo", relation.limit(1).author
  end

  def test_named_extension
    relation = Post.where(:author_id => 1).order('id ASC').extending(Post::NamedExtension)
    assert_equal "lifo", relation.author
    assert_equal "lifo", relation.limit(1).author
  end
1052 1053 1054 1055

  def test_order_by_relation_attribute
    assert_equal Post.order(Post.arel_table[:title]).all, Post.order("title").all
  end
1056

1057
  def test_default_scope_order_with_scope_order
1058 1059
    assert_equal 'zyke', CoolCar.order_using_new_style.limit(1).first.name
    assert_equal 'zyke', FastCar.order_using_new_style.limit(1).first.name
1060 1061 1062
  end

  def test_order_using_scoping
1063
    car1 = CoolCar.order('id DESC').scoping do
1064
      CoolCar.scoped(:order => 'id asc').first
1065
    end
1066 1067 1068
    assert_equal 'zyke', car1.name

    car2 = FastCar.order('id DESC').scoping do
1069
      FastCar.scoped(:order => 'id asc').first
1070 1071 1072 1073 1074 1075 1076
    end
    assert_equal 'zyke', car2.name
  end

  def test_unscoped_block_style
    assert_equal 'honda', CoolCar.unscoped { CoolCar.order_using_new_style.limit(1).first.name}
    assert_equal 'honda', FastCar.unscoped { FastCar.order_using_new_style.limit(1).first.name}
1077 1078
  end

1079 1080 1081
  def test_intersection_with_array
    relation = Author.where(:name => "David")
    rails_author = relation.first
1082

1083 1084 1085
    assert_equal [rails_author], [rails_author] & relation
    assert_equal [rails_author], relation & [rails_author]
  end
1086

1087 1088 1089
  def test_primary_key
    assert_equal "id", Post.scoped.primary_key
  end
1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102

  def test_eager_loading_with_conditions_on_joins
    scope = Post.includes(:comments)

    # This references the comments table, and so it should cause the comments to be eager
    # loaded via a JOIN, rather than by subsequent queries.
    scope = scope.joins(
      Post.arel_table.create_join(
        Post.arel_table,
        Post.arel_table.create_on(Comment.arel_table[:id].eq(3))
      )
    )

1103 1104 1105
    assert_deprecated do
      assert scope.eager_loading?
    end
1106
  end
1107 1108

  def test_ordering_with_extra_spaces
1109
    assert_equal authors(:david), Author.order('id DESC , name DESC').last
1110
  end
1111 1112 1113 1114 1115 1116 1117 1118

  def test_update_all_with_joins
    comments = Comment.joins(:post).where('posts.id' => posts(:welcome).id)
    count    = comments.count

    assert_equal count, comments.update_all(:post_id => posts(:thinking).id)
    assert_equal posts(:thinking), comments(:greetings).post
  end
1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140

  def test_update_all_with_joins_and_limit
    comments = Comment.joins(:post).where('posts.id' => posts(:welcome).id).limit(1)
    assert_equal 1, comments.update_all(:post_id => posts(:thinking).id)
  end

  def test_update_all_with_joins_and_limit_and_order
    comments = Comment.joins(:post).where('posts.id' => posts(:welcome).id).order('comments.id').limit(1)
    assert_equal 1, comments.update_all(:post_id => posts(:thinking).id)
    assert_equal posts(:thinking), comments(:greetings).post
    assert_equal posts(:welcome),  comments(:more_greetings).post
  end

  def test_update_all_with_joins_and_offset
    all_comments = Comment.joins(:post).where('posts.id' => posts(:welcome).id)
    count        = all_comments.count
    comments     = all_comments.offset(1)

    assert_equal count - 1, comments.update_all(:post_id => posts(:thinking).id)
  end

  def test_update_all_with_joins_and_offset_and_order
1141
    all_comments = Comment.joins(:post).where('posts.id' => posts(:welcome).id).order('posts.id', 'comments.id')
1142 1143 1144 1145 1146 1147 1148
    count        = all_comments.count
    comments     = all_comments.offset(1)

    assert_equal count - 1, comments.update_all(:post_id => posts(:thinking).id)
    assert_equal posts(:thinking), comments(:more_greetings).post
    assert_equal posts(:welcome),  comments(:greetings).post
  end
1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164

  def test_uniq
    tag1 = Tag.create(:name => 'Foo')
    tag2 = Tag.create(:name => 'Foo')

    query = Tag.select(:name).where(:id => [tag1.id, tag2.id])

    assert_equal ['Foo', 'Foo'], query.map(&:name)
    assert_sql(/DISTINCT/) do
      assert_equal ['Foo'], query.uniq.map(&:name)
    end
    assert_sql(/DISTINCT/) do
      assert_equal ['Foo'], query.uniq(true).map(&:name)
    end
    assert_equal ['Foo', 'Foo'], query.uniq(true).uniq(false).map(&:name)
  end
1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175

  def test_references_triggers_eager_loading
    scope = Post.includes(:comments)
    assert !scope.eager_loading?
    assert scope.references(:comments).eager_loading?
  end

  def test_references_doesnt_trigger_eager_loading_if_reference_not_included
    scope = Post.references(:comments)
    assert !scope.eager_loading?
  end
1176

1177
  def test_automatically_added_where_references
1178
    scope = Post.where(:comments => { :body => "Bla" })
J
Jon Leighton 已提交
1179
    assert_equal ['comments'], scope.references_values
1180 1181

    scope = Post.where('comments.body' => 'Bla')
J
Jon Leighton 已提交
1182
    assert_equal ['comments'], scope.references_values
1183
  end
1184

1185
  def test_automatically_added_having_references
1186
    scope = Post.having(:comments => { :body => "Bla" })
J
Jon Leighton 已提交
1187
    assert_equal ['comments'], scope.references_values
1188 1189

    scope = Post.having('comments.body' => 'Bla')
J
Jon Leighton 已提交
1190
    assert_equal ['comments'], scope.references_values
1191
  end
1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209

  def test_automatically_added_order_references
    scope = Post.order('comments.body')
    assert_equal ['comments'], scope.references_values

    scope = Post.order('comments.body', 'yaks.body')
    assert_equal ['comments', 'yaks'], scope.references_values

    # Don't infer yaks, let's not go down that road again...
    scope = Post.order('comments.body, yaks.body')
    assert_equal ['comments'], scope.references_values

    scope = Post.order('comments.body asc')
    assert_equal ['comments'], scope.references_values

    scope = Post.order('foo(comments.body)')
    assert_equal [], scope.references_values
  end
1210 1211 1212 1213

  def test_presence
    topics = Topic.scoped

1214
    # the first query is triggered because there are no topics yet.
1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228
    assert_queries(1) { assert topics.present? }

    # checking if there are topics is used before you actually display them,
    # thus it shouldn't invoke an extra count query.
    assert_no_queries { assert topics.present? }
    assert_no_queries { assert !topics.blank? }

    # shows count of topics and loops after loading the query should not trigger extra queries either.
    assert_no_queries { topics.size }
    assert_no_queries { topics.length }
    assert_no_queries { topics.each }

    # count always trigger the COUNT query.
    assert_queries(1) { topics.count }
1229 1230 1231

    assert topics.loaded?
  end
1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248

  test "find_by with hash conditions returns the first matching record" do
    assert_equal posts(:eager_other), Post.order(:id).find_by(author_id: 2)
  end

  test "find_by with non-hash conditions returns the first matching record" do
    assert_equal posts(:eager_other), Post.order(:id).find_by("author_id = 2")
  end

  test "find_by with multi-arg conditions returns the first matching record" do
    assert_equal posts(:eager_other), Post.order(:id).find_by('author_id = ?', 2)
  end

  test "find_by returns nil if the record is missing" do
    assert_equal nil, Post.scoped.find_by("1 = 0")
  end

1249 1250 1251 1252
  test "find_by doesn't have implicit ordering" do
    assert_sql(/^((?!ORDER).)*$/) { Post.find_by(author_id: 2) }
  end

1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264
  test "find_by! with hash conditions returns the first matching record" do
    assert_equal posts(:eager_other), Post.order(:id).find_by!(author_id: 2)
  end

  test "find_by! with non-hash conditions returns the first matching record" do
    assert_equal posts(:eager_other), Post.order(:id).find_by!("author_id = 2")
  end

  test "find_by! with multi-arg conditions returns the first matching record" do
    assert_equal posts(:eager_other), Post.order(:id).find_by!('author_id = ?', 2)
  end

1265 1266 1267 1268
  test "find_by! doesn't have implicit ordering" do
    assert_sql(/^((?!ORDER).)*$/) { Post.find_by!(author_id: 2) }
  end

1269 1270 1271 1272 1273
  test "find_by! raises RecordNotFound if the record is missing" do
    assert_raises(ActiveRecord::RecordNotFound) do
      Post.scoped.find_by!("1 = 0")
    end
  end
P
Pratik Naik 已提交
1274
end