routing_test.rb 75.9 KB
Newer Older
1 2
require "#{File.dirname(__FILE__)}/../abstract_unit"
require "#{File.dirname(__FILE__)}/fake_controllers"
3
require 'action_controller/routing'
4

5
RunTimeTests = ARGV.include? 'time'
6
ROUTING = ActionController::Routing
7

8 9
class ROUTING::RouteBuilder
  attr_reader :warn_output
10

11 12
  def warn(msg)
    (@warn_output ||= []) << msg
13
  end
14
end
15

16
# See RFC 3986, section 3.3 for allowed path characters.
17 18 19 20 21
class UriReservedCharactersRoutingTest < Test::Unit::TestCase
  def setup
    ActionController::Routing.use_controllers! ['controller']
    @set = ActionController::Routing::RouteSet.new
    @set.draw do |map|
22
      map.connect ':controller/:action/:variable'
23
    end
24

25
    safe, unsafe = %w(: @ & = + $ , ;), %w(^ / ? # [ ])
26 27 28 29
    hex = unsafe.map { |char| '%' + char.unpack('H2').first.upcase }

    @segment = "#{safe}#{unsafe}".freeze
    @escaped = "#{safe}#{hex}".freeze
30
  end
31 32 33 34 35 36

  def test_route_generation_escapes_unsafe_path_characters
    assert_equal "/contr#{@segment}oller/act#{@escaped}ion/var#{@escaped}iable",
      @set.generate(:controller => "contr#{@segment}oller",
                    :action => "act#{@segment}ion",
                    :variable => "var#{@segment}iable")
37
  end
38 39 40 41 42 43

  def test_route_recognition_unescapes_path_components
    options = { :controller => "controller",
                :action => "act#{@segment}ion",
                :variable => "var#{@segment}iable" }
    assert_equal options, @set.recognize_path("/controller/act#{@escaped}ion/var#{@escaped}iable")
44 45 46
  end
end

47
class LegacyRouteSetTests < Test::Unit::TestCase
48 49
  attr_reader :rs
  def setup
50
    # These tests assume optimisation is on, so re-enable it.
51
    ActionController::Base.optimise_named_routes = true
52

53 54
    @rs = ::ActionController::Routing::RouteSet.new
    @rs.draw {|m| m.connect ':controller/:action/:id' }
55

56
    ActionController::Routing.use_controllers! %w(content admin/user admin/news_feed)
57
  end
58

59
  def test_default_setup
60 61 62
    assert_equal({:controller => "content", :action => 'index'}, rs.recognize_path("/content"))
    assert_equal({:controller => "content", :action => 'list'}, rs.recognize_path("/content/list"))
    assert_equal({:controller => "content", :action => 'show', :id => '10'}, rs.recognize_path("/content/show/10"))
63
    
64
    assert_equal({:controller => "admin/user", :action => 'show', :id => '10'}, rs.recognize_path("/admin/user/show/10"))
65
    
66
    assert_equal '/admin/user/show/10', rs.generate(:controller => 'admin/user', :action => 'show', :id => 10)
67
    
68 69
    assert_equal '/admin/user/show', rs.generate({:action => 'show'}, {:controller => 'admin/user', :action => 'list', :id => '10'})
    assert_equal '/admin/user/list/10', rs.generate({}, {:controller => 'admin/user', :action => 'list', :id => '10'})
70

71 72
    assert_equal '/admin/stuff', rs.generate({:controller => 'stuff'}, {:controller => 'admin/user', :action => 'list', :id => '10'})
    assert_equal '/stuff', rs.generate({:controller => '/stuff'}, {:controller => 'admin/user', :action => 'list', :id => '10'})
73
  end
74
  
75 76 77 78
  def test_ignores_leading_slash
    @rs.draw {|m| m.connect '/:controller/:action/:id'}
    test_default_setup
  end
79 80 81 82 83 84 85
  
  def test_time_recognition
    n = 10000
    if RunTimeTests
      GC.start
      rectime = Benchmark.realtime do
        n.times do
86 87 88 89 90 91
          rs.recognize_path("content")
          rs.recognize_path("content/list")
          rs.recognize_path("content/show/10")
          rs.recognize_path("admin/user")
          rs.recognize_path("admin/user/list")
          rs.recognize_path("admin/user/show/10")
92 93 94 95 96 97 98
        end
      end
      puts "\n\nRecognition (RouteSet):"
      per_url = rectime / (n * 6)
      puts "#{per_url * 1000} ms/url"
      puts "#{1 / per_url} url/s\n\n"
    end
99
  end
100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125
  def test_time_generation
    n = 5000
    if RunTimeTests
      GC.start
      pairs = [
        [{:controller => 'content', :action => 'index'}, {:controller => 'content', :action => 'show'}],
        [{:controller => 'content'}, {:controller => 'content', :action => 'index'}],   
        [{:controller => 'content', :action => 'list'}, {:controller => 'content', :action => 'index'}],
        [{:controller => 'content', :action => 'show', :id => '10'}, {:controller => 'content', :action => 'list'}],
        [{:controller => 'admin/user', :action => 'index'}, {:controller => 'admin/user', :action => 'show'}],
        [{:controller => 'admin/user'}, {:controller => 'admin/user', :action => 'index'}],
        [{:controller => 'admin/user', :action => 'list'}, {:controller => 'admin/user', :action => 'index'}],
        [{:controller => 'admin/user', :action => 'show', :id => '10'}, {:controller => 'admin/user', :action => 'list'}],
      ]
      p = nil
      gentime = Benchmark.realtime do
        n.times do
        pairs.each {|(a, b)| rs.generate(a, b)}
        end
      end
      
      puts "\n\nGeneration (RouteSet): (#{(n * 8)} urls)"
      per_url = gentime / (n * 8)
      puts "#{per_url * 1000} ms/url"
      puts "#{1 / per_url} url/s\n\n"
    end
126
  end
127

128 129 130 131 132 133 134
  def test_route_with_colon_first
    rs.draw do |map|
      map.connect '/:controller/:action/:id', :action => 'index', :id => nil
      map.connect ':url', :controller => 'tiny_url', :action => 'translate'
    end
  end

135 136 137 138 139
  def test_route_with_regexp_for_controller
    rs.draw do |map|
      map.connect ':controller/:admintoken/:action/:id', :controller => /admin\/.+/
      map.connect ':controller/:action/:id'
    end
140 141 142 143 144
    assert_equal({:controller => "admin/user", :admintoken => "foo", :action => "index"},
        rs.recognize_path("/admin/user/foo"))
    assert_equal({:controller => "content", :action => "foo"}, rs.recognize_path("/content/foo"))
    assert_equal '/admin/user/foo', rs.generate(:controller => "admin/user", :admintoken => "foo", :action => "index")
    assert_equal '/content/foo', rs.generate(:controller => "content", :action => "foo")
145
  end
146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169

  def test_route_with_regexp_and_dot
    rs.draw do |map|
      map.connect ':controller/:action/:file',
                        :controller => /admin|user/,
                        :action => /upload|download/,
                        :defaults => {:file => nil},
                        :requirements => {:file => %r{[^/]+(\.[^/]+)?}}
    end
    # Without a file extension
    assert_equal '/user/download/file',
      rs.generate(:controller => "user", :action => "download", :file => "file")
    assert_equal(
      {:controller => "user", :action => "download", :file => "file"},
      rs.recognize_path("/user/download/file"))

    # Now, let's try a file with an extension, really a dot (.)
    assert_equal '/user/download/file.jpg',
      rs.generate(
        :controller => "user", :action => "download", :file => "file.jpg")
    assert_equal(
      {:controller => "user", :action => "download", :file => "file.jpg"},
      rs.recognize_path("/user/download/file.jpg"))
  end
170
  
171
  def test_basic_named_route
172
    rs.add_named_route :home, '', :controller => 'content', :action => 'list' 
173
    x = setup_for_named_route
174
    assert_equal("http://named.route.test/",
175
                 x.send(:home_url))
176
  end
177

178 179 180 181 182 183 184 185 186
  def test_basic_named_route_with_relative_url_root
    rs.add_named_route :home, '', :controller => 'content', :action => 'list' 
    x = setup_for_named_route
    x.relative_url_root="/foo"
    assert_equal("http://named.route.test/foo/",
                 x.send(:home_url))
    assert_equal "/foo/", x.send(:home_path)
  end

187
  def test_named_route_with_option
188
    rs.add_named_route :page, 'page/:title', :controller => 'content', :action => 'show_page'
189 190
    x = setup_for_named_route
    assert_equal("http://named.route.test/page/new%20stuff",
191
                 x.send(:page_url, :title => 'new stuff'))
192 193 194
  end

  def test_named_route_with_default
195
    rs.add_named_route :page, 'page/:title', :controller => 'content', :action => 'show_page', :title => 'AboutPage'
196 197
    x = setup_for_named_route
    assert_equal("http://named.route.test/page/AboutRails",
198
                 x.send(:page_url, :title => "AboutRails"))
199 200

  end
201

202
  def test_named_route_with_nested_controller
203
    rs.add_named_route :users, 'admin/user', :controller => 'admin/user', :action => 'index'
204 205
    x = setup_for_named_route
    assert_equal("http://named.route.test/admin/user",
206 207
                 x.send(:users_url))
  end
208 209 210 211
  
  uses_mocha "named route optimisation" do
    def test_optimised_named_route_call_never_uses_url_for
      rs.add_named_route :users, 'admin/user', :controller => '/admin/user', :action => 'index'
212
      rs.add_named_route :user, 'admin/user/:id', :controller=>'/admin/user', :action=>'show'
213 214
      x = setup_for_named_route
      x.expects(:url_for).never
215
      x.send(:users_url)
216
      x.send(:users_path)
217
      x.send(:user_url, 2, :foo=>"bar")
218
      x.send(:user_path, 3, :bar=>"foo")
219
    end
220
    
221
    def test_optimised_named_route_with_host 
222 223 224 225
     	rs.add_named_route :pages, 'pages', :controller => 'content', :action => 'show_page', :host => 'foo.com' 
     	x = setup_for_named_route 
     	x.expects(:url_for).with(:host => 'foo.com', :only_path => false, :controller => 'content', :action => 'show_page', :use_route => :pages).once
      x.send(:pages_url)
226
    end  
227
  end
228

229
  def setup_for_named_route
230 231 232
    klass = Class.new(MockController)
    rs.install_helpers(klass)
    klass.new(rs)
233
  end
234 235 236

  def test_named_route_without_hash
    rs.draw do |map|
237
      map.normal ':controller/:action/:id'
238 239
    end
  end
240 241 242 243 244 245
     
  def test_named_route_root
    rs.draw do |map|
      map.root :controller => "hello"
    end                     
    x = setup_for_named_route       
246
    assert_equal("http://named.route.test/", x.send(:root_url))
247
    assert_equal("/", x.send(:root_path))
248 249
  end
  
250 251
  def test_named_route_with_regexps
    rs.draw do |map|
252
      map.article 'page/:year/:month/:day/:title', :controller => 'page', :action => 'show',
253
        :year => /\d+/, :month => /\d+/, :day => /\d+/
254
      map.connect ':controller/:action/:id'
255
    end
256 257 258 259 260
    x = setup_for_named_route
    # assert_equal(
    #   {:controller => 'page', :action => 'show', :title => 'hi', :use_route => :article, :only_path => false},
    #   x.send(:article_url, :title => 'hi')
    # )
261
    assert_equal(
262
      "http://named.route.test/page/2005/6/10/hi",
263
      x.send(:article_url, :title => 'hi', :day => 10, :year => 2005, :month => 6)
264 265 266
    )
  end

267
  def test_changing_controller
268
    assert_equal '/admin/stuff/show/10', rs.generate(
269 270 271 272
      {:controller => 'stuff', :action => 'show', :id => 10},
      {:controller => 'admin/user', :action => 'index'}
    )
  end  
J
Jamis Buck 已提交
273

274 275
  def test_paths_escaped
    rs.draw do |map|
276 277
      map.path 'file/*path', :controller => 'content', :action => 'show_file'
      map.connect ':controller/:action/:id'
278
    end
279 280

    # No + to space in URI escaping, only for query params.
281
    results = rs.recognize_path "/file/hello+world/how+are+you%3F"
282
    assert results, "Recognition should have succeeded"
283 284 285 286 287
    assert_equal ['hello+world', 'how+are+you?'], results[:path]

    # Use %20 for space instead.
    results = rs.recognize_path "/file/hello%20world/how%20are%20you%3F"
    assert results, "Recognition should have succeeded"
288
    assert_equal ['hello world', 'how are you?'], results[:path]
289

290
    results = rs.recognize_path "/file"
291
    assert results, "Recognition should have succeeded"
292
    assert_equal [], results[:path]
293
  end
294
  
295 296 297 298 299
  def test_paths_slashes_unescaped_with_ordered_parameters
    rs.add_named_route :path, '/file/*path', :controller => 'content' 

    # No / to %2F in URI, only for query params. 
    x = setup_for_named_route 
300
    assert_equal("/file/hello/world", x.send(:path_path, 'hello/world'))
301 302
  end
  
303
  def test_non_controllers_cannot_be_matched
304 305
    rs.draw do |map|
      map.connect ':controller/:action/:id'
306
    end
307
    assert_raises(ActionController::RoutingError) { rs.recognize_path("/not_a/show/10") }
308
  end
309

310 311 312
  def test_paths_do_not_accept_defaults
    assert_raises(ActionController::RoutingError) do
      rs.draw do |map|
313 314
        map.path 'file/*path', :controller => 'content', :action => 'show_file', :path => %w(fake default)
        map.connect ':controller/:action/:id'
315 316 317 318
      end
    end
    
    rs.draw do |map|
319 320
      map.path 'file/*path', :controller => 'content', :action => 'show_file', :path => []
      map.connect ':controller/:action/:id'
321 322
    end
  end
323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344
  
  def test_should_list_options_diff_when_routing_requirements_dont_match
    rs.draw do |map|
      map.post 'post/:id', :controller=> 'post', :action=> 'show', :requirements => {:id => /\d+/}
    end
    exception = assert_raise(ActionController::RoutingError) { rs.generate(:controller => 'post', :action => 'show', :bad_param => "foo", :use_route => "post") }
    assert_match /^post_url failed to generate/, exception.message
    from_match = exception.message.match(/from \{[^\}]+\}/).to_s
    assert_match /:bad_param=>"foo"/,   from_match
    assert_match /:action=>"show"/,     from_match
    assert_match /:controller=>"post"/, from_match
    
    expected_match = exception.message.match(/expected: \{[^\}]+\}/).to_s
    assert_no_match /:bad_param=>"foo"/,   expected_match
    assert_match    /:action=>"show"/,     expected_match
    assert_match    /:controller=>"post"/, expected_match

    diff_match = exception.message.match(/diff: \{[^\}]+\}/).to_s
    assert_match    /:bad_param=>"foo"/,   diff_match
    assert_no_match /:action=>"show"/,     diff_match
    assert_no_match /:controller=>"post"/, diff_match
  end
345

346 347 348 349 350
  # this specifies the case where your formerly would get a very confusing error message with an empty diff
  def test_should_have_better_error_message_when_options_diff_is_empty
    rs.draw do |map|
      map.content '/content/:query', :controller => 'content', :action => 'show'
    end
D
David Heinemeier Hansson 已提交
351

352
    exception = assert_raise(ActionController::RoutingError) { rs.generate(:controller => 'content', :action => 'show', :use_route => "content") }
D
David Heinemeier Hansson 已提交
353 354 355
    assert_match %r[:action=>"show"], exception.message
    assert_match %r[:controller=>"content"], exception.message
    assert_match %r[you may have ambiguous routes, or you may need to supply additional parameters for this route], exception.message
356
    assert_match %r[content_url has the following required parameters: \["content", :query\] - are they all satisfied?], exception.message
357 358
  end
  
359 360
  def test_dynamic_path_allowed
    rs.draw do |map|
361
      map.connect '*path', :controller => 'content', :action => 'show_file'
362 363
    end

364
    assert_equal '/pages/boo', rs.generate(:controller => 'content', :action => 'show_file', :path => %w(pages boo))
365 366
  end

367 368 369 370 371 372 373 374 375
  def test_dynamic_recall_paths_allowed
    rs.draw do |map|
      map.connect '*path', :controller => 'content', :action => 'show_file'
    end
    
    recall_path = ActionController::Routing::PathSegment::Result.new(%w(pages boo))
    assert_equal '/pages/boo', rs.generate({}, :controller => 'content', :action => 'show_file', :path => recall_path)
  end

J
Jamis Buck 已提交
376 377
  def test_backwards
    rs.draw do |map|
378 379
      map.connect 'page/:id/:action', :controller => 'pages', :action => 'show'
      map.connect ':controller/:action/:id'
J
Jamis Buck 已提交
380 381
    end

382 383 384
    assert_equal '/page/20', rs.generate({:id => 20}, {:controller => 'pages', :action => 'show'})
    assert_equal '/page/20', rs.generate(:controller => 'pages', :id => 20, :action => 'show')
    assert_equal '/pages/boo', rs.generate(:controller => 'pages', :action => 'boo')
J
Jamis Buck 已提交
385
  end
386

387 388
  def test_route_with_fixnum_default
    rs.draw do |map|
389 390
      map.connect 'page/:id', :controller => 'content', :action => 'show_page', :id => 1
      map.connect ':controller/:action/:id'
391 392
    end

393 394 395 396
    assert_equal '/page', rs.generate(:controller => 'content', :action => 'show_page')
    assert_equal '/page', rs.generate(:controller => 'content', :action => 'show_page', :id => 1)
    assert_equal '/page', rs.generate(:controller => 'content', :action => 'show_page', :id => '1')
    assert_equal '/page/10', rs.generate(:controller => 'content', :action => 'show_page', :id => 10)
397

398 399 400
    assert_equal({:controller => "content", :action => 'show_page', :id => '1'}, rs.recognize_path("/page"))
    assert_equal({:controller => "content", :action => 'show_page', :id => '1'}, rs.recognize_path("/page/1"))
    assert_equal({:controller => "content", :action => 'show_page', :id => '10'}, rs.recognize_path("/page/10"))
401 402
  end

403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419
  # For newer revision
  def test_route_with_text_default
    rs.draw do |map|
      map.connect 'page/:id', :controller => 'content', :action => 'show_page', :id => 1
      map.connect ':controller/:action/:id'
    end

    assert_equal '/page/foo', rs.generate(:controller => 'content', :action => 'show_page', :id => 'foo')
    assert_equal({:controller => "content", :action => 'show_page', :id => 'foo'}, rs.recognize_path("/page/foo"))

    token = "\321\202\320\265\320\272\321\201\321\202" # 'text' in russian
    escaped_token = CGI::escape(token)

    assert_equal '/page/' + escaped_token, rs.generate(:controller => 'content', :action => 'show_page', :id => token)
    assert_equal({:controller => "content", :action => 'show_page', :id => token}, rs.recognize_path("/page/#{escaped_token}"))
  end
  
420
  def test_action_expiry
421
    assert_equal '/content', rs.generate({:controller => 'content'}, {:controller => 'content', :action => 'show'})
422
  end
423 424

  def test_recognition_with_uppercase_controller_name
425 426 427
    assert_equal({:controller => "content", :action => 'index'}, rs.recognize_path("/Content"))
    assert_equal({:controller => "content", :action => 'list'}, rs.recognize_path("/ConTent/list"))
    assert_equal({:controller => "content", :action => 'show', :id => '10'}, rs.recognize_path("/CONTENT/show/10"))
428

429 430 431
    # these used to work, before the routes rewrite, but support for this was pulled in the new version...
    #assert_equal({'controller' => "admin/news_feed", 'action' => 'index'}, rs.recognize_path("Admin/NewsFeed"))
    #assert_equal({'controller' => "admin/news_feed", 'action' => 'index'}, rs.recognize_path("Admin/News_Feed"))
432
  end
433 434 435 436 437
  
  def test_requirement_should_prevent_optional_id
    rs.draw do |map|
      map.post 'post/:id', :controller=> 'post', :action=> 'show', :requirements => {:id => /\d+/}
    end
438

439 440 441 442 443 444 445
    assert_equal '/post/10', rs.generate(:controller => 'post', :action => 'show', :id => 10)
    
    assert_raises ActionController::RoutingError do
      rs.generate(:controller => 'post', :action => 'show')
    end
  end
  
446
  def test_both_requirement_and_optional
447 448
    rs.draw do |map|
      map.blog('test/:year', :controller => 'post', :action => 'show',
449 450 451
        :defaults => { :year => nil },
        :requirements => { :year => /\d{4}/ }
      )
452
      map.connect ':controller/:action/:id'
453 454
    end

455 456
    assert_equal '/test', rs.generate(:controller => 'post', :action => 'show')
    assert_equal '/test', rs.generate(:controller => 'post', :action => 'show', :year => nil)
457
    
458 459
    x = setup_for_named_route
    assert_equal("http://named.route.test/test",
460
                 x.send(:blog_url))
461
  end
462 463
  
  def test_set_to_nil_forgets
464 465 466
    rs.draw do |map|
      map.connect 'pages/:year/:month/:day', :controller => 'content', :action => 'list_pages', :month => nil, :day => nil
      map.connect ':controller/:action/:id'
467 468
    end
    
469
    assert_equal '/pages/2005',
470
      rs.generate(:controller => 'content', :action => 'list_pages', :year => 2005)
471
    assert_equal '/pages/2005/6',
472
      rs.generate(:controller => 'content', :action => 'list_pages', :year => 2005, :month => 6)
473
    assert_equal '/pages/2005/6/12',
474 475
      rs.generate(:controller => 'content', :action => 'list_pages', :year => 2005, :month => 6, :day => 12)
    
476
    assert_equal '/pages/2005/6/4',
477
      rs.generate({:day => 4}, {:controller => 'content', :action => 'list_pages', :year => '2005', :month => '6', :day => '12'})
478

479
    assert_equal '/pages/2005/6',
480
      rs.generate({:day => nil}, {:controller => 'content', :action => 'list_pages', :year => '2005', :month => '6', :day => '12'})
481

482
    assert_equal '/pages/2005',
483 484 485 486
      rs.generate({:day => nil, :month => nil}, {:controller => 'content', :action => 'list_pages', :year => '2005', :month => '6', :day => '12'})
  end
  
  def test_url_with_no_action_specified
487 488 489
    rs.draw do |map|
      map.connect '', :controller => 'content'
      map.connect ':controller/:action/:id'
490 491
    end
    
492 493
    assert_equal '/', rs.generate(:controller => 'content', :action => 'index')
    assert_equal '/', rs.generate(:controller => 'content')
494
  end
495 496

  def test_named_url_with_no_action_specified
497
    rs.draw do |map|
498
      map.home '', :controller => 'content'
499
      map.connect ':controller/:action/:id'
500 501
    end
    
502 503
    assert_equal '/', rs.generate(:controller => 'content', :action => 'index')
    assert_equal '/', rs.generate(:controller => 'content')
504
    
505
    x = setup_for_named_route
506
    assert_equal("http://named.route.test/",
507
                 x.send(:home_url))
508 509 510 511
  end
  
  def test_url_generated_when_forgetting_action
    [{:controller => 'content', :action => 'index'}, {:controller => 'content'}].each do |hash| 
512
      rs.draw do |map|
513
        map.home '', hash
514
        map.connect ':controller/:action/:id'
515
      end
516 517 518
      assert_equal '/', rs.generate({:action => nil}, {:controller => 'content', :action => 'hello'})
      assert_equal '/', rs.generate({:controller => 'content'})
      assert_equal '/content/hi', rs.generate({:controller => 'content', :action => 'hi'})
519 520
    end
  end
521 522
  
  def test_named_route_method
523 524 525
    rs.draw do |map|
      map.categories 'categories', :controller => 'content', :action => 'categories'
      map.connect ':controller/:action/:id'
526 527
    end

528 529
    assert_equal '/categories', rs.generate(:controller => 'content', :action => 'categories')
    assert_equal '/content/hi', rs.generate({:controller => 'content', :action => 'hi'})
530
  end
531

532
  def test_named_routes_array
533
    test_named_route_method
534
    assert_equal [:categories], rs.named_routes.names
535
  end
536 537

  def test_nil_defaults
538 539
    rs.draw do |map|
      map.connect 'journal',
540 541 542
        :controller => 'content',
        :action => 'list_journal',
        :date => nil, :user_id => nil
543
      map.connect ':controller/:action/:id'
544 545
    end

546
    assert_equal '/journal', rs.generate(:controller => 'content', :action => 'list_journal', :date => nil, :user_id => nil)
547
  end
548 549 550 551 552 553 554

  def setup_request_method_routes_for(method)
    @request = ActionController::TestRequest.new
    @request.env["REQUEST_METHOD"] = method
    @request.request_uri = "/match"

    rs.draw do |r|
555 556 557 558
      r.connect '/match', :controller => 'books', :action => 'get', :conditions => { :method => :get }
      r.connect '/match', :controller => 'books', :action => 'post', :conditions => { :method => :post }
      r.connect '/match', :controller => 'books', :action => 'put', :conditions => { :method => :put }
      r.connect '/match', :controller => 'books', :action => 'delete', :conditions => { :method => :delete }
559 560 561 562 563 564 565 566 567 568 569
    end
  end

  %w(GET POST PUT DELETE).each do |request_method|
    define_method("test_request_method_recognized_with_#{request_method}") do
      begin
        Object.const_set(:BooksController, Class.new(ActionController::Base))

        setup_request_method_routes_for(request_method)

        assert_nothing_raised { rs.recognize(@request) }
570
        assert_equal request_method.downcase, @request.path_parameters[:action]
571 572 573 574 575 576 577 578 579 580
      ensure
        Object.send(:remove_const, :BooksController) rescue nil
      end
    end
  end

  def test_subpath_recognized
    Object.const_set(:SubpathBooksController, Class.new(ActionController::Base))

    rs.draw do |r|
581 582 583
      r.connect '/books/:id/edit', :controller => 'subpath_books', :action => 'edit'
      r.connect '/items/:id/:action', :controller => 'subpath_books'
      r.connect '/posts/new/:action', :controller => 'subpath_books'
584
      r.connect '/posts/:id', :controller => 'subpath_books', :action => "show"
585 586
    end

587
    hash = rs.recognize_path "/books/17/edit"
J
Jamis Buck 已提交
588
    assert_not_nil hash
589
    assert_equal %w(subpath_books 17 edit), [hash[:controller], hash[:id], hash[:action]]
J
Jamis Buck 已提交
590
    
591
    hash = rs.recognize_path "/items/3/complete"
J
Jamis Buck 已提交
592
    assert_not_nil hash
593
    assert_equal %w(subpath_books 3 complete), [hash[:controller], hash[:id], hash[:action]]
J
Jamis Buck 已提交
594
    
595
    hash = rs.recognize_path "/posts/new/preview"
J
Jamis Buck 已提交
596
    assert_not_nil hash
597
    assert_equal %w(subpath_books preview), [hash[:controller], hash[:action]]
598

599
    hash = rs.recognize_path "/posts/7"
600
    assert_not_nil hash
601
    assert_equal %w(subpath_books show 7), [hash[:controller], hash[:action], hash[:id]]
602 603 604 605 606 607 608 609
  ensure
    Object.send(:remove_const, :SubpathBooksController) rescue nil
  end

  def test_subpath_generated
    Object.const_set(:SubpathBooksController, Class.new(ActionController::Base))

    rs.draw do |r|
610 611 612
      r.connect '/books/:id/edit', :controller => 'subpath_books', :action => 'edit'
      r.connect '/items/:id/:action', :controller => 'subpath_books'
      r.connect '/posts/new/:action', :controller => 'subpath_books'
613 614
    end

615 616 617
    assert_equal "/books/7/edit", rs.generate(:controller => "subpath_books", :id => 7, :action => "edit")
    assert_equal "/items/15/complete", rs.generate(:controller => "subpath_books", :id => 15, :action => "complete")
    assert_equal "/posts/new/preview", rs.generate(:controller => "subpath_books", :action => "preview")
618 619 620
  ensure
    Object.send(:remove_const, :SubpathBooksController) rescue nil
  end
621 622 623 624 625 626 627 628 629 630 631
  
  def test_failed_requirements_raises_exception_with_violated_requirements
    rs.draw do |r|
      r.foo_with_requirement 'foos/:id', :controller=>'foos', :requirements=>{:id=>/\d+/}
    end
    
    x = setup_for_named_route
    assert_raises(ActionController::RoutingError) do 
      x.send(:foo_with_requirement_url, "I am Against the requirements")
    end
  end
632 633
end

634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659
class SegmentTest < Test::Unit::TestCase
  
  def test_first_segment_should_interpolate_for_structure
    s = ROUTING::Segment.new
    def s.interpolation_statement(array) 'hello' end
    assert_equal 'hello', s.continue_string_structure([])
  end
  
  def test_interpolation_statement
    s = ROUTING::StaticSegment.new
    s.value = "Hello"
    assert_equal "Hello", eval(s.interpolation_statement([]))
    assert_equal "HelloHello", eval(s.interpolation_statement([s]))
    
    s2 = ROUTING::StaticSegment.new
    s2.value = "-"
    assert_equal "Hello-Hello", eval(s.interpolation_statement([s, s2]))
    
    s3 = ROUTING::StaticSegment.new
    s3.value = "World"
    assert_equal "Hello-World", eval(s3.interpolation_statement([s, s2]))
  end
  
end

class StaticSegmentTest < Test::Unit::TestCase
660

661 662
  def test_interpolation_chunk_should_respect_raw
    s = ROUTING::StaticSegment.new
663
    s.value = 'Hello World'
664
    assert ! s.raw?
665 666
    assert_equal 'Hello%20World', s.interpolation_chunk

667 668
    s.raw = true
    assert s.raw?
669
    assert_equal 'Hello World', s.interpolation_chunk
670
  end
671

672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777
  def test_regexp_chunk_should_escape_specials
    s = ROUTING::StaticSegment.new
    
    s.value = 'Hello*World'
    assert_equal 'Hello\*World', s.regexp_chunk
    
    s.value = 'HelloWorld'
    assert_equal 'HelloWorld', s.regexp_chunk
  end
  
  def test_regexp_chunk_should_add_question_mark_for_optionals
    s = ROUTING::StaticSegment.new
    s.value = "/"
    s.is_optional = true
    assert_equal "/?", s.regexp_chunk
    
    s.value = "hello"
    assert_equal "(?:hello)?", s.regexp_chunk
  end
  
end

class DynamicSegmentTest < Test::Unit::TestCase
  
  def segment
    unless @segment
      @segment = ROUTING::DynamicSegment.new
      @segment.key = :a
    end
    @segment
  end
  
  def test_extract_value
    s = ROUTING::DynamicSegment.new
    s.key = :a
    
    hash = {:a => '10', :b => '20'}
    assert_equal '10', eval(s.extract_value)
    
    hash = {:b => '20'}
    assert_equal nil, eval(s.extract_value)
    
    s.default = '20'
    assert_equal '20', eval(s.extract_value)
  end
  
  def test_default_local_name
    assert_equal 'a_value', segment.local_name,
      "Unexpected name -- all value_check tests will fail!"
  end
  
  def test_presence_value_check
    a_value = 10
    assert eval(segment.value_check)
  end
  
  def test_regexp_value_check_rejects_nil
    segment.regexp = /\d+/
    a_value = nil
    assert ! eval(segment.value_check)
  end
  
  def test_optional_regexp_value_check_should_accept_nil
    segment.regexp = /\d+/
    segment.is_optional = true
    a_value = nil
    assert eval(segment.value_check)
  end
  
  def test_regexp_value_check_rejects_no_match
    segment.regexp = /\d+/
    
    a_value = "Hello20World"
    assert ! eval(segment.value_check)
    
    a_value = "20Hi"
    assert ! eval(segment.value_check)
  end
  
  def test_regexp_value_check_accepts_match
    segment.regexp = /\d+/
    
    a_value = "30"
    assert eval(segment.value_check)
  end
  
  def test_value_check_fails_on_nil
    a_value = nil
    assert ! eval(segment.value_check)
  end
  
  def test_optional_value_needs_no_check
    segment.is_optional = true
    a_value = nil
    assert_equal nil, segment.value_check
  end
  
  def test_regexp_value_check_should_accept_match_with_default
    segment.regexp = /\d+/
    segment.default = '200'
    
    a_value = '100'
    assert eval(segment.value_check)
  end
  
  def test_expiry_should_not_trigger_once_expired
778
    expired = true
779 780 781 782 783 784
    hash = merged = {:a => 2, :b => 3}
    options = {:b => 3}
    expire_on = Hash.new { raise 'No!!!' }
    
    eval(segment.expiry_statement)
  rescue RuntimeError
785
    flunk "Expiry check should not have occurred!"
786 787 788
  end
  
  def test_expiry_should_occur_according_to_expire_on
789
    expired = false
790 791 792 793 794
    hash = merged = {:a => 2, :b => 3}
    options = {:b => 3}
    
    expire_on = {:b => true, :a => false}
    eval(segment.expiry_statement)
795
    assert !expired
796 797 798 799
    assert_equal({:a => 2, :b => 3}, hash)
    
    expire_on = {:b => true, :a => true}
    eval(segment.expiry_statement)
800
    assert expired
801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826
    assert_equal({:b => 3}, hash)
  end
  
  def test_extraction_code_should_return_on_nil
    hash = merged = {:b => 3}
    options = {:b => 3}
    a_value = nil
    
    # Local jump because of return inside eval.
    assert_raises(LocalJumpError) { eval(segment.extraction_code) }
  end
  
  def test_extraction_code_should_return_on_mismatch
    segment.regexp = /\d+/
    hash = merged = {:a => 'Hi', :b => '3'}
    options = {:b => '3'}
    a_value = nil
    
    # Local jump because of return inside eval.
    assert_raises(LocalJumpError) { eval(segment.extraction_code) }
  end
  
  def test_extraction_code_should_accept_value_and_set_local
    hash = merged = {:a => 'Hi', :b => '3'}
    options = {:b => '3'}
    a_value = nil
827 828
    expired = true

829 830 831 832 833 834 835 836 837
    eval(segment.extraction_code)
    assert_equal 'Hi', a_value
  end
  
  def test_extraction_should_work_without_value_check
    segment.default = 'hi'
    hash = merged = {:b => '3'}
    options = {:b => '3'}
    a_value = nil
838
    expired = true
839 840 841 842 843 844
    
    eval(segment.extraction_code)
    assert_equal 'hi', a_value
  end
  
  def test_extraction_code_should_perform_expiry
845
    expired = false
846 847 848 849 850 851 852
    hash = merged = {:a => 'Hi', :b => '3'}
    options = {:b => '3'}
    expire_on = {:a => true}
    a_value = nil
    
    eval(segment.extraction_code)
    assert_equal 'Hi', a_value
853
    assert expired
854 855 856 857 858 859 860 861
    assert_equal options, hash
  end
  
  def test_interpolation_chunk_should_replace_value
    a_value = 'Hi'
    assert_equal a_value, eval(%("#{segment.interpolation_chunk}"))
  end
  
862 863 864 865 866
  def test_interpolation_chunk_should_accept_nil
    a_value = nil
    assert_equal '', eval(%("#{segment.interpolation_chunk('a_value')}"))
  end
  
867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883
  def test_value_regexp_should_be_nil_without_regexp
    assert_equal nil, segment.value_regexp
  end
  
  def test_value_regexp_should_match_exacly
    segment.regexp = /\d+/
    assert_no_match segment.value_regexp, "Hello 10 World"
    assert_no_match segment.value_regexp, "Hello 10"
    assert_no_match segment.value_regexp, "10 World"
    assert_match segment.value_regexp, "10"
  end
  
  def test_regexp_chunk_should_return_string
    segment.regexp = /\d+/
    assert_kind_of String, segment.regexp_chunk
  end
  
884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905
  def test_build_pattern_non_optional_with_no_captures
    # Non optioanl
    a_segment = ROUTING::DynamicSegment.new
    a_segment.regexp = /\d+/ #number_of_captures is 0
    assert_equal "(\\d+)stuff", a_segment.build_pattern('stuff')
  end

  def test_build_pattern_non_optional_with_captures
    # Non optioanl
    a_segment = ROUTING::DynamicSegment.new
    a_segment.regexp = /(\d+)(.*?)/ #number_of_captures is 2
    assert_equal "((\\d+)(.*?))stuff", a_segment.build_pattern('stuff')
  end

  def test_optionality_implied
    a_segment = ROUTING::DynamicSegment.new
    a_segment.key = :id
    assert a_segment.optionality_implied?

    a_segment.key = :action
    assert a_segment.optionality_implied?
  end
906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926
end

class ControllerSegmentTest < Test::Unit::TestCase
  
  def test_regexp_should_only_match_possible_controllers
    ActionController::Routing.with_controllers %w(admin/accounts admin/users account pages) do
      cs = ROUTING::ControllerSegment.new :controller
      regexp = %r{\A#{cs.regexp_chunk}\Z}
      
      ActionController::Routing.possible_controllers.each do |name|
        assert_match regexp, name
        assert_no_match regexp, "#{name}_fake"
        
        match = regexp.match name
        assert_equal name, match[1]
      end
    end
  end
  
end

R
Rick Olson 已提交
927
uses_mocha 'RouteTest' do
928 929 930 931 932 933 934 935 936 937

  class MockController
    attr_accessor :routes

    def initialize(routes)
      self.routes = routes
    end

    def url_for(options)
      only_path = options.delete(:only_path)
938 939 940 941 942 943 944
      
      port        = options.delete(:port) || 80
      port_string = port == 80 ? '' : ":#{port}"
      
      host   = options.delete(:host) || "named.route.test"
      anchor = "##{options.delete(:anchor)}" if options.key?(:anchor)
      
945
      path = routes.generate(options)
946 947
      
      only_path ? "#{path}#{anchor}" : "http://#{host}#{port_string}#{path}#{anchor}"
948 949 950 951 952
    end
    
    def request
      @request ||= MockRequest.new(:host => "named.route.test", :method => :get)
    end
953 954 955 956
    
    def relative_url_root=(value)
      request.relative_url_root=value
    end
957 958 959
  end

  class MockRequest
960 961 962
    attr_accessor :path, :path_parameters, :host, :subdomains, :domain,
                  :method, :relative_url_root
    
963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979
    def initialize(values={})
      values.each { |key, value| send("#{key}=", value) }
      if values[:host]
        subdomain, self.domain = values[:host].split(/\./, 2)
        self.subdomains = [subdomain]
      end
    end
    
    def protocol
      "http://"
    end
    
    def host_with_port
      (subdomains * '.') + '.' +  domain
    end
  end

980 981 982 983 984 985 986 987 988 989 990 991 992
class RouteTest < Test::Unit::TestCase

  def setup
    @route = ROUTING::Route.new
  end

  def slash_segment(is_optional = false)
    returning ROUTING::DividerSegment.new('/') do |s|
      s.is_optional = is_optional
    end
  end
  
  def default_route
993
    unless defined?(@default_route)
994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052
      @default_route = ROUTING::Route.new
      
      @default_route.segments << (s = ROUTING::StaticSegment.new)
      s.value = '/'
      s.raw = true
      
      @default_route.segments << (s = ROUTING::DynamicSegment.new)
      s.key = :controller
      
      @default_route.segments << slash_segment(:optional)
      @default_route.segments << (s = ROUTING::DynamicSegment.new)
      s.key = :action
      s.default = 'index'
      s.is_optional = true
      
      @default_route.segments << slash_segment(:optional)
      @default_route.segments << (s = ROUTING::DynamicSegment.new)
      s.key = :id
      s.is_optional = true
      
      @default_route.segments << slash_segment(:optional)
    end
    @default_route
  end

  def test_default_route_recognition
    expected = {:controller => 'accounts', :action => 'show', :id => '10'}
    assert_equal expected, default_route.recognize('/accounts/show/10')
    assert_equal expected, default_route.recognize('/accounts/show/10/')
    
    expected[:id] = 'jamis'
    assert_equal expected, default_route.recognize('/accounts/show/jamis/')
    
    expected.delete :id
    assert_equal expected, default_route.recognize('/accounts/show')
    assert_equal expected, default_route.recognize('/accounts/show/')
    
    expected[:action] = 'index'
    assert_equal expected, default_route.recognize('/accounts/')
    assert_equal expected, default_route.recognize('/accounts')
    
    assert_equal nil, default_route.recognize('/')
    assert_equal nil, default_route.recognize('/accounts/how/goood/it/is/to/be/free')
  end
  
  def test_default_route_should_omit_default_action
    o = {:controller => 'accounts', :action => 'index'}
    assert_equal '/accounts', default_route.generate(o, o, {})
  end
  
  def test_default_route_should_include_default_action_when_id_present
    o = {:controller => 'accounts', :action => 'index', :id => '20'}
    assert_equal '/accounts/index/20', default_route.generate(o, o, {})
  end
  
  def test_default_route_should_work_with_action_but_no_id
    o = {:controller => 'accounts', :action => 'list_all'}
    assert_equal '/accounts/list_all', default_route.generate(o, o, {})
  end
N
Nicholas Seckar 已提交
1053
  
1054 1055 1056 1057 1058 1059 1060
  def test_default_route_should_uri_escape_pluses
    expected = { :controller => 'accounts', :action => 'show', :id => 'hello world' }
    assert_equal expected, default_route.recognize('/accounts/show/hello world')
    assert_equal expected, default_route.recognize('/accounts/show/hello%20world')
    assert_equal '/accounts/show/hello%20world', default_route.generate(expected, expected, {})

    expected[:id] = 'hello+world'
N
Nicholas Seckar 已提交
1061
    assert_equal expected, default_route.recognize('/accounts/show/hello+world')
1062 1063
    assert_equal expected, default_route.recognize('/accounts/show/hello%2Bworld')
    assert_equal '/accounts/show/hello+world', default_route.generate(expected, expected, {})
N
Nicholas Seckar 已提交
1064
  end
R
Rick Olson 已提交
1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076

  def test_matches_controller_and_action
    # requirement_for should only be called for the action and controller _once_
    @route.expects(:requirement_for).with(:controller).times(1).returns('pages')
    @route.expects(:requirement_for).with(:action).times(1).returns('show')
    
    @route.requirements = {:controller => 'pages', :action => 'show'}
    assert @route.matches_controller_and_action?('pages', 'show')
    assert !@route.matches_controller_and_action?('not_pages', 'show')
    assert !@route.matches_controller_and_action?('pages', 'not_show')
  end
    
1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088
  def test_parameter_shell
    page_url = ROUTING::Route.new
    page_url.requirements = {:controller => 'pages', :action => 'show', :id => /\d+/}
    assert_equal({:controller => 'pages', :action => 'show'}, page_url.parameter_shell)
  end

  def test_defaults
    route = ROUTING::RouteBuilder.new.build '/users/:id.:format', :controller => "users", :action => "show", :format => "html"
    assert_equal(
      { :controller => "users", :action => "show", :format => "html" },
      route.defaults)
  end
1089 1090 1091 1092 1093 1094
  
  def test_builder_complains_without_controller
    assert_raises(ArgumentError) do
      ROUTING::RouteBuilder.new.build '/contact', :contoller => "contact", :action => "index"
    end
  end
1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132

  def test_significant_keys_for_default_route
    keys = default_route.significant_keys.sort_by {|k| k.to_s }
    assert_equal [:action, :controller, :id], keys
  end
  
  def test_significant_keys
    user_url = ROUTING::Route.new
    user_url.segments << (s = ROUTING::StaticSegment.new)
    s.value = '/'
    s.raw = true
    
    user_url.segments << (s = ROUTING::StaticSegment.new)
    s.value = 'user'
    
    user_url.segments << (s = ROUTING::StaticSegment.new)
    s.value = '/'
    s.raw = true
    s.is_optional = true
    
    user_url.segments << (s = ROUTING::DynamicSegment.new)
    s.key = :user
    
    user_url.segments << (s = ROUTING::StaticSegment.new)
    s.value = '/'
    s.raw = true
    s.is_optional = true
    
    user_url.requirements = {:controller => 'users', :action => 'show'}
    
    keys = user_url.significant_keys.sort_by { |k| k.to_s }
    assert_equal [:action, :controller, :user], keys
  end

  def test_build_empty_query_string
    assert_equal '', @route.build_query_string({})
  end

1133 1134 1135 1136
  def test_build_query_string_with_nil_value
    assert_equal '', @route.build_query_string({:x => nil})
  end

1137
  def test_simple_build_query_string
1138
    assert_equal '?x=1&y=2', order_query_string(@route.build_query_string(:x => '1', :y => '2'))
1139 1140 1141
  end

  def test_convert_ints_build_query_string
1142
    assert_equal '?x=1&y=2', order_query_string(@route.build_query_string(:x => 1, :y => 2))
1143 1144 1145
  end

  def test_escape_spaces_build_query_string
1146
    assert_equal '?x=hello+world&y=goodbye+world', order_query_string(@route.build_query_string(:x => 'hello world', :y => 'goodbye world'))
1147 1148 1149
  end

  def test_expand_array_build_query_string
1150
    assert_equal '?x%5B%5D=1&x%5B%5D=2', order_query_string(@route.build_query_string(:x => [1, 2]))
1151 1152 1153
  end

  def test_escape_spaces_build_query_string_selected_keys
1154
    assert_equal '?x=hello+world', order_query_string(@route.build_query_string({:x => 'hello world', :y => 'goodbye world'}, [:x]))
1155
  end
1156 1157 1158 1159 1160
  
  private
    def order_query_string(qs)
      '?' + qs[1..-1].split('&').sort.join('&')
    end
1161 1162
end

R
Rick Olson 已提交
1163 1164
end # uses_mocha

1165
class RouteBuilderTest < Test::Unit::TestCase
1166

1167
  def builder
1168
    @builder ||= ROUTING::RouteBuilder.new
1169
  end
1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188

  def build(path, options)
    builder.build(path, options)
  end

  def test_options_should_not_be_modified
    requirements1 = { :id => /\w+/, :controller => /(?:[a-z](?:-?[a-z]+)*)/ }
    requirements2 = requirements1.dup

    assert_equal requirements1, requirements2

    with_options(:controller => 'folder',
                 :requirements => requirements2) do |m|
      m.build 'folders/new', :action => 'new'
    end

    assert_equal requirements1, requirements2
  end

1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289
  def test_segment_for_static
    segment, rest = builder.segment_for 'ulysses'
    assert_equal '', rest
    assert_kind_of ROUTING::StaticSegment, segment
    assert_equal 'ulysses', segment.value
  end
  
  def test_segment_for_action
    segment, rest = builder.segment_for ':action'
    assert_equal '', rest
    assert_kind_of ROUTING::DynamicSegment, segment
    assert_equal :action, segment.key
    assert_equal 'index', segment.default
  end
  
  def test_segment_for_dynamic
    segment, rest = builder.segment_for ':login'
    assert_equal '', rest
    assert_kind_of ROUTING::DynamicSegment, segment
    assert_equal :login, segment.key
    assert_equal nil, segment.default
    assert ! segment.optional?
  end
  
  def test_segment_for_with_rest
    segment, rest = builder.segment_for ':login/:action'
    assert_equal :login, segment.key
    assert_equal '/:action', rest
    segment, rest = builder.segment_for rest
    assert_equal '/', segment.value
    assert_equal ':action', rest
    segment, rest = builder.segment_for rest
    assert_equal :action, segment.key
    assert_equal '', rest
  end
  
  def test_segments_for
    segments = builder.segments_for_route_path '/:controller/:action/:id'
    
    assert_kind_of ROUTING::DividerSegment, segments[0]
    assert_equal '/', segments[2].value
    
    assert_kind_of ROUTING::DynamicSegment, segments[1]
    assert_equal :controller, segments[1].key
    
    assert_kind_of ROUTING::DividerSegment, segments[2]
    assert_equal '/', segments[2].value
    
    assert_kind_of ROUTING::DynamicSegment, segments[3]
    assert_equal :action, segments[3].key
    
    assert_kind_of ROUTING::DividerSegment, segments[4]
    assert_equal '/', segments[4].value
    
    assert_kind_of ROUTING::DynamicSegment, segments[5]
    assert_equal :id, segments[5].key
  end
  
  def test_segment_for_action
    s, r = builder.segment_for(':action/something/else')
    assert_equal '/something/else', r
    assert_equal :action, s.key
  end
  
  def test_action_default_should_not_trigger_on_prefix
    s, r = builder.segment_for ':action_name/something/else'
    assert_equal '/something/else', r
    assert_equal :action_name, s.key
    assert_equal nil, s.default
  end
  
  def test_divide_route_options
    segments = builder.segments_for_route_path '/cars/:action/:person/:car/'
    defaults, requirements = builder.divide_route_options(segments,
      :action => 'buy', :person => /\w+/, :car => /\w+/,
      :defaults => {:person => nil, :car => nil}
    )
    
    assert_equal({:action => 'buy', :person => nil, :car => nil}, defaults)
    assert_equal({:person => /\w+/, :car => /\w+/}, requirements)
  end
  
  def test_assign_route_options
    segments = builder.segments_for_route_path '/cars/:action/:person/:car/'
    defaults = {:action => 'buy', :person => nil, :car => nil}
    requirements = {:person => /\w+/, :car => /\w+/}
    
    route_requirements = builder.assign_route_options(segments, defaults, requirements)
    assert_equal({}, route_requirements)
    
    assert_equal :action, segments[3].key
    assert_equal 'buy', segments[3].default
    
    assert_equal :person, segments[5].key
    assert_equal %r/\w+/, segments[5].regexp
    assert segments[5].optional?
    
    assert_equal :car, segments[7].key
    assert_equal %r/\w+/, segments[7].regexp
    assert segments[7].optional?
  end
1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303
  
  def test_assign_route_options_with_anchor_chars
    segments = builder.segments_for_route_path '/cars/:action/:person/:car/'
    defaults = {:action => 'buy', :person => nil, :car => nil}
    requirements = {:person => /\w+/, :car => /^\w+$/}
    
    assert_raises ArgumentError do
      route_requirements = builder.assign_route_options(segments, defaults, requirements)
    end
    
    requirements[:car] = /[^\/]+/
    route_requirements = builder.assign_route_options(segments, defaults, requirements)
  end
  
1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330

  def test_optional_segments_preceding_required_segments
    segments = builder.segments_for_route_path '/cars/:action/:person/:car/'
    defaults = {:action => 'buy', :person => nil, :car => "model-t"}
    assert builder.assign_route_options(segments, defaults, {}).empty?
    
    0.upto(1) { |i| assert !segments[i].optional?, "segment #{i} is optional and it shouldn't be" }
    assert segments[2].optional?
    
    assert_equal nil, builder.warn_output # should only warn on the :person segment
  end
  
  def test_segmentation_of_dot_path
    segments = builder.segments_for_route_path '/books/:action.rss'
    assert builder.assign_route_options(segments, {}, {}).empty?
    assert_equal 6, segments.length # "/", "books", "/", ":action", ".", "rss"
    assert !segments.any? { |seg| seg.optional? }
  end
  
  def test_segmentation_of_dynamic_dot_path
    segments = builder.segments_for_route_path '/books/:action.:format'
    assert builder.assign_route_options(segments, {}, {}).empty?
    assert_equal 6, segments.length # "/", "books", "/", ":action", ".", ":format"
    assert !segments.any? { |seg| seg.optional? }
    assert_kind_of ROUTING::DynamicSegment, segments.last
  end
  
1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379
  def test_assignment_of_default_options
    segments = builder.segments_for_route_path '/:controller/:action/:id/'
    action, id = segments[-4], segments[-2]
    
    assert_equal :action, action.key
    assert_equal :id, id.key
    assert ! action.optional?
    assert ! id.optional?
    
    builder.assign_default_route_options(segments)
    
    assert_equal 'index', action.default
    assert action.optional?
    assert id.optional?
  end
  
  def test_assignment_of_default_options_respects_existing_defaults
    segments = builder.segments_for_route_path '/:controller/:action/:id/'
    action, id = segments[-4], segments[-2]
    
    assert_equal :action, action.key
    assert_equal :id, id.key
    action.default = 'show'
    action.is_optional = true
    
    id.default = 'Welcome'
    id.is_optional = true
    
    builder.assign_default_route_options(segments)
    
    assert_equal 'show', action.default
    assert action.optional?
    assert_equal 'Welcome', id.default
    assert id.optional?
  end
  
  def test_assignment_of_default_options_respects_regexps
    segments = builder.segments_for_route_path '/:controller/:action/:id/'
    action = segments[-4]
    
    assert_equal :action, action.key
    action.regexp = /show|in/ # Use 'in' to check partial matches
    
    builder.assign_default_route_options(segments)
    
    assert_equal nil, action.default
    assert ! action.optional?
  end
  
1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443
  def test_assignment_of_is_optional_when_default
    segments = builder.segments_for_route_path '/books/:action.rss'
    assert_equal segments[3].key, :action
    segments[3].default = 'changes'
    builder.ensure_required_segments(segments)
    assert ! segments[3].optional?
  end
  
  def test_is_optional_is_assigned_to_default_segments
    segments = builder.segments_for_route_path '/books/:action'
    builder.assign_route_options(segments, {:action => 'index'}, {})
    
    assert_equal segments[3].key, :action
    assert segments[3].optional?
    assert_kind_of ROUTING::DividerSegment, segments[2]
    assert segments[2].optional?
  end
  
  # XXX is optional not being set right?
  # /blah/:defaulted_segment <-- is the second slash optional? it should be.
  
  def test_route_build
    ActionController::Routing.with_controllers %w(users pages) do
      r = builder.build '/:controller/:action/:id/', :action => nil
      
      [0, 2, 4].each do |i|
        assert_kind_of ROUTING::DividerSegment, r.segments[i]
        assert_equal '/', r.segments[i].value
        assert r.segments[i].optional? if i > 1
      end
      
      assert_kind_of ROUTING::DynamicSegment, r.segments[1]
      assert_equal :controller, r.segments[1].key
      assert_equal nil, r.segments[1].default
      
      assert_kind_of ROUTING::DynamicSegment, r.segments[3]
      assert_equal :action, r.segments[3].key
      assert_equal 'index', r.segments[3].default
      
      assert_kind_of ROUTING::DynamicSegment, r.segments[5]
      assert_equal :id, r.segments[5].key
      assert r.segments[5].optional?
    end
  end
  
  def test_slashes_are_implied
    routes = [
      builder.build('/:controller/:action/:id/', :action => nil),
      builder.build('/:controller/:action/:id', :action => nil),
      builder.build(':controller/:action/:id', :action => nil),
      builder.build('/:controller/:action/:id/', :action => nil)
    ]
    expected = routes.first.segments.length
    routes.each_with_index do |route, i|
      found = route.segments.length
      assert_equal expected, found, "Route #{i + 1} has #{found} segments, expected #{expected}"
    end
  end
  
end




1444
class RouteSetTest < Test::Unit::TestCase
1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465

  def set
    @set ||= ROUTING::RouteSet.new
  end

  def request
    @request ||= MockRequest.new(:host => "named.routes.test", :method => :get)
  end

  def test_generate_extras
    set.draw { |m| m.connect ':controller/:action/:id' }
    path, extras = set.generate_extras(:controller => "foo", :action => "bar", :id => 15, :this => "hello", :that => "world")
    assert_equal "/foo/bar/15", path
    assert_equal %w(that this), extras.map(&:to_s).sort
  end

  def test_extra_keys
    set.draw { |m| m.connect ':controller/:action/:id' }
    extras = set.extra_keys(:controller => "foo", :action => "bar", :id => 15, :this => "hello", :that => "world")
    assert_equal %w(that this), extras.map(&:to_s).sort
  end
1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492
  
  def test_generate_extras_not_first
    set.draw do |map| 
      map.connect ':controller/:action/:id.:format'
      map.connect ':controller/:action/:id'
    end    
    path, extras = set.generate_extras(:controller => "foo", :action => "bar", :id => 15, :this => "hello", :that => "world")
    assert_equal "/foo/bar/15", path
    assert_equal %w(that this), extras.map(&:to_s).sort
  end
  
  def test_generate_not_first
    set.draw do |map| 
      map.connect ':controller/:action/:id.:format'
      map.connect ':controller/:action/:id'
    end    
    assert_equal "/foo/bar/15?this=hello", set.generate(:controller => "foo", :action => "bar", :id => 15, :this => "hello")
  end
  
  def test_extra_keys_not_first
    set.draw do |map| 
      map.connect ':controller/:action/:id.:format'
      map.connect ':controller/:action/:id'
    end
    extras = set.extra_keys(:controller => "foo", :action => "bar", :id => 15, :this => "hello", :that => "world")
    assert_equal %w(that this), extras.map(&:to_s).sort
  end   
1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523

  def test_draw
    assert_equal 0, set.routes.size
    set.draw do |map|
      map.connect '/hello/world', :controller => 'a', :action => 'b'
    end
    assert_equal 1, set.routes.size
  end
  
  def test_named_draw
    assert_equal 0, set.routes.size
    set.draw do |map|
      map.hello '/hello/world', :controller => 'a', :action => 'b'
    end
    assert_equal 1, set.routes.size
    assert_equal set.routes.first, set.named_routes[:hello]
  end
  
  def test_later_named_routes_take_precedence
    set.draw do |map|
      map.hello '/hello/world', :controller => 'a', :action => 'b'
      map.hello '/hello', :controller => 'a', :action => 'b'
    end
    assert_equal set.routes.last, set.named_routes[:hello]
  end

  def setup_named_route_test
    set.draw do |map|
      map.show '/people/:id', :controller => 'people', :action => 'show'
      map.index '/people', :controller => 'people', :action => 'index'
      map.multi '/people/go/:foo/:bar/joe/:id', :controller => 'people', :action => 'multi'
1524
      map.users '/admin/users', :controller => 'admin/users', :action => 'index'
1525 1526 1527
    end

    klass = Class.new(MockController)
1528
    set.install_helpers(klass)
1529 1530 1531 1532 1533 1534 1535
    klass.new(set)
  end

  def test_named_route_hash_access_method
    controller = setup_named_route_test

    assert_equal(
1536
      { :controller => 'people', :action => 'show', :id => 5, :use_route => :show, :only_path => false },
1537 1538 1539
      controller.send(:hash_for_show_url, :id => 5))

    assert_equal(
1540
      { :controller => 'people', :action => 'index', :use_route => :index, :only_path => false },
1541
      controller.send(:hash_for_index_url))
1542 1543 1544 1545 1546
    
    assert_equal(
      { :controller => 'people', :action => 'show', :id => 5, :use_route => :show, :only_path => true },
      controller.send(:hash_for_show_path, :id => 5)
    )
1547 1548 1549 1550
  end

  def test_named_route_url_method
    controller = setup_named_route_test
1551
    
1552
    assert_equal "http://named.route.test/people/5", controller.send(:show_url, :id => 5)
1553 1554
    assert_equal "/people/5", controller.send(:show_path, :id => 5)
    
1555
    assert_equal "http://named.route.test/people", controller.send(:index_url)
1556
    assert_equal "/people", controller.send(:index_path)
1557 1558 1559 1560

    assert_equal "http://named.route.test/admin/users", controller.send(:users_url)
    assert_equal '/admin/users', controller.send(:users_path)
    assert_equal '/admin/users', set.generate(controller.send(:hash_for_users_url), {:controller => 'users', :action => 'index'})
1561 1562
  end

1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596
  def test_named_route_url_method_with_anchor
    controller = setup_named_route_test

    assert_equal "http://named.route.test/people/5#location", controller.send(:show_url, :id => 5, :anchor => 'location')
    assert_equal "/people/5#location", controller.send(:show_path, :id => 5, :anchor => 'location')

    assert_equal "http://named.route.test/people#location", controller.send(:index_url, :anchor => 'location')
    assert_equal "/people#location", controller.send(:index_path, :anchor => 'location')

    assert_equal "http://named.route.test/admin/users#location", controller.send(:users_url, :anchor => 'location')
    assert_equal '/admin/users#location', controller.send(:users_path, :anchor => 'location')

    assert_equal "http://named.route.test/people/go/7/hello/joe/5#location",
      controller.send(:multi_url, 7, "hello", 5, :anchor => 'location')

    assert_equal "http://named.route.test/people/go/7/hello/joe/5?baz=bar#location",
      controller.send(:multi_url, 7, "hello", 5, :baz => "bar", :anchor => 'location')

    assert_equal "http://named.route.test/people?baz=bar#location",
      controller.send(:index_url, :baz => "bar", :anchor => 'location')
  end
  
  def test_named_route_url_method_with_port
    controller = setup_named_route_test
    assert_equal "http://named.route.test:8080/people/5", controller.send(:show_url, 5, :port=>8080)
  end
  
  def test_named_route_url_method_with_host
    controller = setup_named_route_test
    assert_equal "http://some.example.com/people/5", controller.send(:show_url, 5, :host=>"some.example.com")
  end
  

  def test_named_route_url_method_with_ordered_parameters
1597 1598 1599 1600
    controller = setup_named_route_test
    assert_equal "http://named.route.test/people/go/7/hello/joe/5",
      controller.send(:multi_url, 7, "hello", 5)
  end
1601

1602 1603 1604 1605 1606 1607
  def test_named_route_url_method_with_ordered_parameters_and_hash
    controller = setup_named_route_test
    assert_equal "http://named.route.test/people/go/7/hello/joe/5?baz=bar",
      controller.send(:multi_url, 7, "hello", 5, :baz => "bar")
  end
  
1608
  def test_named_route_url_method_with_no_positional_arguments
1609
    controller = setup_named_route_test
1610 1611
    assert_equal "http://named.route.test/people?baz=bar",
      controller.send(:index_url, :baz => "bar")
1612 1613
  end
  
1614 1615 1616 1617 1618
  def test_draw_default_route
    ActionController::Routing.with_controllers(['users']) do
      set.draw do |map|
        map.connect '/:controller/:action/:id'
      end
1619

1620 1621
      assert_equal 1, set.routes.size
      route = set.routes.first
1622

1623
      assert route.segments.last.optional?
1624

1625 1626
      assert_equal '/users/show/10', set.generate(:controller => 'users', :action => 'show', :id => 10)
      assert_equal '/users/index/10', set.generate(:controller => 'users', :id => 10)
1627

1628 1629 1630 1631
      assert_equal({:controller => 'users', :action => 'index', :id => '10'}, set.recognize_path('/users/index/10'))
      assert_equal({:controller => 'users', :action => 'index', :id => '10'}, set.recognize_path('/users/index/10/'))
    end
  end
1632

1633 1634 1635 1636 1637 1638 1639 1640 1641
  def test_draw_default_route_with_default_controller
    ActionController::Routing.with_controllers(['users']) do
      set.draw do |map|
        map.connect '/:controller/:action/:id', :controller => 'users'
      end      
      assert_equal({:controller => 'users', :action => 'index'}, set.recognize_path('/'))
    end
  end

1642 1643 1644 1645 1646 1647
  def test_route_with_parameter_shell
    ActionController::Routing.with_controllers(['users', 'pages']) do
      set.draw do |map|
        map.connect 'page/:id', :controller => 'pages', :action => 'show', :id => /\d+/
        map.connect '/:controller/:action/:id'
      end
1648

1649 1650 1651
      assert_equal({:controller => 'pages', :action => 'index'}, set.recognize_path('/pages'))
      assert_equal({:controller => 'pages', :action => 'index'}, set.recognize_path('/pages/index'))
      assert_equal({:controller => 'pages', :action => 'list'}, set.recognize_path('/pages/list'))
1652

1653 1654 1655 1656 1657
      assert_equal({:controller => 'pages', :action => 'show', :id => '10'}, set.recognize_path('/pages/show/10'))
      assert_equal({:controller => 'pages', :action => 'show', :id => '10'}, set.recognize_path('/page/10'))
    end
  end

1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706
  def test_route_requirements_with_anchor_chars_are_invalid
    assert_raises ArgumentError do
      set.draw do |map|
        map.connect 'page/:id', :controller => 'pages', :action => 'show', :id => /^\d+/
      end
    end
    assert_raises ArgumentError do
      set.draw do |map|
        map.connect 'page/:id', :controller => 'pages', :action => 'show', :id => /\A\d+/
      end
    end
    assert_raises ArgumentError do
      set.draw do |map|
        map.connect 'page/:id', :controller => 'pages', :action => 'show', :id => /\d+$/
      end
    end
    assert_raises ArgumentError do
      set.draw do |map|
        map.connect 'page/:id', :controller => 'pages', :action => 'show', :id => /\d+\Z/
      end
    end
    assert_raises ArgumentError do
      set.draw do |map|
        map.connect 'page/:id', :controller => 'pages', :action => 'show', :id => /\d+\z/
      end
    end
    assert_nothing_raised do
      set.draw do |map|
        map.connect 'page/:id', :controller => 'pages', :action => 'show', :id => /\d+/, :name => /^(david|jamis)/
      end
      assert_raises ActionController::RoutingError do
        set.generate :controller => 'pages', :action => 'show', :id => 10
      end
    end
  end
  
  def test_non_path_route_requirements_match_all
    set.draw do |map|
      map.connect 'page/37s', :controller => 'pages', :action => 'show', :name => /(jamis|david)/
    end
    assert_equal '/page/37s', set.generate(:controller => 'pages', :action => 'show', :name => 'jamis')
    assert_raises ActionController::RoutingError do
      set.generate(:controller => 'pages', :action => 'show', :name => 'not_jamis')
    end
    assert_raises ActionController::RoutingError do
      set.generate(:controller => 'pages', :action => 'show', :name => 'nor_jamis_and_david')
    end
  end
  
1707 1708
  def test_recognize_with_encoded_id_and_regex
    set.draw do |map|
1709
      map.connect 'page/:id', :controller => 'pages', :action => 'show', :id => /[a-zA-Z0-9\+]+/
1710
    end
1711

1712
    assert_equal({:controller => 'pages', :action => 'show', :id => '10'}, set.recognize_path('/page/10'))
1713
    assert_equal({:controller => 'pages', :action => 'show', :id => 'hello+world'}, set.recognize_path('/page/hello+world'))
1714 1715
  end

1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736
  def test_recognize_with_conditions
    Object.const_set(:PeopleController, Class.new)

    set.draw do |map|
      map.with_options(:controller => "people") do |people|
        people.people  "/people",     :action => "index",   :conditions => { :method => :get }
        people.connect "/people",     :action => "create",  :conditions => { :method => :post }
        people.person  "/people/:id", :action => "show",    :conditions => { :method => :get }
        people.connect "/people/:id", :action => "update",  :conditions => { :method => :put }
        people.connect "/people/:id", :action => "destroy", :conditions => { :method => :delete }
      end
    end

    request.path = "/people"
    request.method = :get
    assert_nothing_raised { set.recognize(request) }
    assert_equal("index", request.path_parameters[:action])
    
    request.method = :post
    assert_nothing_raised { set.recognize(request) }
    assert_equal("create", request.path_parameters[:action])
1737 1738 1739 1740 1741
    
    request.method = :put
    assert_nothing_raised { set.recognize(request) }
    assert_equal("update", request.path_parameters[:action])

1742 1743 1744 1745 1746 1747 1748
    begin
      request.method = :bacon
      set.recognize(request)
      flunk 'Should have raised NotImplemented'
    rescue ActionController::NotImplemented => e
      assert_equal [:get, :post, :put, :delete], e.allowed_methods
    end
1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764

    request.path = "/people/5"
    request.method = :get
    assert_nothing_raised { set.recognize(request) }
    assert_equal("show", request.path_parameters[:action])
    assert_equal("5", request.path_parameters[:id])

    request.method = :put
    assert_nothing_raised { set.recognize(request) }
    assert_equal("update", request.path_parameters[:action])
    assert_equal("5", request.path_parameters[:id])

    request.method = :delete
    assert_nothing_raised { set.recognize(request) }
    assert_equal("destroy", request.path_parameters[:action])
    assert_equal("5", request.path_parameters[:id])
1765 1766 1767 1768 1769 1770 1771 1772 1773

    begin
      request.method = :post
      set.recognize(request)
      flunk 'Should have raised MethodNotAllowed'
    rescue ActionController::MethodNotAllowed => e
      assert_equal [:get, :put, :delete], e.allowed_methods
    end

1774 1775 1776
  ensure
    Object.send(:remove_const, :PeopleController)
  end
1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799
  
  def test_typo_recognition
    Object.const_set(:ArticlesController, Class.new)

    set.draw do |map|
      map.connect 'articles/:year/:month/:day/:title',
             :controller => 'articles', :action => 'permalink',
             :year => /\d{4}/, :day => /\d{1,2}/, :month => /\d{1,2}/
    end
  
    request.path = "/articles/2005/11/05/a-very-interesting-article"
    request.method = :get
    assert_nothing_raised { set.recognize(request) }
    assert_equal("permalink", request.path_parameters[:action])
    assert_equal("2005", request.path_parameters[:year])
    assert_equal("11", request.path_parameters[:month])
    assert_equal("05", request.path_parameters[:day])
    assert_equal("a-very-interesting-article", request.path_parameters[:title])
    
  ensure
    Object.send(:remove_const, :ArticlesController)
  end

1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811
  def test_routing_traversal_does_not_load_extra_classes
    assert !Object.const_defined?("Profiler__"), "Profiler should not be loaded"
    set.draw do |map|
      map.connect '/profile', :controller => 'profile'
    end

    request.path = '/profile'

    set.recognize(request) rescue nil
    
    assert !Object.const_defined?("Profiler__"), "Profiler should not be loaded"
  end
1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852

  def test_recognize_with_conditions_and_format
    Object.const_set(:PeopleController, Class.new)

    set.draw do |map|
      map.with_options(:controller => "people") do |people|
        people.person  "/people/:id", :action => "show",    :conditions => { :method => :get }
        people.connect "/people/:id", :action => "update",  :conditions => { :method => :put }
        people.connect "/people/:id.:_format", :action => "show", :conditions => { :method => :get }
      end
    end

    request.path = "/people/5"
    request.method = :get
    assert_nothing_raised { set.recognize(request) }
    assert_equal("show", request.path_parameters[:action])
    assert_equal("5", request.path_parameters[:id])

    request.method = :put
    assert_nothing_raised { set.recognize(request) }
    assert_equal("update", request.path_parameters[:action])

    request.path = "/people/5.png"
    request.method = :get
    assert_nothing_raised { set.recognize(request) }
    assert_equal("show", request.path_parameters[:action])
    assert_equal("5", request.path_parameters[:id])
    assert_equal("png", request.path_parameters[:_format])
  ensure
    Object.send(:remove_const, :PeopleController)
  end

  def test_generate_with_default_action
    set.draw do |map|
      map.connect "/people", :controller => "people"
      map.connect "/people/list", :controller => "people", :action => "list"
    end

    url = set.generate(:controller => "people", :action => "list")
    assert_equal "/people/list", url
  end
1853
  
1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866
  def test_root_map
    Object.const_set(:PeopleController, Class.new)

    set.draw { |map| map.root :controller => "people" }

    request.path = ""
    request.method = :get
    assert_nothing_raised { set.recognize(request) }
    assert_equal("people", request.path_parameters[:controller])
    assert_equal("index", request.path_parameters[:action])
  ensure
    Object.send(:remove_const, :PeopleController)
  end
1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908
  
  
  def test_namespace
    Object.const_set(:Api, Module.new { |m| m.const_set(:ProductsController, Class.new) })

    set.draw do |map| 
      
      map.namespace 'api' do |api|
        api.route 'inventory', :controller => "products", :action => 'inventory'
      end
      
    end

    request.path = "/api/inventory"
    request.method = :get
    assert_nothing_raised { set.recognize(request) }
    assert_equal("api/products", request.path_parameters[:controller])
    assert_equal("inventory", request.path_parameters[:action])
  ensure
    Object.send(:remove_const, :Api)
  end
  

  def test_namespaced_root_map
    Object.const_set(:Api, Module.new { |m| m.const_set(:ProductsController, Class.new) })

    set.draw do |map| 
      
      map.namespace 'api' do |api|
        api.root :controller => "products"       
      end
      
    end

    request.path = "/api"
    request.method = :get
    assert_nothing_raised { set.recognize(request) }
    assert_equal("api/products", request.path_parameters[:controller])
    assert_equal("index", request.path_parameters[:action])
  ensure
    Object.send(:remove_const, :Api)
  end
1909

1910 1911 1912 1913 1914 1915 1916 1917 1918
  def test_generate_finds_best_fit
    set.draw do |map|
      map.connect "/people", :controller => "people", :action => "index"
      map.connect "/ws/people", :controller => "people", :action => "index", :ws => true
    end

    url = set.generate(:controller => "people", :action => "index", :ws => true)
    assert_equal "/ws/people", url
  end
1919 1920 1921 1922 1923 1924 1925

  def test_generate_changes_controller_module
    set.draw { |map| map.connect ':controller/:action/:id' }
    current = { :controller => "bling/bloop", :action => "bap", :id => 9 }
    url = set.generate({:controller => "foo/bar", :action => "baz", :id => 7}, current)
    assert_equal "/foo/bar/baz/7", url
  end
1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954 1955 1956

  def test_id_is_not_impossibly_sticky
    set.draw do |map|
      map.connect 'foo/:number', :controller => "people", :action => "index"
      map.connect ':controller/:action/:id'
    end

    url = set.generate({:controller => "people", :action => "index", :number => 3},
      {:controller => "people", :action => "index", :id => "21"})
    assert_equal "/foo/3", url
  end

  def test_id_is_sticky_when_it_ought_to_be
    set.draw do |map|
      map.connect ':controller/:id/:action'
    end

    url = set.generate({:action => "destroy"}, {:controller => "people", :action => "show", :id => "7"})
    assert_equal "/people/7/destroy", url
  end

  def test_use_static_path_when_possible
    set.draw do |map|
      map.connect 'about', :controller => "welcome", :action => "about"
      map.connect ':controller/:action/:id'
    end

    url = set.generate({:controller => "welcome", :action => "about"},
      {:controller => "welcome", :action => "get", :id => "7"})
    assert_equal "/about", url
  end
1957

1958
  def test_generate
1959 1960 1961 1962 1963 1964 1965 1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979
    set.draw { |map| map.connect ':controller/:action/:id' }

    args = { :controller => "foo", :action => "bar", :id => "7", :x => "y" }
    assert_equal "/foo/bar/7?x=y", set.generate(args)
    assert_equal ["/foo/bar/7", [:x]], set.generate_extras(args)
    assert_equal [:x], set.extra_keys(args)
  end

  def test_named_routes_are_never_relative_to_modules
    set.draw do |map|
      map.connect "/connection/manage/:action", :controller => 'connection/manage'
      map.connect "/connection/connection", :controller => "connection/connection"
      map.family_connection "/connection", :controller => "connection"
    end

    url = set.generate({:controller => "connection"}, {:controller => 'connection/manage'})
    assert_equal "/connection/connection", url

    url = set.generate({:use_route => :family_connection, :controller => "connection"}, {:controller => 'connection/manage'})
    assert_equal "/connection", url
  end
1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990
  
  def test_action_left_off_when_id_is_recalled
    set.draw do |map|
      map.connect ':controller/:action/:id'
    end
    assert_equal '/post', set.generate(
      {:controller => 'post', :action => 'index'},
      {:controller => 'post', :action => 'show', :id => '10'}
    )
  end
  
1991 1992 1993 1994 1995 1996 1997 1998 1999 2000
  def test_query_params_will_be_shown_when_recalled
    set.draw do |map|
      map.connect 'show_post/:parameter', :controller => 'post', :action => 'show'
      map.connect ':controller/:action/:id'
    end
    assert_equal '/post/edit?parameter=1', set.generate(
      {:action => 'edit', :parameter => 1},
      {:controller => 'post', :action => 'show', :parameter => 1}
    )
  end
2001 2002 2003 2004 2005 2006 2007 2008

  def test_expiry_determination_should_consider_values_with_to_param
    set.draw { |map| map.connect 'projects/:project_id/:controller/:action' }
    assert_equal '/projects/1/post/show', set.generate(
      {:action => 'show', :project_id => 1},
      {:controller => 'post', :action => 'show', :project_id => '1'})
  end

2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022
  def test_generate_all
    set.draw do |map|
      map.connect 'show_post/:id', :controller => 'post', :action => 'show'
      map.connect ':controller/:action/:id'
    end
    all = set.generate(
      {:action => 'show', :id => 10, :generate_all => true},
      {:controller => 'post', :action => 'show'}
    )
    assert_equal 2, all.length
    assert_equal '/show_post/10', all.first
    assert_equal '/post/show/10', all.last
  end
  
2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036
  def test_named_route_in_nested_resource
    set.draw do |map|
      map.resources :projects do |project|
        project.comments 'comments', :controller => 'comments', :action => 'index'
      end
    end
    
    request.path = "/projects/1/comments"
    request.method = :get
    assert_nothing_raised { set.recognize(request) }
    assert_equal("comments", request.path_parameters[:controller])
    assert_equal("index", request.path_parameters[:action])
  end
  
2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056
  def test_setting_root_in_namespace_using_symbol
    assert_nothing_raised do
      set.draw do |map|
        map.namespace :admin do |admin|
          admin.root :controller => 'home'
        end
      end
    end
  end
  
  def test_setting_root_in_namespace_using_string
    assert_nothing_raised do
      set.draw do |map|
        map.namespace 'admin' do |admin|
          admin.root :controller => 'home'
        end
      end
    end
  end
  
2057 2058 2059 2060 2061
end

class RoutingTest < Test::Unit::TestCase
  
  def test_possible_controllers
2062
    true_controller_paths = ActionController::Routing.controller_paths
J
Jeremy Kemper 已提交
2063

2064
    ActionController::Routing.use_controllers! nil
J
Jeremy Kemper 已提交
2065 2066 2067 2068 2069

    silence_warnings do
      Object.send(:const_set, :RAILS_ROOT, File.dirname(__FILE__) + '/controller_fixtures')
    end

2070
    ActionController::Routing.controller_paths = [
2071 2072 2073 2074 2075
      RAILS_ROOT, RAILS_ROOT + '/app/controllers', RAILS_ROOT + '/vendor/plugins/bad_plugin/lib'
    ]
    
    assert_equal ["admin/user", "plugin", "user"], ActionController::Routing.possible_controllers.sort
  ensure
2076 2077
    if true_controller_paths
      ActionController::Routing.controller_paths = true_controller_paths
2078
    end
2079
    ActionController::Routing.use_controllers! nil
2080 2081 2082
    Object.send(:remove_const, :RAILS_ROOT) rescue nil
  end
  
2083 2084 2085 2086 2087 2088 2089 2090 2091 2092 2093 2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107
  def test_possible_controllers_are_reset_on_each_load
    true_possible_controllers = ActionController::Routing.possible_controllers
    true_controller_paths = ActionController::Routing.controller_paths
    
    ActionController::Routing.use_controllers! nil
    root = File.dirname(__FILE__) + '/controller_fixtures'
    
    ActionController::Routing.controller_paths = []
    assert_equal [], ActionController::Routing.possible_controllers
    
    ActionController::Routing::Routes.load!
    ActionController::Routing.controller_paths = [
      root, root + '/app/controllers', root + '/vendor/plugins/bad_plugin/lib'
    ]
    
    assert_equal ["admin/user", "plugin", "user"], ActionController::Routing.possible_controllers.sort
  ensure
    ActionController::Routing.controller_paths = true_controller_paths
    ActionController::Routing.use_controllers! true_possible_controllers
    Object.send(:remove_const, :RAILS_ROOT) rescue nil
    
    ActionController::Routing::Routes.clear!
    ActionController::Routing::Routes.load_routes!
  end
  
2108 2109 2110 2111 2112 2113
  def test_with_controllers
    c = %w(admin/accounts admin/users account pages)
    ActionController::Routing.with_controllers c do
      assert_equal c, ActionController::Routing.possible_controllers
    end
  end
2114 2115 2116 2117 2118 2119 2120 2121 2122 2123 2124 2125

  def test_normalize_unix_paths
    load_paths = %w(. config/../app/controllers config/../app//helpers script/../config/../vendor/rails/actionpack/lib vendor/rails/railties/builtin/rails_info app/models lib script/../config/../foo/bar/../../app/models)
    paths = ActionController::Routing.normalize_paths(load_paths)
    assert_equal %w(vendor/rails/railties/builtin/rails_info vendor/rails/actionpack/lib app/controllers app/helpers app/models lib .), paths
  end

  def test_normalize_windows_paths
    load_paths = %w(. config\\..\\app\\controllers config\\..\\app\\\\helpers script\\..\\config\\..\\vendor\\rails\\actionpack\\lib vendor\\rails\\railties\\builtin\\rails_info app\\models lib script\\..\\config\\..\\foo\\bar\\..\\..\\app\\models)
    paths = ActionController::Routing.normalize_paths(load_paths)
    assert_equal %w(vendor\\rails\\railties\\builtin\\rails_info vendor\\rails\\actionpack\\lib app\\controllers app\\helpers app\\models lib .), paths
  end
2126
  
2127 2128 2129 2130 2131 2132 2133 2134 2135 2136
  def test_routing_helper_module
    assert_kind_of Module, ActionController::Routing::Helpers
    
    h = ActionController::Routing::Helpers
    c = Class.new
    assert ! c.ancestors.include?(h)
    ActionController::Routing::Routes.install_helpers c
    assert c.ancestors.include?(h)
  end
  
2137
end
2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148 2149 2150 2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184 2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197

uses_mocha 'route loading' do
  class RouteLoadingTest < Test::Unit::TestCase

    def setup
      routes.instance_variable_set '@routes_last_modified', nil
      silence_warnings { Object.const_set :RAILS_ROOT, '.' }

      @stat = stub_everything
    end

    def teardown
      Object.send :remove_const, :RAILS_ROOT
    end

    def test_load
      File.expects(:stat).returns(@stat)
      routes.expects(:load).with(regexp_matches(/routes\.rb$/))

      routes.reload
    end

    def test_no_reload_when_not_modified
      @stat.expects(:mtime).times(2).returns(1)
      File.expects(:stat).times(2).returns(@stat)
      routes.expects(:load).with(regexp_matches(/routes\.rb$/)).at_most_once

      2.times { routes.reload }
    end

    def test_reload_when_modified
      @stat.expects(:mtime).at_least(2).returns(1, 2)
      File.expects(:stat).at_least(2).returns(@stat)
      routes.expects(:load).with(regexp_matches(/routes\.rb$/)).times(2)

      2.times { routes.reload }
    end

    def test_bang_forces_reload
      @stat.expects(:mtime).at_least(2).returns(1)
      File.expects(:stat).at_least(2).returns(@stat)
      routes.expects(:load).with(regexp_matches(/routes\.rb$/)).times(2)

      2.times { routes.reload! }
    end

    def test_adding_inflections_forces_reload
      Inflector::Inflections.instance.expects(:uncountable).with('equipment')
      routes.expects(:reload!)

      Inflector.inflections { |inflect| inflect.uncountable('equipment') }
    end

    private
    def routes
      ActionController::Routing::Routes
    end

  end
end