Subcommands contain pointers to functions which are not updated when
MANUAL_RELOC is enabled. This patch fix it.
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>
Reviewed-by: NSimon Glass <sjg@chromium.org>

Subcommands contain pointers to functions which are not updated when
MANUAL_RELOC is enabled. This patch fix it.
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>
Acked-by: NHeiko Schocher <hs@denx.de>
Reviewed-by: NSimon Glass <sjg@chromium.org>

debug_uart.h is included twice.
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>
Reviewed-by: NBin Meng <bmeng.cn@gmail.com>
Reviewed-by: NSimon Glass <sjg@chromium.org>

Remove this c&p error from s5p driver.
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>
Reviewed-by: NBin Meng <bmeng.cn@gmail.com>
Reviewed-by: NSimon Glass <sjg@chromium.org>

Move driver to DM
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>
Reviewed-by: NSimon Glass <sjg@chromium.org>

Prepare for using DM.
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>

Calculate the minimum sd clock based on max clock. This will
be done by add_sdhci() if we pass minimum clock as zero.
It also does based on SD host contoller version.
Signed-off-by: NSiva Durga Prasad Paladugu <sivadur@xilinx.com>
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>

Remove unused macros when driver was moved to DM.
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>

SPL DM MMC FAT requires more malloc space(3k fat buffers + dm)
that it is available now. Extend SPL malloc space.

Current OCM layout:
0xffff0000 - 0xfff2000 - Full malloc space
0xffff2000 - 0xffff300 - Stack location
0xfffff300 - CONFIG_SYS_MALLOC_F_LEN - Early malloc space
0xfffffd00 - sizeof(GD) - GD
0xfffffe00 - 0xffffffff - SoC specific boot code
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>

The patch
"board_init: Change the logic to setup malloc_base"
(sha1: 9ac4fc82)
breaks SPL for Zynq because it puts early alloc area on the stack which
caused that stack was decreased by CONFIG_SYS_MALLOC_F_LEN (0x400)
and there was not enough space for regular stack.

This patch changes memory layout to better utilize the last 64k OCM
block.
0xffff0000 - 0xfff1000 - Full malloc space
0xffff1000 - 0xffff300 - Stack location
0xfffff300 - CONFIG_SYS_MALLOC_F_LEN - Early malloc space
0xfffffd00 - sizeof(GD) - GD
0xfffffe00 - 0xffffffff - SoC specific boot code
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>
Tested-by: NMoritz Fischer <moritz.fischer@ettus.com>

Signed-off-by: NMichal Simek <michal.simek@xilinx.com>

Remove configuration options from board file.
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>

Enable to break waiting loop at any time.
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>
Acked-by: NJoe Hershberger <joe.hershberger@ni.com>

Signed-off-by: NMichal Simek <michal.simek@xilinx.com>
Reviewed-by: NJagan Teki <jteki@openedev.com>

Do not set interface via configs. Read information from DT.
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>
Reviewed-by: NJagan Teki <jteki@openedev.com>

- Enable DM_ETH by default for Zynq and ZynqMP
- Remove board_eth_init code
- Change miiphy_read function to return value instead of error code
  based on DM requirement
- Do not enable EMIO DT support by default
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>
Reviewed-by: NJagan Teki <jteki@openedev.com>
Reviewed-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NBin Meng <bmeng.cn@gmail.com>

Sync it with write function.
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>
Reviewed-by: NJagan Teki <jteki@openedev.com>

This function was used for OF init before DM.
Remove this function as the part of move to DM.
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>
Reviewed-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NJagan Teki <jteki@openedev.com>

Enable access to MDIO before zynq_gem_init is called.
It enables read information about phy earlier.
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>

Check return value.
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>
Reviewed-by: NJagan Teki <jteki@openedev.com>

Move phy init code out of zynq_gem_init. DM drivers are normally calling
this code from probe function.
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>

Resort code to use priv->phydev variable directly.
It will simplify move to DM.
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>

Next step to move driver to driver model. Do not use eth_device
structure. Use private structure instead.
Add iobase to private structure to store gem iobase.
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>

Pass regs instead of dev because this will be chagned by
driver model.
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>

Add return value for phy detection algorithm to stop init function when
phy is not found.
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>
Reviewed-by: NJagan Teki <jteki@openedev.com>

CONFIG_API is causing compilation error when DM_ETH is enabled because
eth_get_dev() is not available.
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>
Reviewed-by: NJagan Teki <jteki@openedev.com>

Move PHYLIB from board config to defconfig
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>
Reviewed-by: NJagan Teki <jteki@openedev.com>

We now want to make sure that we have the platform data for NS16550 when
we do not have OF_CONTROL set.
Signed-off-by: NTom Rini <trini@konsulko.com>
Reviewed-by: NSimon Glass <sjg@chromium.org>

At present an incorrect #if term is preventing this data from being compiled
in. All tegra boards use driver model for serial, so we can just drop this.

Fixes: fde7e189 ("dm: tegra: pci: Move CONFIG_PCI_TEGRA to Kconfig")
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reported-by: NStephen Warren <swarren@nvidia.com>
Acked-by: NThomas Chou <thomas@wytron.com.tw>

For platforms that don't use device tree in SPL the only way to mark this
driver as 'required by relocation' is with the DM_FLAG_PRE_RELOC flag. Add
this to ensure that the driver is bound.

Fixes: fde7e189 ("dm: tegra: pci: Move CONFIG_PCI_TEGRA to Kconfig")
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reported-by: NStephen Warren <swarren@nvidia.com>
Acked-by: NThomas Chou <thomas@wytron.com.tw>

These were added by mistake in commit fde7e189. They cause a warning when
configuring the boards. Remove them.

Fixes: fde7e189 ("dm: tegra: pci: Move CONFIG_PCI_TEGRA to Kconfig")
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reported-by: NStephen Warren <swarren@nvidia.com>
Tested-by: NStephen Warren <swarren@nvidia.com>
Reported-by: NKevin Hilman <khilman@linaro.org>
Acked-by: NThomas Chou <thomas@wytron.com.tw>

For U-Boot's purposes, at present all we care about is ensuring there's
a model table entry.
Signed-off-by: NStephen Warren <swarren@wwwdotorg.org>

The RPi has two different schemes for encoding board revision values.
When adding RPi 2 support, I thought that the conflicting type field
values were to be interpreted based on bcm2835-vs-bcm2836. In fact, the
scheme bit determines the encoding. The RPi Zero uses the bcm2835 yet
uses the new encoding scheme. Fix the code to cater for this correctly.
Signed-off-by: NStephen Warren <swarren@wwwdotorg.org>

There are two numbering schemes for the RPi revision values; old and new
scheme. The values within each scheme overlap. Hence, it doesn't make
sense to have absolute/global names for the revision IDs. Get rid of the
names and just use the raw revision/type values to set up the array of
per-revision data.

This change makes most sense when coupled with the next change. However,
it's split out so that the mechanical cut/paste is separate from the
logic changes for easier review and problem bisection.
Signed-off-by: NStephen Warren <swarren@wwwdotorg.org>

Seems 92a655c3 broke creating multi and script type images.
Since the file1:file2:file3 string does not get split up,
it fails on trying to open an non-existing file.

mkimage -A arm -O linux -T multi -C none -d zImage:splash.bmp:device.dtb uimage
tools/mkimage: Can't open zImage:splash.bmp:device.dtb: No such file or directory

Since the sizes of the different parts seem to get added in the actual
routine that handles multi and script type images, we can probably skip the
bit of the code that causes the failure for that type of images.
Signed-off-by: NPhilippe De Swert <philippedeswert@gmail.com>

Don't relocate fdt in case of CONFIG_OF EMBED as the fdt is
already embedded with u-boot image.
Update fdt_blob after relocation as the fdt will be copied
during u-boot relocation.
Signed-off-by: NSiva Durga Prasad Paladugu <sivadur@xilinx.com>
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>
Reviewed-by: NAlexey Brodkin <abrodkin@synopsys.com>
Reviewed-by: NBin Meng <bmeng.cn@gmail.com>
Tested-by: Bin Meng <bmeng.cn@gmail.com> (QEMU x86)
Tested-by: Thomas Chou <thomas@wytron.com.tw> (Nios2)
Acked-by: NThomas Chou <thomas@wytron.com.tw>
Acked-by: NSimon Glass <sjg@chromium.org>

It is risky to have two different functions with much the same code. Future
authors may update one but not the other. It is hard to see which parts are
the same and which are different.

Unify the functions and drop the differences that are not really needed.

Note that one puts() becomes printf() as Tom mentioned that this does not
affect image size:

https://patchwork.ozlabs.org/patch/537276/

Note: It would be better to have an empty printf() and avoid the #ifdef for
CONFIG_SPL_LIBCOMMON_SUPPORT.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Tested-by: NMichal Simek <michal.simek@xilinx.com>

The 'p' suffix makes it more obvious that we are dealing with a pointer
to a (pointer) value that will be returned to its caller.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Acked-by: NNikita Kiryanov <nikita@compulab.co.il>
Tested-by: NMichal Simek <michal.simek@xilinx.com>

Since commit 4188ba32 we get the following warning on rockchip boards:

common/spl/spl_mmc.c:31:24: warning: ‘mmc’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  count = mmc->block_dev.block_read(0, sector, 1, header);
                        ^
common/spl/spl_mmc.c:251:14: note: ‘mmc’ was declared here
  struct mmc *mmc;

Correct this by move the variable init earlier.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Tested-by: NMichal Simek <michal.simek@xilinx.com>
Acked-by: NNikita Kiryanov <nikita@compulab.co.il>

Neither uc_pdata->name nor check_name are supposed to be NULL in
_rproc_name_is_unique(). if uc_pdata->name is NULL, we are not
intialized yet, however if check_data is NULL, we do not have
proper data. Further, if either were NULL, strlen will crap out
while attempting to derefence NULL.

Instead, just check if either of these are NULL and bail out.

This should also fix the following coverity scan warnings:
*** CID 132281:  Null pointer dereferences  (FORWARD_NULL)
/drivers/remoteproc/rproc-uclass.c: 73 in _rproc_name_is_unique()
Reported-by: NTom Rini <trini@konsulko.com>
Signed-off-by: NNishanth Menon <nm@ti.com>