Signed-off-by: NMichal Simek <michal.simek@xilinx.com>
Reviewed-by: NJagan Teki <jteki@openedev.com>

Do not set interface via configs. Read information from DT.
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>
Reviewed-by: NJagan Teki <jteki@openedev.com>

- Enable DM_ETH by default for Zynq and ZynqMP
- Remove board_eth_init code
- Change miiphy_read function to return value instead of error code
  based on DM requirement
- Do not enable EMIO DT support by default
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>
Reviewed-by: NJagan Teki <jteki@openedev.com>
Reviewed-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NBin Meng <bmeng.cn@gmail.com>

Sync it with write function.
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>
Reviewed-by: NJagan Teki <jteki@openedev.com>

This function was used for OF init before DM.
Remove this function as the part of move to DM.
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>
Reviewed-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NJagan Teki <jteki@openedev.com>

Enable access to MDIO before zynq_gem_init is called.
It enables read information about phy earlier.
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>

Check return value.
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>
Reviewed-by: NJagan Teki <jteki@openedev.com>

Move phy init code out of zynq_gem_init. DM drivers are normally calling
this code from probe function.
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>

Resort code to use priv->phydev variable directly.
It will simplify move to DM.
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>

Next step to move driver to driver model. Do not use eth_device
structure. Use private structure instead.
Add iobase to private structure to store gem iobase.
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>

Pass regs instead of dev because this will be chagned by
driver model.
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>

Add return value for phy detection algorithm to stop init function when
phy is not found.
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>
Reviewed-by: NJagan Teki <jteki@openedev.com>

CONFIG_API is causing compilation error when DM_ETH is enabled because
eth_get_dev() is not available.
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>
Reviewed-by: NJagan Teki <jteki@openedev.com>

Move PHYLIB from board config to defconfig
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>
Reviewed-by: NJagan Teki <jteki@openedev.com>

We now want to make sure that we have the platform data for NS16550 when
we do not have OF_CONTROL set.
Signed-off-by: NTom Rini <trini@konsulko.com>
Reviewed-by: NSimon Glass <sjg@chromium.org>

At present an incorrect #if term is preventing this data from being compiled
in. All tegra boards use driver model for serial, so we can just drop this.

Fixes: fde7e189 ("dm: tegra: pci: Move CONFIG_PCI_TEGRA to Kconfig")
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reported-by: NStephen Warren <swarren@nvidia.com>
Acked-by: NThomas Chou <thomas@wytron.com.tw>

For platforms that don't use device tree in SPL the only way to mark this
driver as 'required by relocation' is with the DM_FLAG_PRE_RELOC flag. Add
this to ensure that the driver is bound.

Fixes: fde7e189 ("dm: tegra: pci: Move CONFIG_PCI_TEGRA to Kconfig")
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reported-by: NStephen Warren <swarren@nvidia.com>
Acked-by: NThomas Chou <thomas@wytron.com.tw>

These were added by mistake in commit fde7e189. They cause a warning when
configuring the boards. Remove them.

Fixes: fde7e189 ("dm: tegra: pci: Move CONFIG_PCI_TEGRA to Kconfig")
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reported-by: NStephen Warren <swarren@nvidia.com>
Tested-by: NStephen Warren <swarren@nvidia.com>
Reported-by: NKevin Hilman <khilman@linaro.org>
Acked-by: NThomas Chou <thomas@wytron.com.tw>

For U-Boot's purposes, at present all we care about is ensuring there's
a model table entry.
Signed-off-by: NStephen Warren <swarren@wwwdotorg.org>

The RPi has two different schemes for encoding board revision values.
When adding RPi 2 support, I thought that the conflicting type field
values were to be interpreted based on bcm2835-vs-bcm2836. In fact, the
scheme bit determines the encoding. The RPi Zero uses the bcm2835 yet
uses the new encoding scheme. Fix the code to cater for this correctly.
Signed-off-by: NStephen Warren <swarren@wwwdotorg.org>

There are two numbering schemes for the RPi revision values; old and new
scheme. The values within each scheme overlap. Hence, it doesn't make
sense to have absolute/global names for the revision IDs. Get rid of the
names and just use the raw revision/type values to set up the array of
per-revision data.

This change makes most sense when coupled with the next change. However,
it's split out so that the mechanical cut/paste is separate from the
logic changes for easier review and problem bisection.
Signed-off-by: NStephen Warren <swarren@wwwdotorg.org>

Seems 92a655c3 broke creating multi and script type images.
Since the file1:file2:file3 string does not get split up,
it fails on trying to open an non-existing file.

mkimage -A arm -O linux -T multi -C none -d zImage:splash.bmp:device.dtb uimage
tools/mkimage: Can't open zImage:splash.bmp:device.dtb: No such file or directory

Since the sizes of the different parts seem to get added in the actual
routine that handles multi and script type images, we can probably skip the
bit of the code that causes the failure for that type of images.
Signed-off-by: NPhilippe De Swert <philippedeswert@gmail.com>

Don't relocate fdt in case of CONFIG_OF EMBED as the fdt is
already embedded with u-boot image.
Update fdt_blob after relocation as the fdt will be copied
during u-boot relocation.
Signed-off-by: NSiva Durga Prasad Paladugu <sivadur@xilinx.com>
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>
Reviewed-by: NAlexey Brodkin <abrodkin@synopsys.com>
Reviewed-by: NBin Meng <bmeng.cn@gmail.com>
Tested-by: Bin Meng <bmeng.cn@gmail.com> (QEMU x86)
Tested-by: Thomas Chou <thomas@wytron.com.tw> (Nios2)
Acked-by: NThomas Chou <thomas@wytron.com.tw>
Acked-by: NSimon Glass <sjg@chromium.org>

It is risky to have two different functions with much the same code. Future
authors may update one but not the other. It is hard to see which parts are
the same and which are different.

Unify the functions and drop the differences that are not really needed.

Note that one puts() becomes printf() as Tom mentioned that this does not
affect image size:

https://patchwork.ozlabs.org/patch/537276/

Note: It would be better to have an empty printf() and avoid the #ifdef for
CONFIG_SPL_LIBCOMMON_SUPPORT.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Tested-by: NMichal Simek <michal.simek@xilinx.com>

The 'p' suffix makes it more obvious that we are dealing with a pointer
to a (pointer) value that will be returned to its caller.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Acked-by: NNikita Kiryanov <nikita@compulab.co.il>
Tested-by: NMichal Simek <michal.simek@xilinx.com>

Since commit 4188ba32 we get the following warning on rockchip boards:

common/spl/spl_mmc.c:31:24: warning: ‘mmc’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  count = mmc->block_dev.block_read(0, sector, 1, header);
                        ^
common/spl/spl_mmc.c:251:14: note: ‘mmc’ was declared here
  struct mmc *mmc;

Correct this by move the variable init earlier.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Tested-by: NMichal Simek <michal.simek@xilinx.com>
Acked-by: NNikita Kiryanov <nikita@compulab.co.il>

Neither uc_pdata->name nor check_name are supposed to be NULL in
_rproc_name_is_unique(). if uc_pdata->name is NULL, we are not
intialized yet, however if check_data is NULL, we do not have
proper data. Further, if either were NULL, strlen will crap out
while attempting to derefence NULL.

Instead, just check if either of these are NULL and bail out.

This should also fix the following coverity scan warnings:
*** CID 132281:  Null pointer dereferences  (FORWARD_NULL)
/drivers/remoteproc/rproc-uclass.c: 73 in _rproc_name_is_unique()
Reported-by: NTom Rini <trini@konsulko.com>
Signed-off-by: NNishanth Menon <nm@ti.com>

Signed-off-by: NKamil Lulko <kamil.lulko@gmail.com>

Change reg-shift property default to zero. When the integer property
is missing, it should be taken as zero. This is consistent to Linux
drivers/tty/serial/of_serial.c.

The x86 and most powerpc use reg-shift of 0. Most others use reg-shift
of 2. While reg-shift of 1 is rarely used.
Signed-off-by: NThomas Chou <thomas@wytron.com.tw>
Reviewed-by: NBin Meng <bmeng.cn@gmail.com>
Reviewed-by: NMugunthan V N <mugunthanvnm@ti.com>
Acked-by: NSimon Glass <sjg@chromium.org>

With gcc-5.x we get warning about inline non-static functions referring to
static elements.
Signed-off-by: NTom Rini <trini@konsulko.com>
Reviewed-by: NBin Meng <bmeng.cn@gmail.com>

Need to free memory avoid memory leak, when error.
Signed-off-by: NPeng Fan <Peng.Fan@freescale.com>
Reviewed-by: NSimon Glass <sjg@chromium.org>
Cc: Simon Glass <sjg@chromium.org>
Cc: Tom Rini <trini@konsulko.com>

When CONFIG_SPL_OF_TRANSLATE is enabled fdt_support.c needs to get
compiled. Otherwise fdt_translate_address() is missing which is needed
in dev_get_addr().
Signed-off-by: NStefan Roese <sr@denx.de>
Cc: Simon Glass <sjg@chromium.org>
Acked-by: NSimon Glass <sjg@chromium.org>

Enable serial driver model for dra74_evm as ns16550 supports
driver model.
Signed-off-by: NMugunthan V N <mugunthanvnm@ti.com>
Reviewed-by: NSimon Glass <sjg@chromium.org>

Introduce chosen node and specify uart0 to be used as serial console.
Signed-off-by: NMugunthan V N <mugunthanvnm@ti.com>
Reviewed-by: NSimon Glass <sjg@chromium.org>

With the commit 'c7b9686d ("ns16550: unify serial_omap")' all
TI platforms are broken with DM/DT boot as ns16550 driver expects
reg-shift from DT which is not populated for TI platforms.
Earlier it worked as it was hard coded to 2 in serial-omap
driver. So adding the reg-shift to serial nodes for dra7, am4372
and am33xx dtsi files. Tested this patch on am437x-sk-evm,
am437x-gp-evm, am335x-boneblack, dra74x-evm and dra72x-evm.
Signed-off-by: NMugunthan V N <mugunthanvnm@ti.com>
Reviewed-by: NSimon Glass <sjg@chromium.org>
Acked-by: NThomas Chou <thomas@wytron.com.tw>

The following code will alloc memory for new_dev and ldev:
"
new_dev = mdio_alloc();
ldev = malloc(sizeof(*ldev));
"
Either new_dev or ldev is NULL, directly return, but this may leak memory.
So before return, using free(ldev) and mdio_free(new_dev) to avoid
leaking memory, also free can handle NULL pointer.
Signed-off-by: NPeng Fan <Peng.Fan@freescale.com>
Cc: Joe Hershberger <joe.hershberger@ni.com>
Cc: Simon Glass <sjg@chromium.org>
Cc: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: NBin Meng <bmeng.cn@gmail.com>
Acked-by: NJoe Hershberger <joe.hershberger@ni.com>

"enable" is unsigned char type and its value will not be
negative, so discard "enable < 0".
Signed-off-by: NPeng Fan <Peng.Fan@freescale.com>
Cc: Diego Santa Cruz <Diego.SantaCruz@spinetix.com>
Cc: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
Cc: Andrew Gabbasov <andrew_gabbasov@mentor.com>
Cc: Simon Glass <sjg@chromium.org>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Tom Rini <trini@konsulko.com>
Reviewed-by: NSimon Glass <sjg@chromium.org>

This symbol is no longer used anywhere, remove it.
Signed-off-by: NMarek Vasut <marex@denx.de>
Cc: Heiko Schocher <hs@denx.de>
Cc: Tom Rini <trini@konsulko.com>
Acked-by: NHeiko Schocher <hs@denx.de>

Signed-off-by: NVagrant Cascadian <vagrant@debian.org>
Acked-by: NMarek Vasut <marex@denx.de>

Signed-off-by: NVagrant Cascadian <vagrant@debian.org>
Reviewed-by: NJoe Hershberger <joe.hershberger@ni.com>