Hello,

I ran into a problem with the JFFS2 filesystem driver implemented in U-Boot.

I've got a NAND device that has correctable ECC errors (corrected somewhere in mtd/nand/nand_base.c).
The NAND driver tells the filesystem layer (jffs2_1pass.c) above that there occurred correctable ECC errors and returns with a "value > 0".
The JFFS2 driver recognizes the corrected ECC errors as real error and skips this block because the only accepts a "return value == 0" as correct.

This problem exists for over 8 years (I checked version 2010.09) so I'm a little bit worried that I interpreted something wrong or didn't get the whole context.

Can someone confirm this bug (and the bugfix) in the u-boot jffs2 driver?

There was a mail in 2012 that mentioned the same problem, but there was no patch:
http://u-boot.10912.n7.nabble.com/JFFS2-seems-to-drop-nand-data-with-ECC-corrections-td142008.html
Sometime after this discussion the return value of nand_read() changed from -EUCLEAN as correctable ECC error to a positive value with the count of ECC corrected errors.

With kind reguards,
Uwe Engling

Add brief documentation for the recently merged qemu-arm board.
Signed-off-by: NTuomas Tynkkynen <tuomas.tynkkynen@iki.fi>

MMC commands like MMC_CMD_ALL_SEND_CID or MMC_CMD_SEND_CSD can reach
500 us. This patch increases the polling status register delay to avoid
a timeout on a command.
Signed-off-by: NChristophe Kerello <christophe.kerello@st.com>
Signed-off-by: NPatrice Chotard <patrice.chotard@st.com>

Fix bit 2 name of PWR_CR3 register to match with the
last STM32H7 reference manual available here :

http://www.st.com/content/st_com/en/support/resources/
resource-selector.html?querycriteria=productId=SS1951$$
resourceCategory=technical_literature$$resourceType=reference_manual

Update also comment about voltage scaling 1 values
Signed-off-by: NPatrice Chotard <patrice.chotard@st.com>
Reviewed-by: NVikas Manocha <vikas.manocha@st.com>

CLK() macro is a residue of a previously reworked patch,
remove it.
Signed-off-by: NPatrice Chotard <patrice.chotard@st.com>
Reviewed-by: NVikas Manocha <vikas.manocha@st.com>

This macro isn't used by anything, and in fact hasn't ever been used
according to the Git logs.
Signed-off-by: NTuomas Tynkkynen <tuomas.tynkkynen@iki.fi>

Otherwise fs_opendir will fault.
Signed-off-by: NMarek Behun <marek.behun@nic.cz>

I accidentaly left a foreign language note in the code from development.
Signed-off-by: NMarek Behun <marek.behun@nic.cz>

The variable res should be initialized to 0 in these functions,
because if the searched key is not found, the variable is used
uninitialized.

Reported-by: Coverity (CID: 167335)
Reported-by: Coverity (CID: 167336)
Reported-by: Coverity (CID: 167337)
Signed-off-by: NMarek Behun <marek.behun@nic.cz>

Since
  rem = ((long) *tim_p) % SECSPERDAY;
the second while cycle
  while (rem >= SECSPERDAY)
is dead.

Reported-by: Coverity (CID: 167334)
Signed-off-by: NMarek Behun <marek.behun@nic.cz>

The test and info callbacks into the partition callback struct are
used by the "part list" command on the command line. That command
is used by the distro script.

With verb=1 set, "part list" thus throws a lot of warnings about
partitions it can't find when an upper layer searches for partitions.

So let's reduce verbosity to bring it to the same level of noise
as the other partition targets.
Signed-off-by: NAlexander Graf <agraf@suse.de>

CONFIG options surrounded by

  CONFIG_IS_ENABLED(...)
  CONFIG_IS_BUILTIN(...)
  CONFIG_IS_MODULE(...)
  CONFIG_VAL(...)

need special care for proper dependency tracking.

I do not remember why, but I missed to add CONFIG_VAL(...) handling.
Signed-off-by: NMasahiro Yamada <yamada.masahiro@socionext.com>

All BMP files were being treated as though they had a 40 byte header.
There are several BMP header formats consisting of additional data.
This was causing some of the header to be read as color information,
skewing the color palette.
Signed-off-by: NJon Smith <jtsmith@pdiarm.com>

When compiling with W=1 the following warning is observed:

arch/arm/mach-imx/mx6/soc.c:590:6: warning: no previous prototype for ‘s_init’ [-Wmissing-prototypes] void s_init(void)

Remove this warning by adding the function prototype into include/common.h file.
Signed-off-by: NDiego Dorta <diego.dorta@nxp.com>

fit_handle_file function does not quote input and output files while preparing
command to run DTC to convert .its to .itb. This results in a failure if input
or output files contain spaces in their names. Quote input and output files in
DTC command to avoid this failure.
Signed-off-by: NMirza, Taimoor <Taimoor_Mirza@mentor.com>

Upstream Linux has received a few device tree updates to the RPi
which we should propagate into the builtin U-Boot one as well to
gain hardware support.

This patch bumps the dts files to their 4.14 Linux counterparts
with the exception of sdhost on 32bit RPi versions. There we stay
with iproc as the sdhost driver is missing in U-Boot.
Signed-off-by: NAlexander Graf <agraf@suse.de>

While this goes somewhat against normal coding style we should ensure
that dev_desc is not NULL before we dereference it in allocation of
legacy_mbr.

Reported-by: Coverity (CID: 167292)
Signed-off-by: NTom Rini <trini@konsulko.com>

Remove depends on TI_SECURE_DEVICE for other platforms.
Signed-off-by: NVasily Gurevich <ext-vasily.gurevich@vaisala.com>

This allows the NAND driver to enable clock and get its clock rate.
Signed-off-by: NMasahiro Yamada <yamada.masahiro@socionext.com>

Enable clock in the probe hook.  The clock rate will be necessary
when setup_data_interface hook is supported.
Signed-off-by: NMasahiro Yamada <yamada.masahiro@socionext.com>

Now USB 3.0 feature is enabled/disabled by CONFIG_USB_DWC3_UNIPHIER.
Signed-off-by: NMasahiro Yamada <yamada.masahiro@socionext.com>

Enable CONFIGs for the DWC3 core and the UniPhier specific glue layer.
Signed-off-by: NMasahiro Yamada <yamada.masahiro@socionext.com>

ARCH_UNIPHIER_V8_MULTI depends on !SPL, so the default may be hidden.
Use a clearer default.
Signed-off-by: NMasahiro Yamada <yamada.masahiro@socionext.com>

priv->dev does not exist.  Pass the correct pointer to udevice.
Signed-off-by: NMasahiro Yamada <yamada.masahiro@socionext.com>

Add basic clock data for Socionext's new SoC PXs3.
Signed-off-by: NMasahiro Yamada <yamada.masahiro@socionext.com>

U-Boot does not support fancy clock tree structures like the Linux
common clock framework.  Implement a simple clock tree model at the
driver level.  With this, the clock data will be simplified.
Signed-off-by: NMasahiro Yamada <yamada.masahiro@socionext.com>

Use dev_dbg() functions.  It will be helpful to prefix log messages
with the corresponding device name when the core framework is ready.

While I am here, I renamed "dev", which was actually private data,
into "priv" because dev->dev looks confusing.
Signed-off-by: NMasahiro Yamada <yamada.masahiro@socionext.com>

Use dev_dbg() functions.  It will be helpful to prefix log messages
with the corresponding device name when the core framework is ready.

While I am here, I renamed "dev", which was actually private data,
into "priv" because dev->dev looks confusing.
Signed-off-by: NMasahiro Yamada <yamada.masahiro@socionext.com>

Including <common.h> pulls in a lot of bloat.  What this driver needs
is BIT(), so replace it with <linux/bitops.h>
Signed-off-by: NMasahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: NMarek Vasut <marex@denx.de>

Replace printf() with pr_() to specify proper loglevel.
Signed-off-by: NMasahiro Yamada <yamada.masahiro@socionext.com>

The pin data are implemented for old SoCs to specify the bit shift of
the IECTRL register.  They are not wortwhile given the required memory
footprint.  Delete all the pin data and enable all bits of the IECTRL
register.
Signed-off-by: NMasahiro Yamada <yamada.masahiro@socionext.com>

Like other recenct UniPhier SoCs, the pupdctrl number of PXs3
matches to the pin number.
Signed-off-by: NMasahiro Yamada <yamada.masahiro@socionext.com>

Switch to the single node design.
Signed-off-by: NMasahiro Yamada <yamada.masahiro@socionext.com>

First, I implemented this driver as per-bank model, but it was
a design mistake.

  - There are 31 banks in the maximum case.  It is painful to add
    so many nodes to DT.

  - The IRQ control registers are shared between banks.  Per-bank
    design is a problem for Linux.  The counterpart for Linux turned
    around to the single node model.

Rework based on the driver for Linux.
Signed-off-by: NMasahiro Yamada <yamada.masahiro@socionext.com>

The non-volatile storage varies board by board.  The default should
be NOWHERE.  Please choose a proper device via Kconfig.
Signed-off-by: NMasahiro Yamada <yamada.masahiro@socionext.com>

Set Features (0xEF) command toggles the R/B# pin after 4 sub feature
parameters are written.

Currently, nand_command(_lp) calls chip->dev_ready immediately after
the address cycle because NAND_CMD_SET_FEATURES falls into default:
label.  No wait is needed at this point.

If you see nand_onfi_set_features(), R/B# is already cared by the
chip->waitfunc call.
Signed-off-by: NMasahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: NBoris Brezillon <boris.brezillon@free-electrons.com>

[ Linux commit: c5d664aa5a4c4b257a54eb35045031630d105f49 ]

Read ID (0x90) command does not toggle the R/B# pin.  Without this
patch, NAND_CMD_READID falls into the default: label, then R/B# is
checked by chip->dev_ready().
Signed-off-by: NMasahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: NBoris Brezillon <boris.brezillon@free-electrons.com>

[ Linux commit: 3158fa0e739615769cc047d2428f30f4c3b6640e ]

Move the % arch outside the double quote so that the missing toolchain
message is displayed correctly.
Signed-off-by: NChris Packham <judge.packham@gmail.com>
Reviewed-by: NSimon Glass <sjg@chromium.org>
Signed-off-by: NMasahiro Yamada <yamada.masahiro@socionext.com>

Patch queue for efi - 2017-10-13

This is the second batch of amazing improvements for efi_loader in 2017.11:

  - New self tests to verify our own code
  - A few bug fixes
  - colored text support
  - event and SNP improvements, should get us close to iPXE working

When cancelling the timer we should check the return
value provided by the set_timer service.
Signed-off-by: NHeinrich Schuchardt <xypron.glpk@gmx.de>
Signed-off-by: NAlexander Graf <agraf@suse.de>