1. 15 6月, 2016 2 次提交
    • A
      6a4ea002
    • D
      Make x86_64-xlate.pl 'use strict' clean. · c25278db
      David Benjamin 提交于
      use strict would have caught a number of historical bugs in the perlasm
      code, some in the repository and some found during review. It even found
      a fresh masm-only bug (see below).
      
      This required some tweaks. The "single instance is enough" globals got
      switched to proper blessed objects rather than relying on symbolic refs.
      A few types need $opcode passed in as a result.
      
      The $$line thing is a little bit of a nuisance. There may be a clearer
      pattern to use instead.
      
      This even a bug in the masm code.
      9b634c9b added logic to make labels
      global or function-global based on whether something starts with a $,
      seemingly intended to capture the $decor setting of '$L$'. However, it
      references $ret which is not defined in label::out. label::out is always
      called after label::re, so $ret was always the label itself, so the line
      always ran.
      
      I've removed the regular expression so as not to change the behavior of
      the script. A number of the assembly files now routinely jump across
      functions, so this seems to be the desired behavior now.
      
      GH#1165
      Signed-off-by: NAndy Polyakov <appro@openssl.org>
      Reviewed-by: NRich Salz <rsalz@openssl.org>
      c25278db
  2. 20 4月, 2016 2 次提交
  3. 07 3月, 2016 1 次提交
  4. 13 2月, 2016 1 次提交
  5. 12 2月, 2016 2 次提交
    • R
      Perl's chop / chomp considered bad, use a regexp instead · 9ba96fbb
      Richard Levitte 提交于
      Once upon a time, there was chop, which somply chopped off the last
      character of $_ or a given variable, and it was used to take off the
      EOL character (\n) of strings.
      
      ... but then, you had to check for the presence of such character.
      
      So came chomp, the better chop which checks for \n before chopping it
      off.  And this worked well, as long as Perl made internally sure that
      all EOLs were converted to \n.
      
      These days, though, there seems to be a mixture of perls, so lines
      from files in the "wrong" environment might have \r\n as EOL, or just
      \r (Mac OS, unless I'm misinformed).
      
      So it's time we went for the more generic variant and use s|\R$||, the
      better chomp which recognises all kinds of known EOLs and chops them
      off.
      
      A few chops were left alone, as they are use as surgical tools to
      remove one last slash or one last comma.
      
      NOTE: \R came with perl 5.10.0.  It means that from now on, our
      scripts will fail with any older version.
      Reviewed-by: NRich Salz <rsalz@openssl.org>
      9ba96fbb
    • A
      perlasm/x86_64-xlate.pl: pass pure constants verbatim. · fd7dc201
      Andy Polyakov 提交于
      RT#3885
      Reviewed-by: NRich Salz <rsalz@openssl.org>
      fd7dc201
  6. 06 2月, 2016 1 次提交
  7. 12 9月, 2014 1 次提交
  8. 10 7月, 2014 1 次提交
  9. 15 2月, 2014 1 次提交
  10. 10 12月, 2013 1 次提交
  11. 03 10月, 2013 1 次提交
  12. 06 9月, 2013 1 次提交
  13. 01 7月, 2013 1 次提交
  14. 13 5月, 2013 1 次提交
  15. 13 8月, 2012 1 次提交
  16. 14 3月, 2012 1 次提交
  17. 21 1月, 2012 1 次提交
  18. 12 11月, 2011 1 次提交
  19. 18 10月, 2011 1 次提交
  20. 12 9月, 2011 1 次提交
  21. 13 8月, 2011 1 次提交
  22. 04 7月, 2011 1 次提交
  23. 02 7月, 2011 1 次提交
  24. 27 6月, 2011 1 次提交
  25. 04 6月, 2011 1 次提交
  26. 19 5月, 2011 2 次提交
  27. 17 5月, 2011 1 次提交
  28. 11 10月, 2010 1 次提交
  29. 27 7月, 2010 1 次提交
  30. 01 6月, 2010 1 次提交
  31. 13 5月, 2010 1 次提交
  32. 10 4月, 2010 1 次提交
  33. 04 2月, 2010 1 次提交
  34. 20 1月, 2010 1 次提交
  35. 16 11月, 2009 1 次提交
  36. 13 5月, 2009 1 次提交