1. 09 3月, 2014 2 次提交
    • R
      fix incorrect rounding in printf floating point corner cases · 9743a399
      Rich Felker 提交于
      the printf floating point formatting code contains an optimization to
      avoid computing digits that will be thrown away by rounding at the
      specified (or default) precision. while it was correctly retaining all
      places up to the last decimal place to be printed, it was not
      retaining enough precision to see the next nonzero decimal place in
      all cases. this could cause incorrect rounding down in round-to-even
      (default) rounding mode, for example, when printing 0.5+DBL_EPSILON
      with "%.0f".
      
      in the fix, LDBL_MANT_DIG/3 is a lazy (non-sharp) upper bound on the
      number of zeros between any two nonzero decimal digits.
      9743a399
    • R
      fix buffer overflow in printf formatting of denormals with low bit set · ba231cf9
      Rich Felker 提交于
      empirically the overflow was an off-by-one, and it did not seem to be
      overwriting meaningful data. rather than simply increasing the buffer
      size by one, however, I have attempted to make the size obviously
      correct in terms of bounds on the number of iterations for the loops
      that fill the buffer. this still results in no more than a negligible
      size increase of the buffer on the stack (6-7 32-bit slots) and is a
      "safer" fix unless/until somebody wants to do the proof that a smaller
      buffer would suffice.
      ba231cf9
  2. 08 3月, 2014 3 次提交
    • R
      in sys/procfs.h, avoid using __WORDSIZE macro · 73f5b096
      Rich Felker 提交于
      this was problematic because several archs don't define __WORDSIZE. we
      could add it, but I would rather phase this macro out in the long
      term. in our version of the headers, UINTPTR_MAX is available here, so
      just use it instead.
      73f5b096
    • R
      add bits/user.h for sh port · e12fda3b
      Rich Felker 提交于
      this seems to have been overlooked, and resulted in breakage in
      anything including sys/user.h.
      e12fda3b
    • R
      in fcntl, use unsigned long instead of long for variadic argument type · b576766d
      Rich Felker 提交于
      neither is correct; different commands take different argument types,
      and some take no arguments at all. I have a much larger overhaul of
      fcntl prepared to address this, but it's not appropriate to commit
      during freeze.
      
      the immediate problem being addressed affects forward-compatibility on
      x32: if new commands are added and they take pointers, but the
      libc-level fcntl function is not aware of them, using long would
      sign-extend the pointer to 64 bits and give the kernel an invalid
      pointer. on the kernel side, the argument to fcntl is always treated
      as unsigned long, so no harm is done by treating possibly-signed
      integer arguments as unsigned. for every command that takes an integer
      argument except for F_SETOWN, large integer arguments and negative
      arguments are handled identically anyway. in the case of F_SETOWN, the
      kernel is responsible for converting the argument which it received as
      unsigned long to int, so the sign of negative arguments is recovered.
      
      the other problem that will be addressed later is that the type passed
      to va_arg does not match the type in the caller of fcntl. an advanced
      compiler doing cross-translation-unit analysis could potentially see
      this mismatch and issue warnings or otherwise make trouble.
      
      on i386, this patch was confirmed not to alter the code generated by
      gcc 4.7.3. in principle the generated code should not be affected on
      any arch except x32.
      b576766d
  3. 07 3月, 2014 1 次提交
  4. 06 3月, 2014 2 次提交
    • R
      x32: fix sysinfo() · dae8ca73
      rofl0r 提交于
      the kernel uses long longs in the struct, but the documentation
      says they're long. so we need to fixup the mismatch between the
      userspace and kernelspace structs.
      since the struct offers a mem_unit member, we can avoid truncation
      by adjusting that value.
      dae8ca73
    • R
      fix strerror on mips: one error code is out of the 8-bit table range · abdd2e48
      Rich Felker 提交于
      if we ever encounter other targets where error codes don't fit in the
      8-bit range, the table should probably just be bumped to 16-bit, but
      for now I don't want to increase the table size on all archs just
      because of a bug in the mips abi.
      abdd2e48
  5. 01 3月, 2014 1 次提交
    • R
      improve configure's target arch matching · 0b8f0c57
      Rich Felker 提交于
      most notably, it was failing to match sh4-*, etc., but in general the
      explicit matching of hyphens for some archs was problematic because it
      failed to accept simply the musl-style arch name (without a gcc-style
      tuple) as an input. the original motivation of matching hyphens was to
      prevent incorrectly identifying a 64-bit arch as the corresponding
      32-bit arch (e.g. mips* matching mips64) but this is easily fixed by
      simply checking (and for now, rejecting as unsupported) the relevant
      64-bit archs.
      0b8f0c57
  6. 28 2月, 2014 5 次提交
  7. 26 2月, 2014 1 次提交
    • R
      fix readdir not to set ENOENT when directory is removed while reading · b9f7f2e8
      Rich Felker 提交于
      per POSIX, ENOENT is reserved for invalid stream position; it is an
      optional error and would only happen if the application performs
      invalid seeks on the underlying file descriptor. however, linux's
      getdents syscall also returns ENOENT if the directory was removed
      between the time it was opened and the time of the read. we need to
      catch this case and remap it to simple end-of-file condition (null
      pointer return value like an error, but no change to errno). this
      issue reportedly affects GNU make in certain corner cases.
      
      rather than backing up and restoring errno, I've just changed the
      syscall to be made in a way that doesn't affect errno (via an inline
      syscall rather than a call to the __getdents function). the latter
      still exists for the purpose of providing the public getdents alias
      which sets errno.
      b9f7f2e8
  8. 25 2月, 2014 8 次提交
  9. 24 2月, 2014 3 次提交
  10. 23 2月, 2014 7 次提交
  11. 22 2月, 2014 5 次提交
    • R
      sys/sem.h: cheat and make all longs use time_t instead · 1a2e55b9
      rofl0r 提交于
      most of the members should be time_t anyway, and time_t has the
      correct semantics for "syscall_long", so it works on all archs, even x32.
      1a2e55b9
    • R
      3b168ce1
    • R
      internal/syscall.h: add syscall_arg_t macro · 5cc1d920
      rofl0r 提交于
      some 32-on-64 archs require that the actual syscall args be long long.
      in that case syscall_arch.h can define syscall_arg_t to whatever it needs
      and syscall.h picks it up.
      all other archs just use long as usual.
      5cc1d920
    • R
      internal/syscall.h: use a macro for the syscall args casts · bf84967c
      rofl0r 提交于
      this allows syscall_arch.h to define the macro __scc if special
      casting is needed, as is the case for x32, where the actual syscall
      arguments are 64bit, but, in case of pointers, would get sign-extended
      and thus become invalid.
      bf84967c
    • R
      add fallback emulation for accept4 on old kernels · dc01e2cb
      Rich Felker 提交于
      the other atomic FD_CLOEXEC interfaces (dup3, pipe2, socket) already
      had such emulation in place. the justification for doing the emulation
      here is the same as for the other functions: it allows applications to
      simply use accept4 rather than having to have their own fallback code
      for ENOSYS/EINVAL (which one you get is arch-specific!) and there is
      no reasonable way an application could benefit from knowing the
      operation is emulated/non-atomic since there is no workaround at the
      application level for non-atomicity (that is the whole reason these
      interfaces were added).
      dc01e2cb
  12. 19 2月, 2014 1 次提交
  13. 14 2月, 2014 1 次提交