1. 14 4月, 2013 1 次提交
  2. 11 4月, 2013 1 次提交
    • R
      make ifaddrs.h expose sys/socket.h · 4ba3ebdc
      Rich Felker 提交于
      the getifaddrs interface seems to have been invented by glibc, and
      they expose socket.h, so for us not to do so is just gratuitous
      incompatibility with the interface we're mimicing.
      4ba3ebdc
  3. 09 4月, 2013 5 次提交
    • R
      getifaddrs: implement proper ipv6 netmasks · 9947ed5c
      rofl0r 提交于
      9947ed5c
    • R
      mbrtowc: do not leave mbstate_t in permanent-fail state after EILSEQ · 23ab8c25
      Rich Felker 提交于
      the standard is clear that the old behavior is conforming: "In this
      case, [EILSEQ] shall be stored in errno and the conversion state is
      undefined."
      
      however, the specification of mbrtowc has one peculiarity when the
      source argument is a null pointer: in this case, it's required to
      behave as mbrtowc(NULL, "", 1, ps). no motivation is provided for this
      requirement, but the natural one that comes to mind is that the intent
      is to reset the mbstate_t object. for stateful encodings, such
      behavior is actually specified: "If the corresponding wide character
      is the null wide character, the resulting state described shall be the
      initial conversion state." but in the case of UTF-8 where the
      mbstate_t object contains a partially-decoded character rather than a
      shift state, a subsequent '\0' byte indicates that the previous
      partial character is incomplete and thus an illegal sequence.
      
      naturally, applications using their own mbstate_t object should clear
      it themselves after an error, but the standard presently provides no
      way to clear the builtin mbstate_t object used when the ps argument is
      a null pointer. I suspect this issue may be addressed in the future by
      specifying that a null source argument resets the state, as this seems
      to have been the intent all along.
      
      for what it's worth, this change also slightly reduces code size.
      23ab8c25
    • R
      implement mbtowc directly, not as a wrapper for mbrtowc · ea34b1b9
      Rich Felker 提交于
      the interface contract for mbtowc admits a much faster implementation
      than mbrtowc can achieve; wrapping mbrtowc with an extra call frame
      only made the situation worse.
      
      since the regex implementation uses mbtowc already, this change should
      improve regex performance too. it may be possible to improve
      performance in other places internally by switching from mbrtowc to
      mbtowc.
      ea34b1b9
    • R
      optimize mbrtowc · a49e038b
      Rich Felker 提交于
      this simple change, in my measurements, makes about a 7% performance
      improvement. at first glance this change would seem like a
      compiler-specific hack, since the modified code is not even used.
      however, I suspect the reason is that I'm eliminating a second path
      into the main body of the code, allowing the compiler more flexibility
      to optimize the normal (hot) path into the main body. so even if it
      weren't for the measurable (and quite notable) difference in
      performance, I think the change makes sense.
      a49e038b
    • R
      fix out-of-bounds access in UTF-8 decoding · 8f06ab0e
      Rich Felker 提交于
      SA and SB are used as the lowest and highest valid starter bytes, but
      the value of SB was one-past the last valid starter. this caused
      access past the end of the state table when the illegal byte '\xf5'
      was encountered in a starter position. the error did not show up in
      full-character decoding tests, since the bogus state read from just
      past the table was unlikely to admit any continuation bytes as valid,
      but would have shown up had we tested feeding '\xf5' to the
      byte-at-a-time decoding in mbrtowc: it would cause the funtion to
      wrongly return -2 rather than -1.
      
      I may eventually go back and remove all references to SA and SB,
      replacing them with the values; this would make the code more
      transparent, I think. the original motivation for using macros was to
      allow misguided users of the code to redefine them for the purpose of
      enlarging the set of accepted sequences past the end of Unicode...
      8f06ab0e
  4. 08 4月, 2013 1 次提交
    • R
      fix signalfd not to ignore flags · bcd93025
      Rich Felker 提交于
      also include fallback code for broken kernels that don't support the
      flags. as usual, the fallback has a race condition that can leak file
      descriptors.
      bcd93025
  5. 07 4月, 2013 3 次提交
  6. 06 4月, 2013 9 次提交
  7. 05 4月, 2013 12 次提交
    • R
      add prototype for dn_skipname · f4ded939
      Rich Felker 提交于
      f4ded939
    • R
      implement dn_skipname (legacy resolver function) · b6f99412
      Rich Felker 提交于
      b6f99412
    • R
      add arpa/tftp.h · baec93cb
      rofl0r 提交于
      baec93cb
    • R
    • R
      eliminate bits/wchar.h · c7af2710
      Rich Felker 提交于
      the preprocessor can reliably determine the signedness of wchar_t.
      L'\0' is used for 0 in the expressions so that, if the underlying type
      of wchar_t is long rather than int, the promoted type of the
      expression will match the type of wchar_t.
      c7af2710
    • R
      201995f3
    • R
      add put*ent functions for passwd/group files and similar for shadow · ddfb267b
      Rich Felker 提交于
      since shadow does not yet support enumeration (getspent), the
      corresponding FILE-based get and put versions are also subbed out for
      now. this is partly out of laziness and partly because it's not clear
      how they should work in the presence of TCB shadow files. the stubs
      should make it possible to compile some software that expects them to
      exist, but such software still may not work properly.
      ddfb267b
    • R
      cleanup wcstombs · 771c6cea
      Rich Felker 提交于
      remove redundant headers and comments; this file is completely trivial
      now. also, avoid temp var.
      771c6cea
    • R
      cleanup mbstowcs wrapper · b5a527f9
      Rich Felker 提交于
      remove unneeded headers. this file is utterly trivial now and there's
      no sense in having a comment to state that it's in the public domain.
      b5a527f9
    • R
      minor optimization to mbstowcs · f62b12d0
      Rich Felker 提交于
      there is no need to zero-fill an mbstate_t object in the caller;
      mbsrtowcs will automatically treat a null pointer as the initial
      state.
      f62b12d0
    • R
      fix incorrect range checks in wcsrtombs · 40b2b5fa
      Rich Felker 提交于
      negative values of wchar_t need to be treated in the non-ASCII case so
      that they can properly generate EILSEQ rather than getting truncated
      to 8bit values and stored in the output.
      40b2b5fa
    • R
      overhaul mbsrtowcs · 50d9661d
      Rich Felker 提交于
      these changes fix at least two bugs:
      - misaligned access to the input as uint32_t for vectorized ASCII test
      - incorrect src pointer after stopping on EILSEQ
      
      in addition, the text of the standard makes it unclear whether the
      mbstate_t object is to be modified when the destination pointer is
      null; previously it was cleared either way; now, it's only cleared
      when the destination is non-null. this change may need revisiting, but
      it should not affect most applications, since calling mbsrtowcs with
      non-zero state can only happen when the head of the string was already
      processed with mbrtowc.
      
      finally, these changes shave about 20% size off the function and seem
      to improve performance by 1-5%.
      50d9661d
  8. 02 4月, 2013 8 次提交