1. 19 12月, 2014 1 次提交
  2. 18 12月, 2014 7 次提交
    • R
      fix signedness of WINT_MIN expression · aee9b152
      Rich Felker 提交于
      since wint_t is unsigned, WINT_MIN needs to expand to an unsigned zero.
      aee9b152
    • R
      make the definition of _Complex_I explicitly complex · a9c2294e
      Rich Felker 提交于
      it's unclear whether compilers which provide pure imaginary types
      might produce a pure imaginary expression for 1.0fi. using 0.0f+1.0fi
      ensures that the result is explicitly complex and makes this obvious
      to human readers too.
      a9c2294e
    • R
      make the result of the cimag macro a non-lvalue · 4075af43
      Rich Felker 提交于
      this change is not necessary but helps diagnose invalid code. based on
      patch by Jens Gustedt.
      4075af43
    • R
      fix definition of CMPLX macros in complex.h to work in constant expressions · 5ff2a118
      Rich Felker 提交于
      based on patches by Jens Gustedt. these macros need to be usable in
      static initializers, and the old definitions were not.
      
      there is no portable way to provide correct definitions for these
      macros unless the compiler supports pure imaginary types. a portable
      definition is provided for this case even though there are presently
      no compilers that can use it. gcc and compatible compilers provide a
      builtin function that can be used, but clang fails to support this and
      instead requires a construct which is a constraint violation and which
      is only a constant expression as a clang-specific extension.
      
      since these macros are a namespace violation in pre-C11 profiles, and
      since no known pre-C11 compilers provide any way to define them
      correctly anyway, the definitions have been made conditional on C11.
      5ff2a118
    • R
      provide CMPLX macros in implementation-internal libm.h · a414e837
      Rich Felker 提交于
      this avoids assuming the presence of C11 macro definitions in the
      public complex.h, which need changes potentially incompatible with the
      way these macros are being used internally.
      a414e837
    • N
      implement FNM_CASEFOLD extension to fnmatch function · efa9d396
      Nagy Szabolcs 提交于
      efa9d396
    • R
      add basic dns record parsing functions · aac59c11
      Rich Felker 提交于
      based on patch by Timo Teräs, with some corrections to bounds checking
      code and other minor changes.
      
      while they are borderline scope creep, the functions added are fairly
      small and are roughly the minimum code needed to use the results of
      the res_query API without re-implementing error-prone DNS packet
      parsing, and they are used in practice by some kerberos related
      software and possibly other things. at this time there is no intent to
      implement further nameser.h API functions.
      aac59c11
  3. 17 12月, 2014 1 次提交
    • R
      correctly handle write errors encountered by printf-family functions · d42269d7
      Rich Felker 提交于
      previously, write errors neither stopped further output attempts nor
      caused the function to return an error to the caller. this could
      result in silent loss of output, possibly in the middle of output in
      the event of a non-permanent error.
      
      the simplest solution is temporarily clearing the error flag for the
      target stream, then suppressing further output when the error flag is
      set and checking/restoring it at the end of the operation to determine
      the correct return value.
      
      since the wide version of the code internally calls the narrow fprintf
      to perform some of its underlying operations, initial clearing of the
      error flag is suppressed when performing a narrow vfprintf on a
      wide-oriented stream. this is not a problem since the behavior of
      narrow operations on wide-oriented streams is undefined.
      d42269d7
  4. 14 12月, 2014 1 次提交
  5. 13 12月, 2014 1 次提交
  6. 11 12月, 2014 4 次提交
  7. 10 12月, 2014 1 次提交
    • B
      don't shadow functions with macros in C++ · f164875a
      Bobby Bingham 提交于
      C++ programmers typically expect something like "::function(x,y)" to work
      and may be surprised to find that "(::function)(x,y)" is actually required
      due to the headers declaring a macro version of some standard functions.
      
      We already omit function-like macros for C++ in most cases where there is
      a real function available. This commit extends this to the remaining
      function-like macros which have a real function version.
      f164875a
  8. 06 12月, 2014 2 次提交
    • R
      use direct syscall rather than write function in posix_spawn child · 8f7bc690
      Rich Felker 提交于
      the write function is a cancellation point and accesses thread-local
      state belonging to the calling thread in the parent process. since
      cancellation is blocked for the duration of posix_spawn, this is
      probably safe, but it's fragile and unnecessary. making the syscall
      directly is just as easy and clearly safe.
      8f7bc690
    • R
      don't fail posix_spawn on failed close · 1c12c243
      Rich Felker 提交于
      the resolution of austin group issue #370 removes the requirement that
      posix_spawn fail when the close file action is performed on an
      already-closed fd. since there are no other meaningful errors for
      close, just ignoring the return value completely is the simplest fix.
      1c12c243
  9. 04 12月, 2014 1 次提交
    • R
      fix getopt handling of ':' modifier for multibyte option characters · 014275b5
      Rich Felker 提交于
      the previous hard-coded offsets of +1 and +2 contained a hidden
      assumption that the option character matched was single-byte, despite
      this implementation of getopt attempting to support multibyte option
      characters. this patch reworks the matching logic to leave the final
      index pointing just past the matched character so that fixed offsets
      can be used to check for ':'.
      014275b5
  10. 03 12月, 2014 4 次提交
  11. 24 11月, 2014 5 次提交
    • R
      adapt dynamic linker for new binutils versions that omit DT_RPATH · d8dc2b7c
      Rich Felker 提交于
      the new DT_RUNPATH semantics for search order are always used, and
      since binutils had always set both DT_RPATH and DT_RUNPATH when the
      latter was used, processing only DT_RPATH worked fine. however, recent
      binutils has stopped generating DT_RPATH when DT_RUNPATH is used,
      which broke support for this feature completely.
      d8dc2b7c
    • R
      fix tabs/spaces in memcpy.s · 9911754b
      Rich Felker 提交于
      this file had been a mess that went unnoticed ever since it was
      imported. some lines used spaces for indention while others used tabs,
      and tabs were used for alignment.
      9911754b
    • R
    • R
      fix build regression in arm asm for memcpy · 9367fe92
      Rich Felker 提交于
      commit 27828f7e fixed compatibility
      with clang's internal assembler, but broke compatibility with gas and
      the traditional arm asm syntax by switching to the arm "unified
      assembler language" (UAL). recent versions of gas also support UAL,
      but require the .syntax directive to be used to switch to it. clang on
      the other hand defaults to UAL. and old versions of gas (still
      relevant) don't support UAL at all.
      
      for the conditional ldm/stm instructions, "ia" is default and can just
      be omitted, resulting in a mnemonic that's compatible with both
      traditional and UAL syntax. but for byte/halfword loads and stores,
      there seems to be no mnemonic compatible with both, and thus .word is
      used to produce the desired opcode explicitly. the .inst directive is
      not used because it is not compatible with older assemblers.
      9367fe92
    • J
      arm assembly changes for clang compatibility · 27828f7e
      Joakim Sindholt 提交于
      27828f7e
  12. 23 11月, 2014 4 次提交
    • R
      unify non-inline version of syscall code across archs · 4134c68d
      Rich Felker 提交于
      except powerpc, which still lacks inline syscalls simply because
      nobody has written the code, these are all fallbacks used to work
      around a clang bug that probably does not exist in versions of clang
      that can compile musl. however, it's useful to have the generic
      non-inline code anyway, as it eases the task of porting to new archs:
      writing inline syscall code is now optional. this approach could also
      help support compilers which don't understand inline asm or lack
      support for the needed register constraints.
      
      mips could not be unified because it has special fixup code for broken
      layout of the kernel's struct stat.
      4134c68d
    • R
      inline 5- and 6-argument syscalls on arm · 0e971b0e
      Rich Felker 提交于
      0e971b0e
    • R
      remove old clang workarounds from arm syscall implementation · 7d310ed1
      Rich Felker 提交于
      the register constraints in the non-clang case were tested to work on
      clang back to 3.2, and earlier versions of clang have known bugs that
      preclude building musl.
      
      there may be other reasons to prefer not to use inline syscalls, but
      if so the function-call-based implementations should be added back in
      a unified way for all archs.
      7d310ed1
    • R
      fix __aeabi_read_tp oversight in arm atomics/tls overhaul · 8cd0b11e
      Rich Felker 提交于
      calls to __aeabi_read_tp may be generated by the compiler to access
      TLS on pre-v6 targets. previously, this function was hard-coded to
      call the kuser helper, which would crash on kernels with kuser helper
      removed.
      
      to fix the problem most efficiently, the definition of __aeabi_read_tp
      is moved so that it's an alias for the new __a_gettp. however, on v7+
      targets, code to initialize the runtime choice of thread-pointer
      loading code is not even compiled, meaning that defining
      __aeabi_read_tp would have caused an immediate crash due to using the
      default implementation of __a_gettp with a HCF instruction.
      
      fortunately there is an elegant solution which reduces overall code
      size: putting the native thread-pointer loading instruction in the
      default code path for __a_gettp, so that separate default/native code
      paths are not needed. this function should never be called before
      __set_thread_area anyway, and if it is called early on pre-v6
      hardware, the old behavior (crashing) is maintained.
      
      ideally __aeabi_read_tp would not be called at all on v7+ targets
      anyway -- in fact, prior to the overhaul, the same problem existed,
      but it was never caught by users building for v7+ with kuser disabled.
      however, it's possible for calls to __aeabi_read_tp to end up in a v7+
      binary if some of the object files were built for pre-v7 targets, e.g.
      in the case of static libraries that were built separately, so this
      case needs to be handled.
      8cd0b11e
  13. 19 11月, 2014 2 次提交
    • R
      overhaul ARM atomics/tls for performance and compatibility · 4a241f14
      Rich Felker 提交于
      previously, builds for pre-armv6 targets hard-coded use of the "kuser
      helper" system for atomics and thread-pointer access, resulting in
      binaries that fail to run (crash) on systems where this functionality
      has been disabled (as a security/hardening measure) in the kernel.
      additionally, builds for armv6 hard-coded an outdated/deprecated
      memory barrier instruction which may require emulation (extremely
      slow) on future models.
      
      this overhaul replaces the behavior for all pre-armv7 builds (both of
      the above cases) to perform runtime detection of the appropriate
      mechanisms for barrier, atomic compare-and-swap, and thread pointer
      access. detection is based on information provided by the kernel in
      auxv: presence of the HWCAP_TLS bit for AT_HWCAP and the architecture
      version encoded in AT_PLATFORM. direct use of the instructions is
      preferred when possible, since probing for the existence of the kuser
      helper page would be difficult and would incur runtime cost.
      
      for builds targeting armv7 or later, the runtime detection code is not
      compiled at all, and much more efficient versions of the non-cas
      atomic operations are provided by using ldrex/strex directly rather
      than wrapping cas.
      4a241f14
    • R
      save auxv pointer into libc struct early in dynamic linker startup · d8bdc97d
      Rich Felker 提交于
      this allows most code to assume it has already been saved, and is a
      prerequisite for upcoming changes for arm atomic/tls operations.
      d8bdc97d
  14. 16 11月, 2014 3 次提交
    • F
      getopt: fix optional argument processing · acccc93e
      Felix Fietkau 提交于
      Processing an option character with optional argument fails if the
      option is last on the command line. This happens because the
      if (optind >= argc) check runs first before testing for optional
      argument.
      acccc93e
    • J
      implement a private state for the uchar.h functions · 941644e9
      Jens Gustedt 提交于
      The C standard is imperative on that:
      
        7.28.1 ... If ps is a null pointer, each function uses its own internal
        mbstate_t object instead, which is initialized at program startup to
        the initial conversion state;
      
      and these functions are also not supposed to implicitly use the state of
      the wchar.h functions:
      
        7.29.6.3 ... The implementation behaves as if no library function calls
        these functions with a null pointer for ps.
      
      Previously this resulted in two bugs.
      
       - The functions c16rtomb and mbrtoc16 would crash when called with ps
         set to null.
      
       - The function mbrtoc32 used the private state of mbrtowc, which it
         is not allowed to do.
      941644e9
    • R
      fix behavior of printf with alt-form octal, zero precision, zero value · b91cdbe2
      Rich Felker 提交于
      in this case there are two conflicting rules in play: that an explicit
      precision of zero with the value zero produces no output, and that the
      '#' modifier for octal increases the precision sufficiently to yield a
      leading zero. ISO C (7.19.6.1 paragraph 6 in C99+TC3) includes a
      parenthetical remark to clarify that the precision-increasing behavior
      takes precedence, but the corresponding text in POSIX off of which I
      based the implementation is missing this remark.
      
      this issue was covered in WG14 DR#151.
      b91cdbe2
  15. 06 11月, 2014 2 次提交
    • S
      math: use fnstsw consistently instead of fstsw in x87 asm · ec431894
      Szabolcs Nagy 提交于
      fnstsw does not wait for pending unmasked x87 floating-point exceptions
      and it is the same as fstsw when all exceptions are masked which is the
      only environment libc supports.
      ec431894
    • S
      math: fix x86_64 and x32 asm not to use sahf instruction · a732e80d
      Szabolcs Nagy 提交于
      Some early x86_64 cpus (released before 2006) did not support sahf/lahf
      instructions so they should be avoided (intel manual says they are only
      supported if CPUID.80000001H:ECX.LAHF-SAHF[bit 0] = 1).
      
      The workaround simplifies exp2l and expm1l because fucomip can be
      used instead of the fucomp;fnstsw;sahf sequence copied from i386.
      
      In fmodl and remainderl sahf is replaced by a simple bit test.
      a732e80d
  16. 05 11月, 2014 1 次提交
    • R
      fix 64-bit syscall argument passing on or1k · de2b9c21
      Rich Felker 提交于
      the kernel syscall interface for or1k does not expect 64-bit arguments
      to be aligned to "even" register boundaries. this incorrect alignment
      broke truncate/ftruncate and as well as a few less-common syscalls.
      de2b9c21