1. 06 12月, 2014 1 次提交
    • R
      don't fail posix_spawn on failed close · 1c12c243
      Rich Felker 提交于
      the resolution of austin group issue #370 removes the requirement that
      posix_spawn fail when the close file action is performed on an
      already-closed fd. since there are no other meaningful errors for
      close, just ignoring the return value completely is the simplest fix.
      1c12c243
  2. 04 12月, 2014 1 次提交
    • R
      fix getopt handling of ':' modifier for multibyte option characters · 014275b5
      Rich Felker 提交于
      the previous hard-coded offsets of +1 and +2 contained a hidden
      assumption that the option character matched was single-byte, despite
      this implementation of getopt attempting to support multibyte option
      characters. this patch reworks the matching logic to leave the final
      index pointing just past the matched character so that fixed offsets
      can be used to check for ':'.
      014275b5
  3. 03 12月, 2014 4 次提交
  4. 24 11月, 2014 5 次提交
    • R
      adapt dynamic linker for new binutils versions that omit DT_RPATH · d8dc2b7c
      Rich Felker 提交于
      the new DT_RUNPATH semantics for search order are always used, and
      since binutils had always set both DT_RPATH and DT_RUNPATH when the
      latter was used, processing only DT_RPATH worked fine. however, recent
      binutils has stopped generating DT_RPATH when DT_RUNPATH is used,
      which broke support for this feature completely.
      d8dc2b7c
    • R
      fix tabs/spaces in memcpy.s · 9911754b
      Rich Felker 提交于
      this file had been a mess that went unnoticed ever since it was
      imported. some lines used spaces for indention while others used tabs,
      and tabs were used for alignment.
      9911754b
    • R
    • R
      fix build regression in arm asm for memcpy · 9367fe92
      Rich Felker 提交于
      commit 27828f7e fixed compatibility
      with clang's internal assembler, but broke compatibility with gas and
      the traditional arm asm syntax by switching to the arm "unified
      assembler language" (UAL). recent versions of gas also support UAL,
      but require the .syntax directive to be used to switch to it. clang on
      the other hand defaults to UAL. and old versions of gas (still
      relevant) don't support UAL at all.
      
      for the conditional ldm/stm instructions, "ia" is default and can just
      be omitted, resulting in a mnemonic that's compatible with both
      traditional and UAL syntax. but for byte/halfword loads and stores,
      there seems to be no mnemonic compatible with both, and thus .word is
      used to produce the desired opcode explicitly. the .inst directive is
      not used because it is not compatible with older assemblers.
      9367fe92
    • J
      arm assembly changes for clang compatibility · 27828f7e
      Joakim Sindholt 提交于
      27828f7e
  5. 23 11月, 2014 4 次提交
    • R
      unify non-inline version of syscall code across archs · 4134c68d
      Rich Felker 提交于
      except powerpc, which still lacks inline syscalls simply because
      nobody has written the code, these are all fallbacks used to work
      around a clang bug that probably does not exist in versions of clang
      that can compile musl. however, it's useful to have the generic
      non-inline code anyway, as it eases the task of porting to new archs:
      writing inline syscall code is now optional. this approach could also
      help support compilers which don't understand inline asm or lack
      support for the needed register constraints.
      
      mips could not be unified because it has special fixup code for broken
      layout of the kernel's struct stat.
      4134c68d
    • R
      inline 5- and 6-argument syscalls on arm · 0e971b0e
      Rich Felker 提交于
      0e971b0e
    • R
      remove old clang workarounds from arm syscall implementation · 7d310ed1
      Rich Felker 提交于
      the register constraints in the non-clang case were tested to work on
      clang back to 3.2, and earlier versions of clang have known bugs that
      preclude building musl.
      
      there may be other reasons to prefer not to use inline syscalls, but
      if so the function-call-based implementations should be added back in
      a unified way for all archs.
      7d310ed1
    • R
      fix __aeabi_read_tp oversight in arm atomics/tls overhaul · 8cd0b11e
      Rich Felker 提交于
      calls to __aeabi_read_tp may be generated by the compiler to access
      TLS on pre-v6 targets. previously, this function was hard-coded to
      call the kuser helper, which would crash on kernels with kuser helper
      removed.
      
      to fix the problem most efficiently, the definition of __aeabi_read_tp
      is moved so that it's an alias for the new __a_gettp. however, on v7+
      targets, code to initialize the runtime choice of thread-pointer
      loading code is not even compiled, meaning that defining
      __aeabi_read_tp would have caused an immediate crash due to using the
      default implementation of __a_gettp with a HCF instruction.
      
      fortunately there is an elegant solution which reduces overall code
      size: putting the native thread-pointer loading instruction in the
      default code path for __a_gettp, so that separate default/native code
      paths are not needed. this function should never be called before
      __set_thread_area anyway, and if it is called early on pre-v6
      hardware, the old behavior (crashing) is maintained.
      
      ideally __aeabi_read_tp would not be called at all on v7+ targets
      anyway -- in fact, prior to the overhaul, the same problem existed,
      but it was never caught by users building for v7+ with kuser disabled.
      however, it's possible for calls to __aeabi_read_tp to end up in a v7+
      binary if some of the object files were built for pre-v7 targets, e.g.
      in the case of static libraries that were built separately, so this
      case needs to be handled.
      8cd0b11e
  6. 19 11月, 2014 2 次提交
    • R
      overhaul ARM atomics/tls for performance and compatibility · 4a241f14
      Rich Felker 提交于
      previously, builds for pre-armv6 targets hard-coded use of the "kuser
      helper" system for atomics and thread-pointer access, resulting in
      binaries that fail to run (crash) on systems where this functionality
      has been disabled (as a security/hardening measure) in the kernel.
      additionally, builds for armv6 hard-coded an outdated/deprecated
      memory barrier instruction which may require emulation (extremely
      slow) on future models.
      
      this overhaul replaces the behavior for all pre-armv7 builds (both of
      the above cases) to perform runtime detection of the appropriate
      mechanisms for barrier, atomic compare-and-swap, and thread pointer
      access. detection is based on information provided by the kernel in
      auxv: presence of the HWCAP_TLS bit for AT_HWCAP and the architecture
      version encoded in AT_PLATFORM. direct use of the instructions is
      preferred when possible, since probing for the existence of the kuser
      helper page would be difficult and would incur runtime cost.
      
      for builds targeting armv7 or later, the runtime detection code is not
      compiled at all, and much more efficient versions of the non-cas
      atomic operations are provided by using ldrex/strex directly rather
      than wrapping cas.
      4a241f14
    • R
      save auxv pointer into libc struct early in dynamic linker startup · d8bdc97d
      Rich Felker 提交于
      this allows most code to assume it has already been saved, and is a
      prerequisite for upcoming changes for arm atomic/tls operations.
      d8bdc97d
  7. 16 11月, 2014 3 次提交
    • F
      getopt: fix optional argument processing · acccc93e
      Felix Fietkau 提交于
      Processing an option character with optional argument fails if the
      option is last on the command line. This happens because the
      if (optind >= argc) check runs first before testing for optional
      argument.
      acccc93e
    • J
      implement a private state for the uchar.h functions · 941644e9
      Jens Gustedt 提交于
      The C standard is imperative on that:
      
        7.28.1 ... If ps is a null pointer, each function uses its own internal
        mbstate_t object instead, which is initialized at program startup to
        the initial conversion state;
      
      and these functions are also not supposed to implicitly use the state of
      the wchar.h functions:
      
        7.29.6.3 ... The implementation behaves as if no library function calls
        these functions with a null pointer for ps.
      
      Previously this resulted in two bugs.
      
       - The functions c16rtomb and mbrtoc16 would crash when called with ps
         set to null.
      
       - The function mbrtoc32 used the private state of mbrtowc, which it
         is not allowed to do.
      941644e9
    • R
      fix behavior of printf with alt-form octal, zero precision, zero value · b91cdbe2
      Rich Felker 提交于
      in this case there are two conflicting rules in play: that an explicit
      precision of zero with the value zero produces no output, and that the
      '#' modifier for octal increases the precision sufficiently to yield a
      leading zero. ISO C (7.19.6.1 paragraph 6 in C99+TC3) includes a
      parenthetical remark to clarify that the precision-increasing behavior
      takes precedence, but the corresponding text in POSIX off of which I
      based the implementation is missing this remark.
      
      this issue was covered in WG14 DR#151.
      b91cdbe2
  8. 06 11月, 2014 2 次提交
    • S
      math: use fnstsw consistently instead of fstsw in x87 asm · ec431894
      Szabolcs Nagy 提交于
      fnstsw does not wait for pending unmasked x87 floating-point exceptions
      and it is the same as fstsw when all exceptions are masked which is the
      only environment libc supports.
      ec431894
    • S
      math: fix x86_64 and x32 asm not to use sahf instruction · a732e80d
      Szabolcs Nagy 提交于
      Some early x86_64 cpus (released before 2006) did not support sahf/lahf
      instructions so they should be avoided (intel manual says they are only
      supported if CPUID.80000001H:ECX.LAHF-SAHF[bit 0] = 1).
      
      The workaround simplifies exp2l and expm1l because fucomip can be
      used instead of the fucomp;fnstsw;sahf sequence copied from i386.
      
      In fmodl and remainderl sahf is replaced by a simple bit test.
      a732e80d
  9. 05 11月, 2014 1 次提交
    • R
      fix 64-bit syscall argument passing on or1k · de2b9c21
      Rich Felker 提交于
      the kernel syscall interface for or1k does not expect 64-bit arguments
      to be aligned to "even" register boundaries. this incorrect alignment
      broke truncate/ftruncate and as well as a few less-common syscalls.
      de2b9c21
  10. 01 11月, 2014 1 次提交
  11. 31 10月, 2014 4 次提交
    • S
      math: use the rounding idiom consistently · 0ce946cf
      Szabolcs Nagy 提交于
      the idiomatic rounding of x is
      
        n = x + toint - toint;
      
      where toint is either 1/EPSILON (x is non-negative) or 1.5/EPSILON
      (x may be negative and nearest rounding mode is assumed) and EPSILON is
      according to the evaluation precision (the type of toint is not very
      important, because single precision float can represent the 1/EPSILON of
      ieee binary128).
      
      in case of FLT_EVAL_METHOD!=0 this avoids a useless store to double or
      float precision, and the long double code became cleaner with
      1/LDBL_EPSILON instead of ifdefs for toint.
      
      __rem_pio2f and __rem_pio2 functions slightly changed semantics:
      on i386 a double-rounding is avoided so close to half-way cases may
      get evaluated differently eg. as sin(pi/4-eps) instead of cos(pi/4+eps)
      0ce946cf
    • S
      fix rint.c and rintf.c when FLT_EVAL_METHOD!=0 · 79ca8609
      Szabolcs Nagy 提交于
      The old code used the rounding idiom incorrectly:
      
        y = (double)(x + 0x1p52) - 0x1p52;
      
      the cast is useless if FLT_EVAL_METHOD==0 and causes a second rounding
      if FLT_EVAL_METHOD==2 which can give incorrect result in nearest rounding
      mode, so the correct idiom is to add/sub a power-of-2 according to the
      characteristics of double_t.
      
      This did not cause actual bug because only i386 is affected where rint
      is implemented in asm.
      
      Other rounding functions use a similar idiom, but they give correct
      results because they only rely on getting a neighboring integer result
      and the rounding direction is fixed up separately independently of the
      current rounding mode. However they should be fixed to use the idiom
      correctly too.
      79ca8609
    • R
      fix invalid access by openat to possibly-missing variadic mode argument · 2da3ab13
      Rich Felker 提交于
      the mode argument is only required to be present when the O_CREAT or
      O_TMPFILE flag is used.
      2da3ab13
    • R
      9d836ea7
  12. 20 10月, 2014 1 次提交
    • R
      manually "shrink wrap" fast path in pthread_once · dc95322e
      Rich Felker 提交于
      this change is a workaround for the inability of current compilers to
      perform "shrink wrapping" optimizations. in casual testing, it roughly
      doubled the performance of pthread_once when called on an
      already-finished once control object.
      dc95322e
  13. 15 10月, 2014 2 次提交
  14. 14 10月, 2014 2 次提交
  15. 11 10月, 2014 2 次提交
    • R
      fix missing barrier in pthread_once/call_once shortcut path · df37d396
      Rich Felker 提交于
      these functions need to be fast when the init routine has already run,
      since they may be called very often from code which depends on global
      initialization having taken place. as such, a fast path bypassing
      atomic cas on the once control object was used to avoid heavy memory
      contention. however, on archs with weakly ordered memory, the fast
      path failed to ensure that the caller actually observes the side
      effects of the init routine.
      
      preliminary performance testing showed that simply removing the fast
      path was not practical; a performance drop of roughly 85x was observed
      with 20 threads hammering the same once control on a 24-core machine.
      so the new explicit barrier operation from atomic.h is used to retain
      the fast path while ensuring memory visibility.
      
      performance may be reduced on some archs where the barrier actually
      makes a difference, but the previous behavior was unsafe and incorrect
      on these archs. future improvements to the implementation of a_barrier
      should reduce the impact.
      df37d396
    • R
      add explicit barrier operation to internal atomic.h API · 867b1822
      Rich Felker 提交于
      867b1822
  16. 10 10月, 2014 1 次提交
    • R
      fix handling of negative offsets in timezone spec strings · 08b996d1
      Rich Felker 提交于
      previously, the hours were considered as a signed quantity while
      minutes and seconds were always treated as positive offsets. however,
      semantically the '-' sign should negate the whole hh:mm:ss offset.
      this bug only affected timezones east of GMT with non-whole-hours
      offsets, such as those used in India and Nepal.
      08b996d1
  17. 08 10月, 2014 4 次提交
    • S
      add new linux file sealing api to fcntl.h · a3763d64
      Szabolcs Nagy 提交于
      new in linux v3.17 commit 40e041a2c858b3caefc757e26cb85bfceae5062b
      sealing allows some operations to be blocked on a file which makes
      file access safer when fds are shared between processes (only
      supported for shared mem fds currently)
      
      flags:
      F_SEAL_SEAL prevents further sealing
      F_SEAL_SHRINK prevents file from shrinking
      F_SEAL_GROW prevents file from growing
      F_SEAL_WRITE prevents writes
      
      fcntl commands:
      F_GET_SEALS get the current seal flags
      F_ADD_SEALS add new seal flags
      a3763d64
    • S
      add new IPV6_AUTOFLOWLABEL socket option in netinet/in.h · a0c90b97
      Szabolcs Nagy 提交于
      added in linux v3.17 commit 753a2ad54ef45e3417a9d49537c2b42b04a2e1be
      enables automatic flow label generation on transmit
      a0c90b97
    • S
      add new syscall numbers for seccomp, getrandom, memfd_create · 4ffc39c6
      Szabolcs Nagy 提交于
      these syscalls are new in linux v3.17 and present on all supported
      archs except sh.
      
      seccomp was added in commit 48dc92b9fc3926844257316e75ba11eb5c742b2c
      it has operation, flags and pointer arguments (if flags==0 then it is
      the same as prctl(PR_SET_SECCOMP,...)), the uapi header for flag
      definitions is linux/seccomp.h
      
      getrandom was added in commit c6e9d6f38894798696f23c8084ca7edbf16ee895
      it provides an entropy source when open("/dev/urandom",..) would fail,
      the uapi header for flags is linux/random.h
      
      memfd_create was added in commit 9183df25fe7b194563db3fec6dc3202a5855839c
      it allows anon mmap to have an fd, that can be shared, sealed and needs no
      mount point, the uapi header for flags is linux/memfd.h
      4ffc39c6
    • R
      always provide __fpclassifyl and __signbitl definitions · 0539e6da
      Rich Felker 提交于
      previously the external definitions of these functions were omitted on
      archs where long double is the same as double, since the code paths in
      the math.h macros which would call them are unreachable. however, even
      if they are unreachable, the definitions are still mandatory. omitting
      them is invalid C, and in the case of a non-optimizing compiler, will
      result in a link error.
      0539e6da