1. 20 10月, 2016 3 次提交
    • N
      use dynamic buffer for getmntent · 05973dc3
      Natanael Copa 提交于
      overlayfs may have fairly long lines so we use getline to allocate a
      buffer dynamically. The buffer will be allocated on first use, expand as
      needed, but will never be free'ed.
      
      Downstream bug: http://bugs.alpinelinux.org/issues/5703Signed-off-by: NNatanael Copa <ncopa@alpinelinux.org>
      05973dc3
    • R
      fix integer overflows and uncaught EOVERFLOW in printf core · 167dfe96
      Rich Felker 提交于
      this patch fixes a large number of missed internal signed-overflow
      checks and errors in determining when the return value (output length)
      would exceed INT_MAX, which should result in EOVERFLOW. some of the
      issues fixed were reported by Alexander Cherepanov; others were found
      in subsequent review of the code.
      
      aside from the signed overflows being undefined behavior, the
      following specific bugs were found to exist in practice:
      
      - overflows computing length of floating point formats with huge
        explicit precisions, integer formats with prefix characters and huge
        explicit precisions, or string arguments or format strings longer
        than INT_MAX, resulted in wrong return value and wrong %n results.
      
      - literal width and precision values outside the range of int were
        misinterpreted, yielding wrong behavior in at least one well-defined
        case: string formats with precision greater than INT_MAX were
        sometimes truncated.
      
      - in cases where EOVERFLOW is produced, incorrect values could be
        written for %n specifiers past the point of exceeding INT_MAX.
      
      in addition to fixing these bugs, we now stop producing output
      immediately when output length would exceed INT_MAX, rather than
      continuing and returning an error only at the end.
      167dfe96
    • R
      fix integer overflow in float printf needed-precision computation · 70d2687d
      Rich Felker 提交于
      if the requested precision is close to INT_MAX, adding
      LDBL_MANT_DIG/3+8 overflows. in practice the resulting undefined
      behavior manifests as a large negative result, which is then used to
      compute the new end pointer (z) with a wildly out-of-bounds value
      (more overflow, more undefined behavior). the end result is at least
      incorrect output and character count (return value); worse things do
      not seem to happen, but detailed analysis has not been done.
      
      this patch fixes the overflow by performing the intermediate
      computation as unsigned; after division by 9, the final result
      necessarily fits in int.
      70d2687d
  2. 07 10月, 2016 3 次提交
    • R
      fix regexec with haystack strings longer than INT_MAX · aee6abb2
      Rich Felker 提交于
      we inherited from TRE regexec code that's utterly wrong with respect
      to the integer types it's using. while it doesn't appear that
      compilers are producing unsafe output, signed integer overflows seem
      to happen, and regexec fails to find matches past offset INT_MAX.
      
      this patch fixes the type of all variables/fields used to store
      offsets in the string from int to regoff_t. after the changes, basic
      testing showed that regexec can now find matches past 2GB (INT_MAX)
      and past 4GB on x86_64, and code generation is unchanged on i386.
      aee6abb2
    • R
      fix missing integer overflow checks in regexec buffer size computations · c3edc06d
      Rich Felker 提交于
      most of the possible overflows were already ruled out in practice by
      regcomp having already succeeded performing larger allocations.
      however at least the num_states*num_tags multiplication can clearly
      overflow in practice. for safety, check them all, and use the proper
      type, size_t, rather than int.
      
      also improve comments, use calloc in place of malloc+memset, and
      remove bogus casts.
      c3edc06d
    • S
      fix strftime %y for negative tm_year · 583ea835
      Szabolcs Nagy 提交于
      583ea835
  3. 24 9月, 2016 2 次提交
  4. 19 9月, 2016 2 次提交
    • R
      fix undefined behavior in sched.h cpu_set_t usage · 66570ec9
      Rich Felker 提交于
      since cpu sets can be dynamically allocated and have variable size,
      accessing their contents via ->__bits is not valid; performing pointer
      arithmetic outside the range of the size of the declared __bits array
      results in undefined beahavior. instead, only use cpu_set_t for
      fixed-size cpu set objects (instantiated by the caller) and as an
      abstract pointer type for dynamically allocated ones. perform all
      accesses simply by casting the abstract pointer type cpuset_t * back
      to unsigned long *.
      66570ec9
    • R
      simplify/refactor fflush and make fflush_unlocked an alias for fflush · c002668e
      Rich Felker 提交于
      previously, fflush_unlocked was an alias for an internal backend that
      was called by fflush, either for its argument or in a loop for each
      file if a null pointer was passed. since the logic for the latter was
      in the main fflush function, fflush_unlocked crashed when passed a
      null pointer, rather than flushing all open files. since
      fflush_unlocked is not a standard function and has no specification,
      it's not clear whether it should be expected to accept null pointers
      like fflush does, but a reasonable argument could be made that it
      should.
      
      this patch eliminates the helper function, simplifying fflush, and
      makes fflush_unlocked an alias for fflush, which is valid because the
      two functions agree in their behavior in all cases where their
      behavior is defined (the unlocked version has undefined behavior if
      another thread could hold locks).
      c002668e
  5. 17 9月, 2016 4 次提交
  6. 31 8月, 2016 10 次提交
  7. 12 8月, 2016 1 次提交
    • R
      fix pread/pwrite syscall calling convention on sh · 7cc3a28e
      Rich Felker 提交于
      despite sh not generally using register-pair alignment for 64-bit
      syscall arguments, there are arch-specific versions of the syscall
      entry points for pread and pwrite which include a dummy argument for
      alignment before the 64-bit offset argument.
      7cc3a28e
  8. 14 7月, 2016 2 次提交
  9. 08 7月, 2016 1 次提交
  10. 07 7月, 2016 1 次提交
  11. 06 7月, 2016 3 次提交
  12. 04 7月, 2016 8 次提交