1. 18 10月, 2013 6 次提交
  2. 16 10月, 2013 2 次提交
    • B
      [arabic] Make ZWJ prevent ligatures instead of facilitating it · c52ddab7
      Behdad Esfahbod 提交于
      Unicode 6.2.0 Section 16.2 / Figure 16.3 says:
      
      "For backward compatibility, between Arabic characters a ZWJ acts just
      like the sequence <ZWJ, ZWNJ, ZWJ>, preventing a ligature from forming
      instead of requesting the use of a ligature that would not normally be
      used. As a result, there is no plain text mechanism for requesting the
      use of a ligature in Arabic text."
      
      As such, we flip internal zwj to zwnj flags for GSUB matching, which
      means it will block ligation in all features, unless the font
      explicitly matches U+200D glyph.  This doesn't affect joining behavior.
      c52ddab7
    • B
      [otlayout] Minor · 1a31f9f8
      Behdad Esfahbod 提交于
      1a31f9f8
  3. 28 5月, 2013 1 次提交
    • B
      Don't zero advance of mark-non-mark ligatures · 7e08f125
      Behdad Esfahbod 提交于
      If there's a mark ligating forward with non-mark, they were
      inheriting the GC of the mark and later get advance-zeroed.
      Don't do that if there's any non-mark glyph in the ligature.
      
      Sample test: U+1780,U+17D2,U+179F with Kh-Metal-Chrieng.ttf
      
      Also:
      Bug 58922 - Issue with mark advance zeroing in generic shaper
      7e08f125
  4. 05 5月, 2013 2 次提交
  5. 19 3月, 2013 1 次提交
    • B
      [Indic] Futher adjust ZWJ handling in Indic-like shapers · a8cf7b43
      Behdad Esfahbod 提交于
      After the Ngapi hackfest work, we were assuming that fonts
      won't use presentation features to choose specific forms
      (eg. conjuncts).  As such, we were using auto-joiner behavior
      for such features.  It proved to be troublesome as many fonts
      used presentation forms ('pres') for example to form conjuncts,
      which need to be disabled when a ZWJ is inserted.
      
      Two examples:
      
      	U+0D2F,U+200D,U+0D4D,U+0D2F with kartika.ttf
      	U+0995,U+09CD,U+200D,U+09B7 with vrinda.ttf
      
      What we do now is to never do magic to ZWJ during GSUB's main input
      match for Indic-style shapers.  Note that backtrack/lookahead are still
      matched liberally, as is GPOS.  This seems to be an acceptable
      compromise.
      
      As to the bug that initially started this work, that one needs to
      be fixed differently:
      
        Bug 58714 - Kannada u+0cb0 u+200d u+0ccd u+0c95 u+0cbe does not
        provide same results as Windows8
        https://bugs.freedesktop.org/show_bug.cgi?id=58714
      
      New numbers:
      
      BENGALI: 353689 out of 354188 tests passed. 499 failed (0.140886%)
      DEVANAGARI: 707305 out of 707394 tests passed. 89 failed (0.0125814%)
      GUJARATI: 366349 out of 366457 tests passed. 108 failed (0.0294714%)
      GURMUKHI: 60706 out of 60747 tests passed. 41 failed (0.067493%)
      KANNADA: 951030 out of 951913 tests passed. 883 failed (0.0927606%)
      KHMER: 299070 out of 299124 tests passed. 54 failed (0.0180527%)
      LAO: 53611 out of 53644 tests passed. 33 failed (0.0615167%)
      MALAYALAM: 1048102 out of 1048334 tests passed. 232 failed (0.0221304%)
      ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%)
      SINHALA: 271666 out of 271847 tests passed. 181 failed (0.0665816%)
      TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%)
      TELUGU: 970555 out of 970573 tests passed. 18 failed (0.00185457%)
      TIBETAN: 208469 out of 208469 tests passed. 0 failed (0%)
      a8cf7b43
  6. 22 2月, 2013 1 次提交
  7. 15 2月, 2013 3 次提交
    • B
      [Indic-like] Disable automatic joiner handling for basic shaping features · cfc507c5
      Behdad Esfahbod 提交于
      Not for Arabic, but for Indic-like scripts.  ZWJ/ZWNJ have special
      meanings in those scripts, so let font lookups take full control.
      
      This undoes the regression caused by automatic-joiners handling
      introduced two commits ago.
      
      We only disable automatic joiner handling for the "basic shaping
      features" of Indic, Myanmar, and SEAsian shapers.  The "presentation
      forms" and other features are still applied with automatic-joiner
      handling.
      
      This change also changes the test suite failure statistics, such that
      a few scripts show more "failures".  The most affected is Kannada.
      However, upon inspection, we believe that in most, if not all, of the
      new failures, we are producing results superior to Uniscribe.  Hard to
      count those!
      
      Here's an example of what is fixed by the recent joiner-handling
      changes:
      
        https://bugs.freedesktop.org/show_bug.cgi?id=58714
      
      New numbers, for future reference:
      
      BENGALI: 353892 out of 354188 tests passed. 296 failed (0.0835714%)
      DEVANAGARI: 707336 out of 707394 tests passed. 58 failed (0.00819911%)
      GUJARATI: 366262 out of 366457 tests passed. 195 failed (0.0532122%)
      GURMUKHI: 60706 out of 60747 tests passed. 41 failed (0.067493%)
      KANNADA: 950680 out of 951913 tests passed. 1233 failed (0.129529%)
      KHMER: 299074 out of 299124 tests passed. 50 failed (0.0167155%)
      LAO: 53611 out of 53644 tests passed. 33 failed (0.0615167%)
      MALAYALAM: 1047983 out of 1048334 tests passed. 351 failed (0.0334817%)
      ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%)
      SINHALA: 271539 out of 271847 tests passed. 308 failed (0.113299%)
      TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%)
      TELUGU: 970555 out of 970573 tests passed. 18 failed (0.00185457%)
      TIBETAN: 208469 out of 208469 tests passed. 0 failed (0%)
      cfc507c5
    • B
      [OTLayout] Add fine-grained control over ZWJ matching · 0b454791
      Behdad Esfahbod 提交于
      Not used yet.  Next commit...
      0b454791
    • B
      [OTLayout] Ignore default-ignorables when matching GSUB/GPOS · 607feb7c
      Behdad Esfahbod 提交于
      When matching lookups, be smart about default-ignorable characters.
      In particular:
      
      Do nothing specific about ZWNJ, but for the other default-ignorables:
      
      If the lookup in question uses the ignorable character in a sequence,
      then match it as we used to do.  However, if the sequence match will
      fail because the default-ignorable blocked it, try skipping the
      ignorable character and continue.
      
      The most immediate thing it means is that if Lam-Alef forms a ligature,
      then Lam-ZWJ-Alef will do to.  Finally!
      
      One exception: when matching for GPOS, or for backtrack/lookahead of
      GSUB, we ignore ZWNJ too.  That's the right thing to do.
      
      It certainly is possible to build fonts that this feature will result
      in undesirable glyphs, but it's hard to think of a real-world case
      that that would happen.
      
      This *does* break Indic shaping right now, since Indic Unicode has
      specific rules for what ZWJ/ZWNJ mean, and skipping ZWJ is breaking
      those rules.  That will be fixed in upcoming commits.
      607feb7c
  8. 12 2月, 2013 1 次提交
    • B
      Adjust mark advance-width zeroing logic for Myanmar · 56800027
      Behdad Esfahbod 提交于
      Before, we were zeroing advance width of attached marks for
      non-Indic scripts, and not doing it for Indic.
      
      We have now three different behaviors, which seem to better
      reflect what Uniscribe is doing:
      
        - For Indic, no explicit zeroing happens whatsoever, which
          is the same as before,
      
        - For Myanmar, zero advance width of glyphs marked as marks
          *in GDEF*, and do that *before* applying GPOS.  This seems
          to be what the new Win8 Myanmar shaper does,
      
        - For everything else, zero advance width of glyphs that are
          from General_Category=Mn Unicode characters, and do so
          before applying GPOS.  This seems to be what Uniscribe does
          for Latin at least.
      
      With these changes, positioning of all tests matches for Myanmar,
      except for the glitch in Uniscribe not applying 'mark'.  See preivous
      commit.
      56800027
  9. 17 11月, 2012 1 次提交
  10. 16 11月, 2012 2 次提交
    • B
      Bunch of independent changes (ouch) · f3064103
      Behdad Esfahbod 提交于
      API additions:
      
      	hb_segment_properties_t
      	HB_SEGMENT_PROPERTIES_DEFAULT
      	hb_segment_properties_equal()
      	hb_segment_properties_hash()
      
      	hb_buffer_set_segment_properties()
      	hb_buffer_get_segment_properties()
      
      	hb_ot_layout_glyph_class_t
      
      	hb_shape_plan_t
      	hb_shape_plan_create()
      	hb_shape_plan_create_cached()
      	hb_shape_plan_get_empty()
      	hb_shape_plan_reference()
      	hb_shape_plan_destroy()
      	hb_shape_plan_set_user_data()
      	hb_shape_plan_get_user_data()
      	hb_shape_plan_execute()
      
      	hb_ot_shape_plan_collect_lookups()
      
      API changes:
      
      	Rename hb_ot_layout_feature_get_lookup_indexes() to
      	hb_ot_layout_feature_get_lookups().
      
      New header file:
      
      	hb-shape-plan.h
      
      And a bunch of prototyped but not implemented stuff.  Coming soon.
      (Tests fail because of the prototypes right now.)
      f3064103
    • B
      362a990b
  11. 29 8月, 2012 1 次提交
  12. 24 8月, 2012 1 次提交
  13. 10 8月, 2012 1 次提交
  14. 02 8月, 2012 4 次提交
  15. 31 7月, 2012 2 次提交
  16. 30 7月, 2012 5 次提交
  17. 29 7月, 2012 1 次提交
  18. 27 7月, 2012 1 次提交
  19. 26 7月, 2012 1 次提交
  20. 24 7月, 2012 1 次提交
  21. 09 6月, 2012 1 次提交
  22. 11 5月, 2012 1 次提交