!725 Codex警告清零

Merge pull request !725 from yinjiaming/yjm-kernel-fs-20211203

fs/proc/include/proc_fs.h

@@ -53,6 +53,9 @@ extern "C" {
 typedef unsigned short fmode_t;
 #define PROC_ERROR (-1)
 
+/* Default file mode for procfs */
+#define PROCFS_DEFAULT_MODE 0550
+
 /* 64bit hashes as llseek() offset (for directories) */
 #define FMODE_64BITHASH   ((fmode_t)0x400)
 /* 32bit hashes as llseek() offset (for directories) */

fs/proc/os_adapt/proc_init.c

@@ -45,7 +45,7 @@ void ProcFsInit(void)
 {
     int ret;
 
-    ret = mkdir(PROCFS_MOUNT_POINT, 0);
+    ret = mkdir(PROCFS_MOUNT_POINT, PROCFS_DEFAULT_MODE);
     if (ret < 0) {
         PRINT_ERR("failed to mkdir %s, errno = %d\n", PROCFS_MOUNT_POINT, get_errno());
         return;

fs/proc/os_adapt/proc_vfs.c

@@ -41,8 +41,6 @@
 #include "los_tables.h"
 #include "internal.h"
 
-#define PROCFS_DEFAULT_MODE 0555
-
 #ifdef LOSCFG_FS_PROC
 static struct VnodeOps g_procfsVops;
 static struct file_operations_vfs g_procfsFops;

fs/proc/src/proc_file.c

@@ -49,7 +49,7 @@ static struct ProcFile g_procPf = {
 
 static struct ProcDirEntry g_procRootDirEntry = {
     .nameLen     = 5,
-    .mode        = S_IFDIR | S_IRUSR | S_IXUSR | S_IRGRP | S_IXGRP | S_IROTH | S_IXOTH,
+    .mode        = S_IFDIR | PROCFS_DEFAULT_MODE,
     .count       = ATOMIC_INIT(1),
     .procFileOps = NULL,
     .parent      = &g_procRootDirEntry,

syscall/fs_syscall.c

@@ -307,7 +307,7 @@ int SysOpen(const char *path, int oflags, ...)
         goto ERROUT;
     }
 
-    if (oflags & O_CLOEXEC) {
+    if ((unsigned int)oflags & O_CLOEXEC) {
         SetCloexecFlag(procFd);
     }
 
@@ -1640,7 +1640,7 @@ int SysOpenat(int dirfd, const char *path, int oflags, ...)
         goto ERROUT;
     }
 
-    if (oflags & O_CLOEXEC) {
+    if ((unsigned int)oflags & O_CLOEXEC) {
         SetCloexecFlag(procFd);
     }