On heavy loaded VM data might not yet be available, give
the machine second chance in case of Errno 11.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Some tests (polling, sigio, rmmod, ...) raised VirtioPortException
instead of TestFailure. This might be confusing so let's raise
TestFail + original traceback instead.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

This will help us check if we didn't break anything in KVM-specific or
TCG-specific code inside QEMU.
Signed-off-by: NEduardo Habkost <ehabkost@redhat.com>

This will allow us to more easily filter and combine CPU models with the
multiple test cases we have. We can easily introduce new tests that will
automatically be run once for each known CPU model.

Test cases that don't need to be re-run for each CPU model can use the
"cpu.unset" variant that doesn't set any specific cpu_model option.

This also introduces "kvm" and "nokvm" variants, to allow test cases to
be run with KVM disabled and enabled, if necessary.

This way the test output will now look like this:

    (1/94) qemu_cpu.check_models.kvm.cpu.intel.486.qemu13: PASS (0.42 s)
    (2/94) qemu_cpu.check_models.kvm.cpu.intel.core2duo.qemu13: PASS (0.44 s)
    [...]
    (49/94) qemu_cpu.cpuid.default.vendor.nokvm.cpu.intel.core2duo.qemu13: PASS (20.63 s)
    (50/94) qemu_cpu.cpuid.default.vendor.nokvm.cpu.intel.kvm32.qemu13: PASS (21.66 s)
    [...]
    (62/94) qemu_cpu.cpuid.default.vendor.nokvm.cpu.intel.SandyBridge.qemu13: PASS (20.58 s)
    (63/94) qemu_cpu.cpuid.default.vendor.nokvm.cpu.intel.Haswell.qemu13: PASS (20.52 s)
    (64/94) qemu_cpu.cpuid.default.vendor.nokvm.cpu.amd.qemu64.qemu13: PASS (21.51 s)
    (65/94) qemu_cpu.cpuid.default.vendor.nokvm.cpu.amd.phenom.qemu13: PASS (20.53 s)
    [...]
    (71/94) qemu_cpu.cpuid.default.vendor.nokvm.cpu.amd.Opteron_G5.qemu13: PASS (21.59 s)
    (72/94) qemu_cpu.cpuid.custom.vendor.normal.kvm.cpu.unset.qemu13: PASS (20.53 s)
    (73/94) qemu_cpu.cpuid.custom.vendor.tooshort.kvm.cpu.unset.qemu13: PASS (0.87 s)
    (74/94) qemu_cpu.cpuid.custom.vendor.empty.kvm.cpu.unset.qemu13: PASS (0.81 s)
    (75/94) qemu_cpu.cpuid.custom.level.level5.kvm.cpu.unset.qemu13: PASS (20.60 s)
    [...]
Signed-off-by: NEduardo Habkost <ehabkost@redhat.com>

This shouldn't have any visible change, but it will make it easier to
review the changes made later when introducing the per-CPU-model
variants.
Signed-off-by: NEduardo Habkost <ehabkost@redhat.com>

This allows us to make the configuration clearer than just omitting the
vendor value.
Signed-off-by: NEduardo Habkost <ehabkost@redhat.com>

This way we can use the "cpu_model" config option to check for a single
CPU model, if necessary.
Signed-off-by: NEduardo Habkost <ehabkost@redhat.com>

I don't know yet what will be the best way to configure the tests, but
this changes the test code to allow both modes to be used: a single
model can be set using the "cpu_model" option, or multiple models may be
tested using the "cpu_models" option. Or, if cpu_models is "*", all
models reported by QEMU can be tested (that was the current behavior
when cpu_models was not set).
Signed-off-by: NEduardo Habkost <ehabkost@redhat.com>

With this change, the test_qemu_cpu_models_list() command won't include
the full QEMU "-cpu ?" output in the test failure message anymore, but
it can be found in the test logs if necessary.
Signed-off-by: NEduardo Habkost <ehabkost@redhat.com>

Without this option, autotest will set a "cpu_model" config option by
itself.
Signed-off-by: NEduardo Habkost <ehabkost@redhat.com>

Instead of just defining rhel64 and qemu13 and enabling both by default,
define rhel64, qemu13, and unknown_qemu.

unknown_qemu will be enabled by default, so we don't test for things
that may fail on non-RHEL-6 or non-qemu-1.3 hosts. This should make the
tests work by default on most hosts, until we implement some kind of
host-based autoconfiguration system.
Signed-off-by: NEduardo Habkost <ehabkost@redhat.com>

cpuid.custom will fail if qemu is built without kvm,
due to virt-test tries to start qemu in kvm mode.

To fix it run custom variants in TCG mode, since they do
not have anything kvm specific.
Signed-off-by: NIgor Mammedov <imammedo@redhat.com>

If config has only 'disable-kvm=yes' but not 'enable-kvm=no'
qemu will be started in kvm mode and with kvm disabled at
compile time it fails to launch.

Currently disable/enable-kvm config options and qemu supported
options are intermingled in a bunch of ifs, separate apples
and oranges in different bins and make logic straightforward:

* alias disable-kvm to enable-kvm param
* get right option set to disable/enable kvm on qemu/qemu-kvm
* set appropriate option depending on value of param enable-kvm
Signed-off-by: NIgor Mammedov <imammedo@redhat.com>

Make use of extract_cpu_models() on cpuid test.
One of the patches from ehabkost introducing
get_qemu_cpu_models would have to be rebased
according to the fact they were introduced
earlier by this patchset.

CC: Eduardo Habkost <ehabkost@redhat.com>
CC: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

When auto_cpu_model = yes, we'll try to find the best
CPU model to be used by qemu, the process being:

1) Find the host CPU model
2) Try to pass it to qemu

We used to ignore invalid CPU models passed to qemu
in qemu_vm code, but we had to change that to allow
negative CPU model testing. So the sanity check of
whether the CPU model is valid has to be made way
earlier in the code.

Therefore, introduce get_qemu_best_cpu_model, that
will find the host CPU model and then check this
value against the valid CPU models on qemu. In case
there's no such cpu model in qemu, chose a sensible
default value (default_cpu_model if it is defined
in the params dict, or 'qemu64').

The new functions introduced to utils_misc are:
 * get_host_cpu_models -> Rename of get_cpu_model
 * get_qemu_cpu_models
 * extract_qemu_cpu_models
 * get_qemu_best_cpu_model

Some of the functions were extracted from the
cpuid test. In the next patch, we make the
test to use the new functions.

Changes from v1:
 * Refactor code to get qemu cpu models to its
   own function on utils_misc
 * Make the code actually work, by making
   involved functions to return lists

CC: Eduardo Habkost <ehabkost@redhat.com>
CC: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Last line said that No newline at end of file.
When we create subtests.cfg in libvirt project,
the end of virsh_save will like this:
(omit)
save_libvirtd = "off"    - virsh_setmem:
(omit)

Signed-off-by: Yu Mingfei<yumingfei@cn.fujitsu.com>

Hi Chris,Lucas:
I found that in virsh_managedsave.py, the way to get VM's id or uuid is
not very exacting,
so I changed it to use libvirt_vm's function.
Signed-off-by: NLi Yang <liyang.fnst@cn.fujitsu.com>

The command being run is a shell command, so running it as "-cpu ?"
without any quotes around "?" will make the shell expand "?" to the list
of filenames with one letter in the current directory.
Let's fix this by properly escaping the question mark.
Signed-off-by: NEduardo Habkost <ehabkost@redhat.com>

The existence of additional CPU models is not a bug, and should not
cause a test failure.

This changes the code to generate a INFO message in the log file, but
not cause the test to fail.
Signed-off-by: NEduardo Habkost <ehabkost@redhat.com>

We're having trouble to make both RHEL 6 and Fedora 18
koji/brew based installs work with the same cleanup
settings. So, allow to pass a cartesian param
installer_cleanup = yes/no to override the default
parameters being passed to the install function.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Yet another place that didn't have its location updated
according to the new organization of the symlinks and
data files.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

In order to distinguish better between a legitimate
TestFail (the test did fail) and a TestError
(unexpected condition, test bug or misconfiguration),
print a different ERROR state when error.TestError
is raised.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Autotest upstream renamed one particular API:

global_config -> settings

In order to make it cleaner. As we are still in the process
to make autotest 0.15, let's handle gracefully both
libraries installed in the system. This way, we can resume
regression testing for the next branches of both projects.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

The guest might not get ip address sometimes, thus let's record
tcpdump output as well, so that we can debug network problem.
Signed-off-by: NQingtang Zhou <qzhou@redhat.com>

The list of CPU models is the same on RHEL-6 and QEMU-1.3.
Signed-off-by: NEduardo Habkost <ehabkost@redhat.com>

Signed-off-by: NEduardo Habkost <ehabkost@redhat.com>

Signed-off-by: NEduardo Habkost <ehabkost@redhat.com>

Signed-off-by: NEduardo Habkost <ehabkost@redhat.com>

The duplication of settings makes it very hard to spot mistakes. This is
a new version of the config file that uses nesting and cartesian
products of variants to avoid duplication.

To make it easier to test wheter the changes are working, this generates
exactly the same dictionaries as the original config, in exactly the
same sequence, including all the bugs. Look for the #FIXME comments for
places that will be cleaned up or fixed later.
Signed-off-by: NEduardo Habkost <ehabkost@redhat.com>

Signed-off-by: NIgor Mammedov <imammedo@redhat.com>
---
v2:
    * s/TestFail/TestNAError/
    * s/custom_model_id/custom.model_id/ in config

Signed-off-by: NIgor Mammedov <imammedo@redhat.com>
---
v2:
    * s/TestFail/TestNAError/
    * s/custom_xlevel/custom.xlevel/ in config

Signed-off-by: NIgor Mammedov <imammedo@redhat.com>
---
v2:
   * s/TestFail/TestNAError/
   * s/custom_stepping/custom.stepping/ in config

Signed-off-by: NIgor Mammedov <imammedo@redhat.com>
v2:
   * s/TestFail/TestNAError/
   * s/custom_model/custom.model/ in config

Signed-off-by: NIgor Mammedov <imammedo@redhat.com>
---
v2:
    * s/TestFail/TestNAError/
    * s/custom_family/custom.family/ in config

Signed-off-by: NIgor Mammedov <imammedo@redhat.com>
---
v2:
    * s/TestFail/TestNAError/
    * s/custom_level/custom.level/ in config

Signed-off-by: NIgor Mammedov <imammedo@redhat.com>
---
v2:
    * s/TestFail/TestNAError/
    * s/custom_vendor/custom.vendor/ in config

Signed-off-by: NIgor Mammedov <imammedo@redhat.com>
---
v2:
    * remove rhelcpu models form qemu13 test
    * if vendor is missing use  host's vendor
    * remove no needed cpu_models list from kvm test
    * replace cpu_models with shorter ignore_cpu_models in rhel64.kvm.cpuid.default.vendor
    * fix typo
    * s/default_vendor/default.vendor/ in config so we could use
      cpuid.default selector for all default tests

default.vendor fix

... and test utilities to parse its output

CPUID leaves are capped by reported level, xlevel, x2level values.
Signed-off-by: NIgor Mammedov <imammedo@redhat.com>
---
  v3:
    * dump CPUID(EAX=3), CPUID(EAX=4,ECX=3), CPUID(EAX={0xB, 0xC})
    * dump CPUID(EAX=0x80000007) and known paravirt cpuid leaves if
      detected
    * make target name specific to function cpuid_dump_kernel.bin,
      so we could later add another targets for other tests
  v2:
    * log cpuid dump on parsing failure
    * cap by reported level, xlevel, x2level

Signed-off-by: NIgor Mammedov <imammedo@redhat.com>
Signed-off-by: NEduardo Habkost <ehabkost@redhat.com>
---
v2:
  * rebased on top of tree where there is no subtests.cfg.example
  * s/kvm/qemu/ in pathnames and test config
  * Change some errors types to a more suitable ones

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>