Signed-off-by: NXu Han <xuhan@redhat.com>

1. Should report error when leaked clusters are founded
2. As image locking is enabled, must use force shared option to
check a stopped image.
3. Update the function to print the debug info
Signed-off-by: NPing Li <pingl@redhat.com>

Clean up imports across the board in tp-qemu. The criteria
followed was:

1) Remove unnecessary imports
2) Turn multi imports from a single entry point to one
   import per line. This increases both patch and
   source code readability.
3) Separate blocks of imports with a line:
   * Python standard library imports
   * Autotest imports
   * virttest imports
   * Internal tp-qemu imports
4) Remove try/except blocks refering autotest libs and
   stick with the virttest.staging copy

This paves the way for the future removal of autotest
references, replacing those references with avocado ones.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NCong Li <coli@redhat.com>

Use the function from utils_misc to get the qemu and qemu-img binary.
Signed-off-by: NYiqiao Pu <ypu@redhat.com>

There's no need to have the name of the "run_<name>" method (main
test entry point) depend on the test name. So, for simplicity sake,
let's just name the test entry point "run".

I have decided to not fallback gracefully to the previous naming
convention as I believe this can lead to confusion in the future.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

As the drive_format increased, to ignore the devname not defined problem
in the future. Use command to check the disk devname by scripts.
Signed-off-by: NYiqiao Pu <ypu@redhat.com>

Make virt-test to have a docstring style mostly compliant with
the sphinx's [1] format, reStructured text. This means that
we have to trade all '@' tags to be ':', mostly.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

With the help of the PEP8 script, a semi-automated clean
of the code base was made, and effectively changing some
of the coding style rules of our code base:

 * No more 2 lines spacing among functions
 * No more combined module imports

In the end, it was going to be too difficult to take
into consideration E501 (line length > 80) errors and
W601 (.has_key() is deprecated), so these were ignored,
at least for now.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

The cleanup action causes a error if guest still alive when removing
images on LVM, thus this patch destroy guest before cleanup method
called.

Other update:
 * Introduct error.context into this script.
 * Add try-except block when calling cleanup method in case unexpected
   exception is raised.
Signed-off-by: NQingtang Zhou <qzhou@redhat.com>
Acked-by: NFeng Yang <fyang@redhat.com>

Folder structure changed after merging
Now qemu-img is in qemu folder.
Signed-off-by: NFeng Yang <fyang@redhat.com>
Acked-by: NQingtang Zhou <qzhou@redhat.com>

Now use test.bindir will not find the image file, just update it
to new interface data_dir.get_data_dir
Signed-off-by: NMike Qiu <qiudayu@linux.vnet.ibm.com>

Currently, the image_name has changed, the old fashion is like:
/tmp/kvm_autotest_root/images/f18-64, but the new is
images/f18-64.

In test, need to use data_dir to get the images dir.
Signed-off-by: NMike Qiu <qiudayu@linux.vnet.ibm.com>

Currently, when running the tests while the clean
up didn't run on the previous, it will raise an
error like:

Test failed: CmdError:
Command <fuser -k /dev/vg_kvm_test_enospc/lv_kvm_test_enospc>
failed, rc=1, Command returned non-zero exit status
[context: performing enospc setup --> performing enospc cleanup]
* Command:
    fuser -k /dev/vg_kvm_test_enospc/lv_kvm_test_enospc
Exit status: 1
Duration: 0.0501132011414

That is the link /dev/vg_kvm_test_enospc/lv_kvm_test_enospc
exist, but no user. thus the command line:
    fuser -k /dev/vg_kvm_test_enospc/lv_kvm_test_enospc
will return 1(fuser will always return none-zero for nobody use).

So just ignore the return status of the fuser.
Signed-off-by: NMike Qiu <qiudayu@linux.vnet.ibm.com>

This patch benefits from the better error message when key is missing
in config params. Instead of custom handling of missing param it
uses params[] directly.

I modified those params, where I was 100% certain that they are
required and doesn't have default value:
 * val = params.get(..) followed by if not val: raise...
 * int(params.get(...))
 * params.get(...).split()
 * commands which require string (eg. session.cmd(params.get(...)))

I didn't test all the tests before and after in order to verify
possible typos but I used pylint before and after, watching for
new errors (code rate before and after).
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

In order to be consistent with previous changes.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

A frequent request we've got from users is that the name
'kvm' makes assumptions that are not true for a lot of
the use cases of the test suite. Then let's rename
the subtest 'kvm' to 'qemu', making it more accurate.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Currently, When run the test and do some clenup steps it always fail
with lvremove command, because the lv is in used.
Actually, the tests do fuser -k to kill users. but the it is a link
not a file as it check if it is a file.

So change the os.path.isfile to os.path.islink.
Signed-off-by: NMike Qiu <qiudayu@linux.vnet.ibm.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>