Fix indent of statements to improve readability.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Move operator in complex expression to the end of the line to preserve
consistency.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Change multiple definitions in one statement into multiple statements
with one definition per statement.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Change double assignment in one statement into two assignment
statements.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Change double spaces between lexemes into single spaces.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Delete unnecessary empty line.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Change obscure line endings to less obscure ones. (improve readability)
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Change indent of statements to use tabs and to improve readability.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Delete curly braces around single if-else statements.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Change obscure line endings to less obscure ones. (improve readability)
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Remove unnecessary curly braces around single if statement.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Move operators in complex expressions to the end of the lines to
preserve consistency.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Change indent of statements with (less than 8) spaces to indent with
tabs.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Line up comments to match indent of surrounding statements.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Change obscure line endings to less obscure ones. (improve readability)
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Plase operators in complex expressions at the end of the lines to
preserve consistency.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Delete part of the comment that is not checked in code.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Line up constant defines to the same column. (also delete unnecessary
spaces in comments)
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Line up constant defines to the same column.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Fix typo in comment in word 'decoder'.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Change obscure line endings to less obscure ones. (improve readability)
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Change obscure line endings to less obscure ones. (improve readability)
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Change indent of statements that indented with spaces to indent with
tabs.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Delete redundant empty line.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Fix indent of statement to use tab instead of spaces.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Change column of line continuation character ('\') and fix indent of
multiline defines.
Also line up remaining constant defines.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Line up defines to the same column.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Change obscure line endings to less obscure ones. (improve readability)
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Move operator of complex expression to the end of the lines to preserve
consistency.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Change wrong indent (with spaces and less than 7 columns) of statements
to tabs.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Change obscure line endings to less obscure ones. (improve readability)
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Delete unnecessary space before indented statement.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Add curly braces around else clause because corresponding if has them.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Line up comments to the same column.
Signed-off-by: NLeonid V. Fedorenchik <leonidsbox@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

i2c_master_send returns negative errno, or else the number of bytes written.
Signed-off-by: NAxel Lin <axel.lin@gmail.com>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

lirc_serial_probe() must fail if request_irq() returns an error, even if
it isn't EBUSY or EINVAL,
Signed-off-by: NBen Hutchings <ben@decadent.org.uk>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Device not found?  ENODEV, not EINVAL.
Write to read-only device?  EPERM, not EBADF.
Invalid argument?  EINVAL, not ENOSYS.
Unsupported ioctl?  ENOIOCTLCMD, not ENOSYS.
Another function returned an error code?  Use that, don't replace it.
Signed-off-by: NBen Hutchings <ben@decadent.org.uk>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

A resume function cannot remove the device it is resuming!
Signed-off-by: NBen Hutchings <ben@decadent.org.uk>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Failure to allocate the I/O region leaves the IRQ allocated.
A later failure leaves them both allocated.
Reported-by: NTorsten Crass <torsten.crass@eBiology.de>
Signed-off-by: NBen Hutchings <ben@decadent.org.uk>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>

Currently the module init function registers a platform_device and
only then allocates its IRQ and I/O region.  This allows allocation to
race with the device's suspend() function.  Instead, allocate
resources in the platform driver's probe() function and free them in
the remove() function.

The module exit function removes the platform device before the
character device that provides access to it.  Change it to reverse the
order of initialisation.
Signed-off-by: NBen Hutchings <ben@decadent.org.uk>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>