'of_match_ptr' is defined in linux/of.h. Include it explicitly.
Signed-off-by: NSachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The data structure of_match_ptr() protects is always compiled in.
Hence of_match_ptr() is not needed.
Signed-off-by: NSachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The data structure of_match_ptr() protects is always compiled in.
Hence of_match_ptr() is not needed.
Signed-off-by: NSachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Driver core sets driver data to NULL upon failure or remove.
Signed-off-by: NSachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Driver core sets driver data to NULL upon failure or remove.
Signed-off-by: NSachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Driver core sets driver data to NULL upon failure or remove.
Signed-off-by: NSachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Driver core sets the data to NULL upon release or probe
failure. Hence explicit setting is not necessary.
Signed-off-by: NSachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Driver core sets the data to NULL upon release or probe
failure. Hence explicit setting is not necessary.
Signed-off-by: NSachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

After the last architecture switched to generic hard irqs the config
options HAVE_GENERIC_HARDIRQS & GENERIC_HARDIRQS and the related code
for !CONFIG_GENERIC_HARDIRQS can be removed.
Signed-off-by: NMartin Schwidefsky <schwidefsky@de.ibm.com>

Converting to devm functions can make the code smaller and cleaner.
Signed-off-by: NFabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

If both CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME are unset:

drivers/input/touchscreen/cyttsp4_core.c:1556: warning: ‘cyttsp4_core_sleep’ defined but not used
drivers/input/touchscreen/cyttsp4_core.c:1634: warning: ‘cyttsp4_core_wake’ defined but not used

Move cyttsp4_core_sleep(), cyttsp4_core_wake(), and cyttsp4_core_wake_()
(which is called from cyttsp4_core_wake() only) inside the existing section
protected by #if defined(CONFIG_PM_SLEEP) || defined(CONFIG_PM_RUNTIME)
Signed-off-by: NGeert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Remove useless NULL test from cyttsp4_watchdog_timer().
Signed-off-by: NWei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: NFerruh Yigit <fery@cypress.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

__initdata should be placed between the variable name and equal
sign for the variable to be placed in the intended section.
Signed-off-by: NSachin Kamat <sachin.kamat@linaro.org>
Cc: Pau Oliva Fora <pau@eslack.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Add CONFIG_PM_SLEEP to suspend/resume functions to fix the build
warnings when CONFIG_PM_SLEEP is not selected. This is because
sleep PM callbacks defined by SET_SYSTEM_SLEEP_PM_OPS are only used
when the CONFIG_PM_SLEEP is enabled.

drivers/input/touchscreen/eeti_ts.c:268:12: warning: 'eeti_ts_suspend' defined but not used [-Wunused-function]
drivers/input/touchscreen/eeti_ts.c:287:12: warning: 'eeti_ts_resume' defined but not used [-Wunused-function]
Signed-off-by: NJingoo Han <jg1.han@samsung.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Add CONFIG_PM_SLEEP to suspend/resume functions to fix the build
warnings when CONFIG_PM_SLEEP is not selected. This is because
sleep PM callbacks defined by SET_SYSTEM_SLEEP_PM_OPS are only used
when the CONFIG_PM_SLEEP is enabled.

drivers/input/touchscreen/cy8ctmg110_ts.c:295:12: warning: 'cy8ctmg110_suspend' defined but not used [-Wunused-function]
drivers/input/touchscreen/cy8ctmg110_ts.c:309:12: warning: 'cy8ctmg110_resume' defined but not used [-Wunused-function]
Signed-off-by: NJingoo Han <jg1.han@samsung.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

In TSG4, register map is 512bytes long and to access all of it,
one bit from address byte is used (which bit to use differs for
I2C and SPI);

Since common code used for TSG3 and TSG4 for I2C, this parameter
wrongly used as u8. TSG3 does not access beyond 255 bytes
but TSG4 may.

Tested-on:TMA3XX DVB && TMA4XX DVB
Signed-off-by: NFerruh Yigit <fery@cypress.com>
Acked-by: NJavier Martinez Canillas <javier@dowhile0.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

If probe() fails after cd->xfer_buf allocated, it will not freed.
Added kfree(cd->xfer_buf) with and error label.
Signed-off-by: NFerruh Yigit <fery@cypress.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Since the driver was converted to polled device infrastructure we need
to make sure it is enabled.
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Signed-off-by: NDaniel Mack <zonque@gmail.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Let's declare platform data a const pointer so that we don't accitentally
change it. Also fetch it with dev_get_platdata().
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

We leak "cd" if the cd->xfer_buf allocation fails.  It was weird to
"goto error_gpio_irq" so I changed the label name.  (Label names should
reflect the label location not the goto location otherwise you get an
"all roads lead to Rome problem").
Signed-off-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

If "cd" were NULL then we would dereference it when we print the error
message.  Fortunately enough, it can't ever be NULL so we can remove
those lines.
Signed-off-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

"*max" is a size_t (long) type but "1" is an int so static checkers
complain that the shift could wrap.
Signed-off-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

There is no need to roll our own polling scheme when we already have
one implemented by the core.
Tested-by: NManish Badarkhe <badarkhe.manish@gmail.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Cypress TrueTouch(tm) Standard Product controllers,
Generation4 devices, SPI adapter module.

This driver adds communication support with TTSP controller
using SPI bus.
Signed-off-by: NFerruh Yigit <fery@cypress.com>
Acked-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: NJavier Martinez Canillas <javier@dowhile0.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Cypress TrueTouch(tm) Standard Product controllers,
Generation4 devices, I2C adapter module.

This driver adds communication support with TTSP controller
using I2C bus.
Signed-off-by: NFerruh Yigit <fery@cypress.com>
Acked-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: NJavier Martinez Canillas <javier@dowhile0.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Cypress TrueTouch(tm) Standard Product controllers,
Generetion4 devices, Core driver.

Core driver is interface between host and TTSP controller and processes
data sent by controller.

Responsibilities of module are IRQ handling, reading system information
registers and sending multi-touch protocol type B events.
Signed-off-by: NFerruh Yigit <fery@cypress.com>
Acked-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: NJavier Martinez Canillas <javier@dowhile0.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Existing I2C code is for TrueTouch Gen3 devices

TrueTouch Gen4 device is using same protocol, will split driver into
two pieces to use common code with both drivers.

Read/Write functions parameter list modified, since shared code will
be used by two separate drivers and these drivers are not sharing same
structs, parameters updated to use common structures.
Signed-off-by: NFerruh Yigit <fery@cypress.com>
Acked-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: NJavier Martinez Canillas <javier@dowhile0.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Although defined in platform data, vref is not used anywhere.

Also remove model, irq, and clear_penirq as they are not used either.
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

tsc->polling is write only and the poll local is meaningless
Signed-off-by: NAlan Cox <alan@linux.intel.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Although BTN_TOOL_PEN and BTN_TOOL_RUBBER functioned properly, the driver
didn't have hover functionality, so it's been added.

Also, "WACOM_RETRY_CNT" was not used, so it was removed.
Signed-off-by: NTatsunosuke Tobita <tobita.tatsunosuke@wacom.co.jp>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The previous patch ("input/ti_am335x_tsc: ACK the HW_PEN irq in ISR")
acked the interrupt so we don't freeze if we don't handle an enabled
interrupt source. The interrupt core has a mechanism for this and to get
it work one should only say that it handled an interrupt if it is
actually the case.
Signed-off-by: NSebastian Andrzej Siewior <bigeasy@linutronix.de>

The interrupt source IRQENB_HW_PEN is enabled in suspend and suposed to
be used as a wake up source. Once this interrupt source is unmaksed, the
devices ends up in ISR and never continues.
This change ACKs the interrupt and disables it so the system does not
freeze.
Signed-off-by: NSebastian Andrzej Siewior <bigeasy@linutronix.de>

The driver programs a threshold of "coordinate_readouts" say 5. The
REG_FIFO0THR registers says it should it be programmed to "threshold
minus one". The driver does not expect just 5 coordinates but 5 * 2 + 2.
Multiplied by two because 5 for X and 5 for Y and plus 2 because we have
two Z.
The whole thing kind of works because It reads the 5 coordinates for X
and Y from FIFO0 and FIFO1 and the last element in each FIFO is ignored
within the loop and read later.
Nothing guaranties that FIFO1 is ready by the time it is read. In fact I
could see that that FIFO1 reaturns for Y channels 8,9, 10, 12, 6 and for
Y channel 7 for Z. The problem is that channel 7 and channel 12 got
somehow mixed up.
The other Problem is that FIFO1 is also used by the IIO part leading to
wrong results if both (tsc & adc) are used.

The patch tries to clean up the whole thing a little:
- Remove the +1 and -1 in REG_STEPCONFIG, REG_STEPDELAY and its counter
  part in the for loop. This is just confusing.

- Use only FIFO0 in TSC. The fifo has space for 64 entries so should be
  fine.

- Read the whole FIFO in one function and check the channel.

- in case we dawdle around, make sure we only read a multiple of our
  coordinate set. On the second interrupt we will cleanup the remaining
  enties.
Acked-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: NSebastian Andrzej Siewior <bigeasy@linutronix.de>

tsc is a very generic name. This patch adds a TI and HW prefix to it
less generic.
Signed-off-by: NSebastian Andrzej Siewior <bigeasy@linutronix.de>

This patch removes access to platform data mfd_tscadc_board because the
platform is DT only.
Acked-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: NSebastian Andrzej Siewior <bigeasy@linutronix.de>

This patch adds DT support to touch driver. It also provides a binding
document which is used by the MFD and IIO part of the device.
This patch also renames steps_to_configure to coordinate_readouts
because the original name misleads the purpose of the variable.
Signed-off-by: NPantelis Antoniou <panto@antoniou-consulting.com>
Signed-off-by: NPatil, Rachna <rachna@ti.com>
Signed-off-by: NFelipe Balbi <balbi@ti.com>
Signed-off-by: NSebastian Andrzej Siewior <bigeasy@linutronix.de>

When touchscreen and ADC are used together, this
unwanted fifo flush leads to loss of ADC data.
Signed-off-by: NPatil, Rachna <rachna@ti.com>
Signed-off-by: NFelipe Balbi <balbi@ti.com>
Signed-off-by: NSebastian Andrzej Siewior <bigeasy@linutronix.de>

The current driver expected touchscreen input
wires(XP,XN,YP,YN) to be connected in a particular order.
Making changes to accept this as platform data.

Sebastian reworked the original patch and removed a lot of the not
required pieces.
Signed-off-by: NPatil, Rachna <rachna@ti.com>
Signed-off-by: NFelipe Balbi <balbi@ti.com>
Signed-off-by: NSebastian Andrzej Siewior <bigeasy@linutronix.de>