1. 29 11月, 2012 1 次提交
  2. 22 9月, 2012 1 次提交
  3. 18 9月, 2012 5 次提交
  4. 14 9月, 2012 1 次提交
  5. 01 9月, 2012 1 次提交
  6. 14 6月, 2012 1 次提交
    • J
      DMA: PL330: Fix racy mutex unlock · fdec53d5
      Javi Merino 提交于
      pl330_update() stores a pointer to the thrd->req that finished, which
      contains a pointer to the corresponding pl330_req.  This is done with
      the pl330_lock held.  Then, it iterates through the req_done list,
      calling the callback for each of the requests that are done.  The
      problem is that the driver releases the lock before calling the
      callback for each of the callbacks.  pl330_submit_req() running in
      another processor can then acquire the lock and insert another request
      in one of the thrd->req that hasn't been processed yet, replacing the
      pointer to pl330_req there.  When the callback returns in
      pl330_update() and the next rqdone is popped from the list, it
      dereferences the pl330_req pointer to the just scheduled pl330_req,
      instead of the one that has finished, calling pl330 with the wrong r.
      
      This patch fixes this by storing the pointer to pl330_req directly in
      the list.
      Signed-off-by: NJavi Merino <javi.merino@arm.com>
      Cc: Jassi Brar <jaswinder.singh@linaro.org>
      Acked-by: NJassi Brar <jaswinder.singh@linaro.org>
      Signed-off-by: NVinod Koul <vinod.koul@linux.intel.com>
      fdec53d5
  7. 07 6月, 2012 2 次提交
  8. 11 5月, 2012 2 次提交
  9. 25 4月, 2012 1 次提交
    • O
      dma: pl330: fix a couple of compilation warnings · c8473828
      Olof Johansson 提交于
      Move a couple of tests and do a minor refactor to avoid:
      
      drivers/dma/pl330.c: In function 'pl330_probe':
      drivers/dma/pl330.c:2929:215: warning: comparison of distinct pointer types lacks a cast [enabled by default]
      drivers/dma/pl330.c: In function 'pl330_tasklet':
      drivers/dma/pl330.c:2250:8: warning: 'pch' may be used uninitialized in this function [-Wuninitialized]
      drivers/dma/pl330.c:2228:25: note: 'pch' was declared here
      drivers/dma/pl330.c:2277:130: warning: 'pch' may be used uninitialized in this function [-Wuninitialized]
      drivers/dma/pl330.c:2260:25: note: 'pch' was declared here
      Signed-off-by: NOlof Johansson <olof@lixom.net>
      Signed-off-by: NVinod Koul <vinod.koul@linux.intel.com>
      c8473828
  10. 21 3月, 2012 1 次提交
  11. 17 3月, 2012 1 次提交
  12. 13 3月, 2012 7 次提交
  13. 08 3月, 2012 3 次提交
  14. 31 1月, 2012 1 次提交
    • J
      drivers/dma/pl330.c: add missing iounmap · 7bec78e0
      Julia Lawall 提交于
      Add missing iounmap in error handling code, in a case where the function
      already preforms iounmap on some other execution path.
      
      This patch additionally adds calls to clk_disable and clk_put.
      
      A simplified version of the semantic match that finds this problem is as
      follows: (http://coccinelle.lip6.fr/)
      
      // <smpl>
      @@
      expression e;
      statement S,S1;
      int ret;
      @@
      e = \(ioremap\|ioremap_nocache\)(...)
      ... when != iounmap(e)
      if (<+...e...+>) S
      ... when any
          when != iounmap(e)
      *if (...)
         { ... when != iounmap(e)
           return ...; }
      ... when any
      iounmap(e);
      // </smpl>
      Signed-off-by: NJulia Lawall <Julia.Lawall@lip6.fr>
      Signed-off-by: NVinod Koul <vinod.koul@linux.intel.com>
      7bec78e0
  15. 23 12月, 2011 3 次提交
  16. 08 12月, 2011 1 次提交
  17. 22 11月, 2011 1 次提交
  18. 10 11月, 2011 1 次提交
  19. 27 10月, 2011 1 次提交
  20. 20 9月, 2011 1 次提交
  21. 14 9月, 2011 4 次提交