1. 25 8月, 2008 1 次提交
    • B
      PNPACPI: ignore the producer/consumer bit for extended IRQ descriptors · de82ff78
      Bjorn Helgaas 提交于
      The Extended Interrupt descriptor has a producer/consumer bit, but
      it's not clear what that would mean, and existing BIOSes use the bit
      inconsistently.  This patch makes Linux PNPACPI ignore the bit.
      
      The ACPI spec contains examples of PCI Interrupt Link devices marked
      as ResourceProducers, but many BIOSes mark them as ResourceConsumers.
      
      I also checked with a Windows contact, who said:
      
          Windows uses only "resource consumer" when dealing with
          interrupts.  There's no useful way of looking at a resource
          producer of interrupts.
      
          ... NT-based Windows largely infers the producer/consumer stuff
          from the device type and ignores the bits in the namespace.  This
          was necessary because Windows 98 ignored them and early namespaces
          contained random junk.
      
      The reason I want to change this is because if PNPACPI devices exclude
      ResourceProducer IRQ resources, we can't write PNP drivers for those
      devices.
      
      For example, on machines such as the the HP rx7620, rx7640, rx8620,
      rx8640, and Superdome, HPET interrupts are ResourceProducers.  The
      HPET driver currently has to use acpi_bus_register_driver() and do its
      own _CRS parsing, even though it requires absolutely no ACPI-specific
      functionality.
      
      It would be better if the HPET driver were a PNP driver and took
      advantage of the _CRS parsing built into PNPACPI.
      
      This producer/consumer check was originally added here:
          http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=2b8de5f50e4a302b83ebcd5b0120621336d50bd6
      
      to fix this bug:
          http://bugzilla.kernel.org/show_bug.cgi?id=6292
      
      However, the bug was related only to memory and I/O port resources,
      where the distinction is sensible and important to Linux.  Given that
      the distinction is muddled for IRQ resources, I think it was a mistake
      to add the check there.
      Signed-off-by: NBjorn Helgaas <bjorn.helgaas@hp.com>
      Signed-off-by: NAndi Kleen <ak@linux.intel.com>
      de82ff78
  2. 17 7月, 2008 9 次提交
    • B
      PNPACPI: add support for HP vendor-specific CCSR descriptors · 40ab4f4c
      Bjorn Helgaas 提交于
      The HP CCSR descriptor describes MMIO address space that should appear
      as a MEM resource.  This patch adds support for parsing these descriptors
      in the _CRS data.
      
      The visible effect of this is that these MEM resources will appear
      in /sys/devices/pnp0/.../resources, which means that "lspnp -v" will
      report it, user applications can use this to locate device CSR space,
      and kernel drivers can use the normal PNP resource accessors to
      locate them.
      Signed-off-by: NBjorn Helgaas <bjorn.helgaas@hp.com>
      Signed-off-by: NLen Brown <len.brown@intel.com>
      Signed-off-by: NAndi Kleen <ak@linux.intel.com>
      40ab4f4c
    • B
      PNP: convert resource options to single linked list · 1f32ca31
      Bjorn Helgaas 提交于
      ISAPNP, PNPBIOS, and ACPI describe the "possible resource settings" of
      a device, i.e., the possibilities an OS bus driver has when it assigns
      I/O port, MMIO, and other resources to the device.
      
      PNP used to maintain this "possible resource setting" information in
      one independent option structure and a list of dependent option
      structures for each device.  Each of these option structures had lists
      of I/O, memory, IRQ, and DMA resources, for example:
      
        dev
          independent options
            ind-io0  -> ind-io1  ...
            ind-mem0 -> ind-mem1 ...
            ...
          dependent option set 0
            dep0-io0  -> dep0-io1  ...
            dep0-mem0 -> dep0-mem1 ...
            ...
          dependent option set 1
            dep1-io0  -> dep1-io1  ...
            dep1-mem0 -> dep1-mem1 ...
            ...
          ...
      
      This data structure was designed for ISAPNP, where the OS configures
      device resource settings by writing directly to configuration
      registers.  The OS can write the registers in arbitrary order much
      like it writes PCI BARs.
      
      However, for PNPBIOS and ACPI devices, the OS uses firmware interfaces
      that perform device configuration, and it is important to pass the
      desired settings to those interfaces in the correct order.  The OS
      learns the correct order by using firmware interfaces that return the
      "current resource settings" and "possible resource settings," but the
      option structures above doesn't store the ordering information.
      
      This patch replaces the independent and dependent lists with a single
      list of options.  For example, a device might have possible resource
      settings like this:
      
        dev
          options
            ind-io0 -> dep0-io0 -> dep1->io0 -> ind-io1 ...
      
      All the possible settings are in the same list, in the order they
      come from the firmware "possible resource settings" list.  Each entry
      is tagged with an independent/dependent flag.  Dependent entries also
      have a "set number" and an optional priority value.  All dependent
      entries must be assigned from the same set.  For example, the OS can
      use all the entries from dependent set 0, or all the entries from
      dependent set 1, but it cannot mix entries from set 0 with entries
      from set 1.
      
      Prior to this patch PNP didn't keep track of the order of this list,
      and it assigned all independent options first, then all dependent
      ones.  Using the example above, that resulted in a "desired
      configuration" list like this:
      
        ind->io0 -> ind->io1 -> depN-io0 ...
      
      instead of the list the firmware expects, which looks like this:
      
        ind->io0 -> depN-io0 -> ind-io1 ...
      Signed-off-by: NBjorn Helgaas <bjorn.helgaas@hp.com>
      Signed-off-by: NAndi Kleen <ak@linux.intel.com>
      Acked-by: NRene Herman <rene.herman@gmail.com>
      Signed-off-by: NLen Brown <len.brown@intel.com>
      1f32ca31
    • B
      PNP: remove extra 0x100 bit from option priority · e2a1a6f1
      Bjorn Helgaas 提交于
      When building resource options, ISAPNP and PNPBIOS set the priority
      to something like "0x100 | PNP_RES_PRIORITY_ACCEPTABLE", but we
      immediately mask off the 0x100 again in pnp_build_option(), so that
      bit looks superfluous.
      
      Thanks to Rene Herman <rene.herman@gmail.com> for pointing this out.
      Signed-off-by: NBjorn Helgaas <bjorn.helgaas@hp.com>
      Signed-off-by: NAndi Kleen <ak@linux.intel.com>
      Acked-by: NRene Herman <rene.herman@gmail.com>
      Signed-off-by: NLen Brown <len.brown@intel.com>
      e2a1a6f1
    • B
      PNPACPI: ignore _PRS interrupt numbers larger than PNP_IRQ_NR · fe2cf598
      Bjorn Helgaas 提交于
      ACPI Extended Interrupt Descriptors can encode 32-bit interrupt
      numbers, so an interrupt number may exceed the size of the bitmap
      we use to track possible IRQ settings.
      
      To avoid corrupting memory, complain and ignore too-large interrupt
      numbers.
      
      There's similar code in pnpacpi_parse_irq_option(), but I didn't
      change that because the small IRQ descriptor can only encode
      IRQs 0-15, which do not exceed bitmap size.
      
      In the future, we could handle IRQ numbers greater than PNP_IRQ_NR
      by replacing the bitmap with a table or list.
      Signed-off-by: NBjorn Helgaas <bjorn.helgaas@hp.com>
      Signed-off-by: NAndi Kleen <ak@linux.intel.com>
      Acked-by: NRene Herman <rene.herman@gmail.com>
      Signed-off-by: NLen Brown <len.brown@intel.com>
      fe2cf598
    • B
      PNP: centralize resource option allocations · c227536b
      Bjorn Helgaas 提交于
      This patch moves all the option allocations (pnp_mem, pnp_port, etc)
      into the pnp_register_{mem,port,irq,dma}_resource() functions.  This
      will make it easier to rework the option data structures.
      
      The non-trivial part of this patch is the IRQ handling.  The backends
      have to allocate a local pnp_irq_mask_t bitmap, populate it, and pass
      a pointer to pnp_register_irq_resource().
      Signed-off-by: NBjorn Helgaas <bjorn.helgaas@hp.com>
      Signed-off-by: NAndi Kleen <ak@linux.intel.com>
      Acked-by: NRene Herman <rene.herman@gmail.com>
      Signed-off-by: NLen Brown <len.brown@intel.com>
      c227536b
    • B
      PNP: introduce pnp_irq_mask_t typedef · 7aefff51
      Bjorn Helgaas 提交于
      This adds a typedef for the IRQ bitmap, which should cause
      no functional change, but will make it easier to pass a
      pointer to a bitmap to pnp_register_irq_resource().
      Signed-off-by: NBjorn Helgaas <bjorn.helgaas@hp.com>
      Signed-off-by: NAndi Kleen <ak@linux.intel.com>
      Acked-by: NRene Herman <rene.herman@gmail.com>
      Signed-off-by: NLen Brown <len.brown@intel.com>
      7aefff51
    • B
      PNP: define PNP-specific IORESOURCE_IO_* flags alongside IRQ, DMA, MEM · 08c9f262
      Bjorn Helgaas 提交于
      PNP previously defined PNP_PORT_FLAG_16BITADDR and PNP_PORT_FLAG_FIXED
      in a private header file, but put those flags in struct resource.flags
      fields.  Better to make them IORESOURCE_IO_* flags like the existing
      IRQ, DMA, and MEM flags.
      Signed-off-by: NBjorn Helgaas <bjorn.helgaas@hp.com>
      Signed-off-by: NAndi Kleen <ak@linux.intel.com>
      Acked-by: NRene Herman <rene.herman@gmail.com>
      Signed-off-by: NLen Brown <len.brown@intel.com>
      08c9f262
    • B
      PNPACPI: keep disabled resources when parsing current config · 5acf9141
      Bjorn Helgaas 提交于
      When we parse a device's _CRS data (the current resource settings),
      we should keep track of everything we find, even if it's currently
      disabled or invalid.
      
      This is what we already do for ISAPNP and PNPBIOS, and it helps
      keep things matched up when we subsequently re-encode resources.
      For example, consider a device with (mem, irq0, irq1, io), where
      irq0 is disabled.  If we drop irq0 when parsing the _CRS, we will
      mistakenly put irq1 in the irq0 slot when we encode resources
      for an _SRS call.
      Signed-off-by: NBjorn Helgaas <bjorn.helgaas@hp.com>
      Signed-off-by: NLen Brown <len.brown@intel.com>
      Signed-off-by: NAndi Kleen <ak@linux.intel.com>
      5acf9141
    • B
      PNP: replace pnp_resource_table with dynamically allocated resources · aee3ad81
      Bjorn Helgaas 提交于
      PNP used to have a fixed-size pnp_resource_table for tracking the
      resources used by a device.  This table often overflowed, so we've
      had to increase the table size, which wastes memory because most
      devices have very few resources.
      
      This patch replaces the table with a linked list of resources where
      the entries are allocated on demand.
      
      This removes messages like these:
      
          pnpacpi: exceeded the max number of IO resources
          00:01: too many I/O port resources
      
      References:
      
          http://bugzilla.kernel.org/show_bug.cgi?id=9535
          http://bugzilla.kernel.org/show_bug.cgi?id=9740
          http://lkml.org/lkml/2007/11/30/110
      
      This patch also changes the way PNP uses the IORESOURCE_UNSET,
      IORESOURCE_AUTO, and IORESOURCE_DISABLED flags.
      
      Prior to this patch, the pnp_resource_table entries used the flags
      like this:
      
          IORESOURCE_UNSET
      	This table entry is unused and available for use.  When this flag
      	is set, we shouldn't look at anything else in the resource structure.
      	This flag is set when a resource table entry is initialized.
      
          IORESOURCE_AUTO
      	This resource was assigned automatically by pnp_assign_{io,mem,etc}().
      
      	This flag is set when a resource table entry is initialized and
      	cleared whenever we discover a resource setting by reading an ISAPNP
      	config register, parsing a PNPBIOS resource data stream, parsing an
      	ACPI _CRS list, or interpreting a sysfs "set" command.
      
      	Resources marked IORESOURCE_AUTO are reinitialized and marked as
      	IORESOURCE_UNSET by pnp_clean_resource_table() in these cases:
      
      	    - before we attempt to assign resources automatically,
      	    - if we fail to assign resources automatically,
      	    - after disabling a device
      
          IORESOURCE_DISABLED
      	Set by pnp_assign_{io,mem,etc}() when automatic assignment fails.
      	Also set by PNPBIOS and PNPACPI for:
      
      	    - invalid IRQs or GSI registration failures
      	    - invalid DMA channels
      	    - I/O ports above 0x10000
      	    - mem ranges with negative length
      
      After this patch, there is no pnp_resource_table, and the resource list
      entries use the flags like this:
      
          IORESOURCE_UNSET
      	This flag is no longer used in PNP.  Instead of keeping
      	IORESOURCE_UNSET entries in the resource list, we remove
      	entries from the list and free them.
      
          IORESOURCE_AUTO
      	No change in meaning: it still means the resource was assigned
      	automatically by pnp_assign_{port,mem,etc}(), but these functions
      	now set the bit explicitly.
      
      	We still "clean" a device's resource list in the same places,
      	but rather than reinitializing IORESOURCE_AUTO entries, we
      	just remove them from the list.
      
      	Note that IORESOURCE_AUTO entries are always at the end of the
      	list, so removing them doesn't reorder other list entries.
      	This is because non-IORESOURCE_AUTO entries are added by the
      	ISAPNP, PNPBIOS, or PNPACPI "get resources" methods and by the
      	sysfs "set" command.  In each of these cases, we completely free
      	the resource list first.
      
          IORESOURCE_DISABLED
      	In addition to the cases where we used to set this flag, ISAPNP now
      	adds an IORESOURCE_DISABLED resource when it reads a configuration
      	register with a "disabled" value.
      Signed-off-by: NBjorn Helgaas <bjorn.helgaas@hp.com>
      Signed-off-by: NLen Brown <len.brown@intel.com>
      Signed-off-by: NAndi Kleen <ak@linux.intel.com>
      aee3ad81
  3. 12 6月, 2008 3 次提交
  4. 29 4月, 2008 18 次提交
  5. 24 4月, 2008 1 次提交
  6. 27 3月, 2008 1 次提交
  7. 07 2月, 2008 1 次提交
  8. 18 1月, 2008 1 次提交
  9. 13 1月, 2008 1 次提交
    • L
      pnpacpi: print resource shortage message only once · 66a21736
      Len Brown 提交于
      pnpacpi: exceeded the max number of IO resources: 40
      
      While this message is a real error and should thus
      remain KERN_ERR (even a new dmesg line is seen as a regression
      by some, since it was not printed in 2.6.23...) it is certainly
      impolite to print this warning 50 times should you happen to
      have the oddball system with 90 io resources under a device...
      
      So print the warning just once.
      
      In 2.6.25 we'll get rid of the limits altogether
      and these warnings will vanish with them.
      
      http://bugzilla.kernel.org/show_bug.cgi?id=9535Signed-off-by: NLen Brown <len.brown@intel.com>
      66a21736
  10. 30 11月, 2007 1 次提交
  11. 20 11月, 2007 2 次提交
  12. 17 10月, 2007 1 次提交