1. 05 6月, 2008 2 次提交
    • P
      x86: aperture_64.c: corner case wrong · 4f384f8b
      Pavel Machek 提交于
      If
      
      fix == 0, aper_enabled == 1, gart_fix_e820 == 0
      
      	if (!fix && !aper_enabled)
      		return;
      
      	if (gart_fix_e820 && !fix && aper_enabled) {
      		if (e820_any_mapped(aper_base, aper_base + aper_size,
      				    E820_RAM)) {
      			/* reserve it, so we can reuse it in second kernel */
      			printk(KERN_INFO "update e820 for GART\n");
      			add_memory_region(aper_base, aper_size, E820_RESERVED);
      			update_e820();
      		}
      		return;
      	}
      
      	/* different nodes have different setting, disable them all atfirst*/
      
      we'll fall back here and disable all the settings, even when they were
      all consistent.
      
      What about this? (I hope it compiles...)
      Signed-off-by: NPavel Machek <pavel@suse.cz>
      Cc: Dave Jones <davej@codemonkey.org.uk>
      Cc: Andi Kleen <andi@firstfloor.org>
      Signed-off-by: NThomas Gleixner <tglx@linutronix.de>
      4f384f8b
    • P
      aperture_64.c: duplicated code, buggy? · fa5b8a30
      Pavel Machek 提交于
      Hi!
      
      void __init early_gart_iommu_check(void)
      
      contains
      
      	for (num = 24; num < 32; num++) {
      		if (!early_is_k8_nb(read_pci_config(0, num, 3, 0x00)))
      			continue;
      
      loop, with very similar loop duplicated in
      
      void __init gart_iommu_hole_init(void)
      
      . First copy of a loop seems to be buggy, too. It uses 0 as a "nothing
      set" value, which may actually bite us in last_aper_enabled case
      (because it may be often zero).
      
      (Beware, it is hard to test this patch, because this code has about
      2^8 different code paths, depending on hardware and cmdline settings).
      
      Plus, the second loop does not check for consistency of
      aper_enabled. Should it?
      Signed-off-by: NThomas Gleixner <tglx@linutronix.de>
      fa5b8a30
  2. 28 5月, 2008 1 次提交
  3. 22 5月, 2008 1 次提交
  4. 17 5月, 2008 1 次提交
  5. 16 5月, 2008 12 次提交
  6. 15 5月, 2008 23 次提交