1. 06 1月, 2011 1 次提交
  2. 08 12月, 2010 1 次提交
    • V
      ARM: S3C24XX: Fix mess with gpio {set,get}_pull callbacks · 812c4e40
      Vasily Khoruzhick 提交于
      Currently the {set,get}_pull callbacks of the s3c24xx_gpiocfg_default structure
      are initalized via s3c_gpio_{get,set}pull_1up. This results in a linker
      error when only CONFIG_CPU_S3C2442 is selected:
      
      arch/arm/plat-s3c24xx/built-in.o:(.data+0x13f4): undefined reference to
      `s3c_gpio_getpull_1up'
      arch/arm/plat-s3c24xx/built-in.o:(.data+0x13f8): undefined reference to
      `s3c_gpio_setpull_1up'
      
      The s3c2442 has pulldowns instead of pullups compared to the s3c2440.
      The method of controlling them is the same though.
      So this patch modifies the existing s3c_gpio_{get,set}pull_1up helper functions
      to take an additional parameter deciding whether the pin has a pullup or pulldown.
      The s3c_gpio_{get,set}pull_1{down,up} functions then wrap that functions passing
      either S3C_GPIO_PULL_UP or S3C_GPIO_PULL_DOWN.
      
      Furthermore this patch sets up the s3c24xx_gpiocfg_default.{get,set}_pull fields
      in the s3c244{0,2}_map_io function to the new pulldown helper functions.
      
      Based on patch from "Lars-Peter Clausen" <lars@metafoo.de>
      Signed-off-by: NVasily Khoruzhick <anarsoul@gmail.com>
      Signed-off-by: NBen Dooks <ben-linux@fluff.org>
      812c4e40
  3. 26 10月, 2010 1 次提交
  4. 23 10月, 2010 2 次提交
  5. 14 9月, 2010 1 次提交
    • K
      ARM: SAMSUNG: Fix on s5p_gpio_[get,set]_drvstr · cbd2780f
      Kukjin Kim 提交于
      This patch fixes bug on gpio drive strength helper function.
      
      The offset should be like follwoing.
      -       off = chip->chip.base - pin;
      +       off = pin - chip->chip.base;
      
      In the s5p_gpio_get_drvstr(),
      the second line is unnecessary, because overwrite drvstr.
              drvstr = __raw_readl(reg);
      -       drvstr = 0xffff & (0x3 << shift);
      
      And need 2bit masking before return the drvstr value.
              drvstr = drvstr >> shift;
      +       drvstr &= 0x3;
      
      In the s5p_gpio_set_drvstr(), need relevant bit clear.
              tmp = __raw_readl(reg);
      +       tmp &= ~(0x3 << shift);
              tmp |= drvstr << shift;
      Reported-by: NJaecheol Lee <jc.lee@samsung.com>
      Signed-off-by: NKukjin Kim <kgene.kim@samsung.com>
      cbd2780f
  6. 19 5月, 2010 1 次提交
  7. 11 5月, 2010 1 次提交
  8. 06 5月, 2010 4 次提交
  9. 19 1月, 2010 1 次提交
  10. 15 1月, 2010 1 次提交
  11. 22 6月, 2009 1 次提交
  12. 16 4月, 2009 1 次提交
  13. 16 12月, 2008 1 次提交