intel_lvds.c 31.2 KB
Newer Older
J
Jesse Barnes 已提交
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29
/*
 * Copyright © 2006-2007 Intel Corporation
 * Copyright (c) 2006 Dave Airlie <airlied@linux.ie>
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
 * to deal in the Software without restriction, including without limitation
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
 * and/or sell copies of the Software, and to permit persons to whom the
 * Software is furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice (including the next
 * paragraph) shall be included in all copies or substantial portions of the
 * Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
 * DEALINGS IN THE SOFTWARE.
 *
 * Authors:
 *	Eric Anholt <eric@anholt.net>
 *      Dave Airlie <airlied@linux.ie>
 *      Jesse Barnes <jesse.barnes@intel.com>
 */

30
#include <acpi/button.h>
31
#include <linux/dmi.h>
J
Jesse Barnes 已提交
32
#include <linux/i2c.h>
33
#include <linux/slab.h>
34 35 36
#include <drm/drmP.h>
#include <drm/drm_crtc.h>
#include <drm/drm_edid.h>
J
Jesse Barnes 已提交
37
#include "intel_drv.h"
38
#include <drm/i915_drm.h>
J
Jesse Barnes 已提交
39
#include "i915_drv.h"
40
#include <linux/acpi.h>
J
Jesse Barnes 已提交
41

42
/* Private structure for the integrated LVDS support */
43 44
struct intel_lvds_connector {
	struct intel_connector base;
45

46
	struct notifier_block lid_notifier;
47 48
};

49
struct intel_lvds_encoder {
C
Chris Wilson 已提交
50
	struct intel_encoder base;
51

52
	bool is_dual_link;
D
Daniel Vetter 已提交
53
	u32 reg;
54

55
	struct intel_lvds_connector *attached_connector;
56 57
};

58
static struct intel_lvds_encoder *to_lvds_encoder(struct drm_encoder *encoder)
C
Chris Wilson 已提交
59
{
60
	return container_of(encoder, struct intel_lvds_encoder, base.base);
C
Chris Wilson 已提交
61 62
}

63
static struct intel_lvds_connector *to_lvds_connector(struct drm_connector *connector)
64
{
65
	return container_of(connector, struct intel_lvds_connector, base.base);
66 67
}

68 69 70 71 72
static bool intel_lvds_get_hw_state(struct intel_encoder *encoder,
				    enum pipe *pipe)
{
	struct drm_device *dev = encoder->base.dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
D
Daniel Vetter 已提交
73
	struct intel_lvds_encoder *lvds_encoder = to_lvds_encoder(&encoder->base);
74
	enum intel_display_power_domain power_domain;
D
Daniel Vetter 已提交
75
	u32 tmp;
76

77 78 79 80
	power_domain = intel_display_port_power_domain(encoder);
	if (!intel_display_power_enabled(dev_priv, power_domain))
		return false;

D
Daniel Vetter 已提交
81
	tmp = I915_READ(lvds_encoder->reg);
82 83 84 85 86 87 88 89 90 91 92 93

	if (!(tmp & LVDS_PORT_EN))
		return false;

	if (HAS_PCH_CPT(dev))
		*pipe = PORT_TO_PIPE_CPT(tmp);
	else
		*pipe = PORT_TO_PIPE(tmp);

	return true;
}

94 95 96 97 98 99
static void intel_lvds_get_config(struct intel_encoder *encoder,
				  struct intel_crtc_config *pipe_config)
{
	struct drm_device *dev = encoder->base.dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	u32 lvds_reg, tmp, flags = 0;
100
	int dotclock;
101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117

	if (HAS_PCH_SPLIT(dev))
		lvds_reg = PCH_LVDS;
	else
		lvds_reg = LVDS;

	tmp = I915_READ(lvds_reg);
	if (tmp & LVDS_HSYNC_POLARITY)
		flags |= DRM_MODE_FLAG_NHSYNC;
	else
		flags |= DRM_MODE_FLAG_PHSYNC;
	if (tmp & LVDS_VSYNC_POLARITY)
		flags |= DRM_MODE_FLAG_NVSYNC;
	else
		flags |= DRM_MODE_FLAG_PVSYNC;

	pipe_config->adjusted_mode.flags |= flags;
118

119 120 121 122 123
	dotclock = pipe_config->port_clock;

	if (HAS_PCH_SPLIT(dev_priv->dev))
		ironlake_check_encoder_dotclock(pipe_config, dotclock);

124
	pipe_config->adjusted_mode.crtc_clock = dotclock;
125 126
}

127
static void intel_pre_enable_lvds(struct intel_encoder *encoder)
128 129 130 131
{
	struct intel_lvds_encoder *lvds_encoder = to_lvds_encoder(&encoder->base);
	struct drm_device *dev = encoder->base.dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
132
	struct intel_crtc *crtc = to_intel_crtc(encoder->base.crtc);
133 134
	const struct drm_display_mode *adjusted_mode =
		&crtc->config.adjusted_mode;
135
	int pipe = crtc->pipe;
136 137
	u32 temp;

138 139 140 141 142 143 144 145
	if (HAS_PCH_SPLIT(dev)) {
		assert_fdi_rx_pll_disabled(dev_priv, pipe);
		assert_shared_dpll_disabled(dev_priv,
					    intel_crtc_to_shared_dpll(crtc));
	} else {
		assert_pll_disabled(dev_priv, pipe);
	}

146 147
	temp = I915_READ(lvds_encoder->reg);
	temp |= LVDS_PORT_EN | LVDS_A0A2_CLKA_POWER_UP;
148 149 150 151

	if (HAS_PCH_CPT(dev)) {
		temp &= ~PORT_TRANS_SEL_MASK;
		temp |= PORT_TRANS_SEL_CPT(pipe);
152
	} else {
153 154 155 156 157
		if (pipe == 1) {
			temp |= LVDS_PIPEB_SELECT;
		} else {
			temp &= ~LVDS_PIPEB_SELECT;
		}
158
	}
159

160
	/* set the corresponsding LVDS_BORDER bit */
161
	temp &= ~LVDS_BORDER_ENABLE;
162
	temp |= crtc->config.gmch_pfit.lvds_border_bits;
163 164 165 166 167 168 169 170 171 172 173 174
	/* Set the B0-B3 data pairs corresponding to whether we're going to
	 * set the DPLLs for dual-channel mode or not.
	 */
	if (lvds_encoder->is_dual_link)
		temp |= LVDS_B0B3_POWER_UP | LVDS_CLKB_POWER_UP;
	else
		temp &= ~(LVDS_B0B3_POWER_UP | LVDS_CLKB_POWER_UP);

	/* It would be nice to set 24 vs 18-bit mode (LVDS_A3_POWER_UP)
	 * appropriately here, but we need to look more thoroughly into how
	 * panels behave in the two modes.
	 */
175 176 177 178 179

	/* Set the dithering flag on LVDS as needed, note that there is no
	 * special lvds dither control bit on pch-split platforms, dithering is
	 * only controlled through the PIPECONF reg. */
	if (INTEL_INFO(dev)->gen == 4) {
180 181
		/* Bspec wording suggests that LVDS port dithering only exists
		 * for 18bpp panels. */
182
		if (crtc->config.dither && crtc->config.pipe_bpp == 18)
183 184 185 186 187
			temp |= LVDS_ENABLE_DITHER;
		else
			temp &= ~LVDS_ENABLE_DITHER;
	}
	temp &= ~(LVDS_HSYNC_POLARITY | LVDS_VSYNC_POLARITY);
188
	if (adjusted_mode->flags & DRM_MODE_FLAG_NHSYNC)
189
		temp |= LVDS_HSYNC_POLARITY;
190
	if (adjusted_mode->flags & DRM_MODE_FLAG_NVSYNC)
191 192 193 194 195
		temp |= LVDS_VSYNC_POLARITY;

	I915_WRITE(lvds_encoder->reg, temp);
}

J
Jesse Barnes 已提交
196 197 198
/**
 * Sets the power state for the panel.
 */
199
static void intel_enable_lvds(struct intel_encoder *encoder)
J
Jesse Barnes 已提交
200
{
201
	struct drm_device *dev = encoder->base.dev;
202
	struct intel_lvds_encoder *lvds_encoder = to_lvds_encoder(&encoder->base);
203 204
	struct intel_connector *intel_connector =
		&lvds_encoder->attached_connector->base;
J
Jesse Barnes 已提交
205
	struct drm_i915_private *dev_priv = dev->dev_private;
D
Daniel Vetter 已提交
206
	u32 ctl_reg, stat_reg;
207

208
	if (HAS_PCH_SPLIT(dev)) {
209
		ctl_reg = PCH_PP_CONTROL;
210
		stat_reg = PCH_PP_STATUS;
211 212
	} else {
		ctl_reg = PP_CONTROL;
213
		stat_reg = PP_STATUS;
214
	}
J
Jesse Barnes 已提交
215

D
Daniel Vetter 已提交
216
	I915_WRITE(lvds_encoder->reg, I915_READ(lvds_encoder->reg) | LVDS_PORT_EN);
217

218
	I915_WRITE(ctl_reg, I915_READ(ctl_reg) | POWER_TARGET_ON);
D
Daniel Vetter 已提交
219
	POSTING_READ(lvds_encoder->reg);
220 221
	if (wait_for((I915_READ(stat_reg) & PP_ON) != 0, 1000))
		DRM_ERROR("timed out waiting for panel to power on\n");
222

223
	intel_panel_enable_backlight(intel_connector);
224 225
}

226
static void intel_disable_lvds(struct intel_encoder *encoder)
227
{
228
	struct drm_device *dev = encoder->base.dev;
229
	struct intel_lvds_encoder *lvds_encoder = to_lvds_encoder(&encoder->base);
230 231
	struct intel_connector *intel_connector =
		&lvds_encoder->attached_connector->base;
232
	struct drm_i915_private *dev_priv = dev->dev_private;
D
Daniel Vetter 已提交
233
	u32 ctl_reg, stat_reg;
234 235 236

	if (HAS_PCH_SPLIT(dev)) {
		ctl_reg = PCH_PP_CONTROL;
237
		stat_reg = PCH_PP_STATUS;
238 239
	} else {
		ctl_reg = PP_CONTROL;
240
		stat_reg = PP_STATUS;
241 242
	}

243
	intel_panel_disable_backlight(intel_connector);
244 245

	I915_WRITE(ctl_reg, I915_READ(ctl_reg) & ~POWER_TARGET_ON);
246 247
	if (wait_for((I915_READ(stat_reg) & PP_ON) == 0, 1000))
		DRM_ERROR("timed out waiting for panel to power off\n");
248

D
Daniel Vetter 已提交
249 250
	I915_WRITE(lvds_encoder->reg, I915_READ(lvds_encoder->reg) & ~LVDS_PORT_EN);
	POSTING_READ(lvds_encoder->reg);
J
Jesse Barnes 已提交
251 252
}

253 254 255
static enum drm_mode_status
intel_lvds_mode_valid(struct drm_connector *connector,
		      struct drm_display_mode *mode)
J
Jesse Barnes 已提交
256
{
257 258
	struct intel_connector *intel_connector = to_intel_connector(connector);
	struct drm_display_mode *fixed_mode = intel_connector->panel.fixed_mode;
J
Jesse Barnes 已提交
259

260 261 262 263
	if (mode->hdisplay > fixed_mode->hdisplay)
		return MODE_PANEL;
	if (mode->vdisplay > fixed_mode->vdisplay)
		return MODE_PANEL;
J
Jesse Barnes 已提交
264 265 266 267

	return MODE_OK;
}

268 269
static bool intel_lvds_compute_config(struct intel_encoder *intel_encoder,
				      struct intel_crtc_config *pipe_config)
J
Jesse Barnes 已提交
270
{
271
	struct drm_device *dev = intel_encoder->base.dev;
J
Jesse Barnes 已提交
272
	struct drm_i915_private *dev_priv = dev->dev_private;
273 274
	struct intel_lvds_encoder *lvds_encoder =
		to_lvds_encoder(&intel_encoder->base);
275 276
	struct intel_connector *intel_connector =
		&lvds_encoder->attached_connector->base;
277
	struct drm_display_mode *adjusted_mode = &pipe_config->adjusted_mode;
278
	struct intel_crtc *intel_crtc = lvds_encoder->base.new_crtc;
279
	unsigned int lvds_bpp;
J
Jesse Barnes 已提交
280 281

	/* Should never happen!! */
282
	if (INTEL_INFO(dev)->gen < 4 && intel_crtc->pipe == 0) {
283
		DRM_ERROR("Can't support LVDS on pipe A\n");
J
Jesse Barnes 已提交
284 285 286
		return false;
	}

287 288 289 290 291 292
	if ((I915_READ(lvds_encoder->reg) & LVDS_A3_POWER_MASK) ==
	    LVDS_A3_POWER_UP)
		lvds_bpp = 8*3;
	else
		lvds_bpp = 6*3;

293
	if (lvds_bpp != pipe_config->pipe_bpp && !pipe_config->bw_constrained) {
294 295 296 297
		DRM_DEBUG_KMS("forcing display bpp (was %d) to LVDS (%d)\n",
			      pipe_config->pipe_bpp, lvds_bpp);
		pipe_config->pipe_bpp = lvds_bpp;
	}
298

J
Jesse Barnes 已提交
299
	/*
300
	 * We have timings from the BIOS for the panel, put them in
J
Jesse Barnes 已提交
301 302 303 304
	 * to the adjusted mode.  The CRTC will be set up for this mode,
	 * with the panel scaling set up to source from the H/VDisplay
	 * of the original mode.
	 */
305
	intel_fixed_panel_mode(intel_connector->panel.fixed_mode,
306
			       adjusted_mode);
307 308

	if (HAS_PCH_SPLIT(dev)) {
309 310
		pipe_config->has_pch_encoder = true;

311 312
		intel_pch_panel_fitting(intel_crtc, pipe_config,
					intel_connector->panel.fitting_mode);
313 314 315
	} else {
		intel_gmch_panel_fitting(intel_crtc, pipe_config,
					 intel_connector->panel.fitting_mode);
J
Jesse Barnes 已提交
316

317
	}
318

J
Jesse Barnes 已提交
319 320 321 322 323 324 325 326 327 328 329 330
	/*
	 * XXX: It would be nice to support lower refresh rates on the
	 * panels to reduce power consumption, and perhaps match the
	 * user's requested refresh rate.
	 */

	return true;
}

/**
 * Detect the LVDS connection.
 *
331 332 333
 * Since LVDS doesn't have hotlug, we use the lid as a proxy.  Open means
 * connected and closed means disconnected.  We also send hotplug events as
 * needed, using lid status notification from the input layer.
J
Jesse Barnes 已提交
334
 */
335
static enum drm_connector_status
336
intel_lvds_detect(struct drm_connector *connector, bool force)
J
Jesse Barnes 已提交
337
{
338
	struct drm_device *dev = connector->dev;
339
	enum drm_connector_status status;
340

341
	DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n",
342
		      connector->base.id, connector->name);
343

344 345 346
	status = intel_panel_detect(dev);
	if (status != connector_status_unknown)
		return status;
347

348
	return connector_status_connected;
J
Jesse Barnes 已提交
349 350 351 352 353 354 355
}

/**
 * Return the list of DDC modes if available, or the BIOS fixed mode otherwise.
 */
static int intel_lvds_get_modes(struct drm_connector *connector)
{
356
	struct intel_lvds_connector *lvds_connector = to_lvds_connector(connector);
J
Jesse Barnes 已提交
357
	struct drm_device *dev = connector->dev;
358
	struct drm_display_mode *mode;
J
Jesse Barnes 已提交
359

360
	/* use cached edid if we have one */
361
	if (!IS_ERR_OR_NULL(lvds_connector->base.edid))
362
		return drm_add_edid_modes(connector, lvds_connector->base.edid);
J
Jesse Barnes 已提交
363

364
	mode = drm_mode_duplicate(dev, lvds_connector->base.panel.fixed_mode);
C
Chris Wilson 已提交
365
	if (mode == NULL)
366
		return 0;
J
Jesse Barnes 已提交
367

368 369
	drm_mode_probed_add(connector, mode);
	return 1;
J
Jesse Barnes 已提交
370 371
}

372 373
static int intel_no_modeset_on_lid_dmi_callback(const struct dmi_system_id *id)
{
374
	DRM_INFO("Skipping forced modeset for %s\n", id->ident);
375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391
	return 1;
}

/* The GPU hangs up on these systems if modeset is performed on LID open */
static const struct dmi_system_id intel_no_modeset_on_lid[] = {
	{
		.callback = intel_no_modeset_on_lid_dmi_callback,
		.ident = "Toshiba Tecra A11",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
			DMI_MATCH(DMI_PRODUCT_NAME, "TECRA A11"),
		},
	},

	{ }	/* terminating entry */
};

392
/*
393 394 395
 * Lid events. Note the use of 'modeset':
 *  - we set it to MODESET_ON_LID_OPEN on lid close,
 *    and set it to MODESET_DONE on open
396
 *  - we use it as a "only once" bit (ie we ignore
397 398 399 400
 *    duplicate events where it was already properly set)
 *  - the suspend/resume paths will set it to
 *    MODESET_SUSPENDED and ignore the lid open event,
 *    because they restore the mode ("lid open").
401
 */
402 403 404
static int intel_lid_notify(struct notifier_block *nb, unsigned long val,
			    void *unused)
{
405 406 407 408 409
	struct intel_lvds_connector *lvds_connector =
		container_of(nb, struct intel_lvds_connector, lid_notifier);
	struct drm_connector *connector = &lvds_connector->base.base;
	struct drm_device *dev = connector->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
410

411 412 413
	if (dev->switch_power_state != DRM_SWITCH_POWER_ON)
		return NOTIFY_OK;

414 415 416
	mutex_lock(&dev_priv->modeset_restore_lock);
	if (dev_priv->modeset_restore == MODESET_SUSPENDED)
		goto exit;
417 418 419 420
	/*
	 * check and update the status of LVDS connector after receiving
	 * the LID nofication event.
	 */
421
	connector->status = connector->funcs->detect(connector, false);
422

423 424
	/* Don't force modeset on machines where it causes a GPU lockup */
	if (dmi_check_system(intel_no_modeset_on_lid))
425
		goto exit;
426
	if (!acpi_lid_open()) {
427 428 429
		/* do modeset on next lid open event */
		dev_priv->modeset_restore = MODESET_ON_LID_OPEN;
		goto exit;
430
	}
431

432 433
	if (dev_priv->modeset_restore == MODESET_DONE)
		goto exit;
434

435 436 437 438 439 440 441 442 443 444 445 446 447
	/*
	 * Some old platform's BIOS love to wreak havoc while the lid is closed.
	 * We try to detect this here and undo any damage. The split for PCH
	 * platforms is rather conservative and a bit arbitrary expect that on
	 * those platforms VGA disabling requires actual legacy VGA I/O access,
	 * and as part of the cleanup in the hw state restore we also redisable
	 * the vga plane.
	 */
	if (!HAS_PCH_SPLIT(dev)) {
		drm_modeset_lock_all(dev);
		intel_modeset_setup_hw_state(dev, true);
		drm_modeset_unlock_all(dev);
	}
448

449 450 451 452
	dev_priv->modeset_restore = MODESET_DONE;

exit:
	mutex_unlock(&dev_priv->modeset_restore_lock);
453 454 455
	return NOTIFY_OK;
}

J
Jesse Barnes 已提交
456 457 458 459 460 461 462 463 464
/**
 * intel_lvds_destroy - unregister and free LVDS structures
 * @connector: connector to free
 *
 * Unregister the DDC bus for this connector then free the driver private
 * structure.
 */
static void intel_lvds_destroy(struct drm_connector *connector)
{
465 466
	struct intel_lvds_connector *lvds_connector =
		to_lvds_connector(connector);
J
Jesse Barnes 已提交
467

468 469
	if (lvds_connector->lid_notifier.notifier_call)
		acpi_lid_notifier_unregister(&lvds_connector->lid_notifier);
J
Jesse Barnes 已提交
470

471 472 473
	if (!IS_ERR_OR_NULL(lvds_connector->base.edid))
		kfree(lvds_connector->base.edid);

474
	intel_panel_fini(&lvds_connector->base.panel);
475

J
Jesse Barnes 已提交
476 477 478 479
	drm_connector_cleanup(connector);
	kfree(connector);
}

480 481 482 483
static int intel_lvds_set_property(struct drm_connector *connector,
				   struct drm_property *property,
				   uint64_t value)
{
484
	struct intel_connector *intel_connector = to_intel_connector(connector);
485 486
	struct drm_device *dev = connector->dev;

487
	if (property == dev->mode_config.scaling_mode_property) {
488
		struct drm_crtc *crtc;
489

490 491
		if (value == DRM_MODE_SCALE_NONE) {
			DRM_DEBUG_KMS("no scaling not supported\n");
492
			return -EINVAL;
493
		}
494

495
		if (intel_connector->panel.fitting_mode == value) {
496 497 498
			/* the LVDS scaling property is not changed */
			return 0;
		}
499
		intel_connector->panel.fitting_mode = value;
500 501

		crtc = intel_attached_encoder(connector)->base.crtc;
502 503 504 505 506
		if (crtc && crtc->enabled) {
			/*
			 * If the CRTC is enabled, the display will be changed
			 * according to the new panel fitting mode.
			 */
507
			intel_crtc_restore_mode(crtc);
508 509 510
		}
	}

511 512 513
	return 0;
}

J
Jesse Barnes 已提交
514 515 516
static const struct drm_connector_helper_funcs intel_lvds_connector_helper_funcs = {
	.get_modes = intel_lvds_get_modes,
	.mode_valid = intel_lvds_mode_valid,
517
	.best_encoder = intel_best_encoder,
J
Jesse Barnes 已提交
518 519 520
};

static const struct drm_connector_funcs intel_lvds_connector_funcs = {
521
	.dpms = intel_connector_dpms,
J
Jesse Barnes 已提交
522 523
	.detect = intel_lvds_detect,
	.fill_modes = drm_helper_probe_single_connector_modes,
524
	.set_property = intel_lvds_set_property,
J
Jesse Barnes 已提交
525 526 527 528
	.destroy = intel_lvds_destroy,
};

static const struct drm_encoder_funcs intel_lvds_enc_funcs = {
C
Chris Wilson 已提交
529
	.destroy = intel_encoder_destroy,
J
Jesse Barnes 已提交
530 531
};

532 533
static int __init intel_no_lvds_dmi_callback(const struct dmi_system_id *id)
{
534
	DRM_INFO("Skipping LVDS initialization for %s\n", id->ident);
535 536
	return 1;
}
J
Jesse Barnes 已提交
537

538
/* These systems claim to have LVDS, but really don't */
539
static const struct dmi_system_id intel_no_lvds[] = {
540 541 542 543
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Apple Mac Mini (Core series)",
		.matches = {
544
			DMI_MATCH(DMI_SYS_VENDOR, "Apple"),
545 546 547 548 549 550 551
			DMI_MATCH(DMI_PRODUCT_NAME, "Macmini1,1"),
		},
	},
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Apple Mac Mini (Core 2 series)",
		.matches = {
552
			DMI_MATCH(DMI_SYS_VENDOR, "Apple"),
553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571
			DMI_MATCH(DMI_PRODUCT_NAME, "Macmini2,1"),
		},
	},
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "MSI IM-945GSE-A",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "MSI"),
			DMI_MATCH(DMI_PRODUCT_NAME, "A9830IMS"),
		},
	},
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Dell Studio Hybrid",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
			DMI_MATCH(DMI_PRODUCT_NAME, "Studio Hybrid 140g"),
		},
	},
572 573
	{
		.callback = intel_no_lvds_dmi_callback,
574 575 576 577 578 579 580 581
		.ident = "Dell OptiPlex FX170",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
			DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex FX170"),
		},
	},
	{
		.callback = intel_no_lvds_dmi_callback,
582 583 584 585 586 587
		.ident = "AOpen Mini PC",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "AOpen"),
			DMI_MATCH(DMI_PRODUCT_NAME, "i965GMx-IF"),
		},
	},
588 589 590 591 592 593 594 595
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "AOpen Mini PC MP915",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "AOpen"),
			DMI_MATCH(DMI_BOARD_NAME, "i915GMx-F"),
		},
	},
596 597 598 599 600 601 602 603
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "AOpen i915GMm-HFS",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "AOpen"),
			DMI_MATCH(DMI_BOARD_NAME, "i915GMm-HFS"),
		},
	},
604 605 606 607 608 609 610 611
	{
		.callback = intel_no_lvds_dmi_callback,
                .ident = "AOpen i45GMx-I",
                .matches = {
                        DMI_MATCH(DMI_BOARD_VENDOR, "AOpen"),
                        DMI_MATCH(DMI_BOARD_NAME, "i45GMx-I"),
                },
        },
612 613 614 615 616 617 618
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Aopen i945GTt-VFA",
		.matches = {
			DMI_MATCH(DMI_PRODUCT_VERSION, "AO00001JW"),
		},
	},
619 620 621 622 623 624 625 626
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Clientron U800",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "Clientron"),
			DMI_MATCH(DMI_PRODUCT_NAME, "U800"),
		},
	},
627
	{
628 629 630 631 632 633 634 635
                .callback = intel_no_lvds_dmi_callback,
                .ident = "Clientron E830",
                .matches = {
                        DMI_MATCH(DMI_SYS_VENDOR, "Clientron"),
                        DMI_MATCH(DMI_PRODUCT_NAME, "E830"),
                },
        },
        {
636 637 638 639 640 641 642
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Asus EeeBox PC EB1007",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK Computer INC."),
			DMI_MATCH(DMI_PRODUCT_NAME, "EB1007"),
		},
	},
643 644 645 646 647 648 649 650
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Asus AT5NM10T-I",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
			DMI_MATCH(DMI_BOARD_NAME, "AT5NM10T-I"),
		},
	},
651 652
	{
		.callback = intel_no_lvds_dmi_callback,
653
		.ident = "Hewlett-Packard HP t5740",
654 655
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"),
656
			DMI_MATCH(DMI_PRODUCT_NAME, " t5740"),
657 658
		},
	},
659 660 661 662 663
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Hewlett-Packard t5745",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"),
664
			DMI_MATCH(DMI_PRODUCT_NAME, "hp t5745"),
665 666 667 668 669 670 671
		},
	},
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Hewlett-Packard st5747",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"),
672
			DMI_MATCH(DMI_PRODUCT_NAME, "hp st5747"),
673 674
		},
	},
675 676 677 678 679 680 681 682
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "MSI Wind Box DC500",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "MICRO-STAR INTERNATIONAL CO., LTD"),
			DMI_MATCH(DMI_BOARD_NAME, "MS-7469"),
		},
	},
683 684 685 686 687 688 689 690
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Gigabyte GA-D525TUD",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "Gigabyte Technology Co., Ltd."),
			DMI_MATCH(DMI_BOARD_NAME, "D525TUD"),
		},
	},
691 692 693 694 695 696 697 698
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Supermicro X7SPA-H",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "Supermicro"),
			DMI_MATCH(DMI_PRODUCT_NAME, "X7SPA-H"),
		},
	},
699 700 701 702 703 704 705 706
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Fujitsu Esprimo Q900",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
			DMI_MATCH(DMI_PRODUCT_NAME, "ESPRIMO Q900"),
		},
	},
707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Intel D410PT",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "Intel"),
			DMI_MATCH(DMI_BOARD_NAME, "D410PT"),
		},
	},
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Intel D425KT",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "Intel"),
			DMI_EXACT_MATCH(DMI_BOARD_NAME, "D425KT"),
		},
	},
723 724 725 726 727 728 729 730
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Intel D510MO",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "Intel"),
			DMI_EXACT_MATCH(DMI_BOARD_NAME, "D510MO"),
		},
	},
731 732 733 734 735 736 737 738
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Intel D525MW",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "Intel"),
			DMI_EXACT_MATCH(DMI_BOARD_NAME, "D525MW"),
		},
	},
739 740 741

	{ }	/* terminating entry */
};
J
Jesse Barnes 已提交
742

743 744 745 746 747 748 749
/*
 * Enumerate the child dev array parsed from VBT to check whether
 * the LVDS is present.
 * If it is present, return 1.
 * If it is not present, return false.
 * If no child dev is parsed from VBT, it assumes that the LVDS is present.
 */
750 751
static bool lvds_is_present_in_vbt(struct drm_device *dev,
				   u8 *i2c_pin)
752 753
{
	struct drm_i915_private *dev_priv = dev->dev_private;
754
	int i;
755

756
	if (!dev_priv->vbt.child_dev_num)
757
		return true;
758

759
	for (i = 0; i < dev_priv->vbt.child_dev_num; i++) {
760 761
		union child_device_config *uchild = dev_priv->vbt.child_dev + i;
		struct old_child_dev_config *child = &uchild->old;
762 763 764 765

		/* If the device type is not LFP, continue.
		 * We have to check both the new identifiers as well as the
		 * old for compatibility with some BIOSes.
766
		 */
767 768
		if (child->device_type != DEVICE_TYPE_INT_LFP &&
		    child->device_type != DEVICE_TYPE_LFP)
769 770
			continue;

771 772
		if (intel_gmbus_is_port_valid(child->i2c_pin))
			*i2c_pin = child->i2c_pin;
773

774 775 776 777
		/* However, we cannot trust the BIOS writers to populate
		 * the VBT correctly.  Since LVDS requires additional
		 * information from AIM blocks, a non-zero addin offset is
		 * a good indicator that the LVDS is actually present.
778
		 */
779 780 781 782 783 784 785 786 787 788
		if (child->addin_offset)
			return true;

		/* But even then some BIOS writers perform some black magic
		 * and instantiate the device without reference to any
		 * additional data.  Trust that if the VBT was written into
		 * the OpRegion then they have validated the LVDS's existence.
		 */
		if (dev_priv->opregion.vbt)
			return true;
789
	}
790 791

	return false;
792 793
}

794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812
static int intel_dual_link_lvds_callback(const struct dmi_system_id *id)
{
	DRM_INFO("Forcing lvds to dual link mode on %s\n", id->ident);
	return 1;
}

static const struct dmi_system_id intel_dual_link_lvds[] = {
	{
		.callback = intel_dual_link_lvds_callback,
		.ident = "Apple MacBook Pro (Core i5/i7 Series)",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."),
			DMI_MATCH(DMI_PRODUCT_NAME, "MacBookPro8,2"),
		},
	},
	{ }	/* terminating entry */
};

bool intel_is_dual_link_lvds(struct drm_device *dev)
813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828
{
	struct intel_encoder *encoder;
	struct intel_lvds_encoder *lvds_encoder;

	list_for_each_entry(encoder, &dev->mode_config.encoder_list,
			    base.head) {
		if (encoder->type == INTEL_OUTPUT_LVDS) {
			lvds_encoder = to_lvds_encoder(&encoder->base);

			return lvds_encoder->is_dual_link;
		}
	}

	return false;
}

D
Daniel Vetter 已提交
829
static bool compute_is_dual_link_lvds(struct intel_lvds_encoder *lvds_encoder)
830
{
D
Daniel Vetter 已提交
831
	struct drm_device *dev = lvds_encoder->base.base.dev;
832 833 834 835
	unsigned int val;
	struct drm_i915_private *dev_priv = dev->dev_private;

	/* use the module option value if specified */
836 837
	if (i915.lvds_channel_mode > 0)
		return i915.lvds_channel_mode == 2;
838 839 840 841

	if (dmi_check_system(intel_dual_link_lvds))
		return true;

842 843 844 845 846
	/* BIOS should set the proper LVDS register value at boot, but
	 * in reality, it doesn't set the value when the lid is closed;
	 * we need to check "the value to be set" in VBT when LVDS
	 * register is uninitialized.
	 */
D
Daniel Vetter 已提交
847
	val = I915_READ(lvds_encoder->reg);
848
	if (!(val & ~(LVDS_PIPE_MASK | LVDS_DETECTED)))
849
		val = dev_priv->vbt.bios_lvds_val;
850

851 852 853
	return (val & LVDS_CLKB_POWER_MASK) == LVDS_CLKB_POWER_UP;
}

854 855 856 857
static bool intel_lvds_supported(struct drm_device *dev)
{
	/* With the introduction of the PCH we gained a dedicated
	 * LVDS presence pin, use it. */
858
	if (HAS_PCH_IBX(dev) || HAS_PCH_CPT(dev))
859 860 861 862
		return true;

	/* Otherwise LVDS was only attached to mobile products,
	 * except for the inglorious 830gm */
863 864 865 866
	if (INTEL_INFO(dev)->gen <= 4 && IS_MOBILE(dev) && !IS_I830(dev))
		return true;

	return false;
867 868
}

J
Jesse Barnes 已提交
869 870 871 872 873 874 875
/**
 * intel_lvds_init - setup LVDS connectors on this device
 * @dev: drm device
 *
 * Create the connector, register the LVDS DDC bus, and try to figure out what
 * modes we can display on the LVDS panel (if present).
 */
876
void intel_lvds_init(struct drm_device *dev)
J
Jesse Barnes 已提交
877 878
{
	struct drm_i915_private *dev_priv = dev->dev_private;
879
	struct intel_lvds_encoder *lvds_encoder;
880
	struct intel_encoder *intel_encoder;
881
	struct intel_lvds_connector *lvds_connector;
882
	struct intel_connector *intel_connector;
J
Jesse Barnes 已提交
883 884 885
	struct drm_connector *connector;
	struct drm_encoder *encoder;
	struct drm_display_mode *scan; /* *modes, *bios_mode; */
886
	struct drm_display_mode *fixed_mode = NULL;
887
	struct drm_display_mode *downclock_mode = NULL;
888
	struct edid *edid;
J
Jesse Barnes 已提交
889 890
	struct drm_crtc *crtc;
	u32 lvds;
891 892
	int pipe;
	u8 pin;
J
Jesse Barnes 已提交
893

894
	if (!intel_lvds_supported(dev))
895
		return;
896

897 898
	/* Skip init on machines we know falsely report LVDS */
	if (dmi_check_system(intel_no_lvds))
899
		return;
900

901 902
	pin = GMBUS_PORT_PANEL;
	if (!lvds_is_present_in_vbt(dev, &pin)) {
903
		DRM_DEBUG_KMS("LVDS is not present in VBT\n");
904
		return;
A
Adam Jackson 已提交
905
	}
906

907
	if (HAS_PCH_SPLIT(dev)) {
908
		if ((I915_READ(PCH_LVDS) & LVDS_DETECTED) == 0)
909
			return;
910
		if (dev_priv->vbt.edp_support) {
911
			DRM_DEBUG_KMS("disable LVDS for eDP support\n");
912
			return;
913
		}
914 915
	}

916
	lvds_encoder = kzalloc(sizeof(*lvds_encoder), GFP_KERNEL);
917
	if (!lvds_encoder)
918
		return;
J
Jesse Barnes 已提交
919

920
	lvds_connector = kzalloc(sizeof(*lvds_connector), GFP_KERNEL);
921
	if (!lvds_connector) {
922
		kfree(lvds_encoder);
923
		return;
924 925
	}

926 927
	lvds_encoder->attached_connector = lvds_connector;

928
	intel_encoder = &lvds_encoder->base;
929
	encoder = &intel_encoder->base;
930
	intel_connector = &lvds_connector->base;
C
Chris Wilson 已提交
931
	connector = &intel_connector->base;
932
	drm_connector_init(dev, &intel_connector->base, &intel_lvds_connector_funcs,
J
Jesse Barnes 已提交
933 934
			   DRM_MODE_CONNECTOR_LVDS);

935
	drm_encoder_init(dev, &intel_encoder->base, &intel_lvds_enc_funcs,
J
Jesse Barnes 已提交
936 937
			 DRM_MODE_ENCODER_LVDS);

938
	intel_encoder->enable = intel_enable_lvds;
939
	intel_encoder->pre_enable = intel_pre_enable_lvds;
940
	intel_encoder->compute_config = intel_lvds_compute_config;
941
	intel_encoder->disable = intel_disable_lvds;
942
	intel_encoder->get_hw_state = intel_lvds_get_hw_state;
943
	intel_encoder->get_config = intel_lvds_get_config;
944
	intel_connector->get_hw_state = intel_connector_get_hw_state;
945
	intel_connector->unregister = intel_connector_unregister;
946

947
	intel_connector_attach_encoder(intel_connector, intel_encoder);
948
	intel_encoder->type = INTEL_OUTPUT_LVDS;
J
Jesse Barnes 已提交
949

950
	intel_encoder->cloneable = 0;
J
Jesse Barnes 已提交
951 952
	if (HAS_PCH_SPLIT(dev))
		intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
953 954
	else if (IS_GEN4(dev))
		intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
J
Jesse Barnes 已提交
955 956 957
	else
		intel_encoder->crtc_mask = (1 << 1);

J
Jesse Barnes 已提交
958 959 960 961 962
	drm_connector_helper_add(connector, &intel_lvds_connector_helper_funcs);
	connector->display_info.subpixel_order = SubPixelHorizontalRGB;
	connector->interlace_allowed = false;
	connector->doublescan_allowed = false;

D
Daniel Vetter 已提交
963 964 965 966 967 968
	if (HAS_PCH_SPLIT(dev)) {
		lvds_encoder->reg = PCH_LVDS;
	} else {
		lvds_encoder->reg = LVDS;
	}

969 970
	/* create the scaling mode property */
	drm_mode_create_scaling_mode_property(dev);
971
	drm_object_attach_property(&connector->base,
972
				      dev->mode_config.scaling_mode_property,
973
				      DRM_MODE_SCALE_ASPECT);
974
	intel_connector->panel.fitting_mode = DRM_MODE_SCALE_ASPECT;
J
Jesse Barnes 已提交
975 976 977 978 979 980 981 982 983 984 985 986 987 988
	/*
	 * LVDS discovery:
	 * 1) check for EDID on DDC
	 * 2) check for VBT data
	 * 3) check to see if LVDS is already on
	 *    if none of the above, no panel
	 * 4) make sure lid is open
	 *    if closed, act like it's not there for now
	 */

	/*
	 * Attempt to get the fixed panel mode from DDC.  Assume that the
	 * preferred mode is the right one.
	 */
989
	mutex_lock(&dev->mode_config.mutex);
990 991 992
	edid = drm_get_edid(connector, intel_gmbus_get_adapter(dev_priv, pin));
	if (edid) {
		if (drm_add_edid_modes(connector, edid)) {
993
			drm_mode_connector_update_edid_property(connector,
994
								edid);
995
		} else {
996 997
			kfree(edid);
			edid = ERR_PTR(-EINVAL);
998
		}
999 1000
	} else {
		edid = ERR_PTR(-ENOENT);
1001
	}
1002 1003 1004
	lvds_connector->base.edid = edid;

	if (IS_ERR_OR_NULL(edid)) {
1005 1006 1007 1008 1009 1010 1011 1012 1013
		/* Didn't get an EDID, so
		 * Set wide sync ranges so we get all modes
		 * handed to valid_mode for checking
		 */
		connector->display_info.min_vfreq = 0;
		connector->display_info.max_vfreq = 200;
		connector->display_info.min_hfreq = 0;
		connector->display_info.max_hfreq = 200;
	}
J
Jesse Barnes 已提交
1014 1015 1016

	list_for_each_entry(scan, &connector->probed_modes, head) {
		if (scan->type & DRM_MODE_TYPE_PREFERRED) {
1017 1018 1019
			DRM_DEBUG_KMS("using preferred mode from EDID: ");
			drm_mode_debug_printmodeline(scan);

1020
			fixed_mode = drm_mode_duplicate(dev, scan);
1021
			if (fixed_mode) {
1022
				downclock_mode =
1023 1024
					intel_find_panel_downclock(dev,
					fixed_mode, connector);
1025 1026
				if (downclock_mode != NULL &&
					i915.lvds_downclock) {
1027 1028 1029 1030 1031 1032 1033 1034 1035 1036
					/* We found the downclock for LVDS. */
					dev_priv->lvds_downclock_avail = true;
					dev_priv->lvds_downclock =
						downclock_mode->clock;
					DRM_DEBUG_KMS("LVDS downclock is found"
					" in EDID. Normal clock %dKhz, "
					"downclock %dKhz\n",
					fixed_mode->clock,
					dev_priv->lvds_downclock);
				}
1037 1038
				goto out;
			}
J
Jesse Barnes 已提交
1039 1040 1041 1042
		}
	}

	/* Failed to get EDID, what about VBT? */
1043
	if (dev_priv->vbt.lfp_lvds_vbt_mode) {
1044
		DRM_DEBUG_KMS("using mode from VBT: ");
1045
		drm_mode_debug_printmodeline(dev_priv->vbt.lfp_lvds_vbt_mode);
1046

1047
		fixed_mode = drm_mode_duplicate(dev, dev_priv->vbt.lfp_lvds_vbt_mode);
1048 1049
		if (fixed_mode) {
			fixed_mode->type |= DRM_MODE_TYPE_PREFERRED;
1050 1051
			goto out;
		}
J
Jesse Barnes 已提交
1052 1053 1054 1055 1056 1057 1058
	}

	/*
	 * If we didn't get EDID, try checking if the panel is already turned
	 * on.  If so, assume that whatever is currently programmed is the
	 * correct mode.
	 */
1059

1060
	/* Ironlake: FIXME if still fail, not try pipe mode now */
1061
	if (HAS_PCH_SPLIT(dev))
1062 1063
		goto failed;

J
Jesse Barnes 已提交
1064 1065
	lvds = I915_READ(LVDS);
	pipe = (lvds & LVDS_PIPEB_SELECT) ? 1 : 0;
1066
	crtc = intel_get_crtc_for_pipe(dev, pipe);
J
Jesse Barnes 已提交
1067 1068

	if (crtc && (lvds & LVDS_PORT_EN)) {
1069 1070
		fixed_mode = intel_crtc_mode_get(dev, crtc);
		if (fixed_mode) {
1071 1072
			DRM_DEBUG_KMS("using current (BIOS) mode: ");
			drm_mode_debug_printmodeline(fixed_mode);
1073
			fixed_mode->type |= DRM_MODE_TYPE_PREFERRED;
1074
			goto out;
J
Jesse Barnes 已提交
1075 1076 1077 1078
		}
	}

	/* If we still don't have a mode after all that, give up. */
1079
	if (!fixed_mode)
J
Jesse Barnes 已提交
1080 1081 1082
		goto failed;

out:
1083 1084
	mutex_unlock(&dev->mode_config.mutex);

D
Daniel Vetter 已提交
1085
	lvds_encoder->is_dual_link = compute_is_dual_link_lvds(lvds_encoder);
1086 1087 1088
	DRM_DEBUG_KMS("detected %s-link lvds configuration\n",
		      lvds_encoder->is_dual_link ? "dual" : "single");

1089 1090 1091 1092
	/*
	 * Unlock registers and just
	 * leave them unlocked
	 */
1093
	if (HAS_PCH_SPLIT(dev)) {
1094 1095 1096 1097 1098
		I915_WRITE(PCH_PP_CONTROL,
			   I915_READ(PCH_PP_CONTROL) | PANEL_UNLOCK_REGS);
	} else {
		I915_WRITE(PP_CONTROL,
			   I915_READ(PP_CONTROL) | PANEL_UNLOCK_REGS);
1099
	}
1100 1101
	lvds_connector->lid_notifier.notifier_call = intel_lid_notify;
	if (acpi_lid_notifier_register(&lvds_connector->lid_notifier)) {
1102
		DRM_DEBUG_KMS("lid notifier registration failed\n");
1103
		lvds_connector->lid_notifier.notifier_call = NULL;
1104
	}
J
Jesse Barnes 已提交
1105
	drm_sysfs_connector_add(connector);
1106

1107
	intel_panel_init(&intel_connector->panel, fixed_mode, downclock_mode);
1108
	intel_panel_setup_backlight(connector);
1109

1110
	return;
J
Jesse Barnes 已提交
1111 1112

failed:
1113 1114
	mutex_unlock(&dev->mode_config.mutex);

1115
	DRM_DEBUG_KMS("No LVDS modes found, disabling.\n");
J
Jesse Barnes 已提交
1116
	drm_connector_cleanup(connector);
1117
	drm_encoder_cleanup(encoder);
1118
	kfree(lvds_encoder);
1119
	kfree(lvds_connector);
1120
	return;
J
Jesse Barnes 已提交
1121
}