intel_lvds.c 31.8 KB
Newer Older
J
Jesse Barnes 已提交
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29
/*
 * Copyright © 2006-2007 Intel Corporation
 * Copyright (c) 2006 Dave Airlie <airlied@linux.ie>
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
 * to deal in the Software without restriction, including without limitation
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
 * and/or sell copies of the Software, and to permit persons to whom the
 * Software is furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice (including the next
 * paragraph) shall be included in all copies or substantial portions of the
 * Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
 * DEALINGS IN THE SOFTWARE.
 *
 * Authors:
 *	Eric Anholt <eric@anholt.net>
 *      Dave Airlie <airlied@linux.ie>
 *      Jesse Barnes <jesse.barnes@intel.com>
 */

30
#include <acpi/button.h>
31
#include <linux/dmi.h>
J
Jesse Barnes 已提交
32
#include <linux/i2c.h>
33
#include <linux/slab.h>
34 35 36
#include <drm/drmP.h>
#include <drm/drm_crtc.h>
#include <drm/drm_edid.h>
J
Jesse Barnes 已提交
37
#include "intel_drv.h"
38
#include <drm/i915_drm.h>
J
Jesse Barnes 已提交
39
#include "i915_drv.h"
40
#include <linux/acpi.h>
J
Jesse Barnes 已提交
41

42
/* Private structure for the integrated LVDS support */
43 44
struct intel_lvds_connector {
	struct intel_connector base;
45

46
	struct notifier_block lid_notifier;
47 48
};

49
struct intel_lvds_encoder {
C
Chris Wilson 已提交
50
	struct intel_encoder base;
51

52
	bool is_dual_link;
D
Daniel Vetter 已提交
53
	u32 reg;
54

55
	struct intel_lvds_connector *attached_connector;
56 57
};

58
static struct intel_lvds_encoder *to_lvds_encoder(struct drm_encoder *encoder)
C
Chris Wilson 已提交
59
{
60
	return container_of(encoder, struct intel_lvds_encoder, base.base);
C
Chris Wilson 已提交
61 62
}

63
static struct intel_lvds_connector *to_lvds_connector(struct drm_connector *connector)
64
{
65
	return container_of(connector, struct intel_lvds_connector, base.base);
66 67
}

68 69 70 71 72
static bool intel_lvds_get_hw_state(struct intel_encoder *encoder,
				    enum pipe *pipe)
{
	struct drm_device *dev = encoder->base.dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
D
Daniel Vetter 已提交
73 74
	struct intel_lvds_encoder *lvds_encoder = to_lvds_encoder(&encoder->base);
	u32 tmp;
75

D
Daniel Vetter 已提交
76
	tmp = I915_READ(lvds_encoder->reg);
77 78 79 80 81 82 83 84 85 86 87 88

	if (!(tmp & LVDS_PORT_EN))
		return false;

	if (HAS_PCH_CPT(dev))
		*pipe = PORT_TO_PIPE_CPT(tmp);
	else
		*pipe = PORT_TO_PIPE(tmp);

	return true;
}

89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111
static void intel_lvds_get_config(struct intel_encoder *encoder,
				  struct intel_crtc_config *pipe_config)
{
	struct drm_device *dev = encoder->base.dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	u32 lvds_reg, tmp, flags = 0;

	if (HAS_PCH_SPLIT(dev))
		lvds_reg = PCH_LVDS;
	else
		lvds_reg = LVDS;

	tmp = I915_READ(lvds_reg);
	if (tmp & LVDS_HSYNC_POLARITY)
		flags |= DRM_MODE_FLAG_NHSYNC;
	else
		flags |= DRM_MODE_FLAG_PHSYNC;
	if (tmp & LVDS_VSYNC_POLARITY)
		flags |= DRM_MODE_FLAG_NVSYNC;
	else
		flags |= DRM_MODE_FLAG_PVSYNC;

	pipe_config->adjusted_mode.flags |= flags;
112 113 114 115 116 117 118

	/* gen2/3 store dither state in pfit control, needs to match */
	if (INTEL_INFO(dev)->gen < 4) {
		tmp = I915_READ(PFIT_CONTROL);

		pipe_config->gmch_pfit.control |= tmp & PANEL_8TO6_DITHER_ENABLE;
	}
119 120
}

121 122 123 124
/* The LVDS pin pair needs to be on before the DPLLs are enabled.
 * This is an exception to the general rule that mode_set doesn't turn
 * things on.
 */
125
static void intel_pre_enable_lvds(struct intel_encoder *encoder)
126 127 128 129
{
	struct intel_lvds_encoder *lvds_encoder = to_lvds_encoder(&encoder->base);
	struct drm_device *dev = encoder->base.dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
130
	struct intel_crtc *crtc = to_intel_crtc(encoder->base.crtc);
131 132
	const struct drm_display_mode *adjusted_mode =
		&crtc->config.adjusted_mode;
133
	int pipe = crtc->pipe;
134 135
	u32 temp;

136 137 138 139 140 141 142 143
	if (HAS_PCH_SPLIT(dev)) {
		assert_fdi_rx_pll_disabled(dev_priv, pipe);
		assert_shared_dpll_disabled(dev_priv,
					    intel_crtc_to_shared_dpll(crtc));
	} else {
		assert_pll_disabled(dev_priv, pipe);
	}

144 145
	temp = I915_READ(lvds_encoder->reg);
	temp |= LVDS_PORT_EN | LVDS_A0A2_CLKA_POWER_UP;
146 147 148 149

	if (HAS_PCH_CPT(dev)) {
		temp &= ~PORT_TRANS_SEL_MASK;
		temp |= PORT_TRANS_SEL_CPT(pipe);
150
	} else {
151 152 153 154 155
		if (pipe == 1) {
			temp |= LVDS_PIPEB_SELECT;
		} else {
			temp &= ~LVDS_PIPEB_SELECT;
		}
156
	}
157

158
	/* set the corresponsding LVDS_BORDER bit */
159
	temp &= ~LVDS_BORDER_ENABLE;
160
	temp |= crtc->config.gmch_pfit.lvds_border_bits;
161 162 163 164 165 166 167 168 169 170 171 172
	/* Set the B0-B3 data pairs corresponding to whether we're going to
	 * set the DPLLs for dual-channel mode or not.
	 */
	if (lvds_encoder->is_dual_link)
		temp |= LVDS_B0B3_POWER_UP | LVDS_CLKB_POWER_UP;
	else
		temp &= ~(LVDS_B0B3_POWER_UP | LVDS_CLKB_POWER_UP);

	/* It would be nice to set 24 vs 18-bit mode (LVDS_A3_POWER_UP)
	 * appropriately here, but we need to look more thoroughly into how
	 * panels behave in the two modes.
	 */
173 174 175 176 177

	/* Set the dithering flag on LVDS as needed, note that there is no
	 * special lvds dither control bit on pch-split platforms, dithering is
	 * only controlled through the PIPECONF reg. */
	if (INTEL_INFO(dev)->gen == 4) {
178 179
		/* Bspec wording suggests that LVDS port dithering only exists
		 * for 18bpp panels. */
180
		if (crtc->config.dither && crtc->config.pipe_bpp == 18)
181 182 183 184 185
			temp |= LVDS_ENABLE_DITHER;
		else
			temp &= ~LVDS_ENABLE_DITHER;
	}
	temp &= ~(LVDS_HSYNC_POLARITY | LVDS_VSYNC_POLARITY);
186
	if (adjusted_mode->flags & DRM_MODE_FLAG_NHSYNC)
187
		temp |= LVDS_HSYNC_POLARITY;
188
	if (adjusted_mode->flags & DRM_MODE_FLAG_NVSYNC)
189 190 191 192 193
		temp |= LVDS_VSYNC_POLARITY;

	I915_WRITE(lvds_encoder->reg, temp);
}

J
Jesse Barnes 已提交
194 195 196
/**
 * Sets the power state for the panel.
 */
197
static void intel_enable_lvds(struct intel_encoder *encoder)
J
Jesse Barnes 已提交
198
{
199
	struct drm_device *dev = encoder->base.dev;
200
	struct intel_lvds_encoder *lvds_encoder = to_lvds_encoder(&encoder->base);
201
	struct intel_crtc *intel_crtc = to_intel_crtc(encoder->base.crtc);
J
Jesse Barnes 已提交
202
	struct drm_i915_private *dev_priv = dev->dev_private;
D
Daniel Vetter 已提交
203
	u32 ctl_reg, stat_reg;
204

205
	if (HAS_PCH_SPLIT(dev)) {
206
		ctl_reg = PCH_PP_CONTROL;
207
		stat_reg = PCH_PP_STATUS;
208 209
	} else {
		ctl_reg = PP_CONTROL;
210
		stat_reg = PP_STATUS;
211
	}
J
Jesse Barnes 已提交
212

D
Daniel Vetter 已提交
213
	I915_WRITE(lvds_encoder->reg, I915_READ(lvds_encoder->reg) | LVDS_PORT_EN);
214

215
	I915_WRITE(ctl_reg, I915_READ(ctl_reg) | POWER_TARGET_ON);
D
Daniel Vetter 已提交
216
	POSTING_READ(lvds_encoder->reg);
217 218
	if (wait_for((I915_READ(stat_reg) & PP_ON) != 0, 1000))
		DRM_ERROR("timed out waiting for panel to power on\n");
219

220
	intel_panel_enable_backlight(dev, intel_crtc->pipe);
221 222
}

223
static void intel_disable_lvds(struct intel_encoder *encoder)
224
{
225
	struct drm_device *dev = encoder->base.dev;
226
	struct intel_lvds_encoder *lvds_encoder = to_lvds_encoder(&encoder->base);
227
	struct drm_i915_private *dev_priv = dev->dev_private;
D
Daniel Vetter 已提交
228
	u32 ctl_reg, stat_reg;
229 230 231

	if (HAS_PCH_SPLIT(dev)) {
		ctl_reg = PCH_PP_CONTROL;
232
		stat_reg = PCH_PP_STATUS;
233 234
	} else {
		ctl_reg = PP_CONTROL;
235
		stat_reg = PP_STATUS;
236 237
	}

238
	intel_panel_disable_backlight(dev);
239 240

	I915_WRITE(ctl_reg, I915_READ(ctl_reg) & ~POWER_TARGET_ON);
241 242
	if (wait_for((I915_READ(stat_reg) & PP_ON) == 0, 1000))
		DRM_ERROR("timed out waiting for panel to power off\n");
243

D
Daniel Vetter 已提交
244 245
	I915_WRITE(lvds_encoder->reg, I915_READ(lvds_encoder->reg) & ~LVDS_PORT_EN);
	POSTING_READ(lvds_encoder->reg);
J
Jesse Barnes 已提交
246 247 248 249 250
}

static int intel_lvds_mode_valid(struct drm_connector *connector,
				 struct drm_display_mode *mode)
{
251 252
	struct intel_connector *intel_connector = to_intel_connector(connector);
	struct drm_display_mode *fixed_mode = intel_connector->panel.fixed_mode;
J
Jesse Barnes 已提交
253

254 255 256 257
	if (mode->hdisplay > fixed_mode->hdisplay)
		return MODE_PANEL;
	if (mode->vdisplay > fixed_mode->vdisplay)
		return MODE_PANEL;
J
Jesse Barnes 已提交
258 259 260 261

	return MODE_OK;
}

262 263
static bool intel_lvds_compute_config(struct intel_encoder *intel_encoder,
				      struct intel_crtc_config *pipe_config)
J
Jesse Barnes 已提交
264
{
265
	struct drm_device *dev = intel_encoder->base.dev;
J
Jesse Barnes 已提交
266
	struct drm_i915_private *dev_priv = dev->dev_private;
267 268
	struct intel_lvds_encoder *lvds_encoder =
		to_lvds_encoder(&intel_encoder->base);
269 270
	struct intel_connector *intel_connector =
		&lvds_encoder->attached_connector->base;
271
	struct drm_display_mode *adjusted_mode = &pipe_config->adjusted_mode;
272
	struct intel_crtc *intel_crtc = lvds_encoder->base.new_crtc;
273
	unsigned int lvds_bpp;
J
Jesse Barnes 已提交
274 275

	/* Should never happen!! */
276
	if (INTEL_INFO(dev)->gen < 4 && intel_crtc->pipe == 0) {
277
		DRM_ERROR("Can't support LVDS on pipe A\n");
J
Jesse Barnes 已提交
278 279 280
		return false;
	}

281 282 283 284 285 286
	if ((I915_READ(lvds_encoder->reg) & LVDS_A3_POWER_MASK) ==
	    LVDS_A3_POWER_UP)
		lvds_bpp = 8*3;
	else
		lvds_bpp = 6*3;

287
	if (lvds_bpp != pipe_config->pipe_bpp && !pipe_config->bw_constrained) {
288 289 290 291
		DRM_DEBUG_KMS("forcing display bpp (was %d) to LVDS (%d)\n",
			      pipe_config->pipe_bpp, lvds_bpp);
		pipe_config->pipe_bpp = lvds_bpp;
	}
292

J
Jesse Barnes 已提交
293
	/*
294
	 * We have timings from the BIOS for the panel, put them in
J
Jesse Barnes 已提交
295 296 297 298
	 * to the adjusted mode.  The CRTC will be set up for this mode,
	 * with the panel scaling set up to source from the H/VDisplay
	 * of the original mode.
	 */
299
	intel_fixed_panel_mode(intel_connector->panel.fixed_mode,
300
			       adjusted_mode);
301 302

	if (HAS_PCH_SPLIT(dev)) {
303 304
		pipe_config->has_pch_encoder = true;

305 306
		intel_pch_panel_fitting(intel_crtc, pipe_config,
					intel_connector->panel.fitting_mode);
307 308 309
	} else {
		intel_gmch_panel_fitting(intel_crtc, pipe_config,
					 intel_connector->panel.fitting_mode);
J
Jesse Barnes 已提交
310

311
	}
312

J
Jesse Barnes 已提交
313 314 315 316 317 318 319 320 321
	/*
	 * XXX: It would be nice to support lower refresh rates on the
	 * panels to reduce power consumption, and perhaps match the
	 * user's requested refresh rate.
	 */

	return true;
}

322
static void intel_lvds_mode_set(struct intel_encoder *encoder)
J
Jesse Barnes 已提交
323 324
{
	/*
325 326 327
	 * We don't do anything here, the LVDS port is fully set up in the pre
	 * enable hook - the ordering constraints for enabling the lvds port vs.
	 * enabling the display pll are too strict.
J
Jesse Barnes 已提交
328 329 330 331 332 333
	 */
}

/**
 * Detect the LVDS connection.
 *
334 335 336
 * Since LVDS doesn't have hotlug, we use the lid as a proxy.  Open means
 * connected and closed means disconnected.  We also send hotplug events as
 * needed, using lid status notification from the input layer.
J
Jesse Barnes 已提交
337
 */
338
static enum drm_connector_status
339
intel_lvds_detect(struct drm_connector *connector, bool force)
J
Jesse Barnes 已提交
340
{
341
	struct drm_device *dev = connector->dev;
342
	enum drm_connector_status status;
343

344 345 346
	DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n",
		      connector->base.id, drm_get_connector_name(connector));

347 348 349
	status = intel_panel_detect(dev);
	if (status != connector_status_unknown)
		return status;
350

351
	return connector_status_connected;
J
Jesse Barnes 已提交
352 353 354 355 356 357 358
}

/**
 * Return the list of DDC modes if available, or the BIOS fixed mode otherwise.
 */
static int intel_lvds_get_modes(struct drm_connector *connector)
{
359
	struct intel_lvds_connector *lvds_connector = to_lvds_connector(connector);
J
Jesse Barnes 已提交
360
	struct drm_device *dev = connector->dev;
361
	struct drm_display_mode *mode;
J
Jesse Barnes 已提交
362

363
	/* use cached edid if we have one */
364
	if (!IS_ERR_OR_NULL(lvds_connector->base.edid))
365
		return drm_add_edid_modes(connector, lvds_connector->base.edid);
J
Jesse Barnes 已提交
366

367
	mode = drm_mode_duplicate(dev, lvds_connector->base.panel.fixed_mode);
C
Chris Wilson 已提交
368
	if (mode == NULL)
369
		return 0;
J
Jesse Barnes 已提交
370

371 372
	drm_mode_probed_add(connector, mode);
	return 1;
J
Jesse Barnes 已提交
373 374
}

375 376
static int intel_no_modeset_on_lid_dmi_callback(const struct dmi_system_id *id)
{
377
	DRM_INFO("Skipping forced modeset for %s\n", id->ident);
378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394
	return 1;
}

/* The GPU hangs up on these systems if modeset is performed on LID open */
static const struct dmi_system_id intel_no_modeset_on_lid[] = {
	{
		.callback = intel_no_modeset_on_lid_dmi_callback,
		.ident = "Toshiba Tecra A11",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
			DMI_MATCH(DMI_PRODUCT_NAME, "TECRA A11"),
		},
	},

	{ }	/* terminating entry */
};

395
/*
396 397 398
 * Lid events. Note the use of 'modeset':
 *  - we set it to MODESET_ON_LID_OPEN on lid close,
 *    and set it to MODESET_DONE on open
399
 *  - we use it as a "only once" bit (ie we ignore
400 401 402 403
 *    duplicate events where it was already properly set)
 *  - the suspend/resume paths will set it to
 *    MODESET_SUSPENDED and ignore the lid open event,
 *    because they restore the mode ("lid open").
404
 */
405 406 407
static int intel_lid_notify(struct notifier_block *nb, unsigned long val,
			    void *unused)
{
408 409 410 411 412
	struct intel_lvds_connector *lvds_connector =
		container_of(nb, struct intel_lvds_connector, lid_notifier);
	struct drm_connector *connector = &lvds_connector->base.base;
	struct drm_device *dev = connector->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
413

414 415 416
	if (dev->switch_power_state != DRM_SWITCH_POWER_ON)
		return NOTIFY_OK;

417 418 419
	mutex_lock(&dev_priv->modeset_restore_lock);
	if (dev_priv->modeset_restore == MODESET_SUSPENDED)
		goto exit;
420 421 422 423
	/*
	 * check and update the status of LVDS connector after receiving
	 * the LID nofication event.
	 */
424
	connector->status = connector->funcs->detect(connector, false);
425

426 427
	/* Don't force modeset on machines where it causes a GPU lockup */
	if (dmi_check_system(intel_no_modeset_on_lid))
428
		goto exit;
429
	if (!acpi_lid_open()) {
430 431 432
		/* do modeset on next lid open event */
		dev_priv->modeset_restore = MODESET_ON_LID_OPEN;
		goto exit;
433
	}
434

435 436
	if (dev_priv->modeset_restore == MODESET_DONE)
		goto exit;
437

438
	drm_modeset_lock_all(dev);
439
	intel_modeset_setup_hw_state(dev, true);
440
	drm_modeset_unlock_all(dev);
441

442 443 444 445
	dev_priv->modeset_restore = MODESET_DONE;

exit:
	mutex_unlock(&dev_priv->modeset_restore_lock);
446 447 448
	return NOTIFY_OK;
}

J
Jesse Barnes 已提交
449 450 451 452 453 454 455 456 457
/**
 * intel_lvds_destroy - unregister and free LVDS structures
 * @connector: connector to free
 *
 * Unregister the DDC bus for this connector then free the driver private
 * structure.
 */
static void intel_lvds_destroy(struct drm_connector *connector)
{
458 459
	struct intel_lvds_connector *lvds_connector =
		to_lvds_connector(connector);
J
Jesse Barnes 已提交
460

461 462
	if (lvds_connector->lid_notifier.notifier_call)
		acpi_lid_notifier_unregister(&lvds_connector->lid_notifier);
J
Jesse Barnes 已提交
463

464 465 466
	if (!IS_ERR_OR_NULL(lvds_connector->base.edid))
		kfree(lvds_connector->base.edid);

467
	intel_panel_fini(&lvds_connector->base.panel);
468

J
Jesse Barnes 已提交
469 470 471 472 473
	drm_sysfs_connector_remove(connector);
	drm_connector_cleanup(connector);
	kfree(connector);
}

474 475 476 477
static int intel_lvds_set_property(struct drm_connector *connector,
				   struct drm_property *property,
				   uint64_t value)
{
478
	struct intel_connector *intel_connector = to_intel_connector(connector);
479 480
	struct drm_device *dev = connector->dev;

481
	if (property == dev->mode_config.scaling_mode_property) {
482
		struct drm_crtc *crtc;
483

484 485
		if (value == DRM_MODE_SCALE_NONE) {
			DRM_DEBUG_KMS("no scaling not supported\n");
486
			return -EINVAL;
487
		}
488

489
		if (intel_connector->panel.fitting_mode == value) {
490 491 492
			/* the LVDS scaling property is not changed */
			return 0;
		}
493
		intel_connector->panel.fitting_mode = value;
494 495

		crtc = intel_attached_encoder(connector)->base.crtc;
496 497 498 499 500
		if (crtc && crtc->enabled) {
			/*
			 * If the CRTC is enabled, the display will be changed
			 * according to the new panel fitting mode.
			 */
501
			intel_crtc_restore_mode(crtc);
502 503 504
		}
	}

505 506 507
	return 0;
}

J
Jesse Barnes 已提交
508 509 510
static const struct drm_connector_helper_funcs intel_lvds_connector_helper_funcs = {
	.get_modes = intel_lvds_get_modes,
	.mode_valid = intel_lvds_mode_valid,
511
	.best_encoder = intel_best_encoder,
J
Jesse Barnes 已提交
512 513 514
};

static const struct drm_connector_funcs intel_lvds_connector_funcs = {
515
	.dpms = intel_connector_dpms,
J
Jesse Barnes 已提交
516 517
	.detect = intel_lvds_detect,
	.fill_modes = drm_helper_probe_single_connector_modes,
518
	.set_property = intel_lvds_set_property,
J
Jesse Barnes 已提交
519 520 521 522
	.destroy = intel_lvds_destroy,
};

static const struct drm_encoder_funcs intel_lvds_enc_funcs = {
C
Chris Wilson 已提交
523
	.destroy = intel_encoder_destroy,
J
Jesse Barnes 已提交
524 525
};

526 527
static int __init intel_no_lvds_dmi_callback(const struct dmi_system_id *id)
{
528
	DRM_INFO("Skipping LVDS initialization for %s\n", id->ident);
529 530
	return 1;
}
J
Jesse Barnes 已提交
531

532
/* These systems claim to have LVDS, but really don't */
533
static const struct dmi_system_id intel_no_lvds[] = {
534 535 536 537
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Apple Mac Mini (Core series)",
		.matches = {
538
			DMI_MATCH(DMI_SYS_VENDOR, "Apple"),
539 540 541 542 543 544 545
			DMI_MATCH(DMI_PRODUCT_NAME, "Macmini1,1"),
		},
	},
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Apple Mac Mini (Core 2 series)",
		.matches = {
546
			DMI_MATCH(DMI_SYS_VENDOR, "Apple"),
547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565
			DMI_MATCH(DMI_PRODUCT_NAME, "Macmini2,1"),
		},
	},
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "MSI IM-945GSE-A",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "MSI"),
			DMI_MATCH(DMI_PRODUCT_NAME, "A9830IMS"),
		},
	},
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Dell Studio Hybrid",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
			DMI_MATCH(DMI_PRODUCT_NAME, "Studio Hybrid 140g"),
		},
	},
566 567
	{
		.callback = intel_no_lvds_dmi_callback,
568 569 570 571 572 573 574 575
		.ident = "Dell OptiPlex FX170",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
			DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex FX170"),
		},
	},
	{
		.callback = intel_no_lvds_dmi_callback,
576 577 578 579 580 581
		.ident = "AOpen Mini PC",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "AOpen"),
			DMI_MATCH(DMI_PRODUCT_NAME, "i965GMx-IF"),
		},
	},
582 583 584 585 586 587 588 589
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "AOpen Mini PC MP915",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "AOpen"),
			DMI_MATCH(DMI_BOARD_NAME, "i915GMx-F"),
		},
	},
590 591 592 593 594 595 596 597
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "AOpen i915GMm-HFS",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "AOpen"),
			DMI_MATCH(DMI_BOARD_NAME, "i915GMm-HFS"),
		},
	},
598 599 600 601 602 603 604 605
	{
		.callback = intel_no_lvds_dmi_callback,
                .ident = "AOpen i45GMx-I",
                .matches = {
                        DMI_MATCH(DMI_BOARD_VENDOR, "AOpen"),
                        DMI_MATCH(DMI_BOARD_NAME, "i45GMx-I"),
                },
        },
606 607 608 609 610 611 612
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Aopen i945GTt-VFA",
		.matches = {
			DMI_MATCH(DMI_PRODUCT_VERSION, "AO00001JW"),
		},
	},
613 614 615 616 617 618 619 620
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Clientron U800",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "Clientron"),
			DMI_MATCH(DMI_PRODUCT_NAME, "U800"),
		},
	},
621
	{
622 623 624 625 626 627 628 629
                .callback = intel_no_lvds_dmi_callback,
                .ident = "Clientron E830",
                .matches = {
                        DMI_MATCH(DMI_SYS_VENDOR, "Clientron"),
                        DMI_MATCH(DMI_PRODUCT_NAME, "E830"),
                },
        },
        {
630 631 632 633 634 635 636
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Asus EeeBox PC EB1007",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK Computer INC."),
			DMI_MATCH(DMI_PRODUCT_NAME, "EB1007"),
		},
	},
637 638 639 640 641 642 643 644
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Asus AT5NM10T-I",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
			DMI_MATCH(DMI_BOARD_NAME, "AT5NM10T-I"),
		},
	},
645 646
	{
		.callback = intel_no_lvds_dmi_callback,
647
		.ident = "Hewlett-Packard HP t5740",
648 649
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"),
650
			DMI_MATCH(DMI_PRODUCT_NAME, " t5740"),
651 652
		},
	},
653 654 655 656 657
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Hewlett-Packard t5745",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"),
658
			DMI_MATCH(DMI_PRODUCT_NAME, "hp t5745"),
659 660 661 662 663 664 665
		},
	},
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Hewlett-Packard st5747",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"),
666
			DMI_MATCH(DMI_PRODUCT_NAME, "hp st5747"),
667 668
		},
	},
669 670 671 672 673 674 675 676
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "MSI Wind Box DC500",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "MICRO-STAR INTERNATIONAL CO., LTD"),
			DMI_MATCH(DMI_BOARD_NAME, "MS-7469"),
		},
	},
677 678 679 680 681 682 683 684
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Gigabyte GA-D525TUD",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "Gigabyte Technology Co., Ltd."),
			DMI_MATCH(DMI_BOARD_NAME, "D525TUD"),
		},
	},
685 686 687 688 689 690 691 692
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Supermicro X7SPA-H",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "Supermicro"),
			DMI_MATCH(DMI_PRODUCT_NAME, "X7SPA-H"),
		},
	},
693 694 695 696 697 698 699 700
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Fujitsu Esprimo Q900",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
			DMI_MATCH(DMI_PRODUCT_NAME, "ESPRIMO Q900"),
		},
	},
701 702 703 704 705 706 707 708
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Intel D510MO",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "Intel"),
			DMI_EXACT_MATCH(DMI_BOARD_NAME, "D510MO"),
		},
	},
709 710 711 712 713 714 715 716
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Intel D525MW",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "Intel"),
			DMI_EXACT_MATCH(DMI_BOARD_NAME, "D525MW"),
		},
	},
717 718 719

	{ }	/* terminating entry */
};
J
Jesse Barnes 已提交
720

721 722 723 724 725 726 727 728
/**
 * intel_find_lvds_downclock - find the reduced downclock for LVDS in EDID
 * @dev: drm device
 * @connector: LVDS connector
 *
 * Find the reduced downclock for LVDS in EDID.
 */
static void intel_find_lvds_downclock(struct drm_device *dev,
729 730
				      struct drm_display_mode *fixed_mode,
				      struct drm_connector *connector)
731 732
{
	struct drm_i915_private *dev_priv = dev->dev_private;
733
	struct drm_display_mode *scan;
734 735
	int temp_downclock;

736
	temp_downclock = fixed_mode->clock;
737 738 739 740 741 742 743 744
	list_for_each_entry(scan, &connector->probed_modes, head) {
		/*
		 * If one mode has the same resolution with the fixed_panel
		 * mode while they have the different refresh rate, it means
		 * that the reduced downclock is found for the LVDS. In such
		 * case we can set the different FPx0/1 to dynamically select
		 * between low and high frequency.
		 */
745 746 747 748 749 750 751 752
		if (scan->hdisplay == fixed_mode->hdisplay &&
		    scan->hsync_start == fixed_mode->hsync_start &&
		    scan->hsync_end == fixed_mode->hsync_end &&
		    scan->htotal == fixed_mode->htotal &&
		    scan->vdisplay == fixed_mode->vdisplay &&
		    scan->vsync_start == fixed_mode->vsync_start &&
		    scan->vsync_end == fixed_mode->vsync_end &&
		    scan->vtotal == fixed_mode->vtotal) {
753 754 755 756 757 758 759 760 761
			if (scan->clock < temp_downclock) {
				/*
				 * The downclock is already found. But we
				 * expect to find the lower downclock.
				 */
				temp_downclock = scan->clock;
			}
		}
	}
762
	if (temp_downclock < fixed_mode->clock && i915_lvds_downclock) {
763 764 765 766
		/* We found the downclock for LVDS. */
		dev_priv->lvds_downclock_avail = 1;
		dev_priv->lvds_downclock = temp_downclock;
		DRM_DEBUG_KMS("LVDS downclock is found in EDID. "
767 768
			      "Normal clock %dKhz, downclock %dKhz\n",
			      fixed_mode->clock, temp_downclock);
769 770 771
	}
}

772 773 774 775 776 777 778
/*
 * Enumerate the child dev array parsed from VBT to check whether
 * the LVDS is present.
 * If it is present, return 1.
 * If it is not present, return false.
 * If no child dev is parsed from VBT, it assumes that the LVDS is present.
 */
779 780
static bool lvds_is_present_in_vbt(struct drm_device *dev,
				   u8 *i2c_pin)
781 782
{
	struct drm_i915_private *dev_priv = dev->dev_private;
783
	int i;
784

785
	if (!dev_priv->vbt.child_dev_num)
786
		return true;
787

788 789
	for (i = 0; i < dev_priv->vbt.child_dev_num; i++) {
		struct child_device_config *child = dev_priv->vbt.child_dev + i;
790 791 792 793

		/* If the device type is not LFP, continue.
		 * We have to check both the new identifiers as well as the
		 * old for compatibility with some BIOSes.
794
		 */
795 796
		if (child->device_type != DEVICE_TYPE_INT_LFP &&
		    child->device_type != DEVICE_TYPE_LFP)
797 798
			continue;

799 800
		if (intel_gmbus_is_port_valid(child->i2c_pin))
			*i2c_pin = child->i2c_pin;
801

802 803 804 805
		/* However, we cannot trust the BIOS writers to populate
		 * the VBT correctly.  Since LVDS requires additional
		 * information from AIM blocks, a non-zero addin offset is
		 * a good indicator that the LVDS is actually present.
806
		 */
807 808 809 810 811 812 813 814 815 816
		if (child->addin_offset)
			return true;

		/* But even then some BIOS writers perform some black magic
		 * and instantiate the device without reference to any
		 * additional data.  Trust that if the VBT was written into
		 * the OpRegion then they have validated the LVDS's existence.
		 */
		if (dev_priv->opregion.vbt)
			return true;
817
	}
818 819

	return false;
820 821
}

822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840
static int intel_dual_link_lvds_callback(const struct dmi_system_id *id)
{
	DRM_INFO("Forcing lvds to dual link mode on %s\n", id->ident);
	return 1;
}

static const struct dmi_system_id intel_dual_link_lvds[] = {
	{
		.callback = intel_dual_link_lvds_callback,
		.ident = "Apple MacBook Pro (Core i5/i7 Series)",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."),
			DMI_MATCH(DMI_PRODUCT_NAME, "MacBookPro8,2"),
		},
	},
	{ }	/* terminating entry */
};

bool intel_is_dual_link_lvds(struct drm_device *dev)
841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856
{
	struct intel_encoder *encoder;
	struct intel_lvds_encoder *lvds_encoder;

	list_for_each_entry(encoder, &dev->mode_config.encoder_list,
			    base.head) {
		if (encoder->type == INTEL_OUTPUT_LVDS) {
			lvds_encoder = to_lvds_encoder(&encoder->base);

			return lvds_encoder->is_dual_link;
		}
	}

	return false;
}

D
Daniel Vetter 已提交
857
static bool compute_is_dual_link_lvds(struct intel_lvds_encoder *lvds_encoder)
858
{
D
Daniel Vetter 已提交
859
	struct drm_device *dev = lvds_encoder->base.base.dev;
860 861 862 863 864 865 866 867 868 869
	unsigned int val;
	struct drm_i915_private *dev_priv = dev->dev_private;

	/* use the module option value if specified */
	if (i915_lvds_channel_mode > 0)
		return i915_lvds_channel_mode == 2;

	if (dmi_check_system(intel_dual_link_lvds))
		return true;

870 871 872 873 874
	/* BIOS should set the proper LVDS register value at boot, but
	 * in reality, it doesn't set the value when the lid is closed;
	 * we need to check "the value to be set" in VBT when LVDS
	 * register is uninitialized.
	 */
D
Daniel Vetter 已提交
875
	val = I915_READ(lvds_encoder->reg);
876
	if (!(val & ~(LVDS_PIPE_MASK | LVDS_DETECTED)))
877
		val = dev_priv->vbt.bios_lvds_val;
878

879 880 881
	return (val & LVDS_CLKB_POWER_MASK) == LVDS_CLKB_POWER_UP;
}

882 883 884 885
static bool intel_lvds_supported(struct drm_device *dev)
{
	/* With the introduction of the PCH we gained a dedicated
	 * LVDS presence pin, use it. */
886
	if (HAS_PCH_IBX(dev) || HAS_PCH_CPT(dev))
887 888 889 890
		return true;

	/* Otherwise LVDS was only attached to mobile products,
	 * except for the inglorious 830gm */
891 892 893 894
	if (INTEL_INFO(dev)->gen <= 4 && IS_MOBILE(dev) && !IS_I830(dev))
		return true;

	return false;
895 896
}

J
Jesse Barnes 已提交
897 898 899 900 901 902 903
/**
 * intel_lvds_init - setup LVDS connectors on this device
 * @dev: drm device
 *
 * Create the connector, register the LVDS DDC bus, and try to figure out what
 * modes we can display on the LVDS panel (if present).
 */
904
void intel_lvds_init(struct drm_device *dev)
J
Jesse Barnes 已提交
905 906
{
	struct drm_i915_private *dev_priv = dev->dev_private;
907
	struct intel_lvds_encoder *lvds_encoder;
908
	struct intel_encoder *intel_encoder;
909
	struct intel_lvds_connector *lvds_connector;
910
	struct intel_connector *intel_connector;
J
Jesse Barnes 已提交
911 912 913
	struct drm_connector *connector;
	struct drm_encoder *encoder;
	struct drm_display_mode *scan; /* *modes, *bios_mode; */
914
	struct drm_display_mode *fixed_mode = NULL;
915
	struct edid *edid;
J
Jesse Barnes 已提交
916 917
	struct drm_crtc *crtc;
	u32 lvds;
918 919
	int pipe;
	u8 pin;
J
Jesse Barnes 已提交
920

921
	if (!intel_lvds_supported(dev))
922
		return;
923

924 925
	/* Skip init on machines we know falsely report LVDS */
	if (dmi_check_system(intel_no_lvds))
926
		return;
927

928 929
	pin = GMBUS_PORT_PANEL;
	if (!lvds_is_present_in_vbt(dev, &pin)) {
930
		DRM_DEBUG_KMS("LVDS is not present in VBT\n");
931
		return;
A
Adam Jackson 已提交
932
	}
933

934
	if (HAS_PCH_SPLIT(dev)) {
935
		if ((I915_READ(PCH_LVDS) & LVDS_DETECTED) == 0)
936
			return;
937
		if (dev_priv->vbt.edp_support) {
938
			DRM_DEBUG_KMS("disable LVDS for eDP support\n");
939
			return;
940
		}
941 942
	}

943 944
	lvds_encoder = kzalloc(sizeof(struct intel_lvds_encoder), GFP_KERNEL);
	if (!lvds_encoder)
945
		return;
J
Jesse Barnes 已提交
946

947 948
	lvds_connector = kzalloc(sizeof(struct intel_lvds_connector), GFP_KERNEL);
	if (!lvds_connector) {
949
		kfree(lvds_encoder);
950
		return;
951 952
	}

953 954
	lvds_encoder->attached_connector = lvds_connector;

955
	intel_encoder = &lvds_encoder->base;
956
	encoder = &intel_encoder->base;
957
	intel_connector = &lvds_connector->base;
C
Chris Wilson 已提交
958
	connector = &intel_connector->base;
959
	drm_connector_init(dev, &intel_connector->base, &intel_lvds_connector_funcs,
J
Jesse Barnes 已提交
960 961
			   DRM_MODE_CONNECTOR_LVDS);

962
	drm_encoder_init(dev, &intel_encoder->base, &intel_lvds_enc_funcs,
J
Jesse Barnes 已提交
963 964
			 DRM_MODE_ENCODER_LVDS);

965
	intel_encoder->enable = intel_enable_lvds;
966
	intel_encoder->pre_enable = intel_pre_enable_lvds;
967
	intel_encoder->compute_config = intel_lvds_compute_config;
968
	intel_encoder->mode_set = intel_lvds_mode_set;
969
	intel_encoder->disable = intel_disable_lvds;
970
	intel_encoder->get_hw_state = intel_lvds_get_hw_state;
971
	intel_encoder->get_config = intel_lvds_get_config;
972
	intel_connector->get_hw_state = intel_connector_get_hw_state;
973

974
	intel_connector_attach_encoder(intel_connector, intel_encoder);
975
	intel_encoder->type = INTEL_OUTPUT_LVDS;
J
Jesse Barnes 已提交
976

977
	intel_encoder->cloneable = false;
J
Jesse Barnes 已提交
978 979
	if (HAS_PCH_SPLIT(dev))
		intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
980 981
	else if (IS_GEN4(dev))
		intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
J
Jesse Barnes 已提交
982 983 984
	else
		intel_encoder->crtc_mask = (1 << 1);

J
Jesse Barnes 已提交
985 986 987 988 989
	drm_connector_helper_add(connector, &intel_lvds_connector_helper_funcs);
	connector->display_info.subpixel_order = SubPixelHorizontalRGB;
	connector->interlace_allowed = false;
	connector->doublescan_allowed = false;

D
Daniel Vetter 已提交
990 991 992 993 994 995
	if (HAS_PCH_SPLIT(dev)) {
		lvds_encoder->reg = PCH_LVDS;
	} else {
		lvds_encoder->reg = LVDS;
	}

996 997
	/* create the scaling mode property */
	drm_mode_create_scaling_mode_property(dev);
998
	drm_object_attach_property(&connector->base,
999
				      dev->mode_config.scaling_mode_property,
1000
				      DRM_MODE_SCALE_ASPECT);
1001
	intel_connector->panel.fitting_mode = DRM_MODE_SCALE_ASPECT;
J
Jesse Barnes 已提交
1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015
	/*
	 * LVDS discovery:
	 * 1) check for EDID on DDC
	 * 2) check for VBT data
	 * 3) check to see if LVDS is already on
	 *    if none of the above, no panel
	 * 4) make sure lid is open
	 *    if closed, act like it's not there for now
	 */

	/*
	 * Attempt to get the fixed panel mode from DDC.  Assume that the
	 * preferred mode is the right one.
	 */
1016 1017 1018
	edid = drm_get_edid(connector, intel_gmbus_get_adapter(dev_priv, pin));
	if (edid) {
		if (drm_add_edid_modes(connector, edid)) {
1019
			drm_mode_connector_update_edid_property(connector,
1020
								edid);
1021
		} else {
1022 1023
			kfree(edid);
			edid = ERR_PTR(-EINVAL);
1024
		}
1025 1026
	} else {
		edid = ERR_PTR(-ENOENT);
1027
	}
1028 1029 1030
	lvds_connector->base.edid = edid;

	if (IS_ERR_OR_NULL(edid)) {
1031 1032 1033 1034 1035 1036 1037 1038 1039
		/* Didn't get an EDID, so
		 * Set wide sync ranges so we get all modes
		 * handed to valid_mode for checking
		 */
		connector->display_info.min_vfreq = 0;
		connector->display_info.max_vfreq = 200;
		connector->display_info.min_hfreq = 0;
		connector->display_info.max_hfreq = 200;
	}
J
Jesse Barnes 已提交
1040 1041 1042

	list_for_each_entry(scan, &connector->probed_modes, head) {
		if (scan->type & DRM_MODE_TYPE_PREFERRED) {
1043 1044 1045
			DRM_DEBUG_KMS("using preferred mode from EDID: ");
			drm_mode_debug_printmodeline(scan);

1046
			fixed_mode = drm_mode_duplicate(dev, scan);
1047 1048 1049 1050 1051
			if (fixed_mode) {
				intel_find_lvds_downclock(dev, fixed_mode,
							  connector);
				goto out;
			}
J
Jesse Barnes 已提交
1052 1053 1054 1055
		}
	}

	/* Failed to get EDID, what about VBT? */
1056
	if (dev_priv->vbt.lfp_lvds_vbt_mode) {
1057
		DRM_DEBUG_KMS("using mode from VBT: ");
1058
		drm_mode_debug_printmodeline(dev_priv->vbt.lfp_lvds_vbt_mode);
1059

1060
		fixed_mode = drm_mode_duplicate(dev, dev_priv->vbt.lfp_lvds_vbt_mode);
1061 1062
		if (fixed_mode) {
			fixed_mode->type |= DRM_MODE_TYPE_PREFERRED;
1063 1064
			goto out;
		}
J
Jesse Barnes 已提交
1065 1066 1067 1068 1069 1070 1071
	}

	/*
	 * If we didn't get EDID, try checking if the panel is already turned
	 * on.  If so, assume that whatever is currently programmed is the
	 * correct mode.
	 */
1072

1073
	/* Ironlake: FIXME if still fail, not try pipe mode now */
1074
	if (HAS_PCH_SPLIT(dev))
1075 1076
		goto failed;

J
Jesse Barnes 已提交
1077 1078
	lvds = I915_READ(LVDS);
	pipe = (lvds & LVDS_PIPEB_SELECT) ? 1 : 0;
1079
	crtc = intel_get_crtc_for_pipe(dev, pipe);
J
Jesse Barnes 已提交
1080 1081

	if (crtc && (lvds & LVDS_PORT_EN)) {
1082 1083
		fixed_mode = intel_crtc_mode_get(dev, crtc);
		if (fixed_mode) {
1084 1085
			DRM_DEBUG_KMS("using current (BIOS) mode: ");
			drm_mode_debug_printmodeline(fixed_mode);
1086
			fixed_mode->type |= DRM_MODE_TYPE_PREFERRED;
1087
			goto out;
J
Jesse Barnes 已提交
1088 1089 1090 1091
		}
	}

	/* If we still don't have a mode after all that, give up. */
1092
	if (!fixed_mode)
J
Jesse Barnes 已提交
1093 1094 1095
		goto failed;

out:
D
Daniel Vetter 已提交
1096
	lvds_encoder->is_dual_link = compute_is_dual_link_lvds(lvds_encoder);
1097 1098 1099
	DRM_DEBUG_KMS("detected %s-link lvds configuration\n",
		      lvds_encoder->is_dual_link ? "dual" : "single");

1100 1101 1102 1103
	/*
	 * Unlock registers and just
	 * leave them unlocked
	 */
1104
	if (HAS_PCH_SPLIT(dev)) {
1105 1106 1107 1108 1109
		I915_WRITE(PCH_PP_CONTROL,
			   I915_READ(PCH_PP_CONTROL) | PANEL_UNLOCK_REGS);
	} else {
		I915_WRITE(PP_CONTROL,
			   I915_READ(PP_CONTROL) | PANEL_UNLOCK_REGS);
1110
	}
1111 1112
	lvds_connector->lid_notifier.notifier_call = intel_lid_notify;
	if (acpi_lid_notifier_register(&lvds_connector->lid_notifier)) {
1113
		DRM_DEBUG_KMS("lid notifier registration failed\n");
1114
		lvds_connector->lid_notifier.notifier_call = NULL;
1115
	}
J
Jesse Barnes 已提交
1116
	drm_sysfs_connector_add(connector);
1117

1118
	intel_panel_init(&intel_connector->panel, fixed_mode);
1119
	intel_panel_setup_backlight(connector);
1120

1121
	return;
J
Jesse Barnes 已提交
1122 1123

failed:
1124
	DRM_DEBUG_KMS("No LVDS modes found, disabling.\n");
J
Jesse Barnes 已提交
1125
	drm_connector_cleanup(connector);
1126
	drm_encoder_cleanup(encoder);
1127 1128
	if (fixed_mode)
		drm_mode_destroy(dev, fixed_mode);
1129
	kfree(lvds_encoder);
1130
	kfree(lvds_connector);
1131
	return;
J
Jesse Barnes 已提交
1132
}