1. 27 2月, 2014 5 次提交
  2. 15 2月, 2014 1 次提交
  3. 11 2月, 2014 1 次提交
  4. 07 1月, 2014 1 次提交
  5. 25 12月, 2013 1 次提交
    • M
      hw: cannot_instantiate_with_device_add_yet due to pointer props · 1b111dc1
      Markus Armbruster 提交于
      Pointer properties can be set only by code, not by device_add.  A
      device with a pointer property can work with device_add only when the
      property may remain null.
      
      This is the case for property "interrupt_vector" of device
      "etraxfs,pic".  Add a comment there.
      
      Set cannot_instantiate_with_device_add_yet for the other devices with
      pointer properties, with a comment explaining why.
      
      Juha Riihimäki and Peter Maydell deserve my thanks for making "pointer
      property must not remain null" blatantly obvious in the OMAP devices.
      
      Only device "smbus-eeprom" is actually changed.  The others are all
      sysbus devices, which get cannot_instantiate_with_device_add_yet set
      in their abstract base's class init function.  Setting it again in
      their class init function is technically redundant, but serves as
      insurance for when sysbus devices become available with device_add,
      and as documentation.
      Signed-off-by: NMarkus Armbruster <armbru@redhat.com>
      Reviewed-by: Edgar E. Iglesias <edgar.iglesias@gmail.com> (for ETRAX)
      Signed-off-by: NAndreas Färber <afaerber@suse.de>
      1b111dc1
  6. 23 12月, 2013 2 次提交
    • M
      sysbus: Set cannot_instantiate_with_device_add_yet · 837d3716
      Markus Armbruster 提交于
      device_add plugs devices into suitable bus.  For "real" buses, that
      actually connects the device.  For sysbus, the connections need to be
      made separately, and device_add can't do that.  The device would be
      left unconnected, and could not possibly work.
      
      Quite a few, but not all sysbus devices already set
      cannot_instantiate_with_device_add_yet in their class init function.
      
      Set it in their abstract base's class init function
      sysbus_device_class_init(), and remove the now redundant assignments
      from device class init functions.
      Signed-off-by: NMarkus Armbruster <armbru@redhat.com>
      Reviewed-by: NMarcel Apfelbaum <marcel.a@redhat.com>
      Signed-off-by: NAndreas Färber <afaerber@suse.de>
      837d3716
    • M
      qdev: Replace no_user by cannot_instantiate_with_device_add_yet · efec3dd6
      Markus Armbruster 提交于
      In an ideal world, machines can be built by wiring devices together
      with configuration, not code.  Unfortunately, that's not the world we
      live in right now.  We still have quite a few devices that need to be
      wired up by code.  If you try to device_add such a device, it'll fail
      in sometimes mysterious ways.  If you're lucky, you get an
      unmysterious immediate crash.
      
      To protect users from such badness, DeviceClass member no_user used to
      make device models unavailable with -device / device_add, but that
      regressed in commit 18b6dade.  The device model is still omitted from
      help, but is available anyway.
      
      Attempts to fix the regression have been rejected with the argument
      that the purpose of no_user isn't clear, and it's prone to misuse.
      
      This commit clarifies no_user's purpose.  Anthony suggested to rename
      it cannot_instantiate_with_device_add_yet_due_to_internal_bugs, which
      I shorten somewhat to keep checkpatch happy.  While there, make it
      bool.
      
      Every use of cannot_instantiate_with_device_add_yet gets a FIXME
      comment asking for rationale.  The next few commits will clean them
      all up, either by providing a rationale, or by getting rid of the use.
      
      With that done, the regression fix is hopefully acceptable.
      Signed-off-by: NMarkus Armbruster <armbru@redhat.com>
      Reviewed-by: NMarcel Apfelbaum <marcel.a@redhat.com>
      Signed-off-by: NAndreas Färber <afaerber@suse.de>
      efec3dd6
  7. 31 8月, 2013 1 次提交
  8. 23 8月, 2013 2 次提交
  9. 30 7月, 2013 6 次提交
  10. 15 7月, 2013 1 次提交
    • P
      hw/dma/omap_dma: Fix bugs with DMA requests above 32 · 76486736
      Peter Maydell 提交于
      The drqbmp field of struct soc_dma_s is a uint64_t; however several
      places in the code attempt to set bits in it using "(1 << drq)",
      which will fail if drq is large enough that the 1 bit gets shifted
      off the top of a 32 bit integer.  Change these to "(1ULL << drq)" so
      that the promotion to 64 bit happens before the shift rather than
      afterwards.
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      Message-id: 1372423919-5669-1-git-send-email-peter.maydell@linaro.org
      76486736
  11. 04 7月, 2013 4 次提交
  12. 20 6月, 2013 1 次提交
  13. 10 6月, 2013 1 次提交
  14. 07 6月, 2013 1 次提交
  15. 20 5月, 2013 1 次提交
  16. 18 5月, 2013 1 次提交
  17. 29 4月, 2013 1 次提交
  18. 21 4月, 2013 1 次提交
    • P
      qdev: Drop taddr properties · 21e5181f
      Peter Maydell 提交于
      Drop all the infrastructure for taddr properties (ie ones which
      are 'hwaddr' sized). These are now unused, and any further desired
      use would be rather questionable since device properties shouldn't
      generally depend on a type that is conceptually variable based on
      the target CPU. 32 or 64 bit integer properties should be used instead
      as appropriate for the specific device.
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>
      21e5181f
  19. 19 4月, 2013 1 次提交
  20. 16 4月, 2013 7 次提交