- 26 10月, 2015 5 次提交
-
-
由 Marc-André Lureau 提交于
The array is used to have vector specific data, so use a more descriptive name. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
No need to store an extra int for the vector number when it can be computed easily by looking at the position in the array. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
Instead of handling allocation, teach ivshmem to use a memory backend. This allows to use hugetlbfs backed memory now. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
Use the common qemu utility function to parse the memory size. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
Remove shm_fd from device state, closing it as early as possible to avoid leaks. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
- 25 10月, 2015 29 次提交
-
-
由 David Marchand 提交于
Send a protocol version as the first message from server, clients must close communication if they don't support this protocol version. Older QEMUs should be fine with this change in the protocol since they overrides their own vm_id on reception of an id associated to no eventfd. Signed-off-by: NDavid Marchand <david.marchand@6wind.com> Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> [use fifo_update_and_get()] Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
The interrupt mask is a state value, it should be reset, like the interrupt status. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
The number of eventfd that can be handled per peer is limited by the number of vectors. Return an error when receiving too many of them. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
The terms 'guest' and 'peer' are used sometime interchangeably which may be confusing. Instead, use 'peer' for the remote instances of ivshmem clients, and 'guest' for the local VM. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
Free all objects owned by the device, making sure the device is free, fixing hot-unplug. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
The server should not change the shm, and this isn't handled by qemu and we should should verify this in qemu. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
0 is a valid fd value, so change conditions and set -1 value early Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
load_state_old() is used to keep compatibility with version 0. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
The common version correctly checks for 0 value case. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
Both if branches return, move this out to common end. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
Use some more explicit variables to simplify the code. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
The server shouldn't send invalid peer id, so print an error if it's the case. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
The test whether the chardev is an AF_UNIX socket rejects "-chardev socket,id=chr0,path=/tmp/foo,server,nowait -device ivshmem,chardev=chr0", but fails to explain why. Use an explicit error on why a chardev may be rejected. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
Some misc improvements to ivshmem debug. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
max_peer isn't really useful, it tracks the maximum received VM id, but that quickly matches nb_peers, the size of the peers array. Since VM come and go, there might be sparse peers so it doesn't help much in general to have this value around. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
There is no peer when device is initialized, do not let doorbell for inexisting peer 0. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
val isn't used in ivshmem_update_irq() function. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
It simplifies a bit the code to allocate the array when setting the number of peers instead of lazily when receiving the first vector. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
Set the number of peers and array allocation in a single place. Rename to better reflect the function content. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
Limit the maximum number of peers to MAXUINT16. This is more realistic and better matches the limit of the doorbell register. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
Failing to create a chardev shouldn't be fatal. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
Use the latest qemu device modeling API, in particular, convert to realize to fix the error handling; right now a botched device_add ivhsmem command kills the VM. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
qemu_chr_fe_get_msgfd() transfers ownership, there is no need to dup the fd. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
Make a new function fifo_update_and_get() that can be reused by other functions (in next commits). Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
If the fifo has 0 bytes, and the read is of size 1, the call to fifo8_push_all() will copy off boundary data. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
ivshmem_read() only reads sizeof(long) from the input buffer. Accepting more could lead to fifo8 abort() on 32bit systems if fifo is not empty. A following patch will change the protocol to 64-bit little-endian instead. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
- 23 10月, 2015 2 次提交
-
-
由 Laurent Vivier 提交于
macio is a bridge between the PCI bus and the Mac nvram, IDE controller and PIC, so add it to the bridge category. Signed-off-by: NLaurent Vivier <laurent@vivier.eu> Reviewed-by: NThomas Huth <thuth@redhat.com> Signed-off-by: NDavid Gibson <david@gibson.dropbear.id.au>
-
由 Laurent Vivier 提交于
Cuda is a bridge between PowerMac system bus and the ADB controller, real-time clock, pram and the power management unit. So add it to the bridge category. Signed-off-by: NLaurent Vivier <laurent@vivier.eu> Signed-off-by: NDavid Gibson <david@gibson.dropbear.id.au>
-
- 16 10月, 2015 1 次提交
-
-
由 Peter Crosthwaite 提交于
The /4 for offset calculation in MMIO writes was happening twice giving wrong write offsets. Fix. While touching the code, change the if-else to be a short returning if and convert the debug message to a GUEST_ERROR, which is more accurate for this condition. Cc: qemu-stable@nongnu.org Cc: Guenter Roeck <linux@roeck-us.net> Signed-off-by: NPeter Crosthwaite <crosthwaite.peter@gmail.com> Reviewed-by: NAlistair Francis <alistair.francis@xilinx.com> Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
-
- 09 10月, 2015 2 次提交
-
-
由 Paolo Bonzini 提交于
DBDMA_init is not idempotent, and calling it from instance_init breaks a simple object_new/object_unref pair. Work around this, pending qdev-ification of DBDMA, by moving the call to realize. Reported-by: NMarkus Armbruster <armbru@redhat.com> Signed-off-by: NPaolo Bonzini <pbonzini@redhat.com> Reviewed-by: NThomas Huth <thuth@redhat.com> Signed-off-by: NMarkus Armbruster <armbru@redhat.com> Message-Id: <1443689999-12182-4-git-send-email-armbru@redhat.com>
-
由 Paolo Bonzini 提交于
This causes the region to outlive the object, because it attaches the region to /machine. This is not nice for the "realize" method, but much worse for "instance_init" because it can cause dangling pointers after a simple object_new/object_unref pair. Reported-by: NMarkus Armbruster <armbru@redhat.com> Signed-off-by: NPaolo Bonzini <pbonzini@redhat.com> Reviewed-by: NPeter Maydell <peter.maydell@linaro.org> Tested-by: NMarkus Armbruster <armbru@redhat.com> Signed-off-by: NMarkus Armbruster <armbru@redhat.com> Message-Id: <1443689999-12182-3-git-send-email-armbru@redhat.com> Reviewed-by: NThomas Huth <thuth@redhat.com>
-
- 21 9月, 2015 1 次提交
-
-
由 Mark Cave-Ayland 提交于
The code to flush the DBDMA channel was effectively duplicated in dbdma_control_write(), except for the fact that the copy executed outside of a RUN bit transition was broken by not clearing the FLUSH bit once the flush was complete. Newer PPC Linux kernels would timeout waiting for the FLUSH bit to clear again after submitting a FLUSH command. Fix this by always clearing the FLUSH bit once the channel flush is complete and removing the repeated code. Reported-by: NAurelien Jarno <aurelien@aurel32.net> Signed-off-by: NMark Cave-Ayland <mark.cave-ayland@ilande.co.uk> Reviewed-by: NAurelien Jarno <aurelien@aurel32.net> Signed-off-by: NAlexander Graf <agraf@suse.de>
-