- 26 10月, 2015 5 次提交
-
-
由 Marc-André Lureau 提交于
The array is used to have vector specific data, so use a more descriptive name. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
No need to store an extra int for the vector number when it can be computed easily by looking at the position in the array. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
Instead of handling allocation, teach ivshmem to use a memory backend. This allows to use hugetlbfs backed memory now. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
Use the common qemu utility function to parse the memory size. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
Remove shm_fd from device state, closing it as early as possible to avoid leaks. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
- 25 10月, 2015 30 次提交
-
-
由 Marc-André Lureau 提交于
qpci_msix_pending() writes on pba region, causing qemu to SEGV: Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7ffff7fba8c0 (LWP 25882)] 0x0000000000000000 in ?? () (gdb) bt #0 0x0000000000000000 in () #1 0x00005555556556c5 in memory_region_oldmmio_write_accessor (mr=0x5555579f3f80, addr=0, value=0x7fffffffbf68, size=4, shift=0, mask=4294967295, attrs=...) at /home/elmarco/src/qemu/memory.c:434 #2 0x00005555556558e1 in access_with_adjusted_size (addr=0, value=0x7fffffffbf68, size=4, access_size_min=1, access_size_max=4, access=0x55555565563e <memory_region_oldmmio_write_accessor>, mr=0x5555579f3f80, attrs=...) at /home/elmarco/src/qemu/memory.c:506 #3 0x00005555556581eb in memory_region_dispatch_write (mr=0x5555579f3f80, addr=0, data=0, size=4, attrs=...) at /home/elmarco/src/qemu/memory.c:1176 #4 0x000055555560b6f9 in address_space_rw (as=0x555555eff4e0 <address_space_memory>, addr=3759147008, attrs=..., buf=0x7fffffffc1b0 "", len=4, is_write=true) at /home/elmarco/src/qemu/exec.c:2439 #5 0x000055555560baa2 in cpu_physical_memory_rw (addr=3759147008, buf=0x7fffffffc1b0 "", len=4, is_write=1) at /home/elmarco/src/qemu/exec.c:2534 #6 0x000055555564c005 in cpu_physical_memory_write (addr=3759147008, buf=0x7fffffffc1b0, len=4) at /home/elmarco/src/qemu/include/exec/cpu-common.h:80 #7 0x000055555564cd9c in qtest_process_command (chr=0x55555642b890, words=0x5555578de4b0) at /home/elmarco/src/qemu/qtest.c:378 #8 0x000055555564db77 in qtest_process_inbuf (chr=0x55555642b890, inbuf=0x55555641b340) at /home/elmarco/src/qemu/qtest.c:569 #9 0x000055555564dc07 in qtest_read (opaque=0x55555642b890, buf=0x7fffffffc2e0 "writel 0xe0100800 0x0\n", size=22) at /home/elmarco/src/qemu/qtest.c:581 #10 0x000055555574ce3e in qemu_chr_be_write (s=0x55555642b890, buf=0x7fffffffc2e0 "writel 0xe0100800 0x0\n", len=22) at qemu-char.c:306 #11 0x0000555555751263 in tcp_chr_read (chan=0x55555642bcf0, cond=G_IO_IN, opaque=0x55555642b890) at qemu-char.c:2876 #12 0x00007ffff64c9a8a in g_main_context_dispatch (context=0x55555641c400) at gmain.c:3122 (without this patch, this can be reproduced with the ivshmem qtest) Implement an empty mmio write to avoid the crash. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NPaolo Bonzini <pbonzini@redhat.com>
-
由 David Marchand 提交于
Send a protocol version as the first message from server, clients must close communication if they don't support this protocol version. Older QEMUs should be fine with this change in the protocol since they overrides their own vm_id on reception of an id associated to no eventfd. Signed-off-by: NDavid Marchand <david.marchand@6wind.com> Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> [use fifo_update_and_get()] Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
The interrupt mask is a state value, it should be reset, like the interrupt status. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
The number of eventfd that can be handled per peer is limited by the number of vectors. Return an error when receiving too many of them. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
The terms 'guest' and 'peer' are used sometime interchangeably which may be confusing. Instead, use 'peer' for the remote instances of ivshmem clients, and 'guest' for the local VM. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
Free all objects owned by the device, making sure the device is free, fixing hot-unplug. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
The server should not change the shm, and this isn't handled by qemu and we should should verify this in qemu. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
0 is a valid fd value, so change conditions and set -1 value early Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
load_state_old() is used to keep compatibility with version 0. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
The common version correctly checks for 0 value case. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
Both if branches return, move this out to common end. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
Use some more explicit variables to simplify the code. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
The server shouldn't send invalid peer id, so print an error if it's the case. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
The test whether the chardev is an AF_UNIX socket rejects "-chardev socket,id=chr0,path=/tmp/foo,server,nowait -device ivshmem,chardev=chr0", but fails to explain why. Use an explicit error on why a chardev may be rejected. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
Some misc improvements to ivshmem debug. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
max_peer isn't really useful, it tracks the maximum received VM id, but that quickly matches nb_peers, the size of the peers array. Since VM come and go, there might be sparse peers so it doesn't help much in general to have this value around. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
There is no peer when device is initialized, do not let doorbell for inexisting peer 0. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
val isn't used in ivshmem_update_irq() function. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
It simplifies a bit the code to allocate the array when setting the number of peers instead of lazily when receiving the first vector. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
Set the number of peers and array allocation in a single place. Rename to better reflect the function content. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
Limit the maximum number of peers to MAXUINT16. This is more realistic and better matches the limit of the doorbell register. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
Failing to create a chardev shouldn't be fatal. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
Use the latest qemu device modeling API, in particular, convert to realize to fix the error handling; right now a botched device_add ivhsmem command kills the VM. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
qemu_chr_fe_get_msgfd() transfers ownership, there is no need to dup the fd. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
Make a new function fifo_update_and_get() that can be reused by other functions (in next commits). Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
If the fifo has 0 bytes, and the read is of size 1, the call to fifo8_push_all() will copy off boundary data. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
由 Marc-André Lureau 提交于
ivshmem_read() only reads sizeof(long) from the input buffer. Accepting more could lead to fifo8 abort() on 32bit systems if fifo is not empty. A following patch will change the protocol to 64-bit little-endian instead. Signed-off-by: NMarc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: NClaudio Fontana <claudio.fontana@huawei.com>
-
- 23 10月, 2015 5 次提交
-
-
由 Paolo Bonzini 提交于
These messages are disabled by default; a perfect usecase for tracepoints. Convert them over. Signed-off-by: NPaolo Bonzini <pbonzini@redhat.com> Signed-off-by: NDavid Gibson <david@gibson.dropbear.id.au>
-
由 Laurent Vivier 提交于
openpic is a programmable interrupt controller, so add it to the misc category. Signed-off-by: NLaurent Vivier <laurent@vivier.eu> Reviewed-by: NThomas Huth <thuth@redhat.com> Signed-off-by: NDavid Gibson <david@gibson.dropbear.id.au>
-
由 Laurent Vivier 提交于
The macio nvram is a non volatile RAM, so add it the misc category. Signed-off-by: NLaurent Vivier <laurent@vivier.eu> Reviewed-by: NThomas Huth <thuth@redhat.com> Signed-off-by: NDavid Gibson <david@gibson.dropbear.id.au>
-
由 Laurent Vivier 提交于
macio is a bridge between the PCI bus and the Mac nvram, IDE controller and PIC, so add it to the bridge category. Signed-off-by: NLaurent Vivier <laurent@vivier.eu> Reviewed-by: NThomas Huth <thuth@redhat.com> Signed-off-by: NDavid Gibson <david@gibson.dropbear.id.au>
-
由 Laurent Vivier 提交于
Uninorth is the mac99 PCI host controller, so add it to the bridge category. Signed-off-by: NLaurent Vivier <laurent@vivier.eu> Reviewed-by: NThomas Huth <thuth@redhat.com> Signed-off-by: NDavid Gibson <david@gibson.dropbear.id.au>
-