• P
    hw/misc/imx6_src: Don't crash trying to reset missing CPUs · 5e2fb7c5
    Peter Maydell 提交于
    Commit 4881658a introduced a call to arm_get_cpu_by_id(),
    and Coverity noticed that we weren't checking that it didn't
    return NULL (CID 1371652).
    
    Normally this won't happen (because all 4 CPUs are expected
    to exist), but it's possible the user requested fewer CPUs
    on the command line. Handle this possibility by silently
    doing nothing, which is the same behaviour as before commit
    4881658a and also how we handle the other CPU operations
    (since we ignore the INVALID_PARAM returns from arm_set_cpu_on()
    and friends).
    
    There is a slight behavioural difference to the pre-4881658a
    situation: the "reset this core" bit will remain set rather
    than not being permitted to be set. The imx6 datasheet is
    unclear about the behaviour in this odd corner case, so we
    opt for the simpler code rather than complicated logic to
    maintain identical behaviour.
    Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
    Message-id: 1488542374-1256-1-git-send-email-peter.maydell@linaro.org
    Reviewed-by: NAlex Bennée <alex.bennee@linaro.org>
    5e2fb7c5
imx6_src.c 8.8 KB